135523 2014-08-01 15:33:46 -0700 Add some structure related assertions 2014-08-01 15:50:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam oldest_to_newest 1026351 0 mark.lam 2014-08-01 15:33:46 -0700 Adding 2 assertions: 1. assert that we don't index pass the end of the StructureIDTable. This should never happen, but this assertion will help catch bugs where a bad structureID gets passed in. 2. assert that cells in MarkedBlock::callDestructor() that are not zapped should have a non-null StructureID. This will help us catch bugs where the other cell header flag bits get set after the cell is zapped, thereby making the cell look like an unzapped cell but has a null structureID. 1026356 1 235910 mark.lam 2014-08-01 15:38:16 -0700 Created attachment 235910 the patch 1026358 2 235910 ggaren 2014-08-01 15:41:05 -0700 Comment on attachment 235910 the patch r=me 1026367 3 mark.lam 2014-08-01 15:50:50 -0700 Thanks. Landed in r171953: <http://trac.webkit.org/r171953>. 235910 2014-08-01 15:38:16 -0700 2014-08-01 15:41:05 -0700 the patch bug-135523.patch text/plain 2286 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcxOTQ5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDE0LTA4LTAxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgc29tZSBzdHJ1Y3R1cmUgcmVsYXRlZCBhc3NlcnRpb25zLgorICAgICAgICA8aHR0cHM6Ly93 ZWJraXQub3JnL2IvMTM1NTIzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFkZGluZyAyIGFzc2VydGlvbnM6CisgICAgICAgIDEuIGFzc2VydCB0aGF0 IHdlIGRvbid0IGluZGV4IHBhc3MgdGhlIGVuZCBvZiB0aGUgU3RydWN0dXJlSURUYWJsZS4KKyAg ICAgICAgICAgVGhpcyBzaG91bGQgbmV2ZXIgaGFwcGVuLCBidXQgdGhpcyBhc3NlcnRpb24gd2ls bCBoZWxwIGNhdGNoIGJ1Z3MKKyAgICAgICAgICAgd2hlcmUgYSBiYWQgc3RydWN0dXJlSUQgZ2V0 cyBwYXNzZWQgaW4uCisgICAgICAgIDIuIGFzc2VydCB0aGF0IGNlbGxzIGluIE1hcmtlZEJsb2Nr OjpjYWxsRGVzdHJ1Y3RvcigpIHRoYXQgYXJlIG5vdAorICAgICAgICAgICB6YXBwZWQgc2hvdWxk IGhhdmUgYSBub24tbnVsbCBTdHJ1Y3R1cmVJRC4gIFRoaXMgd2lsbCBoZWxwIHVzIGNhdGNoCisg ICAgICAgICAgIGJ1Z3Mgd2hlcmUgdGhlIG90aGVyIGNlbGwgaGVhZGVyIGZsYWcgYml0cyBnZXQg c2V0IGFmdGVyIHRoZSBjZWxsIGlzCisgICAgICAgICAgIHphcHBlZCwgdGhlcmVieSBtYWtpbmcg dGhlIGNlbGwgbG9vayBsaWtlIGFuIHVuemFwcGVkIGNlbGwgYnV0IGhhcyBhCisgICAgICAgICAg IG51bGwgc3RydWN0dXJlSUQuCisKKyAgICAgICAgKiBoZWFwL01hcmtlZEJsb2NrLmNwcDoKKyAg ICAgICAgKEpTQzo6TWFya2VkQmxvY2s6OmNhbGxEZXN0cnVjdG9yKToKKyAgICAgICAgKiBydW50 aW1lL1N0cnVjdHVyZUlEVGFibGUuaDoKKyAgICAgICAgKEpTQzo6U3RydWN0dXJlSURUYWJsZTo6 Z2V0KToKKwogMjAxNC0wOC0wMSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFVSVEJGIGFmdGVyIHIxNzE5NDYgdG8gZml4IG5vbi1BcHBsZSBidWlsZHMu CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRCbG9jay5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya2VkQmxvY2suY3BwCShyZXZp c2lvbiAxNzE4ODIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRCbG9jay5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTYxLDYgKzYxLDcgQEAgaW5saW5lIHZvaWQgTWFya2VkQmxv Y2s6OmNhbGxEZXN0cnVjdG9yKAogICAgIGlmIChjZWxsLT5pc1phcHBlZCgpKQogICAgICAgICBy ZXR1cm47CiAKKyAgICBBU1NFUlQoY2VsbC0+c3RydWN0dXJlSUQoKSk7CiAgICAgaWYgKGR0b3JU eXBlID09IE1hcmtlZEJsb2NrOjpOb3JtYWwpCiAgICAgICAgIGpzQ2FzdDxKU0Rlc3RydWN0aWJs ZU9iamVjdCo+KGNlbGwpLT5jbGFzc0luZm8oKS0+bWV0aG9kVGFibGUuZGVzdHJveShjZWxsKTsK ICAgICBlbHNlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmVJ RFRhYmxlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3Ry dWN0dXJlSURUYWJsZS5oCShyZXZpc2lvbiAxNzE4ODIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9TdHJ1Y3R1cmVJRFRhYmxlLmgJKHdvcmtpbmcgY29weSkKQEAgLTgzLDYgKzgz LDcgQEAgcHJpdmF0ZToKIGlubGluZSBTdHJ1Y3R1cmUqIFN0cnVjdHVyZUlEVGFibGU6OmdldChT dHJ1Y3R1cmVJRCBzdHJ1Y3R1cmVJRCkKIHsKICNpZiBVU0UoSlNWQUxVRTY0KQorICAgIEFTU0VS VChzdHJ1Y3R1cmVJRCAmJiBzdHJ1Y3R1cmVJRCA8IG1fY2FwYWNpdHkpOwogICAgIHJldHVybiB0 YWJsZSgpW3N0cnVjdHVyZUlEXS5zdHJ1Y3R1cmU7CiAjZWxzZQogICAgIHJldHVybiBzdHJ1Y3R1 cmVJRDsK