135522 2014-08-01 15:05:34 -0700 REGRESSION(r171942): [CMAKE] build broken (clean build) 2014-08-01 17:10:37 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Major --- 1 clopez clopez achristensen bunhere commit-queue darin ggaren gyuyoung.kim kling mrobinson ossy rakuco sergio oldest_to_newest 1026344 0 clopez 2014-08-01 15:05:34 -0700 r171942 <http://trac.webkit.org/r171942> broke the build. The bots are green because it only breaks if you do a clean build (It don't seems to break if you rebuild from a previous revision) Test with: # Clean the build rm -fr WebKitBuild/Release/ # Build webkit Tools/Scripts/build-webkit --no-webkit1 --release --gtk In file included from DerivedSources/WebCore/InspectorWebBackendDispatchers.h:12:0, from ../../Source/WebCore/inspector/InspectorDOMAgent.h:36, from ../../Source/WebCore/bindings/js/JSCommandLineAPIHostCustom.cpp:40: DerivedSources/WebCore/InspectorWebTypeBuilders.h:14:47: fatal error: inspector/InspectorJSTypeBuilders.h: No such file or directory #include <inspector/InspectorJSTypeBuilders.h> ^ compilation terminated. ninja: build stopped: subcommand failed. 1026368 1 achristensen 2014-08-01 15:53:27 -0700 Sorry about the breakage. It's related to this change: - COMMAND ${PYTHON_EXECUTABLE} ${JavaScriptCore_INSPECTOR_SCRIPTS_DIR}/CodeGeneratorInspector.py ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJS.json --output_h_dir "${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}" --output_cpp_dir "${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}" --output_js_dir "${DERIVED_SOURCES_WEBINSPECTORUI_DIR}/UserInterface/Protocol" --output_type JavaScript --write_always && mkdir -p ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector && cp ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJSBackendDispatchers.h ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJSFrontendDispatchers.h ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJSTypeBuilders.h ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector + COMMAND ${PYTHON_EXECUTABLE} ${JavaScriptCore_INSPECTOR_SCRIPTS_DIR}/CodeGeneratorInspector.py ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InspectorJS.json --output_h_dir "${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}" --output_cpp_dir "${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector" --output_js_dir "${DERIVED_SOURCES_WEBINSPECTORUI_DIR}/UserInterface/Protocol" --output_type JavaScript --write_always VERBATIM) +file(MAKE_DIRECTORY ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector) I'm not sure if we want to revert it to keep the bots green or find a better fix, but I have no access to a machine actually building GTK or EFL, and we need to get rid of the cp command sometime soon anyway. Is there a good fix for this? 1026375 2 clopez 2014-08-01 16:01:49 -0700 (In reply to comment #1) > > I'm not sure if we want to revert it to keep the bots green or find a better fix, but I have no access to a machine actually building GTK or EFL, and we need to get rid of the cp command sometime soon anyway. > > Is there a good fix for this? I think I have a patch. I will upload it soon for review. 1026397 3 235923 clopez 2014-08-01 16:31:21 -0700 Created attachment 235923 Patch 1026404 4 235923 commit-queue 2014-08-01 17:10:29 -0700 Comment on attachment 235923 Patch Clearing flags on attachment: 235923 Committed r171961: <http://trac.webkit.org/changeset/171961> 1026405 5 commit-queue 2014-08-01 17:10:37 -0700 All reviewed patches have been landed. Closing bug. 235923 2014-08-01 16:31:21 -0700 2014-08-01 17:10:29 -0700 Patch bug-135522-20140802013107.patch text/plain 4369 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxOTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw OTgwOGRkNjYxMWRiMzViMzE3NjI3ZDc0YjZlMGMwZGIyODYzMGZjLi41ZTBlNWI2NDM1ZDVjMmZk ODJjMTBlNGEzZTQzODQxZWNhYTc4NDM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNC0wOC0wMSAgQ2FybG9zIEFsYmVydG8gTG9wZXogUGVyZXogIDxjbG9w ZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIxNzE5NDIpOiBbQ01BS0VdIFtH VEtdIGJ1aWxkIGJyb2tlbiAoY2xlYW4gYnVpbGQpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1NTIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogT3V0cHV0IHRoZSBpbnNw ZWN0b3IgaGVhZGVycyBpbnNpZGUgaW5zcGVjdG9yCisgICAgICAgIHN1YmRpcmVjdG9yeS4KKwog MjAxNC0wOC0wMSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFVSVEJGIGFmdGVyIHIxNzE5NDYgdG8gZml4IG5vbi1BcHBsZSBidWlsZHMuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK aW5kZXggYmM4ODAwYmFmODMxZDcyYTRlNTJlZWFjOWU5ODZmN2QyMWM5YjQ2Zi4uOTM3ZTc3Njk4 MGY1YzM0ZjI0ZjkyOWUwMjM4NTlhN2FhZjEyOGMzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTA4LTAxICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE3MTk0Mik6IFtDTUFLRV0gW0dUS10gYnVp bGQgYnJva2VuIChjbGVhbiBidWlsZCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzU1MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgcmVxdWlyZWQsIG5vIG5ldyBmdW5jdGlvbmFs aXR5LgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6IEFkZCBtaXNzaW5nIGluY2x1ZGUgdG8g dGhlIGluc3BlY3RvciBoZWFkZXJzCisgICAgICAgIGFuZCBmaXggdGhlIHBhdGggdG8gSW5zcGVj dG9ySlNUeXBlQnVpbGRlcnMuaAorCiAyMDE0LTA4LTAxICBCZXRoIERha2luICA8YmRha2luQGFw cGxlLmNvbT4KIAogICAgICAgICBJbnNwZWN0b3IgaGlnaGxpZ2h0cyBjbGlwcGVkIGF0IHRoZSBi b3R0b20gb24gdGhlIHBhZ2UgaW4gV0sxIHZpZXdzIHdpdGggCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01h a2VMaXN0cy50eHQKaW5kZXggNDdiNjAwMTcxMzY5YTU5ZTQ4ZDQ5M2M3MGQ5Y2JkZDQyMmNkMGZi MS4uYWU2OWIwMjA4YTQ0MmNjZTA4MmRmOWFmYWFiMDNiODkwZTUzNzZlMCAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DTWFrZUxpc3RzLnR4dApAQCAtODgzLDcgKzg4Myw3IEBAIGFkZF9jdXN0b21fY29t bWFuZCgKICAgICBNQUlOX0RFUEVOREVOQ1kgJHtERVJJVkVEX1NPVVJDRVNfSkFWQVNDUklQVENP UkVfRElSfS9JbnNwZWN0b3JKUy5qc29uCiAgICAgREVQRU5EUyAke0phdmFTY3JpcHRDb3JlX0lO U1BFQ1RPUl9TQ1JJUFRTX0RJUn0vQ29kZUdlbmVyYXRvckluc3BlY3Rvci5weQogICAgICAgICAg ICAgJHtKYXZhU2NyaXB0Q29yZV9JTlNQRUNUT1JfU0NSSVBUU19ESVJ9L0NvZGVHZW5lcmF0b3JJ bnNwZWN0b3JTdHJpbmdzLnB5Ci0gICAgQ09NTUFORCAke1BZVEhPTl9FWEVDVVRBQkxFfSAke0ph dmFTY3JpcHRDb3JlX0lOU1BFQ1RPUl9TQ1JJUFRTX0RJUn0vQ29kZUdlbmVyYXRvckluc3BlY3Rv ci5weSAke0RFUklWRURfU09VUkNFU19KQVZBU0NSSVBUQ09SRV9ESVJ9L0luc3BlY3RvckpTLmpz b24gLS1vdXRwdXRfaF9kaXIgIiR7REVSSVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0i IC0tb3V0cHV0X2NwcF9kaXIgIiR7REVSSVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0v aW5zcGVjdG9yIiAtLW91dHB1dF9qc19kaXIgIiR7REVSSVZFRF9TT1VSQ0VTX1dFQklOU1BFQ1RP UlVJX0RJUn0vVXNlckludGVyZmFjZS9Qcm90b2NvbCIgLS1vdXRwdXRfdHlwZSBKYXZhU2NyaXB0 IC0td3JpdGVfYWx3YXlzCisgICAgQ09NTUFORCAke1BZVEhPTl9FWEVDVVRBQkxFfSAke0phdmFT Y3JpcHRDb3JlX0lOU1BFQ1RPUl9TQ1JJUFRTX0RJUn0vQ29kZUdlbmVyYXRvckluc3BlY3Rvci5w eSAke0RFUklWRURfU09VUkNFU19KQVZBU0NSSVBUQ09SRV9ESVJ9L0luc3BlY3RvckpTLmpzb24g LS1vdXRwdXRfaF9kaXIgIiR7REVSSVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vaW5z cGVjdG9yIiAtLW91dHB1dF9jcHBfZGlyICIke0RFUklWRURfU09VUkNFU19KQVZBU0NSSVBUQ09S RV9ESVJ9L2luc3BlY3RvciIgLS1vdXRwdXRfanNfZGlyICIke0RFUklWRURfU09VUkNFU19XRUJJ TlNQRUNUT1JVSV9ESVJ9L1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wiIC0tb3V0cHV0X3R5cGUgSmF2 YVNjcmlwdCAtLXdyaXRlX2Fsd2F5cwogICAgIFZFUkJBVElNKQogZmlsZShNQUtFX0RJUkVDVE9S WSAke0RFUklWRURfU09VUkNFU19KQVZBU0NSSVBUQ09SRV9ESVJ9L2luc3BlY3RvcikKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29yZS9D TWFrZUxpc3RzLnR4dAppbmRleCA5NjUxNWQyM2U0OTk1YmVlYzYyZWMxNzQ3MTg3NTczNTM1ZjY2 ZWRkLi5iNTM4NGQxMzEzNmE4M2U4YWQwMzFhMzFlZTA3MTgyZWI5NDBlM2RlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9DTWFr ZUxpc3RzLnR4dApAQCAtMTIwLDYgKzEyMCw3IEBAIHNldChXZWJDb3JlX0lOQ0xVREVfRElSRUNU T1JJRVMKICAgICAiJHtXVEZfRElSfSIKICAgICAiJHtERVJJVkVEX1NPVVJDRVNfRElSfS9Gb3J3 YXJkaW5nSGVhZGVycyIKICAgICAiJHtERVJJVkVEX1NPVVJDRVNfSkFWQVNDUklQVENPUkVfRElS fSIKKyAgICAiJHtERVJJVkVEX1NPVVJDRVNfSkFWQVNDUklQVENPUkVfRElSfS9pbnNwZWN0b3Ii CiAgICAgIiR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfSIKICAgICAiJHtDTUFLRV9TT1VS Q0VfRElSfS9Tb3VyY2UiCiAgICAgIiR7Q01BS0VfQklOQVJZX0RJUn0iCkBAIC0zMjc1LDcgKzMy NzYsNyBAQCBhZGRfY3VzdG9tX2NvbW1hbmQoCiAgICAgREVQRU5EUyAke1dlYkNvcmVfSU5TUEVD VE9SX1NDUklQVFNfRElSfS9Db2RlR2VuZXJhdG9ySW5zcGVjdG9yLnB5CiAgICAgICAgICAgICAk e1dlYkNvcmVfSU5TUEVDVE9SX1NDUklQVFNfRElSfS9Db2RlR2VuZXJhdG9ySW5zcGVjdG9yU3Ry aW5ncy5weQogICAgICAgICAgICAgJHtERVJJVkVEX1NPVVJDRVNfSkFWQVNDUklQVENPUkVfRElS fS9JbnNwZWN0b3JKUy5qc29uCi0gICAgICAgICAgICAke0RFUklWRURfU09VUkNFU19KQVZBU0NS SVBUQ09SRV9ESVJ9L0luc3BlY3RvckpTVHlwZUJ1aWxkZXJzLmgKKyAgICAgICAgICAgICR7REVS SVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vaW5zcGVjdG9yL0luc3BlY3RvckpTVHlw ZUJ1aWxkZXJzLmgKICAgICBDT01NQU5EICR7UFlUSE9OX0VYRUNVVEFCTEV9ICR7V2ViQ29yZV9J TlNQRUNUT1JfU0NSSVBUU19ESVJ9L0NvZGVHZW5lcmF0b3JJbnNwZWN0b3IucHkgJHtERVJJVkVE X1NPVVJDRVNfV0VCQ09SRV9ESVJ9L0luc3BlY3RvcldlYi5qc29uICR7REVSSVZFRF9TT1VSQ0VT X0pBVkFTQ1JJUFRDT1JFX0RJUn0vSW5zcGVjdG9ySlMuanNvbiAtLW91dHB1dF9oX2RpciAiJHtE RVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9IiAtLW91dHB1dF9jcHBfZGlyICIke0RFUklWRURf U09VUkNFU19XRUJDT1JFX0RJUn0iIC0tb3V0cHV0X2pzX2RpciAiJHtERVJJVkVEX1NPVVJDRVNf V0VCSU5TUEVDVE9SVUlfRElSfS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sIiAtLW91dHB1dF90eXBl IFdlYiAtLXdyaXRlX2Fsd2F5cwogICAgIFZFUkJBVElNKQogCg==