135502 2014-08-01 04:12:24 -0700 [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues 2014-10-04 00:35:58 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned mrobinson pnormand oldest_to_newest 1026222 0 cgarcia 2014-08-01 04:12:24 -0700 Generating webkit2gtk documentation... Copying template files to output directory... Copying HTML files to output directory... Running gtkdoc-scan Running gtkdoc-scangobj Running gtkdoc-mktmpl Running gtkdoc-mkdb Running gtkdoc-mkhtml Running gtkdoc-fixxref Traceback (most recent call last): File "../../Tools/gtk/generate-gtkdoc", line 202, in <module> saw_warnings = generate_documentation_for_config(common.build_path('gtkdoc-webkit2gtk.cfg')) File "../../Tools/gtk/generate-gtkdoc", line 152, in generate_documentation_for_config return generate_doc(generator, arguments.skip_html) File "../../Tools/gtk/generate-gtkdoc", line 133, in generate_doc generator.generate(not skip_html) File "../../Tools/gtk/gtkdoc.py", line 151, in generate self._run_gtkdoc_fixxref() File "../../Tools/gtk/gtkdoc.py", line 379, in _run_gtkdoc_fixxref self._run_command(args, cwd=self.output_dir, ignore_warnings=True) File "../../Tools/gtk/gtkdoc.py", line 198, in _run_command sys.stdout.write(stdout.encode("utf-8")) File "/usr/lib/python2.7/codecs.py", line 351, in write data, consumed = self.encode(object, self.errors) UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 883: ordinal not in range(128) 1026223 1 cgarcia 2014-08-01 04:15:44 -0700 It seems it's trying to convert ascii text to utf8, but the text is not ascii, but utf8 already. This line is causing the problem: html/WebKitContextMenuItem.html:200: warning: no link for: 'GtkAction-activate' -> (<span class="type">“activate”</span>). Because of the quotation marks in “activate”. The line crashing is: sys.stdout.write(stdout.encode("utf-8")) and it works if we just remove the encode sys.stdout.write(stdout) 1026288 2 mrobinson 2014-08-01 11:28:07 -0700 I guess the output should be decoded as utf-8? 1027100 3 cgarcia 2014-08-05 23:13:23 -0700 (In reply to comment #2) > I guess the output should be decoded as utf-8? I think we should simply remove all .encode('utf-8') 1029047 4 236582 cgarcia 2014-08-14 01:43:48 -0700 Created attachment 236582 Patch 1029050 5 pnormand 2014-08-14 01:52:25 -0700 I think Martin is right, decode should be used. 1029052 6 cgarcia 2014-08-14 02:07:19 -0700 (In reply to comment #5) > I think Martin is right, decode should be used. I don't see why we need to mess up with stdout/stderr encoding, what we get from the command is what we send to stderr/stdout 1037178 7 238649 cgarcia 2014-09-25 01:39:48 -0700 Created attachment 238649 This should work for everybody 1039472 8 cgarcia 2014-10-04 00:35:58 -0700 Committed r174309: <http://trac.webkit.org/changeset/174309> 236582 2014-08-14 01:43:48 -0700 2014-09-25 01:39:48 -0700 Patch gtkdoc-crash.diff text/plain 1205 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlODAx NTcxLi4wMzE2M2UyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDgtMTQgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIGdlbmVyYXRlLWd0a2RvYyBj cmFzaGVzIHdoZW4gZ2VuZXJhdGluZyBIVE1MIGR1ZSB0byBlbmNvZGluZyBpc3N1ZXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTUwMgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZ3RrL2d0a2RvYy5w eToKKyAgICAgICAgKEdUS0RvYy5fcnVuX2NvbW1hbmQpOiBEbyBub3QgYXNzdW1lIHN0ZGVyci9z dGRvdXQgYXJlIGFzY2lpIGFuZAorICAgICAgICB0cnkgdG8gZW5jb2RlIHRoZW0gYXMgVVRGLTgu CisKIDIwMTQtMDgtMTMgIEFrb3MgS2lzcyAgPGFraXNzQGluZi51LXN6ZWdlZC5odT4KIAogICAg ICAgICBbRUZMXSBCdW1wIHVwIGFuZCBwYXRjaCBkZXBlbmRlbmNpZXMgdG8gYWxsb3cgYnVpbGRp bmcgZm9yIGFhcmNoNjQKZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9ndGtkb2MucHkgYi9Ub29scy9n dGsvZ3RrZG9jLnB5CmluZGV4IDVhZmY2ZmMuLjk0N2MxZTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL2d0 ay9ndGtkb2MucHkKKysrIGIvVG9vbHMvZ3RrL2d0a2RvYy5weQpAQCAtMTk1LDkgKzE5NSw5IEBA IGNsYXNzIEdUS0RvYyhvYmplY3QpOgogCiAgICAgICAgIGlmIHByaW50X291dHB1dDoKICAgICAg ICAgICAgIGlmIHN0ZG91dDoKLSAgICAgICAgICAgICAgICBzeXMuc3Rkb3V0LndyaXRlKHN0ZG91 dC5lbmNvZGUoInV0Zi04IikpCisgICAgICAgICAgICAgICAgc3lzLnN0ZG91dC53cml0ZShzdGRv dXQpCiAgICAgICAgICAgICBpZiBzdGRlcnI6Ci0gICAgICAgICAgICAgICAgc3lzLnN0ZGVyci53 cml0ZShzdGRlcnIuZW5jb2RlKCJ1dGYtOCIpKQorICAgICAgICAgICAgICAgIHN5cy5zdGRlcnIu d3JpdGUoc3RkZXJyKQogCiAgICAgICAgIGlmIHByb2Nlc3MucmV0dXJuY29kZSAhPSAwOgogICAg ICAgICAgICAgcmFpc2UgRXhjZXB0aW9uKCclcyBwcm9kdWNlZCBhIG5vbi16ZXJvIHJldHVybiBj b2RlICVpJwo= 238649 2014-09-25 01:39:48 -0700 2014-10-01 09:22:24 -0700 This should work for everybody wk-gtk-doc-crash.diff text/plain 1562 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5ODE1 YzRhLi4zZjc3NGU5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMDktMjUgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIGdlbmVyYXRlLWd0a2RvYyBj cmFzaGVzIHdoZW4gZ2VuZXJhdGluZyBIVE1MIGR1ZSB0byBlbmNvZGluZyBpc3N1ZXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTUwMgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gd3JpdGluZyB0 byBzdGRvdXQvc3RkZXJyIGZhaWxzIGR1ZSB0byBhIFVuaWNvZGVEZWNvZGVFcnJvcgorICAgICAg ICBleGNlcHRpb24sIHRyeSBhZ2FpbiB3aXRob3V0IGVuY29kaW5nIHRoZSBvdXRwdXQuCisKKyAg ICAgICAgKiBndGsvZ3RrZG9jLnB5OgorICAgICAgICAoR1RLRG9jLl9ydW5fY29tbWFuZCk6CisK IDIwMTQtMDktMjIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtHVEtdIFRlc3QgL3dlYmtpdDIvV2ViS2l0V2ViVmlldy9jYW4tc2hvdy1taW1l LXR5cGUgZmFpbHMgaWYgZXZpbmNlIGJyb3dzZXIgcGx1Z2luIGlzIGluc3RhbGxlZApkaWZmIC0t Z2l0IGEvVG9vbHMvZ3RrL2d0a2RvYy5weSBiL1Rvb2xzL2d0ay9ndGtkb2MucHkKaW5kZXggNWFm ZjZmYy4uYTUyNmI4NyAxMDA2NDQKLS0tIGEvVG9vbHMvZ3RrL2d0a2RvYy5weQorKysgYi9Ub29s cy9ndGsvZ3RrZG9jLnB5CkBAIC0xOTUsOSArMTk1LDE1IEBAIGNsYXNzIEdUS0RvYyhvYmplY3Qp OgogCiAgICAgICAgIGlmIHByaW50X291dHB1dDoKICAgICAgICAgICAgIGlmIHN0ZG91dDoKLSAg ICAgICAgICAgICAgICBzeXMuc3Rkb3V0LndyaXRlKHN0ZG91dC5lbmNvZGUoInV0Zi04IikpCisg ICAgICAgICAgICAgICAgdHJ5OgorICAgICAgICAgICAgICAgICAgICBzeXMuc3Rkb3V0LndyaXRl KHN0ZG91dC5lbmNvZGUoInV0Zi04IikpCisgICAgICAgICAgICAgICAgZXhjZXB0IFVuaWNvZGVE ZWNvZGVFcnJvcjoKKyAgICAgICAgICAgICAgICAgICAgc3lzLnN0ZG91dC53cml0ZShzdGRvdXQp CiAgICAgICAgICAgICBpZiBzdGRlcnI6Ci0gICAgICAgICAgICAgICAgc3lzLnN0ZGVyci53cml0 ZShzdGRlcnIuZW5jb2RlKCJ1dGYtOCIpKQorICAgICAgICAgICAgICAgIHRyeToKKyAgICAgICAg ICAgICAgICAgICAgc3lzLnN0ZGVyci53cml0ZShzdGRlcnIuZW5jb2RlKCJ1dGYtOCIpKQorICAg ICAgICAgICAgICAgIGV4Y2VwdCBVbmljb2RlRGVjb2RlRXJyb3I6CisgICAgICAgICAgICAgICAg ICAgIHN5cy5zdGRlcnIud3JpdGUoc3RkZXJyKQogCiAgICAgICAgIGlmIHByb2Nlc3MucmV0dXJu Y29kZSAhPSAwOgogICAgICAgICAgICAgcmFpc2UgRXhjZXB0aW9uKCclcyBwcm9kdWNlZCBhIG5v bi16ZXJvIHJldHVybiBjb2RlICVpJwo=