135501 2014-08-01 04:05:38 -0700 [CMake] GTK and EFL are using PROJECT_VERSION_PATCH to define the micro version 2014-08-01 11:26:48 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto bunhere cdumez commit-queue gustavo gyuyoung.kim mrobinson rakuco sergio oldest_to_newest 1026219 0 cgarcia 2014-08-01 04:05:38 -0700 It should be PROJECT_VERSION_MICRO instead. 1026220 1 235884 cgarcia 2014-08-01 04:07:58 -0700 Created attachment 235884 Patch 1026221 2 commit-queue 2014-08-01 04:08:52 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1026232 3 235884 gyuyoung.kim 2014-08-01 05:36:19 -0700 Comment on attachment 235884 Patch LGTM 1026236 4 cgarcia 2014-08-01 06:35:22 -0700 Committed r171915: <http://trac.webkit.org/changeset/171915> 1026287 5 235884 mrobinson 2014-08-01 11:26:48 -0700 Comment on attachment 235884 Patch Nice catch! 235884 2014-08-01 04:07:58 -0700 2014-08-01 11:26:48 -0700 Patch wk-project-version-micro.diff text/plain 4748 cgarcia ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzZjllODU4Li42Y2E4Y2I5 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTQtMDgtMDEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgor CisgICAgICAgIFtDTWFrZV0gR1RLIGFuZCBFRkwgYXJlIHVzaW5nIFBST0pFQ1RfVkVSU0lPTl9Q QVRDSCB0byBkZWZpbmUgdGhlIG1pY3JvIHZlcnNpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTUwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBQUk9KRUNUX1ZFUlNJT05fTUlDUk8gaW5zdGVh ZC4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlOgorICAgICAgICAq IFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlOgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9X ZWJLaXRIZWxwZXJzLmNtYWtlOgorCiAyMDE0LTA3LTMxICBSeXVhbiBDaG9pICA8cnl1YW4uY2hv aUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBCdW1wIGV3ZWJraXQgdmVyc2lvbiB0byAx LjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKaW5kZXggNDI1ZDRmZS4uYjhjOTJhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsx LDE3IEBACiAyMDE0LTA4LTAxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KIAorICAgICAgICBbQ01ha2VdIEdUSyBhbmQgRUZMIGFyZSB1c2luZyBQUk9KRUNUX1ZF UlNJT05fUEFUQ0ggdG8gZGVmaW5lIHRoZSBtaWNybyB2ZXJzaW9uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU1MDEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgUFJPSkVDVF9WRVJTSU9OX01JQ1JP IGluc3RlYWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9FV2ViS2l0Mi5oLmluOgor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFZlcnNpb24uaC5pbjoKKworMjAxNC0w OC0wMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAg ICAgVW5yZXZpZXdlZC4gQWRkIG1pc3Npbmcgc2VjdGlvbnMgdG8gZG9jdW1lbnRhdGlvbi4KIAog ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL2RvY3Mvd2Via2l0Mmd0ay1kb2NzLnNnbWw6IEFk ZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRVdlYktpdDIu aC5pbiBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0VXZWJLaXQyLmguaW4KaW5k ZXggZGI5NmQ0MS4uYjY3Zjc5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvRVdlYktpdDIuaC5pbgorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9FV2ViS2l0Mi5oLmluCkBAIC0zMCw3ICszMCw3IEBACiAKICNkZWZpbmUgRVdLX1ZFUlNJ T05fTUFKT1IgQFBST0pFQ1RfVkVSU0lPTl9NQUpPUkAKICNkZWZpbmUgRVdLX1ZFUlNJT05fTUlO T1IgQFBST0pFQ1RfVkVSU0lPTl9NSU5PUkAKLSNkZWZpbmUgRVdLX1ZFUlNJT05fTUlDUk8gQFBS T0pFQ1RfVkVSU0lPTl9QQVRDSEAKKyNkZWZpbmUgRVdLX1ZFUlNJT05fTUlDUk8gQFBST0pFQ1Rf VkVSU0lPTl9NSUNST0AKIAogI2luY2x1ZGUgImV3a19hdXRoX3JlcXVlc3QuaCIKICNpbmNsdWRl ICJld2tfYmFja19mb3J3YXJkX2xpc3QuaCIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFZlcnNpb24uaC5pbiBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdFZlcnNpb24uaC5pbgppbmRleCA1ZTRjZWY4Li4xMzY0YmY2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRWZXJzaW9u LmguaW4KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0VmVyc2lv bi5oLmluCkBAIC01Myw3ICs1Myw3IEBAIEdfQkVHSU5fREVDTFMKICAqIGFwcGxpY2F0aW9uIGNv bXBpbGUgdGltZSwgcmF0aGVyIHRoYW4gZnJvbSB0aGUgbGlicmFyeSBsaW5rZWQKICAqIGFnYWlu c3QgYXQgYXBwbGljYXRpb24gcnVuIHRpbWUuCiAgKi8KLSNkZWZpbmUgV0VCS0lUX01JQ1JPX1ZF UlNJT04gKEBQUk9KRUNUX1ZFUlNJT05fUEFUQ0hAKQorI2RlZmluZSBXRUJLSVRfTUlDUk9fVkVS U0lPTiAoQFBST0pFQ1RfVkVSU0lPTl9NSUNST0ApCiAKIC8qKgogICogV0VCS0lUX0NIRUNLX1ZF UlNJT046CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZSBiL1NvdXJj ZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IDMyNWUzNzcuLmJiZGIzMGUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRp b25zRWZsLmNtYWtlCkBAIC0xLDcgKzEsNyBAQAogc2V0KFBST0pFQ1RfVkVSU0lPTl9NQUpPUiAx KQogc2V0KFBST0pFQ1RfVkVSU0lPTl9NSU5PUiAxMSkKLXNldChQUk9KRUNUX1ZFUlNJT05fUEFU Q0ggMCkKLXNldChQUk9KRUNUX1ZFUlNJT04gJHtQUk9KRUNUX1ZFUlNJT05fTUFKT1J9LiR7UFJP SkVDVF9WRVJTSU9OX01JTk9SfS4ke1BST0pFQ1RfVkVSU0lPTl9QQVRDSH0pCitzZXQoUFJPSkVD VF9WRVJTSU9OX01JQ1JPIDApCitzZXQoUFJPSkVDVF9WRVJTSU9OICR7UFJPSkVDVF9WRVJTSU9O X01BSk9SfS4ke1BST0pFQ1RfVkVSU0lPTl9NSU5PUn0uJHtQUk9KRUNUX1ZFUlNJT05fTUlDUk99 KQogCiBhZGRfZGVmaW5pdGlvbnMoLURCVUlMRElOR19FRkxfXz0xKQogCmRpZmYgLS1naXQgYS9T b3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNt YWtlCmluZGV4IGU0NWQ5NGYuLjI3NzM3MmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0yLDgg KzIsOCBAQCBpbmNsdWRlKEdOVUluc3RhbGxEaXJzKQogCiBzZXQoUFJPSkVDVF9WRVJTSU9OX01B Sk9SIDIpCiBzZXQoUFJPSkVDVF9WRVJTSU9OX01JTk9SIDUpCi1zZXQoUFJPSkVDVF9WRVJTSU9O X1BBVENIIDEpCi1zZXQoUFJPSkVDVF9WRVJTSU9OICR7UFJPSkVDVF9WRVJTSU9OX01BSk9SfS4k e1BST0pFQ1RfVkVSU0lPTl9NSU5PUn0uJHtQUk9KRUNUX1ZFUlNJT05fUEFUQ0h9KQorc2V0KFBS T0pFQ1RfVkVSU0lPTl9NSUNSTyAxKQorc2V0KFBST0pFQ1RfVkVSU0lPTiAke1BST0pFQ1RfVkVS U0lPTl9NQUpPUn0uJHtQUk9KRUNUX1ZFUlNJT05fTUlOT1J9LiR7UFJPSkVDVF9WRVJTSU9OX01J Q1JPfSkKIHNldChXRUJLSVRHVEtfQVBJX1ZFUlNJT04gNC4wKQogCiAjIExpYnRvb2wgbGlicmFy eSB2ZXJzaW9uLCBub3QgdG8gYmUgY29uZnVzZWQgd2l0aCBBUEkgdmVyc2lvbi4KZGlmZiAtLWdp dCBhL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktp dEhlbHBlcnMuY21ha2UKaW5kZXggNzgzOTBlYy4uOTU2NGQyMyAxMDA2NDQKLS0tIGEvU291cmNl L2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdEhlbHBl cnMuY21ha2UKQEAgLTk4LDcgKzk4LDcgQEAgZW5kbWFjcm8oKQogbWFjcm8oQ0FMQ1VMQVRFX0xJ QlJBUllfVkVSU0lPTlNfRlJPTV9MSUJUT09MX1RSSVBMRSBsaWJyYXJ5X25hbWUgY3VycmVudCBy ZXZpc2lvbiBhZ2UpCiAgICAgbWF0aChFWFBSICR7bGlicmFyeV9uYW1lfV9WRVJTSU9OX01BSk9S ICIke2N1cnJlbnR9IC0gJHthZ2V9IikKICAgICBzZXQoJHtsaWJyYXJ5X25hbWV9X1ZFUlNJT05f TUlOT1IgJHthZ2V9KQotICAgIHNldCgke2xpYnJhcnlfbmFtZX1fVkVSU0lPTl9QQVRDSCAke3Jl dmlzaW9ufSkKKyAgICBzZXQoJHtsaWJyYXJ5X25hbWV9X1ZFUlNJT05fTUlDUk8gJHtyZXZpc2lv bn0pCiAgICAgc2V0KCR7bGlicmFyeV9uYW1lfV9WRVJTSU9OICR7JHtsaWJyYXJ5X25hbWV9X1ZF UlNJT05fTUFKT1J9LiR7YWdlfS4ke3JldmlzaW9ufSkKIGVuZG1hY3JvKCkKIApAQCAtMTA5LDgg KzEwOSw4IEBAIGVuZGlmICgpCiBpZiAoTk9UIERFRklORUQgJHtsaWJyYXJ5X25hbWV9X1ZFUlNJ T05fTUlOT1IpCiAgICAgc2V0KCR7bGlicmFyeV9uYW1lfV9WRVJTSU9OX01JTk9SICR7UFJPSkVD VF9WRVJTSU9OX01JTk9SfSkKIGVuZGlmICgpCi1pZiAoTk9UIERFRklORUQgJHtsaWJyYXJ5X25h bWV9X1ZFUlNJT05fUEFUQ0gpCi0gICAgc2V0KCR7bGlicmFyeV9uYW1lfV9WRVJTSU9OX1BBVENI ICR7UFJPSkVDVF9WRVJTSU9OX1BBVENIfSkKK2lmIChOT1QgREVGSU5FRCAke2xpYnJhcnlfbmFt ZX1fVkVSU0lPTl9NSUNSTykKKyAgICBzZXQoJHtsaWJyYXJ5X25hbWV9X1ZFUlNJT05fTUlDUk8g JHtQUk9KRUNUX1ZFUlNJT05fTUlDUk99KQogZW5kaWYgKCkKIGlmIChOT1QgREVGSU5FRCAke2xp YnJhcnlfbmFtZX1fVkVSU0lPTikKICAgICBzZXQoJHtsaWJyYXJ5X25hbWV9X1ZFUlNJT04gJHtQ Uk9KRUNUX1ZFUlNJT059KQo=