135493 2014-07-31 21:45:54 -0700 [Mac] Fullscreen mode for some applications shows only a black screen 2014-08-01 10:39:13 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham jer.noble simon.fraser thorton webkit-bug-importer oldest_to_newest 1026185 0 bfulgham 2014-07-31 21:45:54 -0700 Some WebKit2 client applications that attempt to enter Fullscreen mode end up with a black screen instead of seeing the fullscreen element. You can exit fullscreen mode and return to the full page, but this renders full screen mode unusable for these kinds of clients. 1026186 1 bfulgham 2014-07-31 21:51:16 -0700 This turned out to be due to a mismatch between the type of window hosting the fullscreen view. In some applications, the NSWindow in the non-fullscreen mode is marked as InProcess only. The fullscreen NSWindow expects to be hosted in the display server (OutOfProcess). When this kind of mismatch is encountered, the WK2 layer in the UI process is supposed to relay a message back to the WebProcess application indicating that the window hosting mode has changed. Unfortunately, this step was not happening properly resulting in the failure. 1026187 2 bfulgham 2014-07-31 21:52:31 -0700 <rdar://problem/17628212> 1026250 3 235891 bfulgham 2014-08-01 09:49:07 -0700 Created attachment 235891 Patch 1026254 4 235891 jer.noble 2014-08-01 10:10:14 -0700 Comment on attachment 235891 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235891&action=review r=me, with nit. > Source/WebKit2/UIProcess/API/mac/WKView.mm:2511 > + // TODO: This can be removed when https://bugs.webkit.org/show_bug.cgi?id=135509 is resolved. > + _data->_page->layerHostingModeDidChange(); > + Nit: this should be a "// FIXME(135509):" comment instead. 1026258 5 bfulgham 2014-08-01 10:19:59 -0700 This patch works around Bug 135509. 1026259 6 jer.noble 2014-08-01 10:27:04 -0700 (In reply to comment #5) > This patch works around Bug 135509. Yeah, so "FIXME(135509): This call becomes unnecessary once 135509 is fixed; remove." 1026260 7 235891 bfulgham 2014-08-01 10:27:19 -0700 Comment on attachment 235891 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235891&action=review >> Source/WebKit2/UIProcess/API/mac/WKView.mm:2511 >> + > > Nit: this should be a "// FIXME(135509):" comment instead. OK! 1026266 8 bfulgham 2014-08-01 10:39:13 -0700 Committed r171920: <http://trac.webkit.org/changeset/171920> 235891 2014-08-01 09:49:07 -0700 2014-08-01 10:27:19 -0700 Patch bug-135493-20140801094854.patch text/plain 2510 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTkxNykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDE0LTA4LTAxICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIEZ1bGxzY3JlZW4g bW9kZSBmb3Igc29tZSBhcHBsaWNhdGlvbnMgc2hvd3Mgb25seSBhIGJsYWNrIHNjcmVlbi4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTQ5MworICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMTc2MjgyMTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gc29tZSBhcHBsaWNhdGlvbnMsIHRoZSB3aW5kb3cg aG9zdGluZyB0aGUgV0tWaWV3IGlzIGFuIEluUHJvY2VzcyBsYXllciBob3N0aW5nIG1vZGUuCisg ICAgICAgIFRoZSBmdWxsc2NyZWVuIHdpbmRvdyBjcmVhdGVkIGJ5IHRoZSBXS0Z1bGxTY3JlZW5X aW5kb3dDb250cm9sbGVyIGRlZmF1bHRzIHRvIGFuCisgICAgICAgIE91dE9mUHJvY2VzcyBtb2Rl LgorCisgICAgICAgIFdoZW4gdGhpcyBraW5kIG9mIG1pc21hdGNoIGlzIGVuY291bnRlcmVkLCB0 aGUgV0syIGxheWVyIGluIHRoZSBVSSBwcm9jZXNzIGlzIHN1cHBvc2VkCisgICAgICAgIHRvIHNl bmQgYSBtZXNzYWdlIGJhY2sgdG8gdGhlIFdlYlByb2Nlc3MgaW5kaWNhdGluZyB0aGF0IHRoZSBs YXllciBob3N0aW5nIG1vZGUgb2YgdGhlCisgICAgICAgIGNvbnRhaW5pbmcgd2luZG93IGlzIGRp ZmZlcmVudCwgc28gdGhhdCB0aGUgV2ViUHJvY2VzcyBjYW4gYWRqdXN0IGl0cyBsb2dpYyBhY2Nv cmRpbmdseS4KKyAgICAgICAgVW5mb3J0dW5hdGVseSwgdGhlIG5vdGlmaWNhdGlvbiB0aGF0IHRo aXMgaGFkIGhhcHBlbmVkIHdhcyBub3QgZ2V0dGluZyBzZW50IHRvIHRoZQorICAgICAgICBXZWJQ cm9jZXNzIGR1ZSB0byBhbiBvcHRpbWl6YXRpb24gaW4gd2luZG93IHN0YXRlIGNoYW5nZSBsb2dp YyAoc2VlIEJ1ZyAxMzU1MDkgZm9yCisgICAgICAgIGRldGFpbHMpLgorCisgICAgICAgIFRoZSBm aXggaXMgdG8gY2hlY2sgbGF5ZXIgaG9zdGluZyBtb2RlIHN0YXRlIHdoZW4gYSBXS1ZpZXcgaXMg YWRkZWQgdG8gYSB3aW5kb3csIGFuZAorICAgICAgICBub3RpZnkgdGhlIFdlYlByb2Nlc3Mgd2hl biBpdCBuZWVkcyB0byBjaGFuZ2Ugc3RhdGUgdG8gbWF0Y2guCisgICAgICAgIAorCisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tOgorICAgICAgICAoLVtXS1ZpZXcgdmlld0Rp ZE1vdmVUb1dpbmRvd10pOiBXaGVuIG1vdmluZyB0byBhIG5ldyB3aW5kb3csIGFsd2F5cyBjYWxs CisgICAgICAgICdsYXllckhvc3RpbmdNb2RlRGlkQ2hhbmdlJyB0byBwaWNrIHVwIGFueSBjaGFu Z2VzIGluIHRoZSBsYXllciBob3N0aW5nIG1vZGUuCisKIDIwMTQtMDgtMDEgIENhcmxvcyBHYXJj aWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtDTWFrZV0gR1RLIGFu ZCBFRkwgYXJlIHVzaW5nIFBST0pFQ1RfVkVSU0lPTl9QQVRDSCB0byBkZWZpbmUgdGhlIG1pY3Jv IHZlcnNpb24KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5t bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcu bW0JKHJldmlzaW9uIDE3MTkxNykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFj L1dLVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjUwNiw2ICsyNTA2LDkgQEAgLSAodm9pZCl2 aWV3RGlkTW92ZVRvV2luZG93CiAKICAgICAgICAgW3NlbGYgX3VwZGF0ZVdpbmRvd0FuZFZpZXdG cmFtZXNdOwogCisgICAgICAgIC8vIFRPRE86IFRoaXMgY2FuIGJlIHJlbW92ZWQgd2hlbiBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1NTA5IGlzIHJlc29sdmVkLgor ICAgICAgICBfZGF0YS0+X3BhZ2UtPmxheWVySG9zdGluZ01vZGVEaWRDaGFuZ2UoKTsKKwogICAg ICAgICBpZiAoIV9kYXRhLT5fZmxhZ3NDaGFuZ2VkRXZlbnRNb25pdG9yKSB7CiAgICAgICAgICAg ICBfZGF0YS0+X2ZsYWdzQ2hhbmdlZEV2ZW50TW9uaXRvciA9IFtOU0V2ZW50IGFkZExvY2FsTW9u aXRvckZvckV2ZW50c01hdGNoaW5nTWFzazpOU0ZsYWdzQ2hhbmdlZE1hc2sgaGFuZGxlcjpeKE5T RXZlbnQgKmZsYWdzQ2hhbmdlZEV2ZW50KSB7CiAgICAgICAgICAgICAgICAgW3NlbGYgX3Bvc3RG YWtlTW91c2VNb3ZlZEV2ZW50Rm9yRmxhZ3NDaGFuZ2VkRXZlbnQ6ZmxhZ3NDaGFuZ2VkRXZlbnRd Owo=