135490 2014-07-31 18:59:32 -0700 Web Inspector: "Stop Recording" button feels unresponsive, recording takes a long time to stop 2014-07-31 21:07:29 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1026164 0 joepeck 2014-07-31 18:59:32 -0700 * SUMMARY We recently changed "Stop Recording" button to wait for a "recordingStopped" event from the backend to stop. However, this can produce a very large delay between the time the user clicked "Stop Recording" to when the frontend gets the event. This is especially bad in remote debugging, e.g. with iOS. We should have the UI immediately stop recording and ignore future events. This was the behavior before r171195. * STEPS TO REPRODUCE 1. Load <http://apple.com> in remote target 2. Inspect remote target 3. Reload via inspector 4. Quickly click the record button to "Stop Recording" => recording continues for a couple seconds <rdar://problem/17872655> 1026165 1 235870 joepeck 2014-07-31 19:02:13 -0700 Created attachment 235870 [PATCH] Proposed Fix 1026173 2 235870 timothy 2014-07-31 20:34:53 -0700 Comment on attachment 235870 [PATCH] Proposed Fix Good call. 1026180 3 235870 commit-queue 2014-07-31 21:07:26 -0700 Comment on attachment 235870 [PATCH] Proposed Fix Clearing flags on attachment: 235870 Committed r171908: <http://trac.webkit.org/changeset/171908> 1026181 4 commit-queue 2014-07-31 21:07:29 -0700 All reviewed patches have been landed. Closing bug. 235870 2014-07-31 19:02:13 -0700 2014-07-31 21:07:26 -0700 [PATCH] Proposed Fix stop-in-the-name-of.patch text/plain 1875 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRlN2NjOGUuLmU1MWZmNzkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE0LTA3LTMxICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogIlN0b3Ag UmVjb3JkaW5nIiBidXR0b24gZmVlbHMgdW5yZXNwb25zaXZlLCByZWNvcmRpbmcgdGFrZXMgYSBs b25nIHRpbWUgdG8gc3RvcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTM1NDkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1RpbWVsaW5lTWFuYWdlci5qczoK KyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZU1hbmFnZXIucHJvdG90eXBlLnN0b3BDYXB0 dXJpbmcpOgorICAgICAgICBJbW1lZGlhdGVseSBzdG9wIHRoZSByZWNvcmRpbmcgd2l0aG91dCB3 YWl0aW5nIGZvciBhbiBldmVudCBmcm9tIHRoZSBiYWNrZW5kLgorICAgICAgICBUaGlzIG1ha2Vz IHRoZSBXZWIgSW5zcGVjdG9yIFVJIGZlZWwgcmVzcG9uc2l2ZSB0byB0aGUgdXNlciBzdG9wcGlu ZyB0aGUgcmVjb3JkaW5nLgorICAgICAgICBUaGlzIGFsc28gbWF0Y2hlcyBiZWhhdmlvciBiZWZv cmUgcjE3MTE5NS4KKworMjAxNC0wNy0zMSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBw bGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFRpbWVsaW5lIHJlY29yZGluZyBpcyBu b3Qgd29ya2luZyBpbnNwZWN0aW5nIGlPUyA3IGFuZCBlYXJsaWVyCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU0NjYKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvVGltZWxpbmVNYW5h Z2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMv VGltZWxpbmVNYW5hZ2VyLmpzCmluZGV4IGU1ZDkxOTQuLjgyYzVkNjQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1RpbWVsaW5lTWFu YWdlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9s bGVycy9UaW1lbGluZU1hbmFnZXIuanMKQEAgLTcyLDkgKzcyLDkgQEAgV2ViSW5zcGVjdG9yLlRp bWVsaW5lTWFuYWdlci5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICBUaW1lbGluZUFnZW50 LnN0b3AoKTsKIAotICAgICAgICAvLyBDT01QQVRJQklMSVRZIChpT1MgNyk6IHJlY29yZGluZ1N0 b3BwZWQgZXZlbnQgZGlkIG5vdCBleGlzdCB5ZXQuIFN0b3AgZXhwbGljaXRseS4KLSAgICAgICAg aWYgKCFUaW1lbGluZUFnZW50Lmhhc0V2ZW50KCJyZWNvcmRpbmdTdG9wcGVkIikpCi0gICAgICAg ICAgICB0aGlzLmNhcHR1cmluZ1N0b3BwZWQoKTsKKyAgICAgICAgLy8gTk9URTogQWx3YXlzIHN0 b3AgaW1tZWRpYXRlbHkgaW5zdGVhZCBvZiB3YWl0aW5nIGZvciBhIFRpbWVsaW5lLnJlY29yZGlu Z1N0b3BwZWQgZXZlbnQuCisgICAgICAgIC8vIFRoaXMgd2F5IHRoZSBVSSBmZWVscyBhcyByZXNw b25zaXZlIHRvIGEgc3RvcCBhcyBwb3NzaWJsZS4KKyAgICAgICAgdGhpcy5jYXB0dXJpbmdTdG9w cGVkKCk7CiAgICAgfSwKIAogICAgIGNhcHR1cmluZ1N0YXJ0ZWQ6IGZ1bmN0aW9uKCkK