135488 2014-07-31 18:16:31 -0700 [Media iOS] Ensure there is a nice default fallback for missing wireless target names 2014-08-01 12:42:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino calvaris commit-queue eric.carlson glenn jer.noble philipj sergio oldest_to_newest 1026147 0 dino 2014-07-31 18:16:31 -0700 [Media iOS] Ensure there is a nice default fallback for missing wireless target names 1026149 1 dino 2014-07-31 18:18:11 -0700 We occasionally run into cases where this.host.externalDeviceDisplayName is empty or null, creating a pretty ugly/confusing string in the wireless playback status screen. If this happens, we should default to using "AppleTV" <rdar://problem/17879156> 1026154 2 235868 dino 2014-07-31 18:26:28 -0700 Created attachment 235868 Patch 1026184 3 235868 eric.carlson 2014-07-31 21:45:00 -0700 Comment on attachment 235868 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235868&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:113 > + var externalDeviceDisplayName = (this.host.externalDeviceDisplayName && this.host.externalDeviceDisplayName != "") ? this.host.externalDeviceDisplayName : "AppleTV"; Nit: this would be slightly easier to understand if it was split into two separate lines: var externalDeviceDisplayName = this.host.externalDeviceDisplayName; If (...) 1026319 4 dino 2014-08-01 12:42:44 -0700 Committed r171944: <http://trac.webkit.org/changeset/171944> 235868 2014-07-31 18:26:28 -0700 2014-07-31 21:45:00 -0700 Patch bug-135488-20140801112614.patch text/plain 2677 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxODkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDc5MjZjNmNjZTQ1ZWM4 MTEyMDg5MGFjZTkyNzA1ZDFjMmI3YmJkYy4uNWFiZjRmM2QwODU4MzgwYzA3ODM5YTU3NGEyNzQ1 YTZhZmI5ODMyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE0LTA3LTMxICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAorICAgICAgICBbTWVkaWEgaU9TXSBFbnN1cmUg dGhlcmUgaXMgYSBuaWNlIGRlZmF1bHQgZmFsbGJhY2sgZm9yIG1pc3Npbmcgd2lyZWxlc3MgdGFy Z2V0IG5hbWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzU0ODgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3ODc5MTU2PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIG9jY2FzaW9uYWxseSBydW4g aW50byBjYXNlcyB3aGVyZSB0aGlzLmhvc3QuZXh0ZXJuYWxEZXZpY2VEaXNwbGF5TmFtZQorICAg ICAgICBpcyBlbXB0eSBvciBudWxsLCBjcmVhdGluZyBhIHByZXR0eSB1Z2x5L2NvbmZ1c2luZyBz dHJpbmcgaW4gdGhlCisgICAgICAgIHdpcmVsZXNzIHBsYXliYWNrIHN0YXR1cyBzY3JlZW4uCisK KyAgICAgICAgSWYgdGhpcyBoYXBwZW5zLCB3ZSBzaG91bGQgZGVmYXVsdCB0byB1c2luZyAiQXBw bGVUViIuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lP Uy5qczoKKyAgICAgICAgKENvbnRyb2xsZXJJT1MucHJvdG90eXBlLnVwZGF0ZVdpcmVsZXNzUGxh eWJhY2tTdGF0dXMpOiBDaGVjayBpZiB0aGUgZXh0ZXJuYWxEZXZpY2VEaXNwbGF5TmFtZQorICAg ICAgICBpcyBlbXB0eSBvciBudWxsLCBhbmQgZmFsbCBiYWNrIHRvICJBcHBsZVRWIiBpZiBzby4K KworMjAxNC0wNy0zMSAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CisKICAgICAgICAg RGVmYXVsdCBidXR0b25zIGRvIG5vdCBwdWxzZSBpbiBPUyBYIDEwLjEwCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU0NDcKICAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzE3ODc1ODk2PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9t ZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNpT1MuanMgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qcwppbmRleCBiZGE5ZjFlYjI5ZDZhNGI1 NzdiYzRlZjNmYTcxNDAyOGJkZjQxZTRjLi4wY2U2NjM4ZWE0NDFjNzgzZjdjODkxZjBmMDZiYWNj MDljMTAxNmEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJv bHMvbWVkaWFDb250cm9sc2lPUy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh Y29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qcwpAQCAtMTEwLDEzICsxMTAsMTQgQEAgQ29udHJv bGxlcklPUy5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB2YXIgZGV2aWNlVHlwZSA9ICIiOwog ICAgICAgICAgICAgdmFyIHR5cGUgPSB0aGlzLmhvc3QuZXh0ZXJuYWxEZXZpY2VUeXBlOwogICAg ICAgICAgICAgaWYgKHR5cGUgPT0gImFpcnBsYXkiKSB7CisgICAgICAgICAgICAgICAgdmFyIGV4 dGVybmFsRGV2aWNlRGlzcGxheU5hbWUgPSAodGhpcy5ob3N0LmV4dGVybmFsRGV2aWNlRGlzcGxh eU5hbWUgJiYgdGhpcy5ob3N0LmV4dGVybmFsRGV2aWNlRGlzcGxheU5hbWUgIT0gIiIpID8gdGhp cy5ob3N0LmV4dGVybmFsRGV2aWNlRGlzcGxheU5hbWUgOiAiQXBwbGVUViI7CiAgICAgICAgICAg ICAgICAgZGV2aWNlVHlwZSA9IHRoaXMuVUlTdHJpbmcoJyMjV0lSRUxFU1NfUExBWUJBQ0tfREVW SUNFX1RZUEUjIycpOwotICAgICAgICAgICAgICAgIGRldmljZU5hbWUgPSB0aGlzLlVJU3RyaW5n KCcjI1dJUkVMRVNTX1BMQVlCQUNLX0RFVklDRV9OQU1FIyMnLCAnIyNERVZJQ0VfTkFNRSMjJywg dGhpcy5ob3N0LmV4dGVybmFsRGV2aWNlRGlzcGxheU5hbWUpOworICAgICAgICAgICAgICAgIGRl dmljZU5hbWUgPSB0aGlzLlVJU3RyaW5nKCcjI1dJUkVMRVNTX1BMQVlCQUNLX0RFVklDRV9OQU1F IyMnLCAnIyNERVZJQ0VfTkFNRSMjJywgZXh0ZXJuYWxEZXZpY2VEaXNwbGF5TmFtZSk7CiAgICAg ICAgICAgICB9IGVsc2UgaWYgKHR5cGUgPT0gInR2b3V0IikgewogICAgICAgICAgICAgICAgIGRl dmljZVR5cGUgPSB0aGlzLlVJU3RyaW5nKCcjI1RWT1VUX0RFVklDRV9UWVBFIyMnKTsKICAgICAg ICAgICAgICAgICBkZXZpY2VOYW1lID0gdGhpcy5VSVN0cmluZygnIyNUVk9VVF9ERVZJQ0VfTkFN RSMjJyk7CiAgICAgICAgICAgICB9Ci0gICAgICAgICAgICAKKwogICAgICAgICAgICAgYmFja2dy b3VuZEltYWdlU1ZHID0gYmFja2dyb3VuZEltYWdlU1ZHLnJlcGxhY2UoJyMjREVWSUNFX1RZUEUj IycsIGRldmljZVR5cGUpOwogICAgICAgICAgICAgYmFja2dyb3VuZEltYWdlU1ZHID0gYmFja2dy b3VuZEltYWdlU1ZHLnJlcGxhY2UoJyMjREVWSUNFX05BTUUjIycsIGRldmljZU5hbWUpOwogCg==