135482 2014-07-31 17:02:41 -0700 MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode 2014-07-31 17:51:55 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham oldest_to_newest 1026122 0 bfulgham 2014-07-31 17:02:41 -0700 You cannot enter Fullscreen mode for videos in a MiniBrowser WebKit2 window. This should be fixed! 1026123 1 235861 bfulgham 2014-07-31 17:08:31 -0700 Created attachment 235861 Patch 1026124 2 235861 thorton 2014-07-31 17:15:07 -0700 Comment on attachment 235861 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235861&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h:53 > +@property (nonatomic, setter=_setFullScreenEnabled:) BOOL _fullScreenIsEnabled; no is plz 1026137 3 bfulgham 2014-07-31 17:41:12 -0700 Landed in two patches: Committed r171897 <http://trac.webkit.org/changeset/171897>. Committed r171899 <http://trac.webkit.org/changeset/171899>. 1026143 4 bfulgham 2014-07-31 17:51:55 -0700 One more -- i forgot to fix MinIBrowser itself: Committed r171900 <http://trac.webkit.org/changeset/171900>. 235861 2014-07-31 17:08:31 -0700 2014-07-31 17:15:07 -0700 Patch bug-135482-20140731170818.patch text/plain 3776 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTg5NikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA3LTMxICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIE1pbmlCcm93c2VyIFNob3Vs ZCBTdXBwb3J0IEZ1bGxzY3JlZW4gVmlkZW9zIGluIFdlYktpdDIgTW9kZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1NDgyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBBZGQgYWNjZXNzb3Jz IGZvciB0aGUgbWlzc2luZyBGdWxsc2NyZWVuIEFQSSBzbyB0aGF0IE1pbmlCcm93c2VyCisgICAg ICAgIGNhbiB1c2UgdGhlbS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVm ZXJlbmNlcy5tbToKKyAgICAgICAgKC1bV0tQcmVmZXJlbmNlcyBfZnVsbFNjcmVlbklzRW5hYmxl ZF0pOiBBZGRlZC4KKyAgICAgICAgKC1bV0tQcmVmZXJlbmNlcyBfc2V0RnVsbFNjcmVlbkVuYWJs ZWQ6XSk6IEFkZGVkLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNl c1ByaXZhdGUuaDogQWRkIGFjY2Vzc29yIGZvcgorICAgICAgICBGdWxsc2NyZWVuIG1vZGUuCisK IDIwMTQtMDctMzEgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIEhp dC10ZXN0aW5nIGJyb2tlbiBpbiBXZWJLaXQgMSB2aWV3cyB3aXRoIEFwcEtpdCdzIGNvbnRlbnRJ bnNldHMKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJl bmNlcy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29h L1dLUHJlZmVyZW5jZXMubW0JKHJldmlzaW9uIDE3MTg5NikKKysrIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTYz LDYgKzE2MywxNiBAQCAtICh2b2lkKV9zZXRPZmZsaW5lQXBwbGljYXRpb25DYWNoZUlzRW5hCiAg ICAgX3ByZWZlcmVuY2VzLT5zZXRPZmZsaW5lV2ViQXBwbGljYXRpb25DYWNoZUVuYWJsZWQob2Zm bGluZUFwcGxpY2F0aW9uQ2FjaGVJc0VuYWJsZWQpOwogfQogCistIChCT09MKV9mdWxsU2NyZWVu SXNFbmFibGVkCit7CisgICAgcmV0dXJuIF9wcmVmZXJlbmNlcy0+ZnVsbFNjcmVlbkVuYWJsZWQo KTsKK30KKworLSAodm9pZClfc2V0RnVsbFNjcmVlbkVuYWJsZWQ6KEJPT0wpZnVsbFNjcmVlbkVu YWJsZWQKK3sKKyAgICBfcHJlZmVyZW5jZXMtPnNldEZ1bGxTY3JlZW5FbmFibGVkKGZ1bGxTY3Jl ZW5FbmFibGVkKTsKK30KKwogLSAoQk9PTClfY29tcG9zaXRpbmdCb3JkZXJzVmlzaWJsZQogewog ICAgIHJldHVybiBfcHJlZmVyZW5jZXMtPmNvbXBvc2l0aW5nQm9yZGVyc1Zpc2libGUoKTsKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlc1ByaXZh dGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dL UHJlZmVyZW5jZXNQcml2YXRlLmgJKHJldmlzaW9uIDE3MTg5NikKKysrIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlc1ByaXZhdGUuaAkod29ya2luZyBjb3B5 KQpAQCAtNTAsNiArNTAsNyBAQCB0eXBlZGVmIE5TX0VOVU0oTlNJbnRlZ2VyLCBfV0tTdG9yYWdl QmxvCiAvLyBGSVhNRTogVGhpcyBzaG91bGQgYmUgY29uZmlndXJlZCBvbiB0aGUgV0tXZWJzaXRl RGF0YVN0b3JlLgogLy8gRklYTUU6IFRoaXMgcHJvcGVydHkgc2hvdWxkIG5vdCBoYXZlIHRoZSB2 ZXJiICJpcyIgaW4gaXQuCiBAcHJvcGVydHkgKG5vbmF0b21pYywgc2V0dGVyPV9zZXRPZmZsaW5l QXBwbGljYXRpb25DYWNoZUlzRW5hYmxlZDopIEJPT0wgX29mZmxpbmVBcHBsaWNhdGlvbkNhY2hl SXNFbmFibGVkOworQHByb3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0RnVsbFNjcmVlbkVu YWJsZWQ6KSBCT09MIF9mdWxsU2NyZWVuSXNFbmFibGVkOwogCiBAZW5kCiAKSW5kZXg6IFRvb2xz L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTg5 NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisy MDE0LTA3LTMxICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAg IE1pbmlCcm93c2VyIFNob3VsZCBTdXBwb3J0IEZ1bGxzY3JlZW4gVmlkZW9zIGluIFdlYktpdDIg TW9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1 NDgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBN aW5pQnJvd3Nlci9tYWMvV0syQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIubToKKyAgICAgICAgKC1b V0syQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIgYXdha2VGcm9tTmliXSk6IEFjdGl2YXRlIHRoZSBG dWxsc2NyZWVuCisgICAgICAgIGZlYXR1cmUuCisKIDIwMTQtMDctMzEgIEFsZXhleSBQcm9za3Vy eWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgW01hYywgaU9TXSBSZW1vdmUgLXNldEFs bG93c0FueUhUVFBTQ2VydGlmaWNhdGUgY2FsbHMKSW5kZXg6IFRvb2xzL01pbmlCcm93c2VyL21h Yy9XSzJCcm93c2VyV2luZG93Q29udHJvbGxlci5tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL01pbmlC cm93c2VyL21hYy9XSzJCcm93c2VyV2luZG93Q29udHJvbGxlci5tCShyZXZpc2lvbiAxNzE4OTYp CisrKyBUb29scy9NaW5pQnJvd3Nlci9tYWMvV0syQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIubQko d29ya2luZyBjb3B5KQpAQCAtNTksNiArNTksNyBAQCAtICh2b2lkKWF3YWtlRnJvbU5pYgogICAg ICAgICBjb25maWd1cmF0aW9uLnByZWZlcmVuY2VzLl90aWxlZFNjcm9sbGluZ0luZGljYXRvclZp c2libGUgPSBbc2VsZiB0aWxlZFNjcm9sbGluZ0luZGljYXRvclZpc2libGVdOwogICAgICAgICBj b25maWd1cmF0aW9uLnByZWZlcmVuY2VzLl9jb21wb3NpdGluZ0JvcmRlcnNWaXNpYmxlID0gW3Nl bGYgbGF5ZXJCb3JkZXJzVmlzaWJsZV07CiAgICAgICAgIGNvbmZpZ3VyYXRpb24ucHJlZmVyZW5j ZXMuX2NvbXBvc2l0aW5nUmVwYWludENvdW50ZXJzVmlzaWJsZSA9IFtzZWxmIGxheWVyQm9yZGVy c1Zpc2libGVdOworICAgICAgICBjb25maWd1cmF0aW9uLnByZWZlcmVuY2VzLl9mdWxsU2NyZWVu SXNFbmFibGVkID0gWUVTOwogICAgIH0KICAgICBfd2ViVmlldyA9IFtbV0tXZWJWaWV3IGFsbG9j XSBpbml0V2l0aEZyYW1lOltjb250YWluZXJWaWV3IGJvdW5kc10gY29uZmlndXJhdGlvbjpjb25m aWd1cmF0aW9uXTsKIAo=