135471 2014-07-31 13:56:07 -0700 CodeBlock fails to visit the Executables of its InlineCallFrames 2014-08-01 14:06:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg clopez fpizlo ggaren ossy oldest_to_newest 1026057 0 mhahnenberg 2014-07-31 13:56:07 -0700 This leads to crashes after these Executables are prematurely deleted and then accessed later. 1026059 1 235840 mhahnenberg 2014-07-31 13:59:19 -0700 Created attachment 235840 Patch 1026108 2 235840 ggaren 2014-07-31 16:36:53 -0700 Comment on attachment 235840 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235840&action=review > Source/JavaScriptCore/bytecode/CodeOrigin.h:153 > return jsCast<JSFunction*>(calleeRecovery.constant()); > return 0; > } > + > + void visitAggregate(SlotVisitor& visitor) > + { > + visitor.append(&executable); > + } This poor second-class class can probably be a first-class class in its own header. That way, we provide upward mobility inside our code base. 1026321 3 235840 ggaren 2014-08-01 13:17:48 -0700 Comment on attachment 235840 Patch Clearing flags on attachment: 235840 Committed r171946: <http://trac.webkit.org/changeset/171946> 1026322 4 ggaren 2014-08-01 13:17:50 -0700 All reviewed patches have been landed. Closing bug. 1026327 5 ossy 2014-08-01 14:01:09 -0700 (In reply to comment #3) > (From update of attachment 235840 [details]) > Clearing flags on attachment: 235840 > > Committed r171946: <http://trac.webkit.org/changeset/171946> It broke the non Apple builds as the EWS noticed it. Thanks. :-/ Buildfix landed in http://trac.webkit.org/changeset/171949. 235840 2014-07-31 13:59:19 -0700 2014-08-01 13:17:47 -0700 Patch bug-135471-20140731135906.patch text/plain 3528 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcxODg0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE0LTA3LTMxICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgQ29kZUJsb2NrIGZhaWxzIHRvIHZpc2l0IHRoZSBFeGVjdXRhYmxlcyBvZiBpdHMg SW5saW5lQ2FsbEZyYW1lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTM1NDcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ29kZUJsb2NrIG5lZWRzIHRvIHZpc2l0IGl0cyBJbmxpbmVDYWxsRnJhbWVzJyBv d25lciBFeGVjdXRhYmxlcy4gSWYgaXQgZG9lc24ndCwgdGhleSAKKyAgICAgICAgY2FuIGJlIHBy ZW1hdHVyZWx5IGNvbGxlY3RlZCBhbmQgY2F1c2UgY3Jhc2hlcy4KKworICAgICAgICAqIGJ5dGVj b2RlL0NvZGVCbG9jay5jcHA6CisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6c3Ryb25nbHlWaXNp dFN0cm9uZ1JlZmVyZW5jZXMpOgorICAgICAgICAqIGJ5dGVjb2RlL0NvZGVPcmlnaW4uaDoKKyAg ICAgICAgKEpTQzo6SW5saW5lQ2FsbEZyYW1lOjp2aXNpdEFnZ3JlZ2F0ZSk6CisgICAgICAgICog Ynl0ZWNvZGUvSW5saW5lQ2FsbEZyYW1lU2V0LmNwcDoKKyAgICAgICAgKEpTQzo6SW5saW5lQ2Fs bEZyYW1lU2V0Ojp2aXNpdEFnZ3JlZ2F0ZSk6CisgICAgICAgICogYnl0ZWNvZGUvSW5saW5lQ2Fs bEZyYW1lU2V0Lmg6CisKIDIwMTQtMDctMjkgIE1hdHRoZXcgSGFuc29uICA8bWF0dGhld19oYW5z b25AYXBwbGUuY29tPgogCiAgICAgICAgIE1lcmdlIHIxNzE2ODkuIDxyZGFyOi8vcHJvYmxlbS8x Nzg0NDg5MD4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2su Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxv Y2suY3BwCShyZXZpc2lvbiAxNzE4MjUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNv ZGUvQ29kZUJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjM5OCw2ICsyMzk4LDE0IEBAIHZv aWQgQ29kZUJsb2NrOjpzdHJvbmdseVZpc2l0U3Ryb25nUmVmZXIKICAgICBmb3IgKHVuc2lnbmVk IGkgPSAwOyBpIDwgbV9vYmplY3RBbGxvY2F0aW9uUHJvZmlsZXMuc2l6ZSgpOyArK2kpCiAgICAg ICAgIG1fb2JqZWN0QWxsb2NhdGlvblByb2ZpbGVzW2ldLnZpc2l0QWdncmVnYXRlKHZpc2l0b3Ip OwogCisjaWYgRU5BQkxFKERGR19KSVQpCisgICAgaWYgKEpJVENvZGU6OmlzT3B0aW1pemluZ0pJ VChqaXRUeXBlKCkpKSB7CisgICAgICAgIERGRzo6Q29tbW9uRGF0YSogZGZnQ29tbW9uID0gbV9q aXRDb2RlLT5kZmdDb21tb24oKTsKKyAgICAgICAgaWYgKGRmZ0NvbW1vbi0+aW5saW5lQ2FsbEZy YW1lcy5nZXQoKSkKKyAgICAgICAgICAgIGRmZ0NvbW1vbi0+aW5saW5lQ2FsbEZyYW1lcy0+dmlz aXRBZ2dyZWdhdGUodmlzaXRvcik7CisgICAgfQorI2VuZGlmCisKICAgICB1cGRhdGVBbGxQcmVk aWN0aW9ucygpOwogfQogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29k ZU9yaWdpbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9D b2RlT3JpZ2luLmgJKHJldmlzaW9uIDE3MTgyNSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9i eXRlY29kZS9Db2RlT3JpZ2luLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0Niw2ICsxNDYsMTEgQEAg c3RydWN0IElubGluZUNhbGxGcmFtZSB7CiAgICAgICAgICAgICByZXR1cm4ganNDYXN0PEpTRnVu Y3Rpb24qPihjYWxsZWVSZWNvdmVyeS5jb25zdGFudCgpKTsKICAgICAgICAgcmV0dXJuIDA7CiAg ICAgfQorCisgICAgdm9pZCB2aXNpdEFnZ3JlZ2F0ZShTbG90VmlzaXRvciYgdmlzaXRvcikKKyAg ICB7CisgICAgICAgIHZpc2l0b3IuYXBwZW5kKCZleGVjdXRhYmxlKTsKKyAgICB9CiAgICAgCiAg ICAgLy8gR2V0IHRoZSBjYWxsZWUgZ2l2ZW4gYSBtYWNoaW5lIGNhbGwgZnJhbWUgdG8gd2hpY2gg dGhpcyBJbmxpbmVDYWxsRnJhbWUgYmVsb25ncy4KICAgICBKU0Z1bmN0aW9uKiBjYWxsZWVGb3JD YWxsRnJhbWUoRXhlY1N0YXRlKikgY29uc3Q7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv Ynl0ZWNvZGUvSW5saW5lQ2FsbEZyYW1lU2V0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvYnl0ZWNvZGUvSW5saW5lQ2FsbEZyYW1lU2V0LmNwcAkocmV2aXNpb24gMTcx ODI1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0lubGluZUNhbGxGcmFtZVNl dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM2LDUgKzM2LDExIEBAIElubGluZUNhbGxGcmFtZSog SW5saW5lQ2FsbEZyYW1lU2V0OjphZGQKICAgICByZXR1cm4gbV9mcmFtZXMuYWRkKCk7CiB9CiAK K3ZvaWQgSW5saW5lQ2FsbEZyYW1lU2V0Ojp2aXNpdEFnZ3JlZ2F0ZShTbG90VmlzaXRvciYgdmlz aXRvcikKK3sKKyAgICBmb3IgKElubGluZUNhbGxGcmFtZSogY2FsbEZyYW1lIDogbV9mcmFtZXMp CisgICAgICAgIGNhbGxGcmFtZS0+dmlzaXRBZ2dyZWdhdGUodmlzaXRvcik7Cit9CisgICAgCiB9 IC8vIG5hbWVzcGFjZSBKU0MKIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2Rl L0lubGluZUNhbGxGcmFtZVNldC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ieXRlY29kZS9JbmxpbmVDYWxsRnJhbWVTZXQuaAkocmV2aXNpb24gMTcxODI1KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0lubGluZUNhbGxGcmFtZVNldC5oCSh3b3JraW5n IGNvcHkpCkBAIC00NCw2ICs0NCw4IEBAIHB1YmxpYzoKICAgICB0eXBlZGVmIEJhZzxJbmxpbmVD YWxsRnJhbWU+OjppdGVyYXRvciBpdGVyYXRvcjsKICAgICBpdGVyYXRvciBiZWdpbigpIHsgcmV0 dXJuIG1fZnJhbWVzLmJlZ2luKCk7IH0KICAgICBpdGVyYXRvciBlbmQoKSB7IHJldHVybiBtX2Zy YW1lcy5lbmQoKTsgfQorCisgICAgdm9pZCB2aXNpdEFnZ3JlZ2F0ZShTbG90VmlzaXRvciYpOwog ICAgIAogcHJpdmF0ZToKICAgICBCYWc8SW5saW5lQ2FsbEZyYW1lPiBtX2ZyYW1lczsK