135469 2014-07-31 13:45:16 -0700 Subpixel rendering: Region painting needs to take subpixel accumulation into account. 2014-07-31 16:55:56 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble kondapallykalyan philipj sergio simon.fraser oldest_to_newest 1026055 0 zalan 2014-07-31 13:45:16 -0700 While we round the offset and translate the context with it, the subpixel value gets lost. RenderLayer::paintNamedFlowThreadInsideRegion() 1026063 1 235842 zalan 2014-07-31 14:23:51 -0700 Created attachment 235842 Patch 1026118 2 235842 commit-queue 2014-07-31 16:55:51 -0700 Comment on attachment 235842 Patch Clearing flags on attachment: 235842 Committed r171896: <http://trac.webkit.org/changeset/171896> 1026119 3 commit-queue 2014-07-31 16:55:56 -0700 All reviewed patches have been landed. Closing bug. 235842 2014-07-31 14:23:51 -0700 2014-07-31 16:55:50 -0700 Patch bug-135469-20140731142338.patch text/plain 7443 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxODU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTI1ZDVkM2JkMWE5OTcy NDFmOWIwOTQxMzIwNmRhZDQwN2M1NTYzNS4uNDdiZWMxMmI3NzVlMDhkNzhjMGE3OGQ0YWYzYWY2 YWY0Zjc0NjJhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE0LTA3LTMxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU3VicGl4ZWwgcmVuZGVyaW5n OiBSZWdpb24gcGFpbnRpbmcgbmVlZHMgdG8gdGFrZSBzdWJwaXhlbCBhY2N1bXVsYXRpb24gaW50 byBhY2NvdW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM1NDY5CisKKyAgICAgICAgU2ltaWxhciB0byBub24tcmVnaW9uIHBhaW50aW5nLCB3aGVu IHRoZSBjb250ZXh0IGlzIHRyYW5zbGF0ZWQsIHdlIG5lZWQgdG8gcHJvcGFnYXRlCisgICAgICAg IHRoZSBzdWJwaXhlbCBkaWZmZXJlbmNlIHNvIHRoYXQgcmVuZGVyZXJzIGdldCBzbmFwcGVkIHRv IHRoZSBzYW1lIHBvc2l0aW9uIGFzIGlmIHRoZXkKKyAgICAgICAgd2VyZSBub3QgcGFydCBvZiBh IHJlZ2lvbi4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzL25vdCB0ZXN0YWJsZSAod2Via2l0Lm9yZy9iLzEz NTQ3MCkKKworICAgICAgICAqIGh0bWwvc2hhZG93L01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhQ29udHJvbFRleHRUcmFja0NvbnRhaW5lckVsZW1lbnQ6 OmNyZWF0ZVRleHRUcmFja1JlcHJlc2VudGF0aW9uSW1hZ2UpOgorICAgICAgICAqIHBhZ2UvRnJh bWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6cGFpbnRDb250ZW50cyk6 CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlckxheWVyOjpwYWludCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6Y2Fs Y3VsYXRlQ2xpcFJlY3RzKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaDoKKwog MjAxNC0wNy0zMSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFdl YkNvcmUgcGFydCBvZjogU2VydmVyIHRydXN0IGF1dGhlbnRpY2F0aW9uIGNoYWxsZW5nZXMgYXJl buKAmXQgc2VudCB0byB0aGUgbmF2aWdhdGlvbiBkZWxlZ2F0ZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwIGIvU291cmNlL1dl YkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwCmluZGV4IDhhZGI3OTAw YWRjNDNjYWZlZjU0NGU3Yzg0NTVhODBlM2M3ZGUyMTcuLjU1OTIwMWE0YTI4ZTlkY2FlNmQzZWQ5 YzI3OTRiMmM0ZTZkZjYxNDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93 L01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRv dy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAKQEAgLTE1MzQsNyArMTUzNCw3IEBAIFBhc3NSZWZQ dHI8SW1hZ2U+IE1lZGlhQ29udHJvbFRleHRUcmFja0NvbnRhaW5lckVsZW1lbnQ6OmNyZWF0ZVRl eHRUcmFja1JlcHJlc2VuCiAgICAgaWYgKCFidWZmZXIpCiAgICAgICAgIHJldHVybiBudWxscHRy OwogCi0gICAgbGF5ZXItPnBhaW50KGJ1ZmZlci0+Y29udGV4dCgpLCBwYWludGluZ1JlY3QsIFBh aW50QmVoYXZpb3JGbGF0dGVuQ29tcG9zaXRpbmdMYXllcnMsIG51bGxwdHIsIFJlbmRlckxheWVy OjpQYWludExheWVyUGFpbnRpbmdDb21wb3NpdGluZ0FsbFBoYXNlcyk7CisgICAgbGF5ZXItPnBh aW50KGJ1ZmZlci0+Y29udGV4dCgpLCBwYWludGluZ1JlY3QsIExheW91dFNpemUoKSwgUGFpbnRC ZWhhdmlvckZsYXR0ZW5Db21wb3NpdGluZ0xheWVycywgbnVsbHB0ciwgUmVuZGVyTGF5ZXI6OlBh aW50TGF5ZXJQYWludGluZ0NvbXBvc2l0aW5nQWxsUGhhc2VzKTsKIAogICAgIHJldHVybiBidWZm ZXItPmNvcHlJbWFnZSgpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFt ZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IDk5YjQ2 MzJkN2FlYWI2ODEzODI2ZjYxMjNkOWE3NTg2ZTcwZDE4NWYuLjZmMmQ5YzU4OWQ5ZWU5MDg5OTZl OGE4MDk3Y2YzOWExNTU2YTFiMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJh bWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTM2 ODQsNyArMzY4NCw3IEBAIHZvaWQgRnJhbWVWaWV3OjpwYWludENvbnRlbnRzKEdyYXBoaWNzQ29u dGV4dCogY29udGV4dCwgY29uc3QgSW50UmVjdCYgZGlydHlSZWN0CiAgICAgd2hpbGUgKGVsdFJl bmRlcmVyICYmIGVsdFJlbmRlcmVyLT5pc1JlbmRlcklubGluZSgpICYmICF0b1JlbmRlcklubGlu ZShlbHRSZW5kZXJlciktPmZpcnN0TGluZUJveCgpKQogICAgICAgICBlbHRSZW5kZXJlciA9IGVs dFJlbmRlcmVyLT5wYXJlbnQoKTsKIAotICAgIHJvb3RMYXllci0+cGFpbnQoY29udGV4dCwgZGly dHlSZWN0LCBtX3BhaW50QmVoYXZpb3IsIGVsdFJlbmRlcmVyKTsKKyAgICByb290TGF5ZXItPnBh aW50KGNvbnRleHQsIGRpcnR5UmVjdCwgTGF5b3V0U2l6ZSgpLCBtX3BhaW50QmVoYXZpb3IsIGVs dFJlbmRlcmVyKTsKICAgICBpZiAocm9vdExheWVyLT5jb250YWluc0RpcnR5T3ZlcmxheVNjcm9s bGJhcnMoKSkKICAgICAgICAgcm9vdExheWVyLT5wYWludE92ZXJsYXlTY3JvbGxiYXJzKGNvbnRl eHQsIGRpcnR5UmVjdCwgbV9wYWludEJlaGF2aW9yLCBlbHRSZW5kZXJlcik7CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4IGIyOTIyZDU1ZDFmYmYzZDM4MGQ2 MGViNjI1ODgxOWM0Njg1N2RiODcuLjhjNzY1ODIwYWUxNDEyNzBiOTZiZjdiY2RjMTI2OGEzZmVk MzA4YmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApAQCAtMzU0 NiwxMSArMzU0NiwxMSBAQCBib29sIFJlbmRlckxheWVyOjpzY3JvbGwoU2Nyb2xsRGlyZWN0aW9u IGRpcmVjdGlvbiwgU2Nyb2xsR3JhbnVsYXJpdHkgZ3JhbnVsYXJpdAogICAgIHJldHVybiBTY3Jv bGxhYmxlQXJlYTo6c2Nyb2xsKGRpcmVjdGlvbiwgZ3JhbnVsYXJpdHksIG11bHRpcGxpZXIpOwog fQogCi12b2lkIFJlbmRlckxheWVyOjpwYWludChHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNv bnN0IExheW91dFJlY3QmIGRhbWFnZVJlY3QsIFBhaW50QmVoYXZpb3IgcGFpbnRCZWhhdmlvciwg UmVuZGVyT2JqZWN0KiBzdWJ0cmVlUGFpbnRSb290LCBQYWludExheWVyRmxhZ3MgcGFpbnRGbGFn cykKK3ZvaWQgUmVuZGVyTGF5ZXI6OnBhaW50KEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29u c3QgTGF5b3V0UmVjdCYgZGFtYWdlUmVjdCwgY29uc3QgTGF5b3V0U2l6ZSYgc3VicGl4ZWxBY2N1 bXVsYXRpb24sIFBhaW50QmVoYXZpb3IgcGFpbnRCZWhhdmlvciwgUmVuZGVyT2JqZWN0KiBzdWJ0 cmVlUGFpbnRSb290LCBQYWludExheWVyRmxhZ3MgcGFpbnRGbGFncykKIHsKICAgICBPdmVybGFw VGVzdFJlcXVlc3RNYXAgb3ZlcmxhcFRlc3RSZXF1ZXN0czsKIAotICAgIExheWVyUGFpbnRpbmdJ bmZvIHBhaW50aW5nSW5mbyh0aGlzLCBlbmNsb3NpbmdJbnRSZWN0KGRhbWFnZVJlY3QpLCBwYWlu dEJlaGF2aW9yLCBMYXlvdXRTaXplKCksIHN1YnRyZWVQYWludFJvb3QsICZvdmVybGFwVGVzdFJl cXVlc3RzKTsKKyAgICBMYXllclBhaW50aW5nSW5mbyBwYWludGluZ0luZm8odGhpcywgZW5jbG9z aW5nSW50UmVjdChkYW1hZ2VSZWN0KSwgcGFpbnRCZWhhdmlvciwgc3VicGl4ZWxBY2N1bXVsYXRp b24sIHN1YnRyZWVQYWludFJvb3QsICZvdmVybGFwVGVzdFJlcXVlc3RzKTsKICAgICBwYWludExh eWVyKGNvbnRleHQsIHBhaW50aW5nSW5mbywgcGFpbnRGbGFncyk7CiAKICAgICBPdmVybGFwVGVz dFJlcXVlc3RNYXA6Oml0ZXJhdG9yIGVuZCA9IG92ZXJsYXBUZXN0UmVxdWVzdHMuZW5kKCk7CkBA IC02NjgwLDIxICs2NjgwLDE5IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OmZpbHRlck5lZWRzUmVwYWlu dCgpCiB2b2lkIFJlbmRlckxheWVyOjpwYWludE5hbWVkRmxvd1RocmVhZEluc2lkZVJlZ2lvbihH cmFwaGljc0NvbnRleHQqIGNvbnRleHQsIFJlbmRlck5hbWVkRmxvd0ZyYWdtZW50KiByZWdpb24s IExheW91dFJlY3QgcGFpbnREaXJ0eVJlY3QsIExheW91dFBvaW50IHBhaW50T2Zmc2V0LCBQYWlu dEJlaGF2aW9yIHBhaW50QmVoYXZpb3IsIFBhaW50TGF5ZXJGbGFncyBwYWludEZsYWdzKQogewog ICAgIExheW91dFJlY3QgcmVnaW9uQ29udGVudEJveCA9IHRvUmVuZGVyQm94KHJlZ2lvbi0+bGF5 ZXJPd25lcigpKS5jb250ZW50Qm94UmVjdCgpOwotICAgIExheW91dFNpemUgbW92ZU9mZnNldCA9 IHJlZ2lvbi0+Zmxvd1RocmVhZFBvcnRpb25Mb2NhdGlvbigpIC0gKHBhaW50T2Zmc2V0ICsgcmVn aW9uQ29udGVudEJveC5sb2NhdGlvbigpKSArIHJlZ2lvbi0+ZnJhZ21lbnRDb250YWluZXIoKS5z Y3JvbGxlZENvbnRlbnRPZmZzZXQoKTsKLQotICAgIEZsb2F0UG9pbnQgYWRqdXN0ZWRQYWludE9m ZnNldCA9IHJvdW5kZWRGb3JQYWludGluZyhMYXlvdXRQb2ludCgtbW92ZU9mZnNldC53aWR0aCgp LCAtbW92ZU9mZnNldC5oZWlnaHQoKSksIHJlbmRlcmVyKCkuZG9jdW1lbnQoKS5kZXZpY2VTY2Fs ZUZhY3RvcigpKTsKLSAgICBwYWludERpcnR5UmVjdC5tb3ZlKG1vdmVPZmZzZXQpOwotCi0gICAg Y29udGV4dC0+c2F2ZSgpOwotICAgIGNvbnRleHQtPnRyYW5zbGF0ZShhZGp1c3RlZFBhaW50T2Zm c2V0LngoKSwgYWRqdXN0ZWRQYWludE9mZnNldC55KCkpOwotCiAgICAgQ3VycmVudFJlbmRlckZs b3dUaHJlYWRNYWludGFpbmVyIGZsb3dUaHJlYWRNYWludGFpbmVyKHRvUmVuZGVyRmxvd1RocmVh ZCgmcmVuZGVyZXIoKSkpOwogICAgIEN1cnJlbnRSZW5kZXJSZWdpb25NYWludGFpbmVyIHJlZ2lv bk1haW50YWluZXIoKnJlZ2lvbik7Ci0KICAgICByZWdpb24tPnNldFJlZ2lvbk9iamVjdHNSZWdp b25TdHlsZSgpOwotICAgIHBhaW50KGNvbnRleHQsIHBhaW50RGlydHlSZWN0LCBwYWludEJlaGF2 aW9yLCBudWxscHRyLCBwYWludEZsYWdzIHwgUGFpbnRMYXllclRlbXBvcmFyeUNsaXBSZWN0cyk7 Ci0gICAgcmVnaW9uLT5yZXN0b3JlUmVnaW9uT2JqZWN0c09yaWdpbmFsU3R5bGUoKTsKIAorICAg IExheW91dFNpemUgbW92ZU9mZnNldCA9IHJlZ2lvbi0+Zmxvd1RocmVhZFBvcnRpb25Mb2NhdGlv bigpIC0gKHBhaW50T2Zmc2V0ICsgcmVnaW9uQ29udGVudEJveC5sb2NhdGlvbigpKSArIHJlZ2lv bi0+ZnJhZ21lbnRDb250YWluZXIoKS5zY3JvbGxlZENvbnRlbnRPZmZzZXQoKTsKKyAgICBGbG9h dFBvaW50IGFkanVzdGVkUGFpbnRPZmZzZXQgPSByb3VuZGVkRm9yUGFpbnRpbmcodG9MYXlvdXRQ b2ludChtb3ZlT2Zmc2V0KSwgcmVuZGVyZXIoKS5kb2N1bWVudCgpLmRldmljZVNjYWxlRmFjdG9y KCkpOworICAgIGNvbnRleHQtPnNhdmUoKTsKKyAgICBjb250ZXh0LT50cmFuc2xhdGUoLWFkanVz dGVkUGFpbnRPZmZzZXQueCgpLCAtYWRqdXN0ZWRQYWludE9mZnNldC55KCkpOworCisgICAgTGF5 b3V0U2l6ZSBzdWJwaXhlbEFjY3VtdWxhdGlvbiA9IG1vdmVPZmZzZXQgLSB0b0xheW91dFNpemUo TGF5b3V0UG9pbnQoYWRqdXN0ZWRQYWludE9mZnNldCkpOworICAgIHBhaW50RGlydHlSZWN0Lm1v dmUobW92ZU9mZnNldCk7CisgICAgcGFpbnQoY29udGV4dCwgcGFpbnREaXJ0eVJlY3QsIHN1YnBp eGVsQWNjdW11bGF0aW9uLCBwYWludEJlaGF2aW9yLCBudWxscHRyLCBwYWludEZsYWdzIHwgUGFp bnRMYXllclRlbXBvcmFyeUNsaXBSZWN0cyk7CisgICAgcmVnaW9uLT5yZXN0b3JlUmVnaW9uT2Jq ZWN0c09yaWdpbmFsU3R5bGUoKTsKICAgICBjb250ZXh0LT5yZXN0b3JlKCk7CiB9CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKaW5kZXggMmFhNDk1N2M5ZWI5NDM1NWRiOTdj Y2QzNDIwNTkyNTVkMGMzZTAxNi4uMjZjY2Y2Mzc0ZDQ3NmM2OWRmZmM0NTkzM2M0OGZiNjIyNjU0 MDA3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKQEAgLTY3MSw3ICs2 NzEsOCBAQCBwdWJsaWM6CiAgICAgLy8gcGFpbnRzIHRoZSBsYXllcnMgdGhhdCBpbnRlcnNlY3Qg dGhlIGRhbWFnZSByZWN0IGZyb20gYmFjayB0bwogICAgIC8vIGZyb250LiAgVGhlIGhpdFRlc3Qg bWV0aG9kIGxvb2tzIGZvciBtb3VzZSBldmVudHMgYnkgd2Fsa2luZwogICAgIC8vIGxheWVycyB0 aGF0IGludGVyc2VjdCB0aGUgcG9pbnQgZnJvbSBmcm9udCB0byBiYWNrLgotICAgIHZvaWQgcGFp bnQoR3JhcGhpY3NDb250ZXh0KiwgY29uc3QgTGF5b3V0UmVjdCYgZGFtYWdlUmVjdCwgUGFpbnRC ZWhhdmlvciA9IFBhaW50QmVoYXZpb3JOb3JtYWwsIFJlbmRlck9iamVjdCogc3VidHJlZVBhaW50 Um9vdCA9IG51bGxwdHIsIFBhaW50TGF5ZXJGbGFncyA9IDApOworICAgIHZvaWQgcGFpbnQoR3Jh cGhpY3NDb250ZXh0KiwgY29uc3QgTGF5b3V0UmVjdCYgZGFtYWdlUmVjdCwgY29uc3QgTGF5b3V0 U2l6ZSYgc3VicGl4ZWxBY2N1bXVsYXRpb24gPSBMYXlvdXRTaXplKCksIFBhaW50QmVoYXZpb3Ig PSBQYWludEJlaGF2aW9yTm9ybWFsLAorICAgICAgICBSZW5kZXJPYmplY3QqIHN1YnRyZWVQYWlu dFJvb3QgPSBudWxscHRyLCBQYWludExheWVyRmxhZ3MgPSAwKTsKICAgICBib29sIGhpdFRlc3Qo Y29uc3QgSGl0VGVzdFJlcXVlc3QmLCBIaXRUZXN0UmVzdWx0Jik7CiAgICAgYm9vbCBoaXRUZXN0 KGNvbnN0IEhpdFRlc3RSZXF1ZXN0JiwgY29uc3QgSGl0VGVzdExvY2F0aW9uJiwgSGl0VGVzdFJl c3VsdCYpOwogICAgIHZvaWQgcGFpbnRPdmVybGF5U2Nyb2xsYmFycyhHcmFwaGljc0NvbnRleHQq LCBjb25zdCBMYXlvdXRSZWN0JiBkYW1hZ2VSZWN0LCBQYWludEJlaGF2aW9yLCBSZW5kZXJPYmpl Y3QqIHN1YnRyZWVQYWludFJvb3QgPSBudWxscHRyKTsK