135466 2014-07-31 12:39:37 -0700 Web Inspector: Timeline recording is not working inspecting iOS 7 and earlier 2014-07-31 16:17:36 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1026038 0 joepeck 2014-07-31 12:39:37 -0700 * SUMMARY When switching to recordingStarted/recordingStopped events we broke support for older releases which don't send those events. * STEPS TO REPRODUCE 1. Inspect apple.com on iOS 7 device 2. Click to start a recording => nothing happens 1026039 1 webkit-bug-importer 2014-07-31 12:40:50 -0700 <rdar://problem/17874096> 1026042 2 235836 joepeck 2014-07-31 12:45:58 -0700 Created attachment 235836 [PATCH] Proposed Fix 1026105 3 235836 commit-queue 2014-07-31 16:17:33 -0700 Comment on attachment 235836 [PATCH] Proposed Fix Clearing flags on attachment: 235836 Committed r171894: <http://trac.webkit.org/changeset/171894> 1026106 4 commit-queue 2014-07-31 16:17:36 -0700 All reviewed patches have been landed. Closing bug. 235836 2014-07-31 12:45:58 -0700 2014-07-31 16:17:33 -0700 [PATCH] Proposed Fix fix-ios.patch text/plain 2789 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGMzMjNjNzYuLmQ4MDJmODIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE0LTA3LTMxICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxp bmUgcmVjb3JkaW5nIGlzIG5vdCB3b3JraW5nIGluc3BlY3RpbmcgaU9TIDcgYW5kIGVhcmxpZXIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTQ2Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0YXJ0IC8g c3RvcCBjYXB0dXJpbmcgZm9yIG9sZGVyIGJhY2tlbmRzIHRoYXQgd29uJ3QgZW1pdCBzdGFydCAv IHN0b3AgZXZlbnRzLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Qcm90b2NvbC9JbnNwZWN0 b3JCYWNrZW5kLmpzOgorICAgICAgICAoSW5zcGVjdG9yQmFja2VuZC5BZ2VudC5wcm90b3R5cGUu aGFzRXZlbnQpOgorICAgICAgICBQcm92aWRlIGEgd2F5IHRvIGNoZWNrIGlmIGFuIGV2ZW50IGlz IHN1cHBvcnRlZC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvVGltZWxp bmVNYW5hZ2VyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lTWFuYWdlci5wcm90 b3R5cGUuc3RhcnRDYXB0dXJpbmcpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lTWFu YWdlci5wcm90b3R5cGUuc3RvcENhcHR1cmluZyk6CisgICAgICAgIEZhbGxiYWNrIHRvIHN0YXJ0 aW5nIGFuZCBzdG9wcGluZyBjYXB0dXJpbmcgbWFudWFsbHkgaWYgdGhlIGJhY2tlbmQKKyAgICAg ICAgZG9lcyBub3QgcHJvdmlkZSB0aGUgZXZlbnRzLgorCisyMDE0LTA3LTMxICBKb3NlcGggUGVj b3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogUmln aHQgZWRnZSBvZiBUaW1lbGluZSBSZWNvcmQgYnV0dG9uIGRvZXMgbm90IHdvcmsKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTQ0NAogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9UaW1l bGluZU1hbmFnZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250 cm9sbGVycy9UaW1lbGluZU1hbmFnZXIuanMKaW5kZXggNGU5ODY0Mi4uZTVkOTE5NCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvVGlt ZWxpbmVNYW5hZ2VyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0NvbnRyb2xsZXJzL1RpbWVsaW5lTWFuYWdlci5qcwpAQCAtNjIsMTEgKzYyLDE5IEBAIFdlYklu c3BlY3Rvci5UaW1lbGluZU1hbmFnZXIucHJvdG90eXBlID0gewogICAgIHN0YXJ0Q2FwdHVyaW5n OiBmdW5jdGlvbigpCiAgICAgewogICAgICAgICBUaW1lbGluZUFnZW50LnN0YXJ0KCk7CisKKyAg ICAgICAgLy8gQ09NUEFUSUJJTElUWSAoaU9TIDcpOiByZWNvcmRpbmdTdGFydGVkIGV2ZW50IGRp ZCBub3QgZXhpc3QgeWV0LiBTdGFydCBleHBsaWNpdGx5LgorICAgICAgICBpZiAoIVRpbWVsaW5l QWdlbnQuaGFzRXZlbnQoInJlY29yZGluZ1N0YXJ0ZWQiKSkKKyAgICAgICAgICAgIHRoaXMuY2Fw dHVyaW5nU3RhcnRlZCgpOwogICAgIH0sCiAKICAgICBzdG9wQ2FwdHVyaW5nOiBmdW5jdGlvbigp CiAgICAgewogICAgICAgICBUaW1lbGluZUFnZW50LnN0b3AoKTsKKworICAgICAgICAvLyBDT01Q QVRJQklMSVRZIChpT1MgNyk6IHJlY29yZGluZ1N0b3BwZWQgZXZlbnQgZGlkIG5vdCBleGlzdCB5 ZXQuIFN0b3AgZXhwbGljaXRseS4KKyAgICAgICAgaWYgKCFUaW1lbGluZUFnZW50Lmhhc0V2ZW50 KCJyZWNvcmRpbmdTdG9wcGVkIikpCisgICAgICAgICAgICB0aGlzLmNhcHR1cmluZ1N0b3BwZWQo KTsKICAgICB9LAogCiAgICAgY2FwdHVyaW5nU3RhcnRlZDogZnVuY3Rpb24oKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvSW5zcGVjdG9y QmFja2VuZC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29s L0luc3BlY3RvckJhY2tlbmQuanMKaW5kZXggZjU3YzE1Zi4uZDIxZjI0MSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvSW5zcGVjdG9yQmFj a2VuZC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2Nv bC9JbnNwZWN0b3JCYWNrZW5kLmpzCkBAIC0yOTYsNiArMjk2LDExIEBAIEluc3BlY3RvckJhY2tl bmQuQWdlbnQucHJvdG90eXBlID0gewogICAgICAgICByZXR1cm4gdGhpcy5fZXZlbnRzW2V2ZW50 TmFtZV07CiAgICAgfSwKIAorICAgIGhhc0V2ZW50OiBmdW5jdGlvbihldmVudE5hbWUpCisgICAg eworICAgICAgICByZXR1cm4gZXZlbnROYW1lIGluIHRoaXMuX2V2ZW50czsKKyAgICB9LAorCiAg ICAgZGlzcGF0Y2hFdmVudDogZnVuY3Rpb24oZXZlbnROYW1lLCBldmVudEFyZ3VtZW50cykKICAg ICB7CiAgICAgICAgIGlmICghKGV2ZW50TmFtZSBpbiB0aGlzLl9kaXNwYXRjaGVyKSkgewo=