135464 2014-07-31 10:38:31 -0700 [Win] Fix build failure when using 5-tuple build versions 2014-07-31 11:01:09 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham ddkilzer webkit-bug-importer oldest_to_newest 1026013 0 bfulgham 2014-07-31 10:38:31 -0700 The VersionStamper tool throws an exception when the RC_PROJECTSOURCEVERSION environment variable contains more than three tuples, even when specific build arguments are given to it. To avoid the problem, temporarily set the RC_PROJECTSOURCEVERSION, RC_ProjectSourceVersion, and RC_PROJECTBUILDVERSION environment variables to safe/valid 3-tuple versions of the 5-tuple information before invoking the version stamping tool. 1026014 1 bfulgham 2014-07-31 10:39:05 -0700 Tested on builds with invalid RC_PROJECTSOURCEVERSION, RC_ProjectSourceVersion, and RC_PROJECTBUILDVERSION environment variables set. 1026017 2 235830 bfulgham 2014-07-31 10:42:37 -0700 Created attachment 235830 Patch 1026020 3 webkit-bug-importer 2014-07-31 10:44:28 -0700 <rdar://problem/17872457> 1026021 4 webkit-bug-importer 2014-07-31 10:46:18 -0700 <rdar://problem/17872507> 1026024 5 235830 ddkilzer 2014-07-31 10:53:18 -0700 Comment on attachment 235830 Patch r=me 1026026 6 bfulgham 2014-07-31 11:01:09 -0700 Committed r171870: <http://trac.webkit.org/changeset/171870> 235830 2014-07-31 10:42:37 -0700 2014-07-31 10:53:18 -0700 Patch bug-135464-20140731104240.patch text/plain 2037 bfulgham SW5kZXg6IFdlYktpdExpYnJhcmllcy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0TGli cmFyaWVzL0NoYW5nZUxvZwkocmV2aXNpb24gMTcxODY2KQorKysgV2ViS2l0TGlicmFyaWVzL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA3LTMxICBCcmVu dCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIEZpeCBidWls ZCBmYWlsdXJlIHdoZW4gdXNpbmcgNS10dXBsZSBidWlsZCB2ZXJzaW9ucy4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTQ2NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2luL3Rvb2xzL3NjcmlwdHMv dmVyc2lvbi1zdGFtcC5wbDogTW9kaWZ5IHRoZSBlbnZpcm9ubWVudCBmb3IKKyAgICAgICAgdGhl IFZlcnNpb25TdGFtcGVyIHN1Yi1wcm9jZXNzIHRvIHdvcmsgYXJvdW5kIGJ1ZyBpbiB0aGF0IHRv b2wuCisKIDIwMTQtMDctMjkgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAK ICAgICAgICAgW1dpbl0gTW9kaWZ5IHZlcnNpb24gbnVtYmVyaW5nIHNjaGVtZSB0byBzdXBwb3J0 IDUtdHVwbGUgdmVyc2lvbnMKSW5kZXg6IFdlYktpdExpYnJhcmllcy93aW4vdG9vbHMvc2NyaXB0 cy92ZXJzaW9uLXN0YW1wLnBsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdExpYnJhcmllcy93aW4vdG9v bHMvc2NyaXB0cy92ZXJzaW9uLXN0YW1wLnBsCShyZXZpc2lvbiAxNzE3OTgpCisrKyBXZWJLaXRM aWJyYXJpZXMvd2luL3Rvb2xzL3NjcmlwdHMvdmVyc2lvbi1zdGFtcC5wbAkod29ya2luZyBjb3B5 KQpAQCAtODcsNiArODcsMTcgQEAgcHJpbnQgIlByb2Nlc3NpbmcgdmVyc2lvbiAkY29tcG9uZW50 c3snXwogCiBteSAkVEFSR0VUX1BBVEggPSBGaWxlOjpTcGVjLT5jYW5vbnBhdGgoJHRhcmdldCk7 CiAKK3ByaW50ICJBZGp1c3RpbmcgUkNfUFJPSkVDVFNPVVJDRVZFUlNJT04gYW5kIFJDX1Byb2pl Y3RTb3VyY2VWZXJzaW9uIHRvIGJlIHNhZmUgZm9yIFZlcnNpb25TdGFtcGVyLlxuIjsKKworbXkg JFNBRkVfUFJPSkVDVF9WRVJTSU9OID0gIiRjb21wb25lbnRzeydfX1ZFUlNJT05fTUFKT1JfXyd9 LiRjb21wb25lbnRzeydfX1ZFUlNJT05fTUlOT1JfXyd9LiRjb21wb25lbnRzeydfX1ZFUlNJT05f VElOWV9fJ30iOworCitwcmludCAiVXNpbmcgUkNfUFJPSkVDVFNPVVJDRVZFUlNJT049JFNBRkVf UFJPSkVDVF9WRVJTSU9OIGFuZCBSQ19QUk9KRUNUQlVJTERWRVJTSU9OPSRjb21wb25lbnRzeydf X1ZFUlNJT05fQlVJTERfXyd9XG4iOworCisjIE5vdGU6IFRoZXNlIGVudmlyb25tZW50IHNldHRp bmdzIG9ubHkgYWZmZWN0IHRoaXMgc2NyaXB0IGFuZCBpdHMgY2hpbGQgcHJvY2Vzc2VzOgorJEVO VntSQ19QUk9KRUNUU09VUkNFVkVSU0lPTn0gPSAkU0FGRV9QUk9KRUNUX1ZFUlNJT047CiskRU5W e1JDX1Byb2plY3RTb3VyY2VWZXJzaW9ufSA9ICRTQUZFX1BST0pFQ1RfVkVSU0lPTjsKKyRFTlZ7 UkNfUFJPSkVDVEJVSUxEVkVSU0lPTn0gPSAkY29tcG9uZW50c3snX19WRVJTSU9OX0JVSUxEX18n fTsKKwogbXkgJHJjID0gc3lzdGVtKCRWRVJTSU9OX1NUQU1QRVIsICctLXZlcmJvc2UnLCAkVEFS R0VUX1BBVEgsICctLWZpbGVNYWpvcicsICRjb21wb25lbnRzeydfX1ZFUlNJT05fTUFKT1JfXyd9 LAogICAgICctLWZpbGVNaW5vcicsICRjb21wb25lbnRzeydfX1ZFUlNJT05fTUlOT1JfXyd9LCAn LS1maWxlUmV2aXNpb24nLCAkY29tcG9uZW50c3snX19WRVJTSU9OX1RJTllfXyd9LAogICAgICct LWZpbGVCdWlsZCcsICRjb21wb25lbnRzeydfX1ZFUlNJT05fQlVJTERfXyd9LCAnLS1wcm9kdWN0 TWFqb3InLCAkY29tcG9uZW50c3snX19WRVJTSU9OX01BSk9SX18nfSwK