135463 2014-07-31 07:08:55 -0700 Fix unintentional integer overflow before widen 2014-08-18 14:14:54 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 p.kuczynski webkit-unassigned bunhere cdumez commit-queue gyuyoung.kim japhet m.leszko mpakulavelrutka sergio oldest_to_newest 1025970 0 p.kuczynski 2014-07-31 07:08:55 -0700 Overflowing expression is evaluated using operands arithmetic but then is used in context which expects an wider integer type. To avoid overflow at least one operand has to be representative of the wider type. 1025971 1 235828 p.kuczynski 2014-07-31 07:14:19 -0700 Created attachment 235828 porposed patch 1025974 2 commit-queue 2014-07-31 07:18:27 -0700 Attachment 235828 did not pass style-queue: ERROR: Source/WebCore/loader/FTPDirectoryParser.cpp:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 1025975 3 p.kuczynski 2014-07-31 07:21:06 -0700 (In reply to comment #2) > Attachment 235828 [details] did not pass style-queue: > > > ERROR: Source/WebCore/loader/FTPDirectoryParser.cpp:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] > Total errors found: 1 in 6 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. Whole file is written using 2-space indent. 1029857 4 235828 darin 2014-08-18 13:53:53 -0700 Comment on attachment 235828 porposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=235828&action=review > Source/WebCore/loader/FTPDirectoryParser.cpp:508 > - uint64_t size = strtoul(tokens[1], NULL, 10) * 512; > + uint64_t size = strtoull(tokens[1], 0, 10) * 512; The style checker told you to change the NULL to a 0, but really we would like to use nullptr here. > Source/WebCore/loader/ProgressTracker.cpp:237 > + estimatedBytesForPendingRequests = static_cast<long long>(progressItemDefaultEstimatedLength) * numPendingOrLoadingRequests; A better change would be to change type of progressItemDefaultEstimatedLength from int to long long instead of adding the cast here. 1029868 5 235828 commit-queue 2014-08-18 14:14:49 -0700 Comment on attachment 235828 porposed patch Clearing flags on attachment: 235828 Committed r172725: <http://trac.webkit.org/changeset/172725> 1029869 6 commit-queue 2014-08-18 14:14:54 -0700 All reviewed patches have been landed. Closing bug. 235828 2014-07-31 07:14:19 -0700 2014-08-18 14:14:48 -0700 porposed patch proposed.patch text/plain 4588 p.kuczynski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzNDNkYWYxLi5jNTViNjg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTQtMDctMzEgIFByemVteXNsYXcgS3Vjenluc2tpICA8cC5rdWN6eW5za2lAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgRml4IHVuaW50ZW50aW9uYWwgaW50ZWdlciBvdmVyZmxvdyBiZWZv cmUgd2lkZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzNTQ2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE92ZXJmbG93aW5nIGV4cHJlc3Npb24gaXMgZXZhbHVhdGVkIHVzaW5nIG9wZXJhbmRzIGFyaXRo bWV0aWMgYnV0IHRoZW4gaXMgdXNlZCBpbgorICAgICAgICBjb250ZXh0IHdoaWNoIGV4cGVjdHMg YW4gd2lkZXIgaW50ZWdlciB0eXBlLiBUbyBhdm9pZCBvdmVyZmxvdyBhdCBsZWFzdCBvbmUgb3Bl cmFuZAorICAgICAgICBoYXMgdG8gYmUgcmVwcmVzZW50YXRpdmUgb2YgdGhlIHdpZGVyIHR5cGUu CisKKyAgICAgICAgKiBsb2FkZXIvRlRQRGlyZWN0b3J5UGFyc2VyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OnBhcnNlT25lRlRQTGluZSk6IENoYW5nZWQgc3RydG91bCB0byBzdHJ0b3VsbC4KKyAg ICAgICAgKiBsb2FkZXIvUHJvZ3Jlc3NUcmFja2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBy b2dyZXNzVHJhY2tlcjo6aW5jcmVtZW50UHJvZ3Jlc3MpOiBBZGRlZCBzdGF0aWNfY2FzdCB0byBs b25nIGxvbmcuCisgICAgICAgICogcGxhdGZvcm0vZWZsL0ZpbGVTeXN0ZW1FZmwuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Z2V0Vm9sdW1lRnJlZVNpemVGb3JQYXRoKTogQWRkZWQgc3RhdGljX2Nh c3QgdG8gdWludDY0X3QuCisKIDIwMTQtMDctMzAgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBw bGUuY29tPgogCiAgICAgICAgIFByb3BlcnR5TmFtZSdzIGludGVybmFsIHN0cmluZyBpcyBhbHdh eXMgYXRvbWljLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZUUERpcmVjdG9y eVBhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRlRQRGlyZWN0b3J5UGFyc2VyLmNw cAppbmRleCA5YTViNjExLi4xNWE3ODEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvRlRQRGlyZWN0b3J5UGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRlRQ RGlyZWN0b3J5UGFyc2VyLmNwcApAQCAtNTA1LDcgKzUwNSw3IEBAIEZUUEVudHJ5VHlwZSBwYXJz ZU9uZUZUUExpbmUoY29uc3QgY2hhciogbGluZSwgTGlzdFN0YXRlJiBzdGF0ZSwgTGlzdFJlc3Vs dCYgcmVzCiAgICAgICAgICAgICAgICAqIFNvIGl0cyByb3VuZGVkIHVwIHRvIHRoZSBuZXh0IGJs b2NrLCBzbyB3aGF0LCBpdHMgYmV0dGVyCiAgICAgICAgICAgICAgICAqIHRoYW4gbm90IHNob3dp bmcgdGhlIHNpemUgYXQgYWxsLgogICAgICAgICAgICAgICAqLwotICAgICAgICAgICAgICB1aW50 NjRfdCBzaXplID0gc3RydG91bCh0b2tlbnNbMV0sIE5VTEwsIDEwKSAqIDUxMjsKKyAgICAgICAg ICAgICAgdWludDY0X3Qgc2l6ZSA9IHN0cnRvdWxsKHRva2Vuc1sxXSwgMCwgMTApICogNTEyOwog ICAgICAgICAgICAgICByZXN1bHQuZmlsZVNpemUgPSBTdHJpbmc6Om51bWJlcihzaXplKTsKICAg ICAgICAgICAgIH0gCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Qcm9ncmVz c1RyYWNrZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Byb2dyZXNzVHJhY2tlci5jcHAK aW5kZXggZWNlMGQ0ZS4uMjBkNDQ2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVy L1Byb2dyZXNzVHJhY2tlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Byb2dyZXNz VHJhY2tlci5jcHAKQEAgLTIzNCw3ICsyMzQsNyBAQCB2b2lkIFByb2dyZXNzVHJhY2tlcjo6aW5j cmVtZW50UHJvZ3Jlc3ModW5zaWduZWQgbG9uZyBpZGVudGlmaWVyLCB1bnNpZ25lZCBieXRlcwog ICAgIH0KICAgICAKICAgICBpbnQgbnVtUGVuZGluZ09yTG9hZGluZ1JlcXVlc3RzID0gZnJhbWUt PmxvYWRlcigpLm51bVBlbmRpbmdPckxvYWRpbmdSZXF1ZXN0cyh0cnVlKTsKLSAgICBlc3RpbWF0 ZWRCeXRlc0ZvclBlbmRpbmdSZXF1ZXN0cyA9IHByb2dyZXNzSXRlbURlZmF1bHRFc3RpbWF0ZWRM ZW5ndGggKiBudW1QZW5kaW5nT3JMb2FkaW5nUmVxdWVzdHM7CisgICAgZXN0aW1hdGVkQnl0ZXNG b3JQZW5kaW5nUmVxdWVzdHMgPSBzdGF0aWNfY2FzdDxsb25nIGxvbmc+KHByb2dyZXNzSXRlbURl ZmF1bHRFc3RpbWF0ZWRMZW5ndGgpICogbnVtUGVuZGluZ09yTG9hZGluZ1JlcXVlc3RzOwogICAg IHJlbWFpbmluZ0J5dGVzID0gKChtX3RvdGFsUGFnZUFuZFJlc291cmNlQnl0ZXNUb0xvYWQgKyBl c3RpbWF0ZWRCeXRlc0ZvclBlbmRpbmdSZXF1ZXN0cykgLSBtX3RvdGFsQnl0ZXNSZWNlaXZlZCk7 CiAgICAgaWYgKHJlbWFpbmluZ0J5dGVzID4gMCkgIC8vIFByZXZlbnQgZGl2aWRlIGJ5IDAuCiAg ICAgICAgIHBlcmNlbnRPZlJlbWFpbmluZ0J5dGVzID0gKGRvdWJsZSlieXRlc1JlY2VpdmVkIC8g KGRvdWJsZSlyZW1haW5pbmdCeXRlczsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2VmbC9GaWxlU3lzdGVtRWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9G aWxlU3lzdGVtRWZsLmNwcAppbmRleCBlOGQ4MGVjLi5iYzViOWRlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvRmlsZVN5c3RlbUVmbC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZWZsL0ZpbGVTeXN0ZW1FZmwuY3BwCkBAIC0xMDUsNyArMTA1LDcgQEAg dWludDY0X3QgZ2V0Vm9sdW1lRnJlZVNpemVGb3JQYXRoKGNvbnN0IGNoYXIqIHBhdGgpCiAgICAg aWYgKHN0YXR2ZnMocGF0aCwgJmJ1ZikgPCAwKQogICAgICAgICByZXR1cm4gMDsKIAotICAgIHJl dHVybiBidWYuZl9iYXZhaWwgKiBidWYuZl9ic2l6ZTsKKyAgICByZXR1cm4gc3RhdGljX2Nhc3Q8 dWludDY0X3Q+KGJ1Zi5mX2JhdmFpbCkgKiBidWYuZl9ic2l6ZTsKIH0KIAogfQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmlu ZGV4IDVkZDIwNGMuLjhhOTUyYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNC0w Ny0zMSAgUHJ6ZW15c2xhdyBLdWN6eW5za2kgIDxwLmt1Y3p5bnNraUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBGaXggdW5pbnRlbnRpb25hbCBpbnRlZ2VyIG92ZXJmbG93IGJlZm9yZSB3aWRlbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1NDYzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT3ZlcmZsb3dp bmcgZXhwcmVzc2lvbiBpcyBldmFsdWF0ZWQgdXNpbmcgb3BlcmFuZHMgYXJpdGhtZXRpYyBidXQg dGhlbiBpcyB1c2VkIGluCisgICAgICAgIGNvbnRleHQgd2hpY2ggZXhwZWN0cyBhbiB3aWRlciBp bnRlZ2VyIHR5cGUuIFRvIGF2b2lkIG92ZXJmbG93IGF0IGxlYXN0IG9uZSBvcGVyYW5kCisgICAg ICAgIGhhcyB0byBiZSByZXByZXNlbnRhdGl2ZSBvZiB0aGUgd2lkZXIgdHlwZS4KKworICAgICAg ICAqIFdlYlByb2Nlc3Mvc291cC9XZWJQcm9jZXNzU291cC5jcHA6CisgICAgICAgIChXZWJLaXQ6 OmdldE1lbW9yeVNpemUpOiBBZGRlZCBsb25nIGxvbmcgbGl0ZXJhbC4KKwogMjAxNC0wNy0zMSAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dU S10gQnVtcCBiaW5hcnkgdmVyc2lvbiBmb3IgMi42CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL3NvdXAvV2ViUHJvY2Vzc1NvdXAuY3BwIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9zb3VwL1dlYlByb2Nlc3NTb3VwLmNwcAppbmRleCBhODZjZGM4Li4xZjNiNjg3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3NvdXAvV2ViUHJvY2Vzc1NvdXAu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mvc291cC9XZWJQcm9jZXNzU291cC5j cHAKQEAgLTc0LDcgKzc0LDcgQEAgc3RhdGljIHVpbnQ2NF90IGdldE1lbW9yeVNpemUoKQogICAg IGlmIChwaHlzUGFnZXMgPT0gLTEpCiAgICAgICAgIHJldHVybiBrRGVmYXVsdE1lbW9yeVNpemU7 CiAKLSAgICByZXR1cm4gKChwYWdlU2l6ZSAvIDEwMjQpICogcGh5c1BhZ2VzKSAvIDEwMjQ7Cisg ICAgcmV0dXJuICgocGFnZVNpemUgLyAxMDI0TEwpICogcGh5c1BhZ2VzKSAvIDEwMjRMTDsKICNl bHNlCiAgICAgLy8gRmFsbGJhY2sgdG8gZGVmYXVsdCBmb3Igb3RoZXIgcGxhdGZvcm1zLgogICAg IHJldHVybiBrRGVmYXVsdE1lbW9yeVNpemU7Cg==