135462 2014-07-31 06:51:33 -0700 Fix resource leak in FillLayersPropertyWrapper object member 2014-08-01 17:00:50 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 p.kuczynski simon.fraser commit-queue dino dstockwell m.leszko mpakulavelrutka simon.fraser oldest_to_newest 1025968 0 p.kuczynski 2014-07-31 06:51:33 -0700 Despite allocating memory in constructor, m_fillLayerPropertyWrapper is never freed causing memory leak. 1025969 1 235827 p.kuczynski 2014-07-31 06:53:35 -0700 Created attachment 235827 porposed patch 1025981 2 235827 simon.fraser 2014-07-31 08:43:18 -0700 Comment on attachment 235827 porposed patch This should use std::unique_ptr<> 1026298 3 235897 simon.fraser 2014-08-01 11:50:05 -0700 Created attachment 235897 Patch 1026402 4 235897 commit-queue 2014-08-01 17:00:43 -0700 Comment on attachment 235897 Patch Clearing flags on attachment: 235897 Committed r171960: <http://trac.webkit.org/changeset/171960> 1026403 5 commit-queue 2014-08-01 17:00:50 -0700 All reviewed patches have been landed. Closing bug. 235827 2014-07-31 06:53:35 -0700 2014-08-01 11:49:57 -0700 porposed patch proposed.patch text/plain 1811 p.kuczynski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzNDNkYWYxLi4zOGQ3NjZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMDctMzEgIFByemVteXNsYXcgS3Vjenluc2tpICA8cC5rdWN6eW5za2lAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgRml4IHJlc291cmNlIGxlYWsgaW4gRmlsbExheWVyc1Byb3BlcnR5 V3JhcHBlciBvYmplY3QgbWVtYmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzU0NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBEZXNwaXRlIGFsbG9jYXRpbmcgbWVtb3J5IGluIGNvbnN0cnVjdG9yLCBt X2ZpbGxMYXllclByb3BlcnR5V3JhcHBlciBpcyBuZXZlciBmcmVlZAorICAgICAgICBjYXVzaW5n IG1lbW9yeSBsZWFrLgorCisgICAgICAgICogcGFnZS9hbmltYXRpb24vQ1NTUHJvcGVydHlBbmlt YXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6RmlsbExheWVyc1Byb3BlcnR5V3JhcHBlcjo6 RmlsbExheWVyc1Byb3BlcnR5V3JhcHBlcik6IEFkZGVkIG51bGwgaW5pdGlhbGl6YXRpb24gZm9y IG1fZmlsbExheWVyUHJvcGVydHlXcmFwcGVyLgorICAgICAgICAoV2ViQ29yZTo6RmlsbExheWVy c1Byb3BlcnR5V3JhcHBlcjo6fkZpbGxMYXllcnNQcm9wZXJ0eVdyYXBwZXIpOiBBZGRlZCBtX2Zp bGxMYXllclByb3BlcnR5V3JhcHBlciBkZWxldGlvbi4KKwogMjAxNC0wNy0zMCAgQW5kcmVhcyBL bGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUHJvcGVydHlOYW1lJ3MgaW50ZXJu YWwgc3RyaW5nIGlzIGFsd2F5cyBhdG9taWMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL2FuaW1hdGlvbi9DU1NQcm9wZXJ0eUFuaW1hdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL2FuaW1hdGlvbi9DU1NQcm9wZXJ0eUFuaW1hdGlvbi5jcHAKaW5kZXggMjcxNzA1My4uYWVk OThmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vQ1NTUHJvcGVy dHlBbmltYXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0NTU1By b3BlcnR5QW5pbWF0aW9uLmNwcApAQCAtODk0LDYgKzg5NCw3IEBAIHB1YmxpYzoKIAogICAgIEZp bGxMYXllcnNQcm9wZXJ0eVdyYXBwZXIoQ1NTUHJvcGVydHlJRCBwcm9wLCBMYXllcnNHZXR0ZXIg Z2V0dGVyLCBMYXllcnNBY2Nlc3NvciBhY2Nlc3NvcikKICAgICAgICAgOiBBbmltYXRpb25Qcm9w ZXJ0eVdyYXBwZXJCYXNlKHByb3ApCisgICAgICAgICwgbV9maWxsTGF5ZXJQcm9wZXJ0eVdyYXBw ZXIobnVsbHB0cikKICAgICAgICAgLCBtX2xheWVyc0dldHRlcihnZXR0ZXIpCiAgICAgICAgICwg bV9sYXllcnNBY2Nlc3NvcihhY2Nlc3NvcikKICAgICB7CkBAIC05MTksNiArOTIwLDExIEBAIHB1 YmxpYzoKICAgICAgICAgfQogICAgIH0KIAorICAgIHZpcnR1YWwgfkZpbGxMYXllcnNQcm9wZXJ0 eVdyYXBwZXIoKQorICAgIHsKKyAgICAgICAgZGVsZXRlIG1fZmlsbExheWVyUHJvcGVydHlXcmFw cGVyOworICAgIH0KKwogICAgIHZpcnR1YWwgYm9vbCBlcXVhbHMoY29uc3QgUmVuZGVyU3R5bGUq IGEsIGNvbnN0IFJlbmRlclN0eWxlKiBiKSBjb25zdAogICAgIHsKICAgICAgICAgY29uc3QgRmls bExheWVyKiBmcm9tTGF5ZXIgPSAoYS0+Km1fbGF5ZXJzR2V0dGVyKSgpOwo= 235897 2014-08-01 11:50:05 -0700 2014-08-01 17:00:42 -0700 Patch bug-135462-20140801114952.patch text/plain 3074 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxOTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWExNjI4OTU3ODM1ZTVj N2IzZDc4NmM3ZWRmNjQ2YWE2NDZiNmZlYS4uMDRlNDRhMzY5MjQ5MDhmOGUxMDE3OGZhNzFjMDg2 YzA1MmExMWU5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA4LTAxICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCByZXNvdXJj ZSBsZWFrIGluIEZpbGxMYXllcnNQcm9wZXJ0eVdyYXBwZXIgb2JqZWN0IG1lbWJlcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1NDYyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGxlYWsgb2YgbV9m aWxsTGF5ZXJQcm9wZXJ0eVdyYXBwZXIgYnkgdXNpbmcgdW5pcXVlX3B0cjw+LgorICAgICAgICBC YXNlZCBvbiBwYXRjaCBieSBQcnplbXlzbGF3IEt1Y3p5bnNraS4KKworICAgICAgICAqIHBhZ2Uv YW5pbWF0aW9uL0NTU1Byb3BlcnR5QW5pbWF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZp bGxMYXllcnNQcm9wZXJ0eVdyYXBwZXI6OkZpbGxMYXllcnNQcm9wZXJ0eVdyYXBwZXIpOgorCiAy MDE0LTA4LTAxICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAg ICAgIEZpeCB0aGUgaU9TIGJ1aWxkIGFmdGVyIHIxNzE4OTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0NTU1Byb3BlcnR5QW5pbWF0aW9uLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0NTU1Byb3BlcnR5QW5pbWF0aW9uLmNwcAppbmRleCAyNzE3 MDUzN2Y4ZWY0YmU0YzY2NjkxMWJmNjQ5ZWFiYTRkN2Y3ZTA1Li40NzU5YmYwNzAzYjg2ZmQ3NDJk NTdiMTI3OTI5YTg3MmFlNzAwODgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2Fu aW1hdGlvbi9DU1NQcm9wZXJ0eUFuaW1hdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9hbmltYXRpb24vQ1NTUHJvcGVydHlBbmltYXRpb24uY3BwCkBAIC05MDAsMTkgKzkwMCwxOSBA QCBwdWJsaWM6CiAgICAgICAgIHN3aXRjaCAocHJvcCkgewogICAgICAgICBjYXNlIENTU1Byb3Bl cnR5QmFja2dyb3VuZFBvc2l0aW9uWDoKICAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdE1h c2tQb3NpdGlvblg6Ci0gICAgICAgICAgICBtX2ZpbGxMYXllclByb3BlcnR5V3JhcHBlciA9IG5l dyBGaWxsTGF5ZXJQcm9wZXJ0eVdyYXBwZXI8TGVuZ3RoPigmRmlsbExheWVyOjp4UG9zaXRpb24s ICZGaWxsTGF5ZXI6OnNldFhQb3NpdGlvbik7CisgICAgICAgICAgICBtX2ZpbGxMYXllclByb3Bl cnR5V3JhcHBlciA9IHN0ZDo6bWFrZV91bmlxdWU8RmlsbExheWVyUHJvcGVydHlXcmFwcGVyPExl bmd0aD4+KCZGaWxsTGF5ZXI6OnhQb3NpdGlvbiwgJkZpbGxMYXllcjo6c2V0WFBvc2l0aW9uKTsK ICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIENTU1Byb3BlcnR5QmFja2dyb3VuZFBv c2l0aW9uWToKICAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdE1hc2tQb3NpdGlvblk6Ci0g ICAgICAgICAgICBtX2ZpbGxMYXllclByb3BlcnR5V3JhcHBlciA9IG5ldyBGaWxsTGF5ZXJQcm9w ZXJ0eVdyYXBwZXI8TGVuZ3RoPigmRmlsbExheWVyOjp5UG9zaXRpb24sICZGaWxsTGF5ZXI6OnNl dFlQb3NpdGlvbik7CisgICAgICAgICAgICBtX2ZpbGxMYXllclByb3BlcnR5V3JhcHBlciA9IHN0 ZDo6bWFrZV91bmlxdWU8RmlsbExheWVyUHJvcGVydHlXcmFwcGVyPExlbmd0aD4+KCZGaWxsTGF5 ZXI6OnlQb3NpdGlvbiwgJkZpbGxMYXllcjo6c2V0WVBvc2l0aW9uKTsKICAgICAgICAgICAgIGJy ZWFrOwogICAgICAgICBjYXNlIENTU1Byb3BlcnR5QmFja2dyb3VuZFNpemU6CiAgICAgICAgIGNh c2UgQ1NTUHJvcGVydHlXZWJraXRCYWNrZ3JvdW5kU2l6ZToKICAgICAgICAgY2FzZSBDU1NQcm9w ZXJ0eVdlYmtpdE1hc2tTaXplOgotICAgICAgICAgICAgbV9maWxsTGF5ZXJQcm9wZXJ0eVdyYXBw ZXIgPSBuZXcgRmlsbExheWVyUHJvcGVydHlXcmFwcGVyPExlbmd0aFNpemU+KCZGaWxsTGF5ZXI6 OnNpemVMZW5ndGgsICZGaWxsTGF5ZXI6OnNldFNpemVMZW5ndGgpOworICAgICAgICAgICAgbV9m aWxsTGF5ZXJQcm9wZXJ0eVdyYXBwZXIgPSBzdGQ6Om1ha2VfdW5pcXVlPEZpbGxMYXllclByb3Bl cnR5V3JhcHBlcjxMZW5ndGhTaXplPj4oJkZpbGxMYXllcjo6c2l6ZUxlbmd0aCwgJkZpbGxMYXll cjo6c2V0U2l6ZUxlbmd0aCk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBDU1NQ cm9wZXJ0eUJhY2tncm91bmRJbWFnZToKLSAgICAgICAgICAgIG1fZmlsbExheWVyUHJvcGVydHlX cmFwcGVyID0gbmV3IEZpbGxMYXllclN0eWxlSW1hZ2VQcm9wZXJ0eVdyYXBwZXIoJkZpbGxMYXll cjo6aW1hZ2UsICZGaWxsTGF5ZXI6OnNldEltYWdlKTsKKyAgICAgICAgICAgIG1fZmlsbExheWVy UHJvcGVydHlXcmFwcGVyID0gc3RkOjptYWtlX3VuaXF1ZTxGaWxsTGF5ZXJTdHlsZUltYWdlUHJv cGVydHlXcmFwcGVyPigmRmlsbExheWVyOjppbWFnZSwgJkZpbGxMYXllcjo6c2V0SW1hZ2UpOwog ICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICBicmVhazsK QEAgLTk1MCw3ICs5NTAsNyBAQCBwdWJsaWM6CiAgICAgfQogCiBwcml2YXRlOgotICAgIEZpbGxM YXllckFuaW1hdGlvblByb3BlcnR5V3JhcHBlckJhc2UqIG1fZmlsbExheWVyUHJvcGVydHlXcmFw cGVyOworICAgIHN0ZDo6dW5pcXVlX3B0cjxGaWxsTGF5ZXJBbmltYXRpb25Qcm9wZXJ0eVdyYXBw ZXJCYXNlPiBtX2ZpbGxMYXllclByb3BlcnR5V3JhcHBlcjsKIAogICAgIExheWVyc0dldHRlciBt X2xheWVyc0dldHRlcjsKICAgICBMYXllcnNBY2Nlc3NvciBtX2xheWVyc0FjY2Vzc29yOwo=