135458 2014-07-31 05:37:31 -0700 Fix resource leak in unclosed file descriptor handles 2014-08-18 14:12:13 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 p.kuczynski webkit-unassigned commit-queue m.leszko mpakulavelrutka oldest_to_newest 1025953 0 p.kuczynski 2014-07-31 05:37:31 -0700 Leaving descriptor unclosed will cause the resources associated with the open file description never be freed (they are freed on closing the last descriptor referring to the underlying file). 1025958 1 235823 p.kuczynski 2014-07-31 06:05:13 -0700 Created attachment 235823 proposed patch 1029866 2 235823 commit-queue 2014-08-18 14:12:10 -0700 Comment on attachment 235823 proposed patch Clearing flags on attachment: 235823 Committed r172724: <http://trac.webkit.org/changeset/172724> 1029867 3 commit-queue 2014-08-18 14:12:13 -0700 All reviewed patches have been landed. Closing bug. 235823 2014-07-31 06:05:13 -0700 2014-08-18 14:12:09 -0700 proposed patch proposed.patch text/plain 1732 p.kuczynski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1ZGQyMDRjLi5hZGE2M2Y4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTQtMDctMzEgIFByemVteXNsYXcgS3Vjenluc2tpICA8cC5rdWN6eW5za2lAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgRml4IHJlc291cmNlIGxlYWsgaW4gdW5jbG9zZWQgZmlsZSBkZXNj cmlwdG9yIGhhbmRsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEzNTQ1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIExlYXZpbmcgZGVzY3JpcHRvciB1bmNsb3NlZCB3aWxsIGNhdXNlIHRoZSByZXNvdXJj ZXMgYXNzb2NpYXRlZCB3aXRoIHRoZSBvcGVuCisgICAgICAgIGZpbGUgZGVzY3JpcHRpb24gbmV2 ZXIgYmUgZnJlZWQgKHRoZXkgYXJlIGZyZWVkIG9uIGNsb3NpbmcgdGhlIGxhc3QgZGVzY3JpcHRv cgorICAgICAgICByZWZlcmluZyB0byB0aGUgdW5kZXJseWluZyBmaWxlKS4KKworICAgICAgICAq IFNoYXJlZC9QbHVnaW5zL05ldHNjYXBlL3gxMS9OZXRzY2FwZVBsdWdpbk1vZHVsZVgxMS5jcHA6 CisgICAgICAgIChXZWJLaXQ6OlN0ZG91dERldk51bGxSZWRpcmVjdG9yOjpTdGRvdXREZXZOdWxs UmVkaXJlY3Rvcik6IENsb3NlZCBuZXdTdGRvdXQgZGVzY3JpcHRvci4KKyAgICAgICAgKFdlYktp dDo6U3Rkb3V0RGV2TnVsbFJlZGlyZWN0b3I6On5TdGRvdXREZXZOdWxsUmVkaXJlY3Rvcik6IENs b3NlZCBtX3NhdmVkU3Rkb3V0IGRlc2NyaXB0b3IuCisKIDIwMTQtMDctMzEgIENhcmxvcyBHYXJj aWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEJ1bXAgYmlu YXJ5IHZlcnNpb24gZm9yIDIuNgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1Bs dWdpbnMvTmV0c2NhcGUveDExL05ldHNjYXBlUGx1Z2luTW9kdWxlWDExLmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1NoYXJlZC9QbHVnaW5zL05ldHNjYXBlL3gxMS9OZXRzY2FwZVBsdWdpbk1vZHVsZVgx MS5jcHAKaW5kZXggN2U4ODBhYy4uODU5MTIyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv U2hhcmVkL1BsdWdpbnMvTmV0c2NhcGUveDExL05ldHNjYXBlUGx1Z2luTW9kdWxlWDExLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lucy9OZXRzY2FwZS94MTEvTmV0c2NhcGVQ bHVnaW5Nb2R1bGVYMTEuY3BwCkBAIC01OSwxMiArNTksMTUgQEAgU3Rkb3V0RGV2TnVsbFJlZGly ZWN0b3I6OlN0ZG91dERldk51bGxSZWRpcmVjdG9yKCkKICAgICAgICAgcmV0dXJuOwogICAgIG1f c2F2ZWRTdGRvdXQgPSBkdXAoU1RET1VUX0ZJTEVOTyk7CiAgICAgZHVwMihuZXdTdGRvdXQsIFNU RE9VVF9GSUxFTk8pOworICAgIGNsb3NlKG5ld1N0ZG91dCk7CiB9CiAKIFN0ZG91dERldk51bGxS ZWRpcmVjdG9yOjp+U3Rkb3V0RGV2TnVsbFJlZGlyZWN0b3IoKQogewotICAgIGlmIChtX3NhdmVk U3Rkb3V0ICE9IC0xKQorICAgIGlmIChtX3NhdmVkU3Rkb3V0ICE9IC0xKSB7CiAgICAgICAgIGR1 cDIobV9zYXZlZFN0ZG91dCwgU1RET1VUX0ZJTEVOTyk7CisgICAgICAgIGNsb3NlKG1fc2F2ZWRT dGRvdXQpOworICAgIH0KIH0KIAogCg==