135456 2014-07-31 04:43:18 -0700 [EFL] remove ewk_defines.h 2014-07-31 19:18:36 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi bunhere cdumez commit-queue gyuyoung.kim lucas.de.marchi sergio oldest_to_newest 1025943 0 ryuan.choi 2014-07-31 04:43:18 -0700 ewk_defines.h mentioned "Defines the Ewk Structs", but it just only defines Ewk_Context_Menu and Ewk_Context_Menu_Item. 1025944 1 235818 ryuan.choi 2014-07-31 04:44:57 -0700 Created attachment 235818 Patch 1025946 2 235818 gyuyoung.kim 2014-07-31 05:13:09 -0700 Comment on attachment 235818 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235818&action=review > Source/WebKit2/ChangeLog:3 > + [EFL] remove ewk_defines.h IIRC, ewk_defines.h was added because there was circular include chain problem in ewk. Is there no the problem now ? 1025950 3 ryuan.choi 2014-07-31 05:34:29 -0700 (In reply to comment #2) > (From update of attachment 235818 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235818&action=review > > > Source/WebKit2/ChangeLog:3 > > + [EFL] remove ewk_defines.h > > IIRC, ewk_defines.h was added because there was circular include chain problem in ewk. Is there no the problem now ? right, there are circular include issue because both ewk_context_menu.h and ewk_context_menu_item.h requires Ewk_Context_Menu and Ewk_Context_Menu_Item. In order to avoid it, this patch just declares them to ewk_context_menu_item.h and let ewk_context.h include ewk_context_menu.h instead of using ewk_defines.h. 1026166 4 235818 ryuan.choi 2014-07-31 19:18:26 -0700 Comment on attachment 235818 Patch Clearing flags on attachment: 235818 Committed r171901: <http://trac.webkit.org/changeset/171901> 1026167 5 ryuan.choi 2014-07-31 19:18:36 -0700 All reviewed patches have been landed. Closing bug. 235818 2014-07-31 04:44:57 -0700 2014-07-31 19:18:26 -0700 Patch bug-135456-20140731204443.patch text/plain 4412 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxNzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmIyNDAyZjg0MDI5NDEz YmMwYjhkNTM1NTZlMzBkZDVlMDBhOGRmMS4uYjQ0MjBiMWU1ZGE1MmYwMjY4M2I5OTE0OTQzNjZj ZmZkNjZjYTA0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA3LTMxICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSByZW1vdmUg ZXdrX2RlZmluZXMuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTM1NDU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfY29udGV4dF9tZW51Lmg6CisgICAgICAgICog VUlQcm9jZXNzL0FQSS9lZmwvZXdrX2NvbnRleHRfbWVudV9pdGVtLmg6IE1vdmVkIHRoZSBkZWNs YXJhdGlvbiBmcm9tIGV3a19kZWZpbmVzLmgKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9l d2tfZGVmaW5lcy5oOiBSZW1vdmVkLgorCiAyMDE0LTA3LTI5ICBUaW0gSG9ydG9uICA8dGltb3Ro eV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFdLUERGVmlldyBwYWludHMgcm90YXRlZCBw YWdlcyBzcXVpc2hlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l ZmwvZXdrX2NvbnRleHRfbWVudS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv ZXdrX2NvbnRleHRfbWVudS5oCmluZGV4IGFkMzU2MTkzOTI3ODUwZGI3MTM3OGFiNzI1ZTYxYzA1 MDc1YmE5NWQuLjk0ZWJiMDZlNDFhMjhjYmU5MWM4NWFiYWQ1NTYzNGJkNTdkYjI2YzggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250ZXh0X21lbnUu aAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfY29udGV4dF9tZW51 LmgKQEAgLTMxLDggKzMxLDcgQEAKICNpZm5kZWYgZXdrX2NvbnRleHRfbWVudV9oCiAjZGVmaW5l IGV3a19jb250ZXh0X21lbnVfaAogCi0jaW5jbHVkZSAiZXdrX2RlZmluZXMuaCIKLSNpbmNsdWRl IDxFaW5hLmg+CisjaW5jbHVkZSAiZXdrX2NvbnRleHRfbWVudV9pdGVtLmgiCiAKICNpZmRlZiBf X2NwbHVzcGx1cwogZXh0ZXJuICJDIiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC9ld2tfY29udGV4dF9tZW51X2l0ZW0uaCBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL2V3a19jb250ZXh0X21lbnVfaXRlbS5oCmluZGV4IGQ5Zjc0ZjlhZmFj ZGIzZTQ5YmVlOWE1ZmI3YzRjOThjMDU5YmNkYTEuLjlhZTIyN2Y4NGRhMjMyZWJmYmI5ODA4YTY0 NzhjY2U2Y2NkMmZhYzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL2V3a19jb250ZXh0X21lbnVfaXRlbS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL2V3a19jb250ZXh0X21lbnVfaXRlbS5oCkBAIC0zMSw3ICszMSw2IEBACiAjaWZu ZGVmIGV3a19jb250ZXh0X21lbnVfaXRlbV9oCiAjZGVmaW5lIGV3a19jb250ZXh0X21lbnVfaXRl bV9oCiAKLSNpbmNsdWRlICJld2tfZGVmaW5lcy5oIgogI2luY2x1ZGUgPEVpbmEuaD4KIAogI2lm ZGVmIF9fY3BsdXNwbHVzCkBAIC0zOSw2ICszOCwxNiBAQCBleHRlcm4gIkMiIHsKICNlbmRpZgog CiAvKioKKyAqIERlY2xhcmUgRXdrX0NvbnRleHRfTWVudSBhcyBFd2tfT2JqZWN0LgorICoKKyAq IEBzZWUgRXdrX09iamVjdAorICovCit0eXBlZGVmIHN0cnVjdCBFd2tPYmplY3QgRXdrX0NvbnRl eHRfTWVudTsKKworLyoqIENyZWF0ZXMgYSB0eXBlIG5hbWUgZm9yIEV3a19Db250ZXh0X01lbnVf SXRlbSAqLwordHlwZWRlZiBzdHJ1Y3QgRXdrQ29udGV4dE1lbnVJdGVtIEV3a19Db250ZXh0X01l bnVfSXRlbTsKKworLyoqCiAgKiBcZW51bSAgICBFd2tfQ29udGV4dF9NZW51X0l0ZW1fVHlwZQog ICogQGJyaWVmICAgRGVmaW5lcyB0aGUgdHlwZXMgb2YgdGhlIGl0ZW1zIGZvciB0aGUgY29udGV4 dCBtZW51LgogICogQGluZm8gICAgS2VlcCB0aGlzIGluIHN5bmMgd2l0aCBXS0NvbnRleHRNZW51 SXRlbVR5cGVzLmgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs L2V3a19kZWZpbmVzLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfZGVm aW5lcy5oCmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCBiZjAxNzdmOGJhNzc3NjU3OTE5 MTJhMjkwNzI0NGU5MjlhZmE1NWRjLi4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwCi0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19kZWZpbmVz LmgKKysrIC9kZXYvbnVsbApAQCAtMSw1MiArMCwwIEBACi0vKgotICogQ29weXJpZ2h0IChDKSAy MDEyIFNhbXN1bmcgRWxlY3Ryb25pY3MuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCi0gKgotICogUmVk aXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3 aXRob3V0Ci0gKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUg Zm9sbG93aW5nIGNvbmRpdGlvbnMKLSAqIGFyZSBtZXQ6Ci0gKiAxLiBSZWRpc3RyaWJ1dGlvbnMg b2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAotICogICAgbm90 aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVy LgotICogMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRo ZSBhYm92ZSBjb3B5cmlnaHQKLSAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMg YW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKLSAqICAgIGRvY3VtZW50YXRpb24g YW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCi0g KgotICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMg QU5EIENPTlRSSUJVVE9SUwotICogIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBX QVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKLSAqIFRIRSBJTVBMSUVE IFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VM QVIKLSAqIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuICBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09Q WVJJR0hUIEhPTERFUiBPUgotICogQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVD VCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsCi0gKiBFWEVNUExBUlksIE9SIENPTlNF UVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCi0gKiBQUk9D VVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFU QSwgT1IKLSAqIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVT RUQgQU5EIE9OIEFOWSBUSEVPUlkKLSAqIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFD VCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVCAoSU5DTFVESU5HCi0gKiBORUdMSUdFTkNFIE9S IE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GIFRISVMKLSAq IFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFN QUdFLgotICovCi0KLS8qKgotICogQGZpbGUgICAgZXdrX2RlZmluZXMuaAotICogQGJyaWVmICAg RGVmaW5lcyB0aGUgRXdrIFN0cnVjdHMKLSAqLwotCi0jaWZuZGVmIGV3a19kZWZpbmVzX2gKLSNk ZWZpbmUgZXdrX2RlZmluZXNfaAotCi0jaWZkZWYgX19jcGx1c3BsdXMKLWV4dGVybiAiQyIgewot I2VuZGlmCi0KLS8qKgotICogRGVjbGFyZSBFd2tfQ29udGV4dF9NZW51IGFzIEV3a19PYmplY3Qu Ci0gKgotICogQHNlZSBFd2tfT2JqZWN0Ci0gKi8KLXR5cGVkZWYgc3RydWN0IEV3a09iamVjdCBF d2tfQ29udGV4dF9NZW51OwotCi0vKiogQ3JlYXRlcyBhIHR5cGUgbmFtZSBmb3IgRXdrX0NvbnRl eHRfTWVudV9JdGVtICovCi10eXBlZGVmIHN0cnVjdCBFd2tDb250ZXh0TWVudUl0ZW0gRXdrX0Nv bnRleHRfTWVudV9JdGVtOwotCi0jaWZkZWYgX19jcGx1c3BsdXMKLX0KLSNlbmRpZgotCi0jZW5k aWYgLyogZXdrX2RlZmluZXNfaCAqLwo=