135447 2014-07-30 18:25:03 -0700 Default buttons do not pulse in OS X 10.10 2014-07-31 15:08:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 1025857 0 dino 2014-07-30 18:25:03 -0700 Default buttons do not pulse in OS X 10.10 1025858 1 dino 2014-07-30 18:25:55 -0700 OS X Yosemite does not need a redraw timer on RenderButton, since the default blue button for forms doesn't pulse in the manner of previous releases. 1025866 2 235797 dino 2014-07-30 18:58:31 -0700 Created attachment 235797 Patch 1025869 3 235797 mitz 2014-07-30 19:01:40 -0700 Comment on attachment 235797 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235797&action=review > Source/WebCore/rendering/RenderThemeMac.mm:2033 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101000 > + return true; > +#else > + return false; > +#endif We usually put the “present and future” case before the “legacy” case. 1025874 4 dino 2014-07-30 19:17:06 -0700 <rdar://problem/17577321> 1026080 5 dino 2014-07-31 15:08:26 -0700 Committed r171890: <http://trac.webkit.org/changeset/171890> 235797 2014-07-30 18:58:31 -0700 2014-07-30 19:01:39 -0700 Patch bug-135447-20140731115817.patch text/plain 5054 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxODI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGZkZjAxMmNlZGQ4Y2Iz MDc0N2FkZTU2ZWI4MTY4OTM1NjkzYWVjZC4uNGQyNTlmYWNmZGVlYjhkOTM3MWYyMWI0NGJlZTFi MGEyYzk1ZThlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE0LTA3LTMwICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBEZWZhdWx0IGJ1dHRvbnMgZG8g bm90IHB1bHNlIGluIE9TIFggMTAuMTAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzNTQ0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE9TIFggWW9zZW1pdGUgZG9lcyBub3QgaGF2ZSB0aGUgYW5pbWF0ZWQg cHVsc2luZyBkZWZhdWx0CisgICAgICAgIGJ1dHRvbnMgc2VlbiBpbiBwcmV2aW91cyByZWxlYXNl cy4gV2UgZG9uJ3QgbmVlZCB0byBoYXZlCisgICAgICAgIGEgdGltZXIgaW4gUmVuZGVyQnV0dG9u IGNvbnN0YW50bHkgdHJpZ2dlcmluZyByZXBhaW50cy4KKworICAgICAgICAqIHBsYXRmb3JtL21h Yy9UaGVtZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OnBhaW50QnV0dG9uKTogTm8gbmVlZCB0 byBhZHZhbmNlIHRoZSBhbmltYXRpb24uCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJ1dHRv bi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCdXR0b246OnN0eWxlRGlkQ2hhbmdlKTog QXNrIHRoZSB0aGVtZSBpZiBpdAorICAgICAgICBzaG91bGQgYWR2YW5jZSB0aGUgYW5pbWF0aW9u LgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZS5oOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyVGhlbWU6OmRlZmF1bHRCdXR0b25IYXNBbmltYXRpb24pOiBWaXJ0dWFsIGZ1bmN0aW9u CisgICAgICAgIGluZGljYXRpbmcgaWYgdGhlIGJ1dHRvbiBuZWVkcyB0byByZXBhaW50LgorICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5oOgorICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJUaGVtZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lTWFjOjpkZWZh dWx0QnV0dG9uSGFzQW5pbWF0aW9uKTogUHJvdmlkZSBwbGF0Zm9ybQorICAgICAgICBzcGVjaWZp YyByZXN1bHQgb24gWW9zZW1pdGUgYW5kIGFib3ZlLgorCiAyMDE0LTA3LTMwICBBbmRyZWFzIEts aW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBTdGF0aWMgaGFzaCB0YWJsZXMgbm8g bG9uZ2VyIG5lZWQgdG8gYmUgY291cGxlZCB3aXRoIGEgVk0uCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tYWMvVGhlbWVNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tYWMvVGhlbWVNYWMubW0KaW5kZXggMmQ1NzExZmE0Y2NlNDkyZDg1MTU1MGE5YzQxMDhhZWQ4 MTExOGRlNC4uZThmODMyYzRlOGVkMDZhZjE0MjMwMTk4OGZhNDc2YzRkMDkzOTExOSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1RoZW1lTWFjLm1tCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9UaGVtZU1hYy5tbQpAQCAtNTYzLDcgKzU2Myw5IEBAIHN0 YXRpYyB2b2lkIHBhaW50QnV0dG9uKENvbnRyb2xQYXJ0IHBhcnQsIENvbnRyb2xTdGF0ZXMqIGNv bnRyb2xTdGF0ZXMsIEdyYXBoaWNzCiAKICAgICBpZiAoc3RhdGVzICYgQ29udHJvbFN0YXRlczo6 RGVmYXVsdFN0YXRlKSB7CiAgICAgICAgIFt3aW5kb3cgc2V0RGVmYXVsdEJ1dHRvbkNlbGw6YnV0 dG9uQ2VsbF07CisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDEwMTAwMAog ICAgICAgICB3a0FkdmFuY2VEZWZhdWx0QnV0dG9uUHVsc2VBbmltYXRpb24oYnV0dG9uQ2VsbCk7 CisjZW5kaWYKICAgICB9IGVsc2UgaWYgKFtwcmV2aW91c0RlZmF1bHRCdXR0b25DZWxsIGlzRXF1 YWw6YnV0dG9uQ2VsbF0pCiAgICAgICAgIFt3aW5kb3cgc2V0RGVmYXVsdEJ1dHRvbkNlbGw6bmls XTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJ1dHRvbi5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQnV0dG9uLmNwcAppbmRleCBlMDY3 ODg0ODQxYWFiMmEyY2YwZTE2NWM3ODViMTlhODI4NGRmMjQyLi5mNGRhY2ZhZTNjMGYzYTEzZjQ5 OWFhMTA5MGM4OTE0MDQyMzE0ZjY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyQnV0dG9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy QnV0dG9uLmNwcApAQCAtMTE0LDkgKzExNCwxMSBAQCB2b2lkIFJlbmRlckJ1dHRvbjo6c3R5bGVE aWRDaGFuZ2UoU3R5bGVEaWZmZXJlbmNlIGRpZmYsIGNvbnN0IFJlbmRlclN0eWxlKiBvbGRTdAog ICAgICAgICBzZXR1cElubmVyU3R5bGUoJm1faW5uZXItPnN0eWxlKCkpOwogCiAgICAgaWYgKCFt X2RlZmF1bHQgJiYgdGhlbWUoKS5pc0RlZmF1bHQoKnRoaXMpKSB7Ci0gICAgICAgIGlmICghbV90 aW1lcikKLSAgICAgICAgICAgIG1fdGltZXIgPSBzdGQ6Om1ha2VfdW5pcXVlPFRpbWVyPFJlbmRl ckJ1dHRvbj4+KHRoaXMsICZSZW5kZXJCdXR0b246OnRpbWVyRmlyZWQpOwotICAgICAgICBtX3Rp bWVyLT5zdGFydFJlcGVhdGluZygwLjAzKTsKKyAgICAgICAgaWYgKHRoZW1lKCkuZGVmYXVsdEJ1 dHRvbkhhc0FuaW1hdGlvbigpKSB7CisgICAgICAgICAgICBpZiAoIW1fdGltZXIpCisgICAgICAg ICAgICAgICAgbV90aW1lciA9IHN0ZDo6bWFrZV91bmlxdWU8VGltZXI8UmVuZGVyQnV0dG9uPj4o dGhpcywgJlJlbmRlckJ1dHRvbjo6dGltZXJGaXJlZCk7CisgICAgICAgICAgICBtX3RpbWVyLT5z dGFydFJlcGVhdGluZygwLjAzKTsKKyAgICAgICAgfQogICAgICAgICBtX2RlZmF1bHQgPSB0cnVl OwogICAgIH0gZWxzZSBpZiAobV9kZWZhdWx0ICYmICF0aGVtZSgpLmlzRGVmYXVsdCgqdGhpcykp IHsKICAgICAgICAgbV9kZWZhdWx0ID0gZmFsc2U7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUaGVtZS5oCmluZGV4IGM5ZDg0YTRlYTllNWQ2ODI4NTZmOTRhMjNkYTJjZmMzYzU5YWRiODEu LjI0NmVkMGE5Y2YzYWZjMTU4NWIxOGIzNTU3OTMxOGNkYzQ2ZTY0ZjggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJUaGVtZS5oCkBAIC0yNDksNiArMjQ5LDggQEAgcHVibGljOgogICAg IHZpcnR1YWwgSW50U2l6ZSBpbWFnZUNvbnRyb2xzQnV0dG9uUG9zaXRpb25PZmZzZXQoKSBjb25z dCB7IHJldHVybiBJbnRTaXplKCk7IH0KICNlbmRpZgogCisgICAgdmlydHVhbCBib29sIGRlZmF1 bHRCdXR0b25IYXNBbmltYXRpb24oKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQorCiBwcm90ZWN0 ZWQ6CiAgICAgLy8gVGhlIHBsYXRmb3JtIHNlbGVjdGlvbiBjb2xvci4KICAgICB2aXJ0dWFsIENv bG9yIHBsYXRmb3JtQWN0aXZlU2VsZWN0aW9uQmFja2dyb3VuZENvbG9yKCkgY29uc3Q7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMuaCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5oCmluZGV4IDJiODNkNDBiZmVkNGVl ZjY3NWViN2VkMzVkN2NhNzllYmQyZGY3NTIuLjI1MjJhMjcxYjk4ZDNhZDdjODQyZTc1Yzc3YTU0 YjQwMzU2Njk2M2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJU aGVtZU1hYy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5o CkBAIC0xMDYsNiArMTA2LDggQEAgcHVibGljOgogICAgIC8vIEEgdmlldyBhc3NvY2lhdGVkIHRv IHRoZSBjb250YWluZWQgZG9jdW1lbnQuCiAgICAgTlNWaWV3KiBkb2N1bWVudFZpZXdGb3IoY29u c3QgUmVuZGVyT2JqZWN0JikgY29uc3Q7CiAKKyAgICB2aXJ0dWFsIGJvb2wgZGVmYXVsdEJ1dHRv bkhhc0FuaW1hdGlvbigpIGNvbnN0IG92ZXJyaWRlOworCiBwcm90ZWN0ZWQ6CiAgICAgUmVuZGVy VGhlbWVNYWMoKTsKICAgICB2aXJ0dWFsIH5SZW5kZXJUaGVtZU1hYygpOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCmluZGV4IGE0YzY4NmQ5NzViN2FmYzhiNmZk NGJmNTljMWNmYTM0ODFlN2M4ZjUuLmI4NTNmN2NlODhjZDUzZGY3NWQzOTE3ZjM4NzFlYmZmNDVj OTU0NjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZU1h Yy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0KQEAg LTIwMjQsNiArMjAyNCwxNSBAQCBTdHJpbmcgUmVuZGVyVGhlbWVNYWM6OmZpbGVMaXN0TmFtZUZv cldpZHRoKGNvbnN0IEZpbGVMaXN0KiBmaWxlTGlzdCwgY29uc3QgRm9udAogICAgIHJldHVybiBT dHJpbmdUcnVuY2F0b3I6OmNlbnRlclRydW5jYXRlKHN0clRvVHJ1bmNhdGUsIHdpZHRoLCBmb250 LCBTdHJpbmdUcnVuY2F0b3I6OkVuYWJsZVJvdW5kaW5nSGFja3MpOwogfQogCitib29sIFJlbmRl clRoZW1lTWFjOjpkZWZhdWx0QnV0dG9uSGFzQW5pbWF0aW9uKCkgY29uc3QKK3sKKyNpZiBfX01B Q19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEIDwgMTAxMDAwCisgICAgcmV0dXJuIHRydWU7Cisj ZWxzZQorICAgIHJldHVybiBmYWxzZTsKKyNlbmRpZgorfQorCiAjaWYgRU5BQkxFKFNFUlZJQ0Vf Q09OVFJPTFMpCiBOU1NlcnZpY2VzUm9sbG92ZXJCdXR0b25DZWxsKiBSZW5kZXJUaGVtZU1hYzo6 c2VydmljZXNSb2xsb3ZlckJ1dHRvbkNlbGwoKSBjb25zdAogewo=