135418 2014-07-30 09:44:06 -0700 media/track/add-and-remove-track.html and media/media-fragments/TC0001.html are flaky on Mac WK2 EWS, asserting under TestRunner::removeAllWebNotificationPermissions 2014-07-31 12:22:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap oliver ossy simon.fraser oldest_to_newest 1025722 0 ap 2014-07-30 09:44:06 -0700 Mac WK2 EWS very frequently fails, claiming media/track/add-and-remove-track.html to be failing. But it's actually flaky. Quite obviously, it's caused by some other test doing Web Notification work. It is very likely that the same issue happens on testers too, but we botwatched it away by marking affected tests in TestExpectations. But due to the nature of this failure, it can clearly happen on other tests randomly, and can migrate to other tests with time. Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x000000010ffdbc1e WTFCrash + 62 (Assertions.cpp:329) 1 WebKitTestRunnerInjectedBundle 0x0000000113e60703 WTF::CrashOnOverflow::overflowed() + 9 2 WebKitTestRunnerInjectedBundle 0x0000000113e632e4 WTR::InjectedBundle::page() const + 24 (InjectedBundle.cpp:134) 3 WebKitTestRunnerInjectedBundle 0x0000000113e568a1 WTR::TestRunner::removeAllWebNotificationPermissions() + 27 (InjectedBundlePage.h:41) 4 WebKitTestRunnerInjectedBundle 0x0000000113e63054 WTR::InjectedBundle::didReceiveMessage(OpaqueWKString const*, void const*) + 398 (Vector.h:610) 5 com.apple.WebKit 0x000000010ef97618 WebKit::InjectedBundleClient::didReceiveMessage(WebKit::InjectedBundle*, WTF::String const&, API::Object*) + 120 (WKSharedAPICast.h:130) 6 com.apple.WebKit 0x000000010f0f58e5 WebKit::WebProcess::postInjectedBundleMessage(IPC::DataReference const&) + 135 (RefPtr.h:55) 7 com.apple.WebKit 0x000000010f0fefd0 WebKit::WebProcess::didReceiveWebProcessMessage(IPC::Connection*, IPC::MessageDecoder&) + 2356 (HandleMessage.h:16) 8 com.apple.WebKit 0x000000010f0f41e9 WebKit::WebProcess::didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) + 175 (WebProcess.cpp:612) 9 com.apple.WebKit 0x000000010ef52400 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >) + 94 (memory:2665) 1025728 1 ap 2014-07-30 09:51:57 -0700 media/media-fragments/TC0001.html is another test that's randomly affected. 1025829 2 ap 2014-07-30 16:56:22 -0700 I wonder if this is related to bug 122475. Apparently m_pages can be empty sometimes. Perhaps a race when terminating a process and creating a new one? 1026007 3 ap 2014-07-31 10:34:48 -0700 > I wonder if this is related to bug 122475. Yes it is! I could reproduce, looks like that fix was not sufficient for single-WebProcess case (as used on Mountain Lion). 1026029 4 235832 ap 2014-07-31 11:35:33 -0700 Created attachment 235832 proposed fix 1026033 5 ap 2014-07-31 12:22:00 -0700 Committed <http://trac.webkit.org/r171880>. 235832 2014-07-31 11:35:33 -0700 2014-07-31 12:19:23 -0700 proposed fix FreezingTest.txt text/plain 3741 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3MTg3MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI4IEBACisyMDE0LTA3LTMxICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIG1lZGlhL3RyYWNrL2FkZC1hbmQtcmVtb3ZlLXRyYWNrLmh0bWwgYW5kIG1l ZGlhL21lZGlhLWZyYWdtZW50cy9UQzAwMDEuaHRtbCBhcmUgZmxha3kKKyAgICAgICAgb24gTWFj IFdLMiBFV1MsIGFzc2VydGluZyB1bmRlciBUZXN0UnVubmVyOjpyZW1vdmVBbGxXZWJOb3RpZmlj YXRpb25QZXJtaXNzaW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTM1NDE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhpcyB3YXMgb25seSBoYXBwZW5pbmcgaW4gc2hhcmVkIHdlYiBwcm9jZXNzIG1v ZGUsIGJlY2F1c2UgV0tCdW5kbGVQb3N0TWVzc2FnZQorICAgICAgICBoYXMgZGlmZmVyZW50IGJl aGF2aW9yIHRoZW4uIFdoZW4gdGhlcmUgaXMgbm8gcHJvY2VzcywgdGhlIG1lc3NhZ2UgaXMgZHJv cHBlZCBvbgorICAgICAgICB0aGUgZmxvb3IgaW4gbXVsdGlwbGUgcHJvY2VzcyBtb2RlLCBidXQg aXQncyBzdG9yZWQgdG8gYmUgZGVsaXZlcmVkIGFmdGVyIGxhdW5jaAorICAgICAgICBpbiBzaGFy ZWQgcHJvY2VzcyBtb2RlLgorCisgICAgICAgIEFzIGEgcmVzdWx0LCBjYWxsaW5nIHJlc2V0U3Rh dGVUb0NvbnNpc3RlbnRWYWx1ZXMoKSByZXN1bHRlZCBpbiBzdG9yaW5nIGEgUmVzZXQKKyAgICAg ICAgYnVuZGxlIG1lc3NhZ2UgdGhhdCB3YXMgZGVsaXZlcmVkIGltbWVkaWF0ZWx5IGFmdGVyIGxh dW5jaCwgd2hlbiB0aGVyZSBpcyBub3RoaW5nCisgICAgICAgIHRvIHJlc2V0LgorCisgICAgICAg IFdlIGRvbid0IGFjdHVhbGx5IG5lZWQgdG8gcmVzZXQgYW55dGhpbmcgYXQgdGhpcyBwb2ludCwg YXMgdGhlIHByZXZpb3VzIGNhbGwgaGFzCisgICAgICAgIGFscmVhZHkgcmVzZXQgZXZlcnl0aGlu ZyBVSSBwcm9jZXNzIHNpZGUsIGFuZCB3ZWIgcHJvY2VzcyBpcyBicmFuZCBuZXcuIEFsbCB3ZSBu ZWVkCisgICAgICAgIGlzIHRvIHJlYXR0YWNoIHRoZSBwYWdlIHRvIGEgcHJvY2VzcywgYXMgaW52 b2tlKCkgZXhwZWN0cyBvbmUgdG8gZXhpc3QuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVy L1Rlc3RDb250cm9sbGVyLmNwcDogKFdUUjo6VGVzdENvbnRyb2xsZXI6OnJlYXR0YWNoUGFnZVRv V2ViUHJvY2Vzcyk6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5o OgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvVGVzdEludm9jYXRpb24uY3BwOiAoV1RSOjpU ZXN0SW52b2NhdGlvbjo6aW52b2tlKToKKwogMjAxNC0wNy0zMSAgRGFuIEJlcm5zdGVpbiAgPG1p dHpAYXBwbGUuY29tPgogCiAgICAgICAgIFtXSzJdIFJlZ3Jlc3Npb24gdGVzdHMgY2FuJ3QgbG9h ZCBIVFRQUyBwYWdlcyB3aXRoIE5ldHdvcmtQcm9jZXNzIGR1ZSB0byBzZWxmLXNpZ25lZCBjZXJ0 aWZpY2F0ZQpJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAJ KHJldmlzaW9uIDE3MTc3MikKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xs ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NjMsNiArNjYzLDE0IEBAIHZvaWQgVGVzdENvbnRy b2xsZXI6OnRlcm1pbmF0ZVdlYkNvbnRlbnQKICAgICBXS1BhZ2VUZXJtaW5hdGUobV9tYWluV2Vi Vmlldy0+cGFnZSgpKTsKIH0KIAordm9pZCBUZXN0Q29udHJvbGxlcjo6cmVhdHRhY2hQYWdlVG9X ZWJQcm9jZXNzKCkKK3sKKyAgICAvLyBMb2FkaW5nIGEgd2ViIHBhZ2UgaXMgdGhlIG9ubHkgd2F5 IHRvIHJlYXR0YWNoIGFuIGV4aXN0aW5nIHBhZ2UgdG8gYSBwcm9jZXNzLgorICAgIG1fZG9uZVJl c2V0dGluZyA9IGZhbHNlOworICAgIFdLUGFnZUxvYWRVUkwobV9tYWluV2ViVmlldy0+cGFnZSgp LCBibGFua1VSTCgpKTsKKyAgICBydW5VbnRpbChtX2RvbmVSZXNldHRpbmcsIExvbmdUaW1lb3V0 KTsKK30KKwogdm9pZCBUZXN0Q29udHJvbGxlcjo6dXBkYXRlV2ViVmlld1NpemVGb3JUZXN0KGNv bnN0IFRlc3RJbnZvY2F0aW9uJiB0ZXN0KQogewogICAgIGJvb2wgaXNTVkdXM0NUZXN0ID0gc3Ry c3RyKHRlc3QucGF0aE9yVVJMKCksICJzdmcvVzNDLVNWRy0xLjEiKSB8fCBzdHJzdHIodGVzdC5w YXRoT3JVUkwoKSwgInN2Z1xcVzNDLVNWRy0xLjEiKTsKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RS dW5uZXIvVGVzdENvbnRyb2xsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0UnVu bmVyL1Rlc3RDb250cm9sbGVyLmgJKHJldmlzaW9uIDE3MTc0OSkKKysrIFRvb2xzL1dlYktpdFRl c3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtOTgsNiArOTgsNyBA QCBwdWJsaWM6CiAgICAgdm9pZCByZXNldFByZWZlcmVuY2VzVG9Db25zaXN0ZW50VmFsdWVzKCk7 CiAKICAgICB2b2lkIHRlcm1pbmF0ZVdlYkNvbnRlbnRQcm9jZXNzKCk7CisgICAgdm9pZCByZWF0 dGFjaFBhZ2VUb1dlYlByb2Nlc3MoKTsKIAogICAgIFdvcmtRdWV1ZU1hbmFnZXImIHdvcmtRdWV1 ZU1hbmFnZXIoKSB7IHJldHVybiBtX3dvcmtRdWV1ZU1hbmFnZXI7IH0KIApJbmRleDogVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9UZXN0SW52b2NhdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9UZXN0SW52b2NhdGlvbi5jcHAJKHJldmlzaW9uIDE3MTc0OSkKKysr IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdEludm9jYXRpb24uY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yMDUsNyArMjA1LDggQEAgZW5kOgogICAgICAgICAvLyBUaGUgcHJvY2VzcyBmcm96ZSB3 aGlsZSBsb2FkaW5nIGFib3V0OmJsYW5rLCBsZXQncyBzdGFydCBhIGZyZXNoIG9uZS4KICAgICAg ICAgLy8gSXQgd291bGQgYmUgbmljZSB0byByZXBvcnQgdGhhdCB0aGUgcHJldmlvdXMgdGVzdCBm cm96ZSBhZnRlciBkdW1waW5nIHJlc3VsdHMsIGJ1dCB3ZSBoYXZlIG5vIHdheSB0byBkbyB0aGF0 LgogICAgICAgICBUZXN0Q29udHJvbGxlcjo6c2hhcmVkKCkudGVybWluYXRlV2ViQ29udGVudFBy b2Nlc3MoKTsKLSAgICAgICAgVGVzdENvbnRyb2xsZXI6OnNoYXJlZCgpLnJlc2V0U3RhdGVUb0Nv bnNpc3RlbnRWYWx1ZXMoKTsKKyAgICAgICAgLy8gTWFrZSBzdXJlIHRoYXQgd2UgaGF2ZSBhIHBy b2Nlc3MsIGFzIGludm9rZSgpIHdpbGwgbmVlZCBvbmUgdG8gc2VuZCBidW5kbGUgbWVzc2FnZXMg Zm9yIHRoZSBuZXh0IHRlc3QuCisgICAgICAgIFRlc3RDb250cm9sbGVyOjpzaGFyZWQoKS5yZWF0 dGFjaFBhZ2VUb1dlYlByb2Nlc3MoKTsKICAgICB9CiB9CiAK