135414 2014-07-30 02:47:31 -0700 Build warning in webkit/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp 2014-07-31 10:38:05 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tanay.c webkit-unassigned commit-queue mhahnenberg ossy oldest_to_newest 1025693 0 tanay.c 2014-07-30 02:47:31 -0700 Build warning as follows /home/tanay.c/webkit-tar/webkit/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1447:18: warning: unused parameter ‘vm’ [-Wunused-parameter] static JSObject* putToScopeCommon(ExecState* exec, Instruction* pc, VM& vm) 1025695 1 235738 tanay.c 2014-07-30 02:59:04 -0700 Created attachment 235738 Patch 1025704 2 235738 mhahnenberg 2014-07-30 05:53:59 -0700 Comment on attachment 235738 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235738&action=review > Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1447 > +static JSObject* putToScopeCommon(ExecState* exec, Instruction* pc, VM& /*vm*/) You don't need to comment it out. Since it's not adding any useful information, you can simply remove the parameter name entirely. 1025913 3 235807 tanay.c 2014-07-30 22:26:28 -0700 Created attachment 235807 Patch 1026011 4 235807 commit-queue 2014-07-31 10:38:03 -0700 Comment on attachment 235807 Patch Clearing flags on attachment: 235807 Committed r171867: <http://trac.webkit.org/changeset/171867> 1026012 5 commit-queue 2014-07-31 10:38:05 -0700 All reviewed patches have been landed. Closing bug. 235738 2014-07-30 02:59:04 -0700 2014-07-30 22:26:20 -0700 Patch bug-135414-20140730152928.patch text/plain 1359 tanay.c SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcxNzk1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTA3LTMwICBUYW5heSBDICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KKworICAgICAgICBC dWlsZCB3YXJuaW5nIGluIHdlYmtpdC9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnRT bG93UGF0aHMuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzU0MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGxsaW50L0xMSW50U2xvd1BhdGhzLmNwcDogY29tbWVudGVkICd2bScgcGFyYW1ldGVy IHRvIHJlbW92ZSBidWlsZCB3YXJuaW5nCisgICAgICAgIChKU0M6OkxMSW50OjpwdXRUb1Njb3Bl Q29tbW9uKToKKwogMjAxNC0wNy0yOSAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+ CiAKICAgICAgICAgVXNlIFdURjo6bW92ZSgpIGluc3RlYWQgb2Ygc3RkOjptb3ZlKCkgdG8gaGVs cCBlbnN1cmUgbW92ZSBzZW1hbnRpY3MKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGlu dC9MTEludFNsb3dQYXRocy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2xsaW50L0xMSW50U2xvd1BhdGhzLmNwcAkocmV2aXNpb24gMTcxNzg5KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2xsaW50L0xMSW50U2xvd1BhdGhzLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTQ0NCw3ICsxNDQ0LDcgQEAgTExJTlRfU0xPV19QQVRIX0RFQ0woc2xvd19wYXRoX2dldF9mcm9t XwogICAgIExMSU5UX1JFVFVSTihzbG90LmdldFZhbHVlKGV4ZWMsIGlkZW50KSk7CiB9CiAKLXN0 YXRpYyBKU09iamVjdCogcHV0VG9TY29wZUNvbW1vbihFeGVjU3RhdGUqIGV4ZWMsIEluc3RydWN0 aW9uKiBwYywgVk0mIHZtKQorc3RhdGljIEpTT2JqZWN0KiBwdXRUb1Njb3BlQ29tbW9uKEV4ZWNT dGF0ZSogZXhlYywgSW5zdHJ1Y3Rpb24qIHBjLCBWTSYgLyp2bSovKQogewogICAgIENvZGVCbG9j ayogY29kZUJsb2NrID0gZXhlYy0+Y29kZUJsb2NrKCk7CiAgICAgY29uc3QgSWRlbnRpZmllciYg aWRlbnQgPSBjb2RlQmxvY2stPmlkZW50aWZpZXIocGNbMl0udS5vcGVyYW5kKTsK 235807 2014-07-30 22:26:28 -0700 2014-07-31 10:38:03 -0700 Patch bug-135414-20140731105652.patch text/plain 1339 tanay.c SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcxODM3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTA3LTMwICBUYW5heSBDICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KKworICAgICAgICBC dWlsZCB3YXJuaW5nIGluIHdlYmtpdC9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnRT bG93UGF0aHMuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzU0MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGxsaW50L0xMSW50U2xvd1BhdGhzLmNwcDoKKyAgICAgICAgKEpTQzo6TExJbnQ6OnB1 dFRvU2NvcGVDb21tb24pOnJlbW92ZWQgdW51c2VkIHBhcmFtZXRlciBmcm9tIGZ1bmN0aW9uIGRl ZmluaXRpb24KKwogMjAxNC0wNy0zMCAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAK ICAgICAgICAgVVNFKENPTlRFTlRfRklMVEVSSU5HKSBzaG91bGQgYmUgRU5BQkxFKENPTlRFTlRf RklMVEVSSU5HKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50U2xvd1Bh dGhzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnRT bG93UGF0aHMuY3BwCShyZXZpc2lvbiAxNzE3ODkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv bGxpbnQvTExJbnRTbG93UGF0aHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDQ0LDcgKzE0NDQs NyBAQCBMTElOVF9TTE9XX1BBVEhfREVDTChzbG93X3BhdGhfZ2V0X2Zyb21fCiAgICAgTExJTlRf UkVUVVJOKHNsb3QuZ2V0VmFsdWUoZXhlYywgaWRlbnQpKTsKIH0KIAotc3RhdGljIEpTT2JqZWN0 KiBwdXRUb1Njb3BlQ29tbW9uKEV4ZWNTdGF0ZSogZXhlYywgSW5zdHJ1Y3Rpb24qIHBjLCBWTSYg dm0pCitzdGF0aWMgSlNPYmplY3QqIHB1dFRvU2NvcGVDb21tb24oRXhlY1N0YXRlKiBleGVjLCBJ bnN0cnVjdGlvbiogcGMsIFZNJikKIHsKICAgICBDb2RlQmxvY2sqIGNvZGVCbG9jayA9IGV4ZWMt PmNvZGVCbG9jaygpOwogICAgIGNvbnN0IElkZW50aWZpZXImIGlkZW50ID0gY29kZUJsb2NrLT5p ZGVudGlmaWVyKHBjWzJdLnUub3BlcmFuZCk7Cg==