135413 2014-07-30 01:50:53 -0700 Clean up the WebKit build from unused parameter warning in Webkit2/WebProcess module 2014-07-31 10:15:34 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kumar.rohit webkit-unassigned cdumez commit-queue darin gyuyoung.kim rniwa ryuan.choi sergio oldest_to_newest 1025691 0 kumar.rohit 2014-07-30 01:50:53 -0700 Clean up WebKit build from usused parameters since r171749. [ 82%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/__/__/DerivedSources/WebKit2/CoordinatedLayerTreeHostProxyMessageReceiver.cpp.o /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/OriginData/WebOriginDataManager.cpp:57:6: warning: unused parameter ‘types’ [-Wunused-parameter] void WebOriginDataManager::getOrigins(WKOriginDataTypes types, uint64_t callbackID) ^ /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/OriginData/WebOriginDataManager.cpp:73:6: warning: unused parameter ‘types’ [-Wunused-parameter] void WebOriginDataManager::deleteEntriesForOrigin(WKOriginDataTypes types, const SecurityOriginData& originData, uint64_t callbackID) ^ /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/OriginData/WebOriginDataManager.cpp:73:6: warning: unused parameter ‘originData’ [-Wunused-parameter] /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/OriginData/WebOriginDataManager.cpp:88:6: warning: unused parameter ‘types’ [-Wunused-parameter] void WebOriginDataManager::deleteEntriesModifiedBetweenDates(WKOriginDataTypes types, double startTime, double endTime, uint64_t callbackID) ^ /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/OriginData/WebOriginDataManager.cpp:88:6: warning: unused parameter ‘startTime’ [-Wunused-parameter] /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/OriginData/WebOriginDataManager.cpp:88:6: warning: unused parameter ‘endTime’ [-Wunused-parameter] /home/kumar.rohit/WebKit/Source/WebKit2/WebProcess/OriginData/WebOriginDataManager.cpp:102:6: warning: unused parameter ‘types’ [-Wunused-parameter] void WebOriginDataManager::deleteAllEntries(WKOriginDataTypes types, uint64_t callbackID) ^ Linking CXX shared library ../../lib/libewebkit2.so 1025692 1 235737 kumar.rohit 2014-07-30 02:03:41 -0700 Created attachment 235737 Patch 1025999 2 235737 commit-queue 2014-07-31 10:15:28 -0700 Comment on attachment 235737 Patch Clearing flags on attachment: 235737 Committed r171861: <http://trac.webkit.org/changeset/171861> 1026000 3 commit-queue 2014-07-31 10:15:34 -0700 All reviewed patches have been landed. Closing bug. 235737 2014-07-30 02:03:41 -0700 2014-07-31 10:15:28 -0700 Patch bug-135413-20140730143415.patch text/plain 2784 kumar.rohit U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxNzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjBmZmZiNzJmNzExNzgy YjE4NjkzMTliYjJmZGQ4N2QyZTMzNGQ5Yy4uMTQwMGM3ZThmODczOWRmZjJiOGI2M2NhZDE0MzY5 ZTBhNGNmMjZjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA3LTMwICBSb2hp dCBLdW1hciAgPGt1bWFyLnJvaGl0QHNhbXN1bmcuY29tPgorCisgICAgICAgIENsZWFuIHVwIHRo ZSBXZWJLaXQgYnVpbGQgZnJvbSB1bnVzZWQgcGFyYW1ldGVyIHdhcm5pbmcgaW4gV2Via2l0Mi9X ZWJQcm9jZXNzIG1vZHVsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTM1NDEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBXZWJQcm9jZXNzL09yaWdpbkRhdGEvV2ViT3JpZ2luRGF0YU1hbmFnZXIuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJPcmlnaW5EYXRhTWFuYWdlcjo6Z2V0T3JpZ2lucyk6Cisg ICAgICAgIChXZWJLaXQ6OldlYk9yaWdpbkRhdGFNYW5hZ2VyOjpkZWxldGVFbnRyaWVzRm9yT3Jp Z2luKToKKyAgICAgICAgKFdlYktpdDo6V2ViT3JpZ2luRGF0YU1hbmFnZXI6OmRlbGV0ZUVudHJp ZXNNb2RpZmllZEJldHdlZW5EYXRlcyk6CisgICAgICAgIChXZWJLaXQ6OldlYk9yaWdpbkRhdGFN YW5hZ2VyOjpkZWxldGVBbGxFbnRyaWVzKToKKwogMjAxNC0wNy0yOSAgQ2FybG9zIEdhcmNpYSBD YW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gUmVtb3ZlIFdlYktp dENlcnRpZmljYXRlSW5mbyBmcm9tIFdlYktpdDJHVEsrIEFQSQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9PcmlnaW5EYXRhL1dlYk9yaWdpbkRhdGFNYW5hZ2VyLmNwcCBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvT3JpZ2luRGF0YS9XZWJPcmlnaW5EYXRhTWFuYWdl ci5jcHAKaW5kZXggNGFhZTViZDhjZmY5YzdlMWEzMGIwODc0YjFjZWJmZWUwMGJlYmNkZi4uNjhl OGI3NzAxNGNlNzRjOWM4OGQzY2U1NGQ2OTk4N2Y5MzlmMzc3YSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9PcmlnaW5EYXRhL1dlYk9yaWdpbkRhdGFNYW5hZ2VyLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL09yaWdpbkRhdGEvV2ViT3JpZ2luRGF0YU1h bmFnZXIuY3BwCkBAIC02NCw2ICs2NCw4IEBAIHZvaWQgV2ViT3JpZ2luRGF0YU1hbmFnZXI6Omdl dE9yaWdpbnMoV0tPcmlnaW5EYXRhVHlwZXMgdHlwZXMsIHVpbnQ2NF90IGNhbGxiYWNrCiAgICAg ICAgIERhdGFiYXNlUHJvY2Vzczo6c2hhcmVkKCkuZ2V0SW5kZXhlZERhdGFiYXNlT3JpZ2lucyhj YWxsYmFja0lEKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KKyNlbHNlCisgICAgVU5VU0VEX1BB UkFNKHR5cGVzKTsKICNlbmRpZgogCiAgICAgVmVjdG9yPFNlY3VyaXR5T3JpZ2luRGF0YT4gcmVz dWx0czsKQEAgLTgwLDYgKzgyLDkgQEAgdm9pZCBXZWJPcmlnaW5EYXRhTWFuYWdlcjo6ZGVsZXRl RW50cmllc0Zvck9yaWdpbihXS09yaWdpbkRhdGFUeXBlcyB0eXBlcywgY29uc3QKICAgICAgICAg RGF0YWJhc2VQcm9jZXNzOjpzaGFyZWQoKS5kZWxldGVJbmRleGVkRGF0YWJhc2VFbnRyaWVzRm9y T3JpZ2luKG9yaWdpbkRhdGEsIGNhbGxiYWNrSUQpOwogICAgICAgICByZXR1cm47CiAgICAgfQor I2Vsc2UKKyAgICBVTlVTRURfUEFSQU0odHlwZXMpOworICAgIFVOVVNFRF9QQVJBTShvcmlnaW5E YXRhKTsKICNlbmRpZgogCiAgICAgbV9jaGlsZFByb2Nlc3MtPnNlbmQoTWVzc2FnZXM6OldlYk9y aWdpbkRhdGFNYW5hZ2VyUHJveHk6OkRpZERlbGV0ZUVudHJpZXMoY2FsbGJhY2tJRCksIDApOwpA QCAtOTUsNiArMTAwLDEwIEBAIHZvaWQgV2ViT3JpZ2luRGF0YU1hbmFnZXI6OmRlbGV0ZUVudHJp ZXNNb2RpZmllZEJldHdlZW5EYXRlcyhXS09yaWdpbkRhdGFUeXBlcyB0CiAgICAgICAgIERhdGFi YXNlUHJvY2Vzczo6c2hhcmVkKCkuZGVsZXRlSW5kZXhlZERhdGFiYXNlRW50cmllc01vZGlmaWVk QmV0d2VlbkRhdGVzKHN0YXJ0VGltZSwgZW5kVGltZSwgY2FsbGJhY2tJRCk7CiAgICAgICAgIHJl dHVybjsKICAgICB9CisjZWxzZQorICAgIFVOVVNFRF9QQVJBTSh0eXBlcyk7CisgICAgVU5VU0VE X1BBUkFNKHN0YXJ0VGltZSk7CisgICAgVU5VU0VEX1BBUkFNKGVuZFRpbWUpOwogI2VuZGlmCiAg ICAgbV9jaGlsZFByb2Nlc3MtPnNlbmQoTWVzc2FnZXM6OldlYk9yaWdpbkRhdGFNYW5hZ2VyUHJv eHk6OkRpZERlbGV0ZUVudHJpZXMoY2FsbGJhY2tJRCksIDApOwogfQpAQCAtMTA5LDYgKzExOCw4 IEBAIHZvaWQgV2ViT3JpZ2luRGF0YU1hbmFnZXI6OmRlbGV0ZUFsbEVudHJpZXMoV0tPcmlnaW5E YXRhVHlwZXMgdHlwZXMsIHVpbnQ2NF90IGNhCiAgICAgICAgIERhdGFiYXNlUHJvY2Vzczo6c2hh cmVkKCkuZGVsZXRlQWxsSW5kZXhlZERhdGFiYXNlRW50cmllcyhjYWxsYmFja0lEKTsKICAgICAg ICAgcmV0dXJuOwogICAgIH0KKyNlbHNlCisgICAgVU5VU0VEX1BBUkFNKHR5cGVzKTsKICNlbmRp ZgogICAgIG1fY2hpbGRQcm9jZXNzLT5zZW5kKE1lc3NhZ2VzOjpXZWJPcmlnaW5EYXRhTWFuYWdl clByb3h5OjpEaWREZWxldGVBbGxFbnRyaWVzKGNhbGxiYWNrSUQpLCAwKTsKIH0K