135406 2014-07-29 20:33:14 -0700 Web Inspector: Only compute full ProfileNode times if needed 2014-07-29 21:17:51 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1025630 0 joepeck 2014-07-29 20:33:14 -0700 * SUMMARY Profiling the timeline a lot of time was spent inside ProfileNode computing each profile node's time information. Unfortunately this information is only used by Legacy Profiler views, and not used at all in the new Timeline view, so the computation is a complete waste. We should only compute this information if needed. 1025631 1 webkit-bug-importer 2014-07-29 20:33:22 -0700 <rdar://problem/17852395> 1025632 2 235727 joepeck 2014-07-29 20:35:49 -0700 Created attachment 235727 [PATCH] Proposed Fix 1025635 3 235727 timothy 2014-07-29 20:38:11 -0700 Comment on attachment 235727 [PATCH] Proposed Fix There is no clients if these getters! It was just over engineering of the API on my part before I added the time range computation. I see no harm keeping them as lazy getters though. 1025655 4 235727 commit-queue 2014-07-29 21:17:48 -0700 Comment on attachment 235727 [PATCH] Proposed Fix Clearing flags on attachment: 235727 Committed r171787: <http://trac.webkit.org/changeset/171787> 1025656 5 commit-queue 2014-07-29 21:17:51 -0700 All reviewed patches have been landed. Closing bug. 235727 2014-07-29 20:35:49 -0700 2014-07-29 21:17:48 -0700 [PATCH] Proposed Fix profile-node-computation.patch text/plain 3513 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGExYmY0OTguLjJjMDZjYjEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE0LTA3LTI5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogT25seSBj b21wdXRlIGZ1bGwgUHJvZmlsZU5vZGUgdGltZXMgaWYgbmVlZGVkIC0gTGVnYWN5IFByb2ZpbGVy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU0MDYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGdWxsIFBy b2ZpbGVOb2RlIHRpbWVzIGFyZSBvbmx5IHVzZWQgYnkgdGhlIExlZ2FjeSBQcm9maWxlci4gVGhl IG5ldyBwcm9maWxlCisgICAgICAgIGluZm9ybWF0aW9uIGluIHRoZSBTY3JpcHRzIFRpbWVsaW5l cyBjdXJyZW50bHkgbmV2ZXIgdXNlcyB0aGUgcGFzcy4gV2Ugc2hvdWxkCisgICAgICAgIGF2b2lk IGNhbGN1bGF0aW5nIGl0IGlmIHdlIG5ldmVyIHVzZSBpdC4KKworICAgICAgICAqIFVzZXJJbnRl cmZhY2UvTW9kZWxzL1Byb2ZpbGVOb2RlLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlByb2Zp bGVOb2RlLnByb3RvdHlwZS5nZXQgc3RhcnRUaW1lKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Q cm9maWxlTm9kZS5wcm90b3R5cGUuZ2V0IGVuZFRpbWUpOgorICAgICAgICAoV2ViSW5zcGVjdG9y LlByb2ZpbGVOb2RlLnByb3RvdHlwZS5nZXQgc2VsZlRpbWUpOgorICAgICAgICAoV2ViSW5zcGVj dG9yLlByb2ZpbGVOb2RlLnByb3RvdHlwZS5nZXQgdG90YWxUaW1lKToKKyAgICAgICAgKFdlYklu c3BlY3Rvci5Qcm9maWxlTm9kZS5wcm90b3R5cGUuZXN0YWJsaXNoUmVsYXRpb25zaGlwcyk6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuUHJvZmlsZU5vZGUucHJvdG90eXBlLl9jb21wdXRlVG90YWxU aW1lcyk6CisKKzIwMTQtMDctMjkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNv bT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZWR1Y2UgZm9yY2VkIGxheW91dHMgaW4gVGlt ZWxpbmVPdmVydmlldwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTM1NDA1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL01vZGVscy9Qcm9maWxlTm9kZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL01vZGVscy9Qcm9maWxlTm9kZS5qcwppbmRleCAxN2JiMWM0Li43YmIwM2U0IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvUHJv ZmlsZU5vZGUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9k ZWxzL1Byb2ZpbGVOb2RlLmpzCkBAIC00NSwxOCArNDUsMTMgQEAgV2ViSW5zcGVjdG9yLlByb2Zp bGVOb2RlID0gZnVuY3Rpb24oaWQsIHR5cGUsIGZ1bmN0aW9uTmFtZSwgc291cmNlQ29kZUxvY2F0 aW9uLAogICAgIHRoaXMuX3BhcmVudE5vZGUgPSBudWxsOwogICAgIHRoaXMuX3ByZXZpb3VzU2li bGluZyA9IG51bGw7CiAgICAgdGhpcy5fbmV4dFNpYmxpbmcgPSBudWxsOworICAgIHRoaXMuX2Nv bXB1dGVkVG90YWxUaW1lcyA9IGZhbHNlOwogCiAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCB0aGlz Ll9jaGlsZE5vZGVzLmxlbmd0aDsgKytpKQogICAgICAgICB0aGlzLl9jaGlsZE5vZGVzW2ldLmVz dGFibGlzaFJlbGF0aW9uc2hpcHModGhpcywgdGhpcy5fY2hpbGROb2Rlc1tpIC0gMV0sIHRoaXMu X2NoaWxkTm9kZXNbaSArIDFdKTsKIAogICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdGhpcy5fY2Fs bHMubGVuZ3RoOyArK2kpCiAgICAgICAgIHRoaXMuX2NhbGxzW2ldLmVzdGFibGlzaFJlbGF0aW9u c2hpcHModGhpcywgdGhpcy5fY2FsbHNbaSAtIDFdLCB0aGlzLl9jYWxsc1tpICsgMV0pOwotCi0g ICAgdmFyIGluZm8gPSB0aGlzLmNvbXB1dGVDYWxsSW5mb0ZvclRpbWVSYW5nZSgwLCBJbmZpbml0 eSk7Ci0gICAgdGhpcy5fc3RhcnRUaW1lID0gaW5mby5zdGFydFRpbWU7Ci0gICAgdGhpcy5fZW5k VGltZSA9IGluZm8uZW5kVGltZTsKLSAgICB0aGlzLl9zZWxmVGltZSA9IGluZm8uc2VsZlRpbWU7 Ci0gICAgdGhpcy5fdG90YWxUaW1lID0gaW5mby50b3RhbFRpbWU7CiB9OwogCiBXZWJJbnNwZWN0 b3IuUHJvZmlsZU5vZGUuVHlwZSA9IHsKQEAgLTk5LDIxICs5NCwyNSBAQCBXZWJJbnNwZWN0b3Iu UHJvZmlsZU5vZGUucHJvdG90eXBlID0gewogCiAgICAgZ2V0IHN0YXJ0VGltZSgpCiAgICAgewor ICAgICAgICB0aGlzLl9jb21wdXRlVG90YWxUaW1lc0lmTmVlZGVkKCk7CiAgICAgICAgIHJldHVy biB0aGlzLl9zdGFydFRpbWU7CiAgICAgfSwKIAogICAgIGdldCBlbmRUaW1lKCkKICAgICB7Cisg ICAgICAgIHRoaXMuX2NvbXB1dGVUb3RhbFRpbWVzSWZOZWVkZWQoKTsKICAgICAgICAgcmV0dXJu IHRoaXMuX2VuZFRpbWU7CiAgICAgfSwKIAogICAgIGdldCBzZWxmVGltZSgpCiAgICAgeworICAg ICAgICB0aGlzLl9jb21wdXRlVG90YWxUaW1lc0lmTmVlZGVkKCk7CiAgICAgICAgIHJldHVybiB0 aGlzLl9zZWxmVGltZTsKICAgICB9LAogCiAgICAgZ2V0IHRvdGFsVGltZSgpCiAgICAgeworICAg ICAgICB0aGlzLl9jb21wdXRlVG90YWxUaW1lc0lmTmVlZGVkKCk7CiAgICAgICAgIHJldHVybiB0 aGlzLl90b3RhbFRpbWU7CiAgICAgfSwKIApAQCAtMjE2LDUgKzIxNSwyMSBAQCBXZWJJbnNwZWN0 b3IuUHJvZmlsZU5vZGUucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLl9wYXJlbnROb2RlID0g cGFyZW50Tm9kZSB8fCBudWxsOwogICAgICAgICB0aGlzLl9wcmV2aW91c1NpYmxpbmcgPSBwcmV2 aW91c1NpYmxpbmcgfHwgbnVsbDsKICAgICAgICAgdGhpcy5fbmV4dFNpYmxpbmcgPSBuZXh0U2li bGluZyB8fCBudWxsOworICAgIH0sCisKKyAgICAvLyBQcml2YXRlCisKKyAgICBfY29tcHV0ZVRv dGFsVGltZXM6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIGlmICh0aGlzLl9jb21wdXRlZFRv dGFsVGltZXMpCisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgdGhpcy5fY29tcHV0ZWRU b3RhbFRpbWVzID0gdHJ1ZTsKKworICAgICAgICB2YXIgaW5mbyA9IHRoaXMuY29tcHV0ZUNhbGxJ bmZvRm9yVGltZVJhbmdlKDAsIEluZmluaXR5KTsKKyAgICAgICAgdGhpcy5fc3RhcnRUaW1lID0g aW5mby5zdGFydFRpbWU7CisgICAgICAgIHRoaXMuX2VuZFRpbWUgPSBpbmZvLmVuZFRpbWU7Cisg ICAgICAgIHRoaXMuX3NlbGZUaW1lID0gaW5mby5zZWxmVGltZTsKKyAgICAgICAgdGhpcy5fdG90 YWxUaW1lID0gaW5mby50b3RhbFRpbWU7CiAgICAgfQogfTsK