135405 2014-07-29 20:26:05 -0700 Web Inspector: Reduce forced layouts in TimelineOverview 2014-07-29 21:01:01 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1025629 0 joepeck 2014-07-29 20:26:05 -0700 * SUMMARY I am seeing forced layouts in TimelineOverview.prototype.updateLayout checking this._scrollContainer.offsetWidth. These seem unnecessary, as the scrollContainer did not change size at all. The container should only change if the ContentView changes size (window resize, sidebar expand/collapse), e.g. the normal ContentView.prototype.updateLayout. 1025633 1 235728 joepeck 2014-07-29 20:36:14 -0700 Created attachment 235728 [PATCH] Proposed Fix 1025634 2 webkit-bug-importer 2014-07-29 20:36:32 -0700 <rdar://problem/17852407> 1025638 3 235728 timothy 2014-07-29 20:46:53 -0700 Comment on attachment 235728 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=235728&action=review > Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:224 > + updateLayoutForResize: function() Maybe we should/could start doing this in more places. Timeline is the first place is used updatLayout heavily to mean more than just resize. 1025647 4 235728 commit-queue 2014-07-29 21:00:58 -0700 Comment on attachment 235728 [PATCH] Proposed Fix Clearing flags on attachment: 235728 Committed r171786: <http://trac.webkit.org/changeset/171786> 1025648 5 commit-queue 2014-07-29 21:01:01 -0700 All reviewed patches have been landed. Closing bug. 235728 2014-07-29 20:36:14 -0700 2014-07-29 21:00:58 -0700 [PATCH] Proposed Fix resize-forced-layout.patch text/plain 3442 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGE0M2VmZTYuLmExYmY0OTggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDE0LTA3LTI5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVkdWNl IGZvcmNlZCBsYXlvdXRzIGluIFRpbWVsaW5lT3ZlcnZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTQwNQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBhbm90aGVyIGZvcmNlZCBsYXlvdXQu IFRoZSBzY3JvbGwgY29udGFpbmVyIHdvbid0CisgICAgICAgIGNoYW5nZSBzaXplIHVubGVzcyB0 aGUgQ29udGVudFZpZXcgaXRzZWxmIHJlc2l6ZWQuIE1ha2UgdGhlCisgICAgICAgIGRpc3RpbmN0 aW9uIGJldHdlZW4gYSBsYXlvdXQgdXBkYXRlIGR1ZSB0byBhIHJlc2l6ZSBhbmQKKyAgICAgICAg bm9ybWFsIGV2ZW50cyAoc2NhbGUgY2hhbmdlcywgZXRjKSBhbmQgb25seSBjYWxjdWxhdGUKKyAg ICAgICAgZWxlbWVudCBzaXplcyB0aGVuLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3 cy9UaW1lbGluZUNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5l Q29udGVudFZpZXcucHJvdG90eXBlLnVwZGF0ZUxheW91dCk6CisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9UaW1lbGluZU92ZXJ2aWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRp bWVsaW5lT3ZlcnZpZXcpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lT3ZlcnZpZXcu cHJvdG90eXBlLmdldCB2aXNpYmxlRHVyYXRpb24pOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRp bWVsaW5lT3ZlcnZpZXcucHJvdG90eXBlLnVwZGF0ZUxheW91dEZvclJlc2l6ZSk6CisKKzIwMTQt MDctMjkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBFbGltaW5hdGUgbW9yZSBmb3JjZWQgbGF5b3V0cyBkdXJpbmcgdGltZWxp bmUgcmVjb3JkaW5ncwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTM1Mzk3CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZUNvbnRlbnRWaWV3LmpzCmluZGV4IDIxYzEy ZWMuLjU5ZmRhMmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1RpbWVsaW5lQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVDb250ZW50Vmlldy5qcwpAQCAtMTU2LDcg KzE1Niw3IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZUNvbnRlbnRWaWV3LnByb3RvdHlwZSA9IHsK IAogICAgIHVwZGF0ZUxheW91dDogZnVuY3Rpb24oKQogICAgIHsKLSAgICAgICAgdGhpcy5fdGlt ZWxpbmVPdmVydmlldy51cGRhdGVMYXlvdXQoKTsKKyAgICAgICAgdGhpcy5fdGltZWxpbmVPdmVy dmlldy51cGRhdGVMYXlvdXRGb3JSZXNpemUoKTsKIAogICAgICAgICBpZiAoIXRoaXMuX2N1cnJl bnRUaW1lbGluZVZpZXcpCiAgICAgICAgICAgICByZXR1cm47CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZU92ZXJ2aWV3LmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVPdmVydmll dy5qcwppbmRleCBlMzFhNTY3Li5jMmY1NjNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZU92ZXJ2aWV3LmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lT3ZlcnZpZXcuanMK QEAgLTY5LDYgKzY5LDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lT3ZlcnZpZXcgPSBmdW5jdGlv bih0aW1lbGluZU92ZXJ2aWV3R3JhcGhzTWFwKQogICAgIHRoaXMuX2VuZFRpbWUgPSAwOwogICAg IHRoaXMuX3NlY29uZHNQZXJQaXhlbCA9IHRoaXMuX3NlY29uZHNQZXJQaXhlbFNldHRpbmcudmFs dWU7CiAgICAgdGhpcy5fc2Nyb2xsU3RhcnRUaW1lID0gMDsKKyAgICB0aGlzLl9jYWNoZWRTY3Jv bGxDb250YWluZXJXaWR0aCA9IE5hTjsKIAogICAgIHRoaXMuc2VsZWN0aW9uU3RhcnRUaW1lID0g dGhpcy5fc2VsZWN0aW9uU3RhcnRUaW1lU2V0dGluZy52YWx1ZTsKICAgICB0aGlzLnNlbGVjdGlv bkR1cmF0aW9uID0gdGhpcy5fc2VsZWN0aW9uRHVyYXRpb25TZXR0aW5nLnZhbHVlOwpAQCAtMTc3 LDcgKzE3OCwxMiBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVPdmVydmlldy5wcm90b3R5cGUgPSB7 CiAKICAgICBnZXQgdmlzaWJsZUR1cmF0aW9uKCkKICAgICB7Ci0gICAgICAgIHJldHVybiB0aGlz Ll9zY3JvbGxDb250YWluZXIub2Zmc2V0V2lkdGggKiB0aGlzLl9zZWNvbmRzUGVyUGl4ZWw7Cisg ICAgICAgIGlmIChpc05hTih0aGlzLl9jYWNoZWRTY3JvbGxDb250YWluZXJXaWR0aCkpIHsKKyAg ICAgICAgICAgIHRoaXMuX2NhY2hlZFNjcm9sbENvbnRhaW5lcldpZHRoID0gdGhpcy5fc2Nyb2xs Q29udGFpbmVyLm9mZnNldFdpZHRoOworICAgICAgICAgICAgY29uc29sZS5hc3NlcnQodGhpcy5f Y2FjaGVkU2Nyb2xsQ29udGFpbmVyV2lkdGggPiAwKTsKKyAgICAgICAgfQorCisgICAgICAgIHJl dHVybiB0aGlzLl9jYWNoZWRTY3JvbGxDb250YWluZXJXaWR0aCAqIHRoaXMuX3NlY29uZHNQZXJQ aXhlbDsKICAgICB9LAogCiAgICAgZ2V0IHNlbGVjdGlvblN0YXJ0VGltZSgpCkBAIC0yMTUsNiAr MjIxLDEyIEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3LnByb3RvdHlwZSA9IHsKICAg ICAgICAgdGhpcy5zY3JvbGxTdGFydFRpbWUgPSBtYXJrZXIudGltZSAtICh0aGlzLnZpc2libGVE dXJhdGlvbiAvIDIpOwogICAgIH0sCiAKKyAgICB1cGRhdGVMYXlvdXRGb3JSZXNpemU6IGZ1bmN0 aW9uKCkKKyAgICB7CisgICAgICAgIHRoaXMuX2NhY2hlZFNjcm9sbENvbnRhaW5lcldpZHRoID0g TmFOOworICAgICAgICB0aGlzLnVwZGF0ZUxheW91dCgpOworICAgIH0sCisKICAgICB1cGRhdGVM YXlvdXQ6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIGlmICh0aGlzLl9zY2hlZHVsZWRMYXlv dXRVcGRhdGVJZGVudGlmaWVyKSB7Cg==