135384 2014-07-29 06:46:57 -0700 [TexMap] Move TextureMapperLayer::textureMapper() definition into the header 2014-07-30 00:48:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan cmarcelo commit-queue kondapallykalyan luiz mrobinson noam oldest_to_newest 1025460 0 zan 2014-07-29 06:46:57 -0700 [TexMap] Move TextureMapperLayer::textureMapper() definition into the header 1025461 1 235685 zan 2014-07-29 06:56:07 -0700 Created attachment 235685 Patch 1025504 2 235685 mrobinson 2014-07-29 10:05:12 -0700 Comment on attachment 235685 Patch Does this result in notable performance improvement. I ask because changes like these also increase code size. 1025554 3 zan 2014-07-29 14:04:13 -0700 Inlining the two methods results in the generation of 7 instructions in total that crawl up the combined chain of effect targets and parent layers. I think this is a better alternative to the overhead of branching into a separate function and setting up the prologue and epilogue there. This only affects three call sites, one of which was noticeably hot during the profiling. It's still only a small improvement, but comes at a minimal cost of increase in code size. 1025683 4 235685 zan 2014-07-30 00:48:05 -0700 Comment on attachment 235685 Patch Clearing flags on attachment: 235685 Committed r171795: <http://trac.webkit.org/changeset/171795> 1025684 5 zan 2014-07-30 00:48:13 -0700 All reviewed patches have been landed. Closing bug. 235685 2014-07-29 06:56:07 -0700 2014-07-30 00:48:05 -0700 Patch bug-135384-20140729065553.patch text/plain 3650 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTc0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE0LTA3LTI5ICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbVGV4TWFwXSBNb3ZlIFRl eHR1cmVNYXBwZXJMYXllcjo6dGV4dHVyZU1hcHBlcigpIGRlZmluaXRpb24gaW50byB0aGUgaGVh ZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzUz ODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3Zl IHRoZSBkZWZpbml0aW9ucyBvZiBUZXh0dXJlTWFwcGVyTGF5ZXI6OnRleHR1cmVNYXBwZXIoKSBh bmQgVGV4dHVyZU1hcHBlckxheWVyOjpyb290TGF5ZXIoKQorICAgICAgICBpbnRvIHRoZSBUZXh0 dXJlTWFwcGVyTGF5ZXIgaGVhZGVyLiBUaGlzIG1ha2VzIGJvdGggZnVuY3Rpb25zIGlubGluZS1h YmxlLCByZW1vdmluZyB1bm5lY2Vzc2FyeQorICAgICAgICBjYWxsaW5nIG92ZXJoZWFkIGluIEdy YXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyOjpmbHVzaENvbXBvc2l0aW5nU3RhdGUoKSBhbmQKKyAg ICAgICAgR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXI6OnVwZGF0ZUJhY2tpbmdTdG9yZUlmTmVl ZGVkKCkuCisKKyAgICAgICAgVGV4dHVyZU1hcHBlckxheWVyOjpyb290TGF5ZXIoKSBub3cgYWxz byByZXR1cm5zIGEgcmVmZXJlbmNlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4 bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0dXJlTWFw cGVyTGF5ZXI6On5UZXh0dXJlTWFwcGVyTGF5ZXIpOgorICAgICAgICAoV2ViQ29yZTo6VGV4dHVy ZU1hcHBlckxheWVyOjpyb290TGF5ZXIpOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6VGV4 dHVyZU1hcHBlckxheWVyOjp0ZXh0dXJlTWFwcGVyKTogRGVsZXRlZC4KKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmg6CisgICAgICAgIChXZWJD b3JlOjpUZXh0dXJlTWFwcGVyTGF5ZXI6OnRleHR1cmVNYXBwZXIpOgorICAgICAgICAoV2ViQ29y ZTo6VGV4dHVyZU1hcHBlckxheWVyOjpyb290TGF5ZXIpOgorCiAyMDE0LTA3LTI5ICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbVGV4TWFwXSBHcmFwaGlj c0xheWVyVGV4dHVyZU1hcHBlcjo6YWRkQW5pbWF0aW9uKCkgYm94IHNpemUgcGFyYW1ldGVyIHNo b3VsZCBiZSBGbG9hdFNpemUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCShyZXZp c2lvbiAxNzE3NDIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAv VGV4dHVyZU1hcHBlckxheWVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDEsMTUgKzQxLDYgQEAg cHVibGljOgogICAgIHsgfQogfTsKIAotY29uc3QgVGV4dHVyZU1hcHBlckxheWVyKiBUZXh0dXJl TWFwcGVyTGF5ZXI6OnJvb3RMYXllcigpIGNvbnN0Ci17Ci0gICAgaWYgKG1fZWZmZWN0VGFyZ2V0 KQotICAgICAgICByZXR1cm4gbV9lZmZlY3RUYXJnZXQtPnJvb3RMYXllcigpOwotICAgIGlmICht X3BhcmVudCkKLSAgICAgICAgcmV0dXJuIG1fcGFyZW50LT5yb290TGF5ZXIoKTsKLSAgICByZXR1 cm4gdGhpczsKLX0KLQogdm9pZCBUZXh0dXJlTWFwcGVyTGF5ZXI6OmNvbXB1dGVUcmFuc2Zvcm1z UmVjdXJzaXZlKCkKIHsKICAgICBpZiAobV9zdGF0ZS5zaXplLmlzRW1wdHkoKSAmJiBtX3N0YXRl Lm1hc2tzVG9Cb3VuZHMpCkBAIC00NjcsMTEgKzQ1OCw2IEBAIFRleHR1cmVNYXBwZXJMYXllcjo6 flRleHR1cmVNYXBwZXJMYXllcigKICAgICByZW1vdmVGcm9tUGFyZW50KCk7CiB9CiAKLVRleHR1 cmVNYXBwZXIqIFRleHR1cmVNYXBwZXJMYXllcjo6dGV4dHVyZU1hcHBlcigpIGNvbnN0Ci17Ci0g ICAgcmV0dXJuIHJvb3RMYXllcigpLT5tX3RleHR1cmVNYXBwZXI7Ci19Ci0KIHZvaWQgVGV4dHVy ZU1hcHBlckxheWVyOjpzZXRDaGlsZHJlbihjb25zdCBWZWN0b3I8VGV4dHVyZU1hcHBlckxheWVy Kj4mIG5ld0NoaWxkcmVuKQogewogICAgIHJlbW92ZUFsbENoaWxkcmVuKCk7CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1Rl eHR1cmVNYXBwZXJMYXllci5oCShyZXZpc2lvbiAxNzE3NDIpCisrKyBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmgJKHdvcmtpbmcgY29w eSkKQEAgLTc0LDcgKzc0LDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0SXNTY3JvbGxhYmxlKGJv b2wgaXNTY3JvbGxhYmxlKSB7IG1faXNTY3JvbGxhYmxlID0gaXNTY3JvbGxhYmxlOyB9CiAgICAg Ym9vbCBpc1Njcm9sbGFibGUoKSBjb25zdCB7IHJldHVybiBtX2lzU2Nyb2xsYWJsZTsgfQogCi0g ICAgVGV4dHVyZU1hcHBlciogdGV4dHVyZU1hcHBlcigpIGNvbnN0OworICAgIFRleHR1cmVNYXBw ZXIqIHRleHR1cmVNYXBwZXIoKSBjb25zdCB7IHJldHVybiByb290TGF5ZXIoKS5tX3RleHR1cmVN YXBwZXI7IH0KICAgICB2b2lkIHNldFRleHR1cmVNYXBwZXIoVGV4dHVyZU1hcHBlciogdGV4bWFw KSB7IG1fdGV4dHVyZU1hcHBlciA9IHRleG1hcDsgfQogCiAgICAgdm9pZCBzZXRDaGlsZHJlbihj b25zdCBWZWN0b3I8VGV4dHVyZU1hcHBlckxheWVyKj4mKTsKQEAgLTEzNCw3ICsxMzQsMTQgQEAg cHVibGljOgogICAgIHZvaWQgYWRkQ2hpbGQoVGV4dHVyZU1hcHBlckxheWVyKik7CiAKIHByaXZh dGU6Ci0gICAgY29uc3QgVGV4dHVyZU1hcHBlckxheWVyKiByb290TGF5ZXIoKSBjb25zdDsKKyAg ICBjb25zdCBUZXh0dXJlTWFwcGVyTGF5ZXImIHJvb3RMYXllcigpIGNvbnN0CisgICAgeworICAg ICAgICBpZiAobV9lZmZlY3RUYXJnZXQpCisgICAgICAgICAgICByZXR1cm4gbV9lZmZlY3RUYXJn ZXQtPnJvb3RMYXllcigpOworICAgICAgICBpZiAobV9wYXJlbnQpCisgICAgICAgICAgICByZXR1 cm4gbV9wYXJlbnQtPnJvb3RMYXllcigpOworICAgICAgICByZXR1cm4gKnRoaXM7CisgICAgfQog ICAgIHZvaWQgY29tcHV0ZVRyYW5zZm9ybXNSZWN1cnNpdmUoKTsKIAogICAgIHN0YXRpYyBpbnQg Y29tcGFyZUdyYXBoaWNzTGF5ZXJzWlZhbHVlKGNvbnN0IHZvaWQqIGEsIGNvbnN0IHZvaWQqIGIp Owo=