135373 2014-07-28 19:44:32 -0700 Web Inspector: Reduce work creating the initial WebInspector.TimelineRecordBar 2014-07-28 21:15:01 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1025365 0 joepeck 2014-07-28 19:44:32 -0700 * SUMMARY WebInspector.TimelineRecordBar initializes its records and renderMode twice. Once in the constructor with empty values, and then immediately after. We can eliminate unnecessary duplication. 1025366 1 webkit-bug-importer 2014-07-28 19:44:40 -0700 <rdar://problem/17838230> 1025367 2 235658 joepeck 2014-07-28 19:48:01 -0700 Created attachment 235658 [PATCH] Proposed Fix 1025378 3 235658 commit-queue 2014-07-28 21:14:59 -0700 Comment on attachment 235658 [PATCH] Proposed Fix Clearing flags on attachment: 235658 Committed r171720: <http://trac.webkit.org/changeset/171720> 1025379 4 commit-queue 2014-07-28 21:15:01 -0700 All reviewed patches have been landed. Closing bug. 235658 2014-07-28 19:48:01 -0700 2014-07-28 21:14:59 -0700 [PATCH] Proposed Fix reduce-work.patch text/plain 6568 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGZjN2RiOTUuLmFmZWQ3NGQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI4IEBACiAyMDE0LTA3LTI4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVkdWNl IHdvcmsgY3JlYXRpbmcgdGhlIGluaXRpYWwgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkQmFy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzUzNzMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbGltaW5h dGUgYSBiaXQgb2YgZXh0cmEgd29yayBjcmVhdGluZyBUaW1lbGluZVJlY29yZEJhcnMuIFByZXZp b3VzbHkKKyAgICAgICAgdGhlIGNvbnN0cnVjdG9yIHdvdWxkIHNldHVwIGFuIGVtcHR5IGxpc3Qg b2YgcmVjb3JkcywgYW5kIHRoZW4gd2Ugd291bGQKKyAgICAgICAgaW1tZWRpYXRlbHkgYWZ0ZXIg cmVwbGFjZSB0aGVtLiBOb3cganVzdCBzZXQgdGhlbSBpbiB0aGUgY29uc3RydWN0b3IuCisKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0xheW91dFRpbWVsaW5lT3ZlcnZpZXdHcmFwaC5q czoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5MYXlvdXRUaW1lbGluZU92ZXJ2aWV3R3JhcGgucHJv dG90eXBlLnVwZGF0ZUxheW91dC5jcmVhdGVCYXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkxh eW91dFRpbWVsaW5lT3ZlcnZpZXdHcmFwaC5wcm90b3R5cGUudXBkYXRlTGF5b3V0KToKKyAgICAg ICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUaW1lbGluZU92ZXJ2aWV3R3JhcGguanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmV0d29ya1RpbWVsaW5lT3ZlcnZpZXdHcmFwaC5wcm90 b3R5cGUudXBkYXRlTGF5b3V0LmNyZWF0ZUJhcik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmV0 d29ya1RpbWVsaW5lT3ZlcnZpZXdHcmFwaC5wcm90b3R5cGUudXBkYXRlTGF5b3V0KToKKyAgICAg ICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1NjcmlwdFRpbWVsaW5lT3ZlcnZpZXdHcmFwaC5qczoK KyAgICAgICAgKFdlYkluc3BlY3Rvci5TY3JpcHRUaW1lbGluZU92ZXJ2aWV3R3JhcGgucHJvdG90 eXBlLnVwZGF0ZUxheW91dC5jcmVhdGVCYXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlw dFRpbWVsaW5lT3ZlcnZpZXdHcmFwaC5wcm90b3R5cGUudXBkYXRlTGF5b3V0KToKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lRGF0YUdyaWROb2RlLmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLlRpbWVsaW5lRGF0YUdyaWROb2RlLnByb3RvdHlwZS5yZWZyZXNoR3JhcGgu Y3JlYXRlQmFyKToKKworMjAxNC0wNy0yOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBw bGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEluY29ycmVjdGx5IHNpemVkIFRpbWVs aW5lRGF0YUdyaWQgZXZlbnQgYnViYmxlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzUzNzEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTGF5b3V0VGltZWxpbmVPdmVydmlld0dyYXBoLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTGF5b3V0VGltZWxpbmVP dmVydmlld0dyYXBoLmpzCmluZGV4IGZmMTExNDQuLmIxY2U4N2QgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xheW91dFRpbWVsaW5lT3ZlcnZp ZXdHcmFwaC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9MYXlvdXRUaW1lbGluZU92ZXJ2aWV3R3JhcGguanMKQEAgLTY3LDkgKzY3LDExIEBAIFdlYklu c3BlY3Rvci5MYXlvdXRUaW1lbGluZU92ZXJ2aWV3R3JhcGgucHJvdG90eXBlID0gewogICAgICAg ICB7CiAgICAgICAgICAgICB2YXIgdGltZWxpbmVSZWNvcmRCYXIgPSB0aGlzLl90aW1lbGluZVJl Y29yZEJhcnNbcmVjb3JkQmFySW5kZXhdOwogICAgICAgICAgICAgaWYgKCF0aW1lbGluZVJlY29y ZEJhcikKLSAgICAgICAgICAgICAgICB0aW1lbGluZVJlY29yZEJhciA9IHRoaXMuX3RpbWVsaW5l UmVjb3JkQmFyc1tyZWNvcmRCYXJJbmRleF0gPSBuZXcgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVj b3JkQmFyOwotICAgICAgICAgICAgdGltZWxpbmVSZWNvcmRCYXIucmVuZGVyTW9kZSA9IHJlbmRl ck1vZGU7Ci0gICAgICAgICAgICB0aW1lbGluZVJlY29yZEJhci5yZWNvcmRzID0gcmVjb3JkczsK KyAgICAgICAgICAgICAgICB0aW1lbGluZVJlY29yZEJhciA9IHRoaXMuX3RpbWVsaW5lUmVjb3Jk QmFyc1tyZWNvcmRCYXJJbmRleF0gPSBuZXcgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkQmFy KHJlY29yZHMsIHJlbmRlck1vZGUpOworICAgICAgICAgICAgZWxzZSB7CisgICAgICAgICAgICAg ICAgdGltZWxpbmVSZWNvcmRCYXIucmVuZGVyTW9kZSA9IHJlbmRlck1vZGU7CisgICAgICAgICAg ICAgICAgdGltZWxpbmVSZWNvcmRCYXIucmVjb3JkcyA9IHJlY29yZHM7CisgICAgICAgICAgICB9 CiAgICAgICAgICAgICB0aW1lbGluZVJlY29yZEJhci5yZWZyZXNoKHRoaXMpOwogICAgICAgICAg ICAgaWYgKCF0aW1lbGluZVJlY29yZEJhci5lbGVtZW50LnBhcmVudE5vZGUpCiAgICAgICAgICAg ICAgICAgdGhpcy5lbGVtZW50LmFwcGVuZENoaWxkKHRpbWVsaW5lUmVjb3JkQmFyLmVsZW1lbnQp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv TmV0d29ya1RpbWVsaW5lT3ZlcnZpZXdHcmFwaC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUaW1lbGluZU92ZXJ2aWV3R3JhcGguanMKaW5kZXgg MDkzNWNiYi4uYTc1OTcyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvTmV0d29ya1RpbWVsaW5lT3ZlcnZpZXdHcmFwaC5qcworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGltZWxpbmVPdmVy dmlld0dyYXBoLmpzCkBAIC04NCw5ICs4NCwxMSBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya1RpbWVs aW5lT3ZlcnZpZXdHcmFwaC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHsKICAgICAgICAgICAgIHZh ciB0aW1lbGluZVJlY29yZEJhciA9IHJvd1JlY29yZEJhcnNbcmVjb3JkQmFySW5kZXhdOwogICAg ICAgICAgICAgaWYgKCF0aW1lbGluZVJlY29yZEJhcikKLSAgICAgICAgICAgICAgICB0aW1lbGlu ZVJlY29yZEJhciA9IHJvd1JlY29yZEJhcnNbcmVjb3JkQmFySW5kZXhdID0gbmV3IFdlYkluc3Bl Y3Rvci5UaW1lbGluZVJlY29yZEJhcjsKLSAgICAgICAgICAgIHRpbWVsaW5lUmVjb3JkQmFyLnJl bmRlck1vZGUgPSByZW5kZXJNb2RlOwotICAgICAgICAgICAgdGltZWxpbmVSZWNvcmRCYXIucmVj b3JkcyA9IHJlY29yZHM7CisgICAgICAgICAgICAgICAgdGltZWxpbmVSZWNvcmRCYXIgPSByb3dS ZWNvcmRCYXJzW3JlY29yZEJhckluZGV4XSA9IG5ldyBXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNv cmRCYXIocmVjb3JkcywgcmVuZGVyTW9kZSk7CisgICAgICAgICAgICBlbHNlIHsKKyAgICAgICAg ICAgICAgICB0aW1lbGluZVJlY29yZEJhci5yZW5kZXJNb2RlID0gcmVuZGVyTW9kZTsKKyAgICAg ICAgICAgICAgICB0aW1lbGluZVJlY29yZEJhci5yZWNvcmRzID0gcmVjb3JkczsKKyAgICAgICAg ICAgIH0KICAgICAgICAgICAgIHRpbWVsaW5lUmVjb3JkQmFyLnJlZnJlc2godGhpcyk7CiAgICAg ICAgICAgICBpZiAoIXRpbWVsaW5lUmVjb3JkQmFyLmVsZW1lbnQucGFyZW50Tm9kZSkKICAgICAg ICAgICAgICAgICByb3dFbGVtZW50LmFwcGVuZENoaWxkKHRpbWVsaW5lUmVjb3JkQmFyLmVsZW1l bnQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvU2NyaXB0VGltZWxpbmVPdmVydmlld0dyYXBoLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvU2NyaXB0VGltZWxpbmVPdmVydmlld0dyYXBoLmpzCmluZGV4 IDkwNGVhZTEuLjg0MjUxMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1NjcmlwdFRpbWVsaW5lT3ZlcnZpZXdHcmFwaC5qcworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TY3JpcHRUaW1lbGluZU92ZXJ2 aWV3R3JhcGguanMKQEAgLTY3LDkgKzY3LDExIEBAIFdlYkluc3BlY3Rvci5TY3JpcHRUaW1lbGlu ZU92ZXJ2aWV3R3JhcGgucHJvdG90eXBlID0gewogICAgICAgICB7CiAgICAgICAgICAgICB2YXIg dGltZWxpbmVSZWNvcmRCYXIgPSB0aGlzLl90aW1lbGluZVJlY29yZEJhcnNbcmVjb3JkQmFySW5k ZXhdOwogICAgICAgICAgICAgaWYgKCF0aW1lbGluZVJlY29yZEJhcikKLSAgICAgICAgICAgICAg ICB0aW1lbGluZVJlY29yZEJhciA9IHRoaXMuX3RpbWVsaW5lUmVjb3JkQmFyc1tyZWNvcmRCYXJJ bmRleF0gPSBuZXcgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkQmFyOwotICAgICAgICAgICAg dGltZWxpbmVSZWNvcmRCYXIucmVuZGVyTW9kZSA9IHJlbmRlck1vZGU7Ci0gICAgICAgICAgICB0 aW1lbGluZVJlY29yZEJhci5yZWNvcmRzID0gcmVjb3JkczsKKyAgICAgICAgICAgICAgICB0aW1l bGluZVJlY29yZEJhciA9IHRoaXMuX3RpbWVsaW5lUmVjb3JkQmFyc1tyZWNvcmRCYXJJbmRleF0g PSBuZXcgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkQmFyKHJlY29yZHMsIHJlbmRlck1vZGUp OworICAgICAgICAgICAgZWxzZSB7CisgICAgICAgICAgICAgICAgdGltZWxpbmVSZWNvcmRCYXIu cmVuZGVyTW9kZSA9IHJlbmRlck1vZGU7CisgICAgICAgICAgICAgICAgdGltZWxpbmVSZWNvcmRC YXIucmVjb3JkcyA9IHJlY29yZHM7CisgICAgICAgICAgICB9CiAgICAgICAgICAgICB0aW1lbGlu ZVJlY29yZEJhci5yZWZyZXNoKHRoaXMpOwogICAgICAgICAgICAgaWYgKCF0aW1lbGluZVJlY29y ZEJhci5lbGVtZW50LnBhcmVudE5vZGUpCiAgICAgICAgICAgICAgICAgdGhpcy5lbGVtZW50LmFw cGVuZENoaWxkKHRpbWVsaW5lUmVjb3JkQmFyLmVsZW1lbnQpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVEYXRhR3JpZE5vZGUu anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZURh dGFHcmlkTm9kZS5qcwppbmRleCBmM2ZmZGRhLi5kYTdkM2E2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZURhdGFHcmlkTm9kZS5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGlu ZURhdGFHcmlkTm9kZS5qcwpAQCAtMjQ1LDkgKzI0NSwxMSBAQCBXZWJJbnNwZWN0b3IuVGltZWxp bmVEYXRhR3JpZE5vZGUucHJvdG90eXBlID0gewogICAgICAgICB7CiAgICAgICAgICAgICB2YXIg dGltZWxpbmVSZWNvcmRCYXIgPSB0aGlzLl90aW1lbGluZVJlY29yZEJhcnNbcmVjb3JkQmFySW5k ZXhdOwogICAgICAgICAgICAgaWYgKCF0aW1lbGluZVJlY29yZEJhcikKLSAgICAgICAgICAgICAg ICB0aW1lbGluZVJlY29yZEJhciA9IHRoaXMuX3RpbWVsaW5lUmVjb3JkQmFyc1tyZWNvcmRCYXJJ bmRleF0gPSBuZXcgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkQmFyOwotICAgICAgICAgICAg dGltZWxpbmVSZWNvcmRCYXIucmVuZGVyTW9kZSA9IHJlbmRlck1vZGU7Ci0gICAgICAgICAgICB0 aW1lbGluZVJlY29yZEJhci5yZWNvcmRzID0gcmVjb3JkczsKKyAgICAgICAgICAgICAgICB0aW1l bGluZVJlY29yZEJhciA9IHRoaXMuX3RpbWVsaW5lUmVjb3JkQmFyc1tyZWNvcmRCYXJJbmRleF0g PSBuZXcgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkQmFyKHJlY29yZHMsIHJlbmRlck1vZGUp OworICAgICAgICAgICAgZWxzZSB7CisgICAgICAgICAgICAgICAgdGltZWxpbmVSZWNvcmRCYXIu cmVuZGVyTW9kZSA9IHJlbmRlck1vZGU7CisgICAgICAgICAgICAgICAgdGltZWxpbmVSZWNvcmRC YXIucmVjb3JkcyA9IHJlY29yZHM7CisgICAgICAgICAgICB9CiAgICAgICAgICAgICB0aW1lbGlu ZVJlY29yZEJhci5yZWZyZXNoKHRoaXMuX2dyYXBoRGF0YVNvdXJjZSk7CiAgICAgICAgICAgICBp ZiAoIXRpbWVsaW5lUmVjb3JkQmFyLmVsZW1lbnQucGFyZW50Tm9kZSkKICAgICAgICAgICAgICAg ICB0aGlzLl9ncmFwaENvbnRhaW5lckVsZW1lbnQuYXBwZW5kQ2hpbGQodGltZWxpbmVSZWNvcmRC YXIuZWxlbWVudCk7Cg==