135372 2014-07-28 17:11:50 -0700 Web Inspector: Dragging selection window when mouse goes out of window bounds does not behave as expected 2014-08-07 13:51:54 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned graouts joepeck timothy webkit-bug-importer oldest_to_newest 1025334 0 joepeck 2014-07-28 17:11:50 -0700 * SUMMARY Dragging selection window when mouse goes out of window bounds does not behave as expected. The selection window moves left/right as the mouse moves left/right outside of the window. The drag should only move once the mouse comes back over the window. It should always be vertically aligned with the cursor when the cursor is over the window. * STEPS TO REPRODUCE 1. Open inspector 2. Select a small time range 3. Start dragging the selection (from the time ruler so you move the selection entirely with the mouse) 4. Mouse out of the right side of the window (ranged selection is flush to the right side) 5. Start moving the mouse back left to the window => ranged selection moved left! I would only expect this once the mouse is back over the window 1025336 1 webkit-bug-importer 2014-07-28 17:12:41 -0700 <rdar://problem/17836873> 1027593 2 236217 joepeck 2014-08-07 13:44:33 -0700 Created attachment 236217 [PATCH] Proposed Fix 1027595 3 236217 timothy 2014-08-07 13:46:31 -0700 Comment on attachment 236217 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=236217&action=review > Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:611 > + var selectionDragElementRects = this._selectionDragElement.getBoundingClientRect(); selectionDragElementRect instead of selectionDragElementRects? 1027596 4 236217 joepeck 2014-08-07 13:47:09 -0700 Comment on attachment 236217 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=236217&action=review >> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:611 >> + var selectionDragElementRects = this._selectionDragElement.getBoundingClientRect(); > > selectionDragElementRect instead of selectionDragElementRects? Oop, yeah. Will fix. 1027599 5 joepeck 2014-08-07 13:51:54 -0700 <http://trac.webkit.org/changeset/172249> 236217 2014-08-07 13:44:33 -0700 2014-08-07 13:47:16 -0700 [PATCH] Proposed Fix drag-window.patch text/plain 4875 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGJhMWM5MTkuLjk3ZDc2NGQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA4LTA3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRHJhZ2dp bmcgc2VsZWN0aW9uIHdpbmRvdyB3aGVuIG1vdXNlIGdvZXMgb3V0IG9mIHdpbmRvdyBib3VuZHMg ZG9lcyBub3QgYmVoYXZlIGFzIGV4cGVjdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzUzNzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBDb25zdHJhaW4gbW92ZSBzZWxlY3Rpb24gd2luZG93IGRyYWdn aW5nIHRvIHRoZSBydWxlciBib3VuZHMKKyAgICAgICAgYmFzZWQgb24gdGhlIG1vdXNlIGRvd24g cG9zaXRpb24gb24gdGhlIGRyYWcgd2luZG93LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9W aWV3cy9UaW1lbGluZVJ1bGVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUnVs ZXIucHJvdG90eXBlLl9oYW5kbGVNb3VzZURvd24pOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRp bWVsaW5lUnVsZXIucHJvdG90eXBlLl9oYW5kbGVNb3VzZU1vdmUpOgorICAgICAgICAoV2ViSW5z cGVjdG9yLlRpbWVsaW5lUnVsZXIucHJvdG90eXBlLl9oYW5kbGVNb3VzZVVwKToKKwogMjAxNC0w OC0wNyAgQnJpYW4gSi4gQnVyZyAgPGJ1cmdAY3Mud2FzaGluZ3Rvbi5lZHU+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogRGVidWdnZXJNYW5hZ2VyIHNlbmRzIHNwdXJpb3VzIHNldEJyZWFrcG9p bnRzQWN0aXZlIGNvbW1hbmRzIHdoZW4gc2V0dGluZyBhIGJyZWFrcG9pbnQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUnVsZXIu anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJ1 bGVyLmpzCmluZGV4IDJmYTZkODUuLjlkZGVlOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUnVsZXIuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSdWxlci5qcwpAQCAt NjA0LDExICs2MDQsMTUgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUnVsZXIucHJvdG90eXBlID0g ewogCiAgICAgICAgIHRoaXMuX3NlbGVjdGlvbklzTW92ZSA9IGV2ZW50LnRhcmdldCA9PT0gdGhp cy5fc2VsZWN0aW9uRHJhZ0VsZW1lbnQ7CiAgICAgICAgIHRoaXMuX3N1cHByZXNzVGltZVJhbmdl U2VsZWN0aW9uQ2hhbmdlZEV2ZW50ID0gIXRoaXMuX3NlbGVjdGlvbklzTW92ZTsKKyAgICAgICAg dGhpcy5fcnVsZXJCb3VuZGluZ0NsaWVudFJlY3QgPSB0aGlzLl9lbGVtZW50LmdldEJvdW5kaW5n Q2xpZW50UmVjdCgpOwogCi0gICAgICAgIGlmICh0aGlzLl9zZWxlY3Rpb25Jc01vdmUpCisgICAg ICAgIGlmICh0aGlzLl9zZWxlY3Rpb25Jc01vdmUpIHsKICAgICAgICAgICAgIHRoaXMuX2xhc3RN b3VzZVBvc2l0aW9uID0gZXZlbnQucGFnZVg7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIHRo aXMuX21vdXNlRG93blBvc2l0aW9uID0gZXZlbnQucGFnZVggLSB0aGlzLl9lbGVtZW50LnRvdGFs T2Zmc2V0TGVmdDsKKyAgICAgICAgICAgIHZhciBzZWxlY3Rpb25EcmFnRWxlbWVudFJlY3RzID0g dGhpcy5fc2VsZWN0aW9uRHJhZ0VsZW1lbnQuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCk7CisgICAg ICAgICAgICB0aGlzLl9tb3ZlU2VsZWN0aW9uTWF4aW11bUxlZnRPZmZzZXQgPSB0aGlzLl9ydWxl ckJvdW5kaW5nQ2xpZW50UmVjdC5sZWZ0ICsgKGV2ZW50LnBhZ2VYIC0gc2VsZWN0aW9uRHJhZ0Vs ZW1lbnRSZWN0cy5sZWZ0KTsKKyAgICAgICAgICAgIHRoaXMuX21vdmVTZWxlY3Rpb25NYXhpbXVt UmlnaHRPZmZzZXQgPSB0aGlzLl9ydWxlckJvdW5kaW5nQ2xpZW50UmVjdC5yaWdodCAtIChzZWxl Y3Rpb25EcmFnRWxlbWVudFJlY3RzLnJpZ2h0IC0gZXZlbnQucGFnZVgpOworICAgICAgICB9IGVs c2UKKyAgICAgICAgICAgIHRoaXMuX21vdXNlRG93blBvc2l0aW9uID0gZXZlbnQucGFnZVggLSB0 aGlzLl9ydWxlckJvdW5kaW5nQ2xpZW50UmVjdC5sZWZ0OwogCiAgICAgICAgIHRoaXMuX21vdXNl TW92ZUV2ZW50TGlzdGVuZXIgPSB0aGlzLl9oYW5kbGVNb3VzZU1vdmUuYmluZCh0aGlzKTsKICAg ICAgICAgdGhpcy5fbW91c2VVcEV2ZW50TGlzdGVuZXIgPSB0aGlzLl9oYW5kbGVNb3VzZVVwLmJp bmQodGhpcyk7CkBAIC02MjYsNyArNjMwLDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUnVsZXIu cHJvdG90eXBlID0gewogICAgICAgICBjb25zb2xlLmFzc2VydChldmVudC5idXR0b24gPT09IDAp OwogCiAgICAgICAgIGlmICh0aGlzLl9zZWxlY3Rpb25Jc01vdmUpIHsKLSAgICAgICAgICAgIHZh ciBjdXJyZW50TW91c2VQb3NpdGlvbiA9IGV2ZW50LnBhZ2VYOworICAgICAgICAgICAgdmFyIGN1 cnJlbnRNb3VzZVBvc2l0aW9uID0gTWF0aC5tYXgodGhpcy5fbW92ZVNlbGVjdGlvbk1heGltdW1M ZWZ0T2Zmc2V0LCBNYXRoLm1pbih0aGlzLl9tb3ZlU2VsZWN0aW9uTWF4aW11bVJpZ2h0T2Zmc2V0 LCBldmVudC5wYWdlWCkpOwogCiAgICAgICAgICAgICB2YXIgb2Zmc2V0VGltZSA9IChjdXJyZW50 TW91c2VQb3NpdGlvbiAtIHRoaXMuX2xhc3RNb3VzZVBvc2l0aW9uKSAqIHRoaXMuc2Vjb25kc1Bl clBpeGVsOwogICAgICAgICAgICAgdmFyIHNlbGVjdGlvbkR1cmF0aW9uID0gdGhpcy5zZWxlY3Rp b25FbmRUaW1lIC0gdGhpcy5zZWxlY3Rpb25TdGFydFRpbWU7CkBAIC02MzYsNyArNjQwLDcgQEAg V2ViSW5zcGVjdG9yLlRpbWVsaW5lUnVsZXIucHJvdG90eXBlID0gewogCiAgICAgICAgICAgICB0 aGlzLl9sYXN0TW91c2VQb3NpdGlvbiA9IGN1cnJlbnRNb3VzZVBvc2l0aW9uOwogICAgICAgICB9 IGVsc2UgewotICAgICAgICAgICAgdmFyIGN1cnJlbnRNb3VzZVBvc2l0aW9uID0gZXZlbnQucGFn ZVggLSB0aGlzLl9lbGVtZW50LnRvdGFsT2Zmc2V0TGVmdDsKKyAgICAgICAgICAgIHZhciBjdXJy ZW50TW91c2VQb3NpdGlvbiA9IGV2ZW50LnBhZ2VYIC0gdGhpcy5fcnVsZXJCb3VuZGluZ0NsaWVu dFJlY3QubGVmdDsKIAogICAgICAgICAgICAgdGhpcy5zZWxlY3Rpb25TdGFydFRpbWUgPSBNYXRo Lm1heCh0aGlzLnN0YXJ0VGltZSwgdGhpcy5zdGFydFRpbWUgKyAoTWF0aC5taW4oY3VycmVudE1v dXNlUG9zaXRpb24sIHRoaXMuX21vdXNlRG93blBvc2l0aW9uKSAqIHRoaXMuc2Vjb25kc1BlclBp eGVsKSk7CiAgICAgICAgICAgICB0aGlzLnNlbGVjdGlvbkVuZFRpbWUgPSBNYXRoLm1pbih0aGlz LnN0YXJ0VGltZSArIChNYXRoLm1heChjdXJyZW50TW91c2VQb3NpdGlvbiwgdGhpcy5fbW91c2VE b3duUG9zaXRpb24pICogdGhpcy5zZWNvbmRzUGVyUGl4ZWwpLCB0aGlzLmVuZFRpbWUpOwpAQCAt NjU0LDcgKzY1OCw3IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVJ1bGVyLnByb3RvdHlwZSA9IHsK IAogICAgICAgICBpZiAoIXRoaXMuX3NlbGVjdGlvbklzTW92ZSAmJiB0aGlzLnNlbGVjdGlvbkVu ZFRpbWUgLSB0aGlzLnNlbGVjdGlvblN0YXJ0VGltZSA8IFdlYkluc3BlY3Rvci5UaW1lbGluZVJ1 bGVyLk1pbmltdW1TZWxlY3Rpb25UaW1lUmFuZ2UpIHsKICAgICAgICAgICAgIC8vIFRoZSBzZWN0 aW9uIGlzIHNtYWxsZXIgdGhhbiBhbGxvd2VkLCBncm93IGluIHRoZSBkaXJlY3Rpb24gb2YgdGhl IGRyYWcgdG8gbWVldCB0aGUgbWludW11bS4KLSAgICAgICAgICAgIHZhciBjdXJyZW50TW91c2VQ b3NpdGlvbiA9IGV2ZW50LnBhZ2VYIC0gdGhpcy5fZWxlbWVudC50b3RhbE9mZnNldExlZnQ7Cisg ICAgICAgICAgICB2YXIgY3VycmVudE1vdXNlUG9zaXRpb24gPSBldmVudC5wYWdlWCAtIHRoaXMu X3J1bGVyQm91bmRpbmdDbGllbnRSZWN0LmxlZnQ7CiAgICAgICAgICAgICBpZiAoY3VycmVudE1v dXNlUG9zaXRpb24gPiB0aGlzLl9tb3VzZURvd25Qb3NpdGlvbikgewogICAgICAgICAgICAgICAg IHRoaXMuc2VsZWN0aW9uRW5kVGltZSA9IE1hdGgubWluKHRoaXMuc2VsZWN0aW9uU3RhcnRUaW1l ICsgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUnVsZXIuTWluaW11bVNlbGVjdGlvblRpbWVSYW5nZSwg dGhpcy5lbmRUaW1lKTsKICAgICAgICAgICAgICAgICB0aGlzLnNlbGVjdGlvblN0YXJ0VGltZSA9 IHRoaXMuc2VsZWN0aW9uRW5kVGltZSAtIFdlYkluc3BlY3Rvci5UaW1lbGluZVJ1bGVyLk1pbmlt dW1TZWxlY3Rpb25UaW1lUmFuZ2U7CkBAIC02NzYsNiArNjgwLDkgQEAgV2ViSW5zcGVjdG9yLlRp bWVsaW5lUnVsZXIucHJvdG90eXBlID0gewogICAgICAgICBkZWxldGUgdGhpcy5fbW91c2VEb3du UG9zaXRpb247CiAgICAgICAgIGRlbGV0ZSB0aGlzLl9sYXN0TW91c2VQb3NpdGlvbjsKICAgICAg ICAgZGVsZXRlIHRoaXMuX3NlbGVjdGlvbklzTW92ZTsKKyAgICAgICAgZGVsZXRlIHRoaXMuX3J1 bGVyQm91bmRpbmdDbGllbnRSZWN0OworICAgICAgICBkZWxldGUgdGhpcy5fbW92ZVNlbGVjdGlv bk1heGltdW1MZWZ0T2Zmc2V0OworICAgICAgICBkZWxldGUgdGhpcy5fbW92ZVNlbGVjdGlvbk1h eGltdW1SaWdodE9mZnNldDsKIAogICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOwogICAg ICAgICBldmVudC5zdG9wUHJvcGFnYXRpb24oKTsK