135368 2014-07-28 16:32:10 -0700 [iOS WK2] WKWebView sometime tries to change the size of a null DrawingAreaProxy 2014-07-28 16:47:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue oldest_to_newest 1025304 0 benjamin 2014-07-28 16:32:10 -0700 [iOS WK2] WKWebView sometime tries to change the size of a null DrawingAreaProxy 1025305 1 235639 benjamin 2014-07-28 16:35:19 -0700 Created attachment 235639 Patch 1025306 2 commit-queue 2014-07-28 16:37:43 -0700 Attachment 235639 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2241: The parameter name "drawingArea" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1025308 3 235639 simon.fraser 2014-07-28 16:43:18 -0700 Comment on attachment 235639 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235639&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1354 > + if (WebKit::DrawingAreaProxy* drawingArea = _page->drawingArea()) Aren't we in the WebKit namespace here? > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2241 > + if (WebKit::DrawingAreaProxy* drawingArea = _page->drawingArea()) Ditto. 1025311 4 235639 benjamin 2014-07-28 16:47:30 -0700 Comment on attachment 235639 Patch Clearing flags on attachment: 235639 Committed r171709: <http://trac.webkit.org/changeset/171709> 1025312 5 benjamin 2014-07-28 16:47:32 -0700 All reviewed patches have been landed. Closing bug. 235639 2014-07-28 16:35:19 -0700 2014-07-28 16:47:30 -0700 Patch bug-135368-20140728163407.patch text/plain 3081 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxNzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODY4YjEwZjc0MmE0ODcz Y2M0YTE0ZWFhZmZlZDc4MjA0MTEyYmM5MC4uMTg0ZDQ1Yzg0MGI4NDFiZjlmZTY2MTRlNTUzZjQ1 ZDhmZDg4MmE5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE0LTA3LTI4ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgV0syXSBX S1dlYlZpZXcgc29tZXRpbWUgdHJpZXMgdG8gY2hhbmdlIHRoZSBzaXplIG9mIGEgbnVsbCBEcmF3 aW5nQXJlYVByb3h5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzUzNjgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2OTg4ODg3PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZCBuZXZlciBh c3N1bWUgRHJhd2luZ0FyZWFQcm94eSBleGlzdHMgaW4gdGhlIEFQSSBpbnZva2VkIGJ5IHRoZSBj bGllbnRzCisgICAgICAgIG9mIFdLV2ViVmlldy4gVGhlcmUgYXJlIGF0IGxlYXN0IHR3byBjYXNl cyB3aGVyZSB0aGUgRHJhd2luZ0FyZWFQcm94eSBpcyBudWxsOgorICAgICAgICAtSW4gc29tZSBw YXRoIG9uIGluaXRpYWxpemF0aW9uLgorICAgICAgICAtQWZ0ZXIgYSBjcmFzaC4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgorICAgICAgICAoLVtXS1dlYlZp ZXcgX2ZyYW1lT3JCb3VuZHNDaGFuZ2VkXSk6CisgICAgICAgICgtW1dLV2ViVmlldyBfYmVnaW5B bmltYXRlZFJlc2l6ZVdpdGhVcGRhdGVzOl0pOgorICAgICAgICBXZSBjYW4gc2FmZWx5IG51bGwg Y2hlY2sgYW5kIHNraXAgc2V0dGluZyB0aGUgc2l6ZS4gSWYgdGhlIGNhbGwgd2FzIHNraXBwZWQs CisgICAgICAgIHRoZSBzaXplIGlzIHNldCBvbiBEcmF3aW5nQXJlYVByb3h5IGluaXRpYWxpemF0 aW9uIGJ5IHF1ZXJ5aW5nIHRoZSBjdXJyZW50CisgICAgICAgIHNpemUgdGhyb3VnaCB0aGUgcGFn ZSBjbGllbnQuCisKIDIwMTQtMDctMjggIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxlLmNv bT4KIAogICAgICAgICBEaXNhYmxlIHRhZ2dlZCBzdHJpbmdzIGZvciB0aGUgcGx1Z2luIHByb2Nl c3MuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vi Vmlldy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1t CmluZGV4IGYwY2I5NmJjNzJmYjcxZjM2OTZiODQwMDAxM2FlOGE1NTBhZmYzOGEuLmJkMDE5Nzc2 MDcyNjM2Y2YzOTc2NmEzZmNhMTA2N2NiNmViMWI1N2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCkBAIC0xMzUxLDcgKzEzNTEsOCBAQCBz dGF0aWMgV2ViQ29yZTo6RmxvYXRQb2ludCBjb25zdHJhaW5Db250ZW50T2Zmc2V0KFdlYkNvcmU6 OkZsb2F0UG9pbnQgY29udGVudE9mZgogICAgICAgICAgICAgX3BhZ2UtPnNldFZpZXdwb3J0Q29u ZmlndXJhdGlvbk1pbmltdW1MYXlvdXRTaXplRm9yTWluaW1hbFVJKFdlYkNvcmU6OkZsb2F0U2l6 ZShib3VuZHMuc2l6ZSkpOwogICAgICAgICBpZiAoIV9vdmVycmlkZXNNYXhpbXVtVW5vYnNjdXJl ZFNpemUpCiAgICAgICAgICAgICBfcGFnZS0+c2V0TWF4aW11bVVub2JzY3VyZWRTaXplKFdlYkNv cmU6OkZsb2F0U2l6ZShib3VuZHMuc2l6ZSkpOwotICAgICAgICBfcGFnZS0+ZHJhd2luZ0FyZWEo KS0+c2V0U2l6ZShXZWJDb3JlOjpJbnRTaXplKGJvdW5kcy5zaXplKSwgV2ViQ29yZTo6SW50U2l6 ZSgpLCBXZWJDb3JlOjpJbnRTaXplKCkpOworICAgICAgICBpZiAoV2ViS2l0OjpEcmF3aW5nQXJl YVByb3h5KiBkcmF3aW5nQXJlYSA9IF9wYWdlLT5kcmF3aW5nQXJlYSgpKQorICAgICAgICAgICAg ZHJhd2luZ0FyZWEtPnNldFNpemUoV2ViQ29yZTo6SW50U2l6ZShib3VuZHMuc2l6ZSksIFdlYkNv cmU6OkludFNpemUoKSwgV2ViQ29yZTo6SW50U2l6ZSgpKTsKICAgICB9CiAKICAgICBbX2N1c3Rv bUNvbnRlbnRWaWV3IHdlYl9zZXRNaW5pbXVtU2l6ZTpib3VuZHMuc2l6ZV07CkBAIC0yMjM3LDcg KzIyMzgsOCBAQCBzdGF0aWMgaW5saW5lIFdlYktpdDo6RmluZE9wdGlvbnMgdG9GaW5kT3B0aW9u cyhfV0tGaW5kT3B0aW9ucyB3a0ZpbmRPcHRpb25zKQogICAgIENHUmVjdCB1bm9ic2N1cmVkUmVj dEluQ29udGVudENvb3JkaW5hdGVzID0gW3NlbGYgY29udmVydFJlY3Q6ZnV0dXJlVW5vYnNjdXJl ZFJlY3RJblNlbGZDb29yZGluYXRlcyB0b1ZpZXc6X2NvbnRlbnRWaWV3LmdldCgpXTsKIAogICAg IF9wYWdlLT5keW5hbWljVmlld3BvcnRTaXplVXBkYXRlKG5ld01pbmltdW1MYXlvdXRTaXplLCBu ZXdNaW5pbXVtTGF5b3V0U2l6ZUZvck1pbmltYWxVSSwgbmV3TWF4aW11bVVub2JzY3VyZWRTaXpl LCB2aXNpYmxlUmVjdEluQ29udGVudENvb3JkaW5hdGVzLCB1bm9ic2N1cmVkUmVjdEluQ29udGVu dENvb3JkaW5hdGVzLCBmdXR1cmVVbm9ic2N1cmVkUmVjdEluU2VsZkNvb3JkaW5hdGVzLCB0YXJn ZXRTY2FsZSwgbmV3T3JpZW50YXRpb24pOwotICAgIF9wYWdlLT5kcmF3aW5nQXJlYSgpLT5zZXRT aXplKFdlYkNvcmU6OkludFNpemUobmV3Qm91bmRzLnNpemUpLCBXZWJDb3JlOjpJbnRTaXplKCks IFdlYkNvcmU6OkludFNpemUoKSk7CisgICAgaWYgKFdlYktpdDo6RHJhd2luZ0FyZWFQcm94eSog ZHJhd2luZ0FyZWEgPSBfcGFnZS0+ZHJhd2luZ0FyZWEoKSkKKyAgICAgICAgZHJhd2luZ0FyZWEt PnNldFNpemUoV2ViQ29yZTo6SW50U2l6ZShuZXdCb3VuZHMuc2l6ZSksIFdlYkNvcmU6OkludFNp emUoKSwgV2ViQ29yZTo6SW50U2l6ZSgpKTsKIH0KIAogLSAodm9pZClfZW5kQW5pbWF0ZWRSZXNp emUK