135364 2014-07-28 16:10:15 -0700 Web Inspector: Disable Copy Row in Timelines DataGrids, it does not currently provide value 2014-07-28 16:53:03 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1025282 0 joepeck 2014-07-28 16:10:15 -0700 * SUMMARY In Timelines datagrids, Copy Row doesn't produce meaningful values yet. Disable it. 1025283 1 webkit-bug-importer 2014-07-28 16:11:10 -0700 <rdar://problem/17835883> 1025286 2 235631 joepeck 2014-07-28 16:11:49 -0700 Created attachment 235631 [PATCH] Proposed Fix 1025294 3 timothy 2014-07-28 16:20:02 -0700 I am surprised the data isn't there though. Maybe because we format most of the values from objects like ScriptLocation? 1025295 4 joepeck 2014-07-28 16:20:57 -0700 Yeah, it provides just like a timestamp, which is not very useful. 1025316 5 235631 commit-queue 2014-07-28 16:53:00 -0700 Comment on attachment 235631 [PATCH] Proposed Fix Clearing flags on attachment: 235631 Committed r171710: <http://trac.webkit.org/changeset/171710> 1025317 6 commit-queue 2014-07-28 16:53:03 -0700 All reviewed patches have been landed. Closing bug. 235631 2014-07-28 16:11:49 -0700 2014-07-28 16:53:00 -0700 [PATCH] Proposed Fix copyable.patch text/plain 3062 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDA0NzA0YjguLjIzNmRlZmYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA3LTI4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRGlzYWJs ZSBDb3B5IFJvdyBpbiBUaW1lbGluZXMgRGF0YUdyaWRzLCBpdCBkb2VzIG5vdCBjdXJyZW50bHkg cHJvdmlkZSB2YWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTM1MzY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLkRhdGFHcmlkTm9kZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGF0YUdyaWROb2Rl LnByb3RvdHlwZS5nZXQgY29weWFibGUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRhdGFHcmlk Tm9kZS5wcm90b3R5cGUuc2V0IGNvcHlhYmxlKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Zp ZXdzL1RpbWVsaW5lRGF0YUdyaWROb2RlLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVs aW5lRGF0YUdyaWROb2RlKToKKwogMjAxNC0wNy0yNiAgQnJpYW4gSi4gQnVyZyAgPGJ1cmdAY3Mu d2FzaGluZ3Rvbi5lZHU+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUmVwbGF5TWFuYWdlciB1 c2VzIHVuZGVmaW5lZCBldmVudHMgYW5kIGluY29uc2lzdGVudCBldmVudCBkYXRhCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpz CmluZGV4IGU2MzNkMWUuLmRmMzNkODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzCkBAIC0xMTI5LDcgKzExMjksNyBA QCBXZWJJbnNwZWN0b3IuRGF0YUdyaWQucHJvdG90eXBlID0gewogICAgICAgICBpZiAodGhpcy5k YXRhR3JpZC5fcmVmcmVzaENhbGxiYWNrICYmICghZ3JpZE5vZGUgfHwgZ3JpZE5vZGUgIT09IHRo aXMucGxhY2Vob2xkZXJOb2RlKSkKICAgICAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0o V2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJSZWZyZXNoIiksIHRoaXMuX3JlZnJlc2hDYWxsYmFjay5i aW5kKHRoaXMpKTsKIAotICAgICAgICBpZiAoZ3JpZE5vZGUgJiYgZ3JpZE5vZGUuc2VsZWN0YWJs ZSAmJiAhZ3JpZE5vZGUuaXNFdmVudFdpdGhpbkRpc2Nsb3N1cmVUcmlhbmdsZShldmVudCkpIHsK KyAgICAgICAgaWYgKGdyaWROb2RlICYmIGdyaWROb2RlLnNlbGVjdGFibGUgJiYgZ3JpZE5vZGUu Y29weWFibGUgJiYgIWdyaWROb2RlLmlzRXZlbnRXaXRoaW5EaXNjbG9zdXJlVHJpYW5nbGUoZXZl bnQpKSB7CiAgICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdlYkluc3BlY3Rvci5V SVN0cmluZygiQ29weSBSb3ciKSwgdGhpcy5fY29weVJvdy5iaW5kKHRoaXMsIGV2ZW50LnRhcmdl dCkpOwogCiAgICAgICAgICAgICBpZiAodGhpcy5kYXRhR3JpZC5fZWRpdENhbGxiYWNrKSB7CkBA IC0xMzEyLDYgKzEzMTIsNyBAQCBXZWJJbnNwZWN0b3IuRGF0YUdyaWROb2RlID0gZnVuY3Rpb24o ZGF0YSwgaGFzQ2hpbGRyZW4pCiB7CiAgICAgdGhpcy5fZXhwYW5kZWQgPSBmYWxzZTsKICAgICB0 aGlzLl9zZWxlY3RlZCA9IGZhbHNlOworICAgIHRoaXMuX2NvcHlhYmxlID0gdHJ1ZTsKICAgICB0 aGlzLl9zaG91bGRSZWZyZXNoQ2hpbGRyZW4gPSB0cnVlOwogICAgIHRoaXMuX2RhdGEgPSBkYXRh IHx8IHt9OwogICAgIHRoaXMuaGFzQ2hpbGRyZW4gPSBoYXNDaGlsZHJlbiB8fCBmYWxzZTsKQEAg LTEzMjksNiArMTMzMCwxNiBAQCBXZWJJbnNwZWN0b3IuRGF0YUdyaWROb2RlLnByb3RvdHlwZSA9 IHsKICAgICAgICAgcmV0dXJuICF0aGlzLl9lbGVtZW50IHx8ICF0aGlzLl9lbGVtZW50LmNsYXNz TGlzdC5jb250YWlucygiaGlkZGVuIik7CiAgICAgfSwKIAorICAgIGdldCBjb3B5YWJsZSgpCisg ICAgeworICAgICAgICByZXR1cm4gdGhpcy5fY29weWFibGU7CisgICAgfSwKKworICAgIHNldCBj b3B5YWJsZSh4KQorICAgIHsKKyAgICAgICAgdGhpcy5fY29weWFibGUgPSB4OworICAgIH0sCisK ICAgICBnZXQgZWxlbWVudCgpCiAgICAgewogICAgICAgICBpZiAodGhpcy5fZWxlbWVudCkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVs aW5lRGF0YUdyaWROb2RlLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvVGltZWxpbmVEYXRhR3JpZE5vZGUuanMKaW5kZXggNzQ3OGI4MC4uOGI5NDgzMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxp bmVEYXRhR3JpZE5vZGUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvVGltZWxpbmVEYXRhR3JpZE5vZGUuanMKQEAgLTI3LDYgKzI3LDggQEAgV2ViSW5z cGVjdG9yLlRpbWVsaW5lRGF0YUdyaWROb2RlID0gZnVuY3Rpb24oZ3JhcGhPbmx5LCBncmFwaERh dGFTb3VyY2UsIGhhc0NoaWwKIHsKICAgICBXZWJJbnNwZWN0b3IuRGF0YUdyaWROb2RlLmNhbGwo dGhpcywge30sIGhhc0NoaWxkcmVuKTsKIAorICAgIHRoaXMuY29weWFibGUgPSBmYWxzZTsKKwog ICAgIHRoaXMuX2dyYXBoT25seSA9IGdyYXBoT25seSB8fCBmYWxzZTsKICAgICB0aGlzLl9ncmFw aERhdGFTb3VyY2UgPSBncmFwaERhdGFTb3VyY2UgfHwgbnVsbDsKIAo=