135357 2014-07-28 15:00:47 -0700 Text-shadow with (0, 0) offset and radius = 0 is ugly 2014-09-07 12:47:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield commit-queue dino esprehn+autocc glenn jonlee kondapallykalyan mark.lam mitz simon.fraser thorton webkit-bug-importer oldest_to_newest 1025244 0 mmaxfield 2014-07-28 15:00:47 -0700 Text-shadow with (0, 0) offset and radius = 0 is ugly 1025247 1 235620 mmaxfield 2014-07-28 15:04:10 -0700 Created attachment 235620 Patch 1025248 2 mmaxfield 2014-07-28 15:04:36 -0700 <rdar://problem/15000806> 1027003 3 235620 darin 2014-08-05 16:58:04 -0700 Comment on attachment 235620 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235620&action=review > Source/WebCore/rendering/TextPainter.cpp:68 > + const auto& shadow = *shadowPtr; > + return shadow.location() == IntPoint() && !shadow.radius(); Seems a little strange to have this local variable just so we can use "." in two places instead of "->". > Source/WebCore/rendering/TextPainter.cpp:84 > + if (shadow && !shadowIsEmpty) No need to null check shadow here since isEmptyShadow already null checks it. 1027196 4 mmaxfield 2014-08-06 10:36:39 -0700 http://trac.webkit.org/changeset/172153 1027209 5 mark.lam 2014-08-06 10:46:56 -0700 This caused a build failure: http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20%28Build%29/builds/9771/steps/compile-webkit/logs/stdio 1027491 6 mark.lam 2014-08-07 08:38:42 -0700 (In reply to comment #5) > This caused a build failure: > http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20%28Build%29/builds/9771/steps/compile-webkit/logs/stdio Fixed in http://trac.webkit.org/changeset/172156. 1033750 7 mitz 2014-09-07 12:47:24 -0700 (In reply to comment #4) > http://trac.webkit.org/changeset/172153 This caused bug 136612. 235620 2014-07-28 15:04:10 -0700 2014-08-05 16:58:04 -0700 Patch bug-135357-20140728150356.patch text/plain 4527 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxNjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODM0M2M1M2E5YTUxYWNk MWYyMjg5MjRmYjRhMzM1NjBiYmFkZTAwNy4uYWFmOTY1ZmQ0Yjc2ZGViYTJjNmFmOTA5YjNmOWYz MTZiODllZDg3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA3LTI4ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgVGV4dC1zaGFk b3cgd2l0aCAoMCwgMCkgb2Zmc2V0IGFuZCByYWRpdXMgPSAwIGlzIHVnbHkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTM1NworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluc3RlYWQsIGNoZWNrIGZvciB0 aGlzIGtpbmQgb2Ygc2hhZG93IGFuZCBkb24ndCBkcmF3IGl0LgorCisgICAgICAgIFRlc3Q6IGZh c3QvdGV4dC9lbXB0eS1zaGFkb3cuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1RleHRQYWlu dGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmlzRW1wdHlTaGFkb3cpOiBEb2VzIGEgc2hhZG93 IG1hdGNoIHRoZXNlIGNyaXRlcmlhPworICAgICAgICAoV2ViQ29yZTo6cGFpbnRUZXh0V2l0aFNo YWRvd3MpOiBJZiBzbywgZG9uJ3QgZHJhdyBpdC4KKwogMjAxNC0wNy0yOCAgQnJlbnQgRnVsZ2hh bSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkICdtZXJnZScgZml4 LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHRQYWludGVyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0UGFpbnRlci5jcHAKaW5kZXggYWYzNDI1N2Fl MGEzMWVmZmY5YzkxZTA3ZmNjMzE5MDc2OWViNjE5Mi4uYjQ1NTg3MWY2YWU2ZTQ2YzNkZjlkODkw YjVlMzU4MjIwYWQzN2FmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Rl eHRQYWludGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvVGV4dFBhaW50ZXIu Y3BwCkBAIC02MCw2ICs2MCwxNCBAQCBzdGF0aWMgdm9pZCBkcmF3VGV4dE9yRW1waGFzaXNNYXJr cyhHcmFwaGljc0NvbnRleHQmIGNvbnRleHQsIGNvbnN0IEZvbnQmIGZvbnQsCiAgICAgICAgIGNv bnRleHQuZHJhd0VtcGhhc2lzTWFya3MoZm9udCwgdGV4dFJ1biwgZW1waGFzaXNNYXJrLCBwb2lu dCArIEludFNpemUoMCwgZW1waGFzaXNNYXJrT2Zmc2V0KSwgZnJvbSwgdG8pOwogfQogCitzdGF0 aWMgYm9vbCBpc0VtcHR5U2hhZG93KGNvbnN0IFNoYWRvd0RhdGEqIHNoYWRvd1B0cikKK3sKKyAg ICBpZiAoIXNoYWRvd1B0cikKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgY29uc3QgYXV0byYg c2hhZG93ID0gKnNoYWRvd1B0cjsKKyAgICByZXR1cm4gc2hhZG93LmxvY2F0aW9uKCkgPT0gSW50 UG9pbnQoKSAmJiAhc2hhZG93LnJhZGl1cygpOworfQorCiBzdGF0aWMgdm9pZCBwYWludFRleHRX aXRoU2hhZG93cyhHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IEZvbnQmIGZvbnQsIGNv bnN0IFRleHRSdW4mIHRleHRSdW4sIGNvbnN0IEF0b21pY1N0cmluZyYgZW1waGFzaXNNYXJrLAog ICAgIGludCBlbXBoYXNpc01hcmtPZmZzZXQsIGludCBzdGFydE9mZnNldCwgaW50IGVuZE9mZnNl dCwgaW50IHRydW5jYXRpb25Qb2ludCwgY29uc3QgRmxvYXRQb2ludCYgdGV4dE9yaWdpbiwgY29u c3QgRmxvYXRSZWN0JiBib3hSZWN0LAogICAgIGNvbnN0IFNoYWRvd0RhdGEqIHNoYWRvdywgYm9v bCBzdHJva2VkLCBib29sIGhvcml6b250YWwpCkBAIC03Miw3ICs4MCw4IEBAIHN0YXRpYyB2b2lk IHBhaW50VGV4dFdpdGhTaGFkb3dzKEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgRm9u dCYgZm9udCwgY29uCiAKICAgICBkbyB7CiAgICAgICAgIEludFNpemUgZXh0cmFPZmZzZXQ7Ci0g ICAgICAgIGlmIChzaGFkb3cpCisgICAgICAgIGJvb2wgc2hhZG93SXNFbXB0eSA9IGlzRW1wdHlT aGFkb3coc2hhZG93KTsKKyAgICAgICAgaWYgKHNoYWRvdyAmJiAhc2hhZG93SXNFbXB0eSkKICAg ICAgICAgICAgIGV4dHJhT2Zmc2V0ID0gcm91bmRlZEludFNpemUoSW5saW5lVGV4dEJveDo6YXBw bHlTaGFkb3dUb0dyYXBoaWNzQ29udGV4dChjb250ZXh0LCBzaGFkb3csIGJveFJlY3QsIHN0cm9r ZWQsIG9wYXF1ZSwgaG9yaXpvbnRhbCkpOwogICAgICAgICBlbHNlIGlmICghb3BhcXVlKQogICAg ICAgICAgICAgY29udGV4dC0+c2V0RmlsbENvbG9yKGZpbGxDb2xvciwgZmlsbENvbG9yU3BhY2Up OwpAQCAtOTEsNyArMTAwLDcgQEAgc3RhdGljIHZvaWQgcGFpbnRUZXh0V2l0aFNoYWRvd3MoR3Jh cGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBGb250JiBmb250LCBjb24KIAogICAgICAgICBp ZiAoc2hhZG93LT5uZXh0KCkgfHwgc3Ryb2tlZCB8fCAhb3BhcXVlKQogICAgICAgICAgICAgY29u dGV4dC0+cmVzdG9yZSgpOwotICAgICAgICBlbHNlCisgICAgICAgIGVsc2UgaWYgKCFzaGFkb3dJ c0VtcHR5KQogICAgICAgICAgICAgY29udGV4dC0+Y2xlYXJTaGFkb3coKTsKIAogICAgICAgICBz aGFkb3cgPSBzaGFkb3ctPm5leHQoKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmNTljOGNkOWE2ZGZmMzc4NWViZDhjZTZk YTYzNTc3MjAwYmZhZDE4Li5jM2RjYmNmZThjODFmNjAwOGVkMmJiNjVkYmIwMjA5ZDc3MDk4NzVm IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDctMjggIE15bGVzIEMuIE1heGZpZWxkICA8 bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAgICAgICBUZXh0LXNoYWRvdyB3aXRoICgwLCAwKSBv ZmZzZXQgYW5kIHJhZGl1cyA9IDAgaXMgdWdseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1MzU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ2hlY2sgdGhhdCB0aGlzIGtpbmQgb2Ygc2hhZG93IGVuZHMg dXAgaW52aXNpYmxlLgorCisgICAgICAgICogZmFzdC90ZXh0L2VtcHR5LXNoYWRvdy1leHBlY3Rl ZC5odG1sOiBBZGRlZAorICAgICAgICAqIGZhc3QvdGV4dC9lbXB0eS1zaGFkb3cuaHRtbDogQWRk ZWQKKwogMjAxNC0wNy0yOCAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9yZz4KIAog ICAgICAgICBbQ1NTMy1UZXh0XSBVcGRhdGUgdGV4dC1leHBlY3RhdGlvbnMgYWZ0ZXIgcjE3MTY3 NwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2VtcHR5LXNoYWRvdy1leHBlY3Rl ZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2VtcHR5LXNoYWRvdy1leHBlY3RlZC5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLmNlMmI5NmIwYmQwMmY5Y2ZjOGRmYzY5OTc3MTYzYzk1MmY2NjM2YTgKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQvZW1wdHktc2hhZG93LWV4cGVj dGVkLmh0bWwKQEAgLTAsMCArMSwzIEBACitUaGlzIHRlc3RzIHRoYXQgdGV4dCBkcmF3biB3aXRo IHRleHQtc2hhZG93cyBvZiByYWRpdXMgMCBhbmQgKDAsIDApIG9mZnNldCBhcmUgbm90IGRyYXdu LgorVGhpcyBpcyBhIGJldHRlciBvdXRjb21lIHRoYW4gdGhlbSBiZWluZyBkcmF3biBpbiBhbiB1 Z2x5IHdheS4KK1RoaXMgdGVzdCBpcyBzdWNjZXNzZnVsIGlmIHRoZSB0ZXh0IGJlbG93IGlzIGNv bXBsZXRlbHkgaW52aXNpYmxlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2Vt cHR5LXNoYWRvdy5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2VtcHR5LXNoYWRvdy5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjQyN2NkZDhjNjNjOWExODJhNWMwZGYxYWQyOGQzMWQ0NGIyNGEzY2YKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQvZW1wdHktc2hhZG93Lmh0bWwK QEAgLTAsMCArMSw0IEBACitUaGlzIHRlc3RzIHRoYXQgdGV4dCBkcmF3biB3aXRoIHRleHQtc2hh ZG93cyBvZiByYWRpdXMgMCBhbmQgKDAsIDApIG9mZnNldCBhcmUgbm90IGRyYXduLgorVGhpcyBp cyBhIGJldHRlciBvdXRjb21lIHRoYW4gdGhlbSBiZWluZyBkcmF3biBpbiBhbiB1Z2x5IHdheS4K K1RoaXMgdGVzdCBpcyBzdWNjZXNzZnVsIGlmIHRoZSB0ZXh0IGJlbG93IGlzIGNvbXBsZXRlbHkg aW52aXNpYmxlLgorPGRpdiBzdHlsZT0iY29sb3I6I2ZmZjt0ZXh0LXNoYWRvdzowIDAgIzAwMCI+ VGhpcyBpcyBzb21lIHRleHQ8L2Rpdj4K