135356 2014-07-28 14:54:54 -0700 <embed> videos flashes constantly while playing inline on iPad, making it unwatchable 2014-07-28 15:18:47 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned commit-queue esprehn+autocc gyuyoung.kim kling simon.fraser oldest_to_newest 1025240 0 koivisto 2014-07-28 14:54:54 -0700 For example http://www.sambushell.com/morepower/ We are repeatedly reconstructing the render tree. 1025245 1 235619 koivisto 2014-07-28 15:02:34 -0700 Created attachment 235619 patch 1025246 2 koivisto 2014-07-28 15:03:29 -0700 <rdar://problem/16828238> 1025249 3 235619 simon.fraser 2014-07-28 15:07:33 -0700 Comment on attachment 235619 patch View in context: https://bugs.webkit.org/attachment.cgi?id=235619&action=review > Source/WebCore/html/HTMLPlugInImageElement.cpp:231 > // FIXME: There shoudn't be need to force render tree reconstruction here. I would prefer a blank line before the comment. 1025255 4 koivisto 2014-07-28 15:18:47 -0700 http://trac.webkit.org/changeset/171702 235619 2014-07-28 15:02:34 -0700 2014-07-28 15:07:33 -0700 patch plugin-controls-reconstruct.patch text/plain 2280 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTY5OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE0LTA3LTI4ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICA8ZW1iZWQ+IHZpZGVvcyBmbGFz aGVzIGNvbnN0YW50bHkgd2hpbGUgcGxheWluZyBpbmxpbmUgb24gaVBhZCwgbWFraW5nIGl0IHVu d2F0Y2hhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzUzNTYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE2ODI4MjM4PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVGhlIHNoYWRvdyB0 cmVlIGZvciBtZWRpYSBjb250cm9scyBpcyBzY2hlZHVsaW5nIHN0eWxlIHJlY2FsYy4gVGhlIGdl bmVyYWwgc2lsbGluZXNzIG9mCisgICAgICAgIEhUTUxQbHVnSW5JbWFnZUVsZW1lbnQ6OndpbGxS ZWNhbGNTdHlsZS93aWxsRGV0YWNoUmVuZGVyZXJzIGlzIHR1cm5pbmcgdGhvc2UgaW50byByZW5k ZXIKKyAgICAgICAgdHJlZSByZWNvbnN0cnVjdGlvbnMgY2F1c2luZyBmbGlja2VyLgorCisgICAg ICAgICogaHRtbC9IVE1MUGx1Z0luSW1hZ2VFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkhUTUxQbHVnSW5JbWFnZUVsZW1lbnQ6OndpbGxSZWNhbGNTdHlsZSk6CisgICAgICAgIAorICAg ICAgICAgICAgRG9uJ3QgZG8gdGhlIGZvcmNlZCByZW5kZXJlciByZWNvbnN0cnVjdGlvbiBpZiB0 aGVyZSBpcyBubyBzdHlsZSBjaGFuZ2UgZm9yIHRoZSBlbGVtZW50CisgICAgICAgICAgICBvciBp dHMgYW5jZXN0b3JzLiBUaGlzIHdheSByZWNhbGNzIHNjaGVkdWxlZCBieSB0aGUgc2hhZG93IHRy ZWUgZG9uJ3QgdHJpZ2dlciB0aGUgd2lkZ2V0CisgICAgICAgICAgICB1cGRhdGUgY29kZSBwYXRo LgorCiAyMDE0LTA3LTI4ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAg ICAgICBSRUdSRVNTSU9OIChyMTYwODA2KTogQ1NTIHpvb20gcHJvcGVydHkgZG9lc24ndCB3b3Jr IG9uIGFueXRoaW5nIGluc2lkZSBhbmNob3JzLgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MUGx1Z0luSW1hZ2VFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwCShyZXZpc2lvbiAxNzE2OTQpCisrKyBTb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yMjMsOCArMjIzLDExIEBAIFJlbmRlclB0cjxSZW5kZXJFbGVtZW50PiBIVE1MUGx1Z0lu SW1hZ2UKICAgICByZXR1cm4gSFRNTFBsdWdJbkVsZW1lbnQ6OmNyZWF0ZUVsZW1lbnRSZW5kZXJl cihXVEY6Om1vdmUoc3R5bGUpKTsKIH0KIAotYm9vbCBIVE1MUGx1Z0luSW1hZ2VFbGVtZW50Ojp3 aWxsUmVjYWxjU3R5bGUoU3R5bGU6OkNoYW5nZSkKK2Jvb2wgSFRNTFBsdWdJbkltYWdlRWxlbWVu dDo6d2lsbFJlY2FsY1N0eWxlKFN0eWxlOjpDaGFuZ2UgY2hhbmdlKQogeworICAgIC8vIE1ha2Ug c3VyZSBzdHlsZSByZWNhbGNzIHNjaGVkdWxlZCBieSB0aGUgY2hpbGQgc2hhZG93IHRyZWUgZG9l c24ndCB0cmlnZ2VyIHJlY29uc3RydWN0aW9uIGFuZCBjYXVzZSBmbGlja2VyLgorICAgIGlmIChj aGFuZ2UgPT0gU3R5bGU6Ok5vQ2hhbmdlICYmIHN0eWxlQ2hhbmdlVHlwZSgpID09IE5vU3R5bGVD aGFuZ2UpCisgICAgICAgIHJldHVybiB0cnVlOwogICAgIC8vIEZJWE1FOiBUaGVyZSBzaG91ZG4n dCBiZSBuZWVkIHRvIGZvcmNlIHJlbmRlciB0cmVlIHJlY29uc3RydWN0aW9uIGhlcmUuCiAgICAg Ly8gSXQgaXMgb25seSBkb25lIGJlY2F1c2UgbG9hZGluZyBhbmQgbG9hZCBldmVudCBkaXNwYXRj aGluZyBpcyB0aWVkIHRvIHJlbmRlciB0cmVlIGNvbnN0cnVjdGlvbi4KICAgICBpZiAoIXVzZUZh bGxiYWNrQ29udGVudCgpICYmIG5lZWRzV2lkZ2V0VXBkYXRlKCkgJiYgcmVuZGVyZXIoKSAmJiAh aXNJbWFnZVR5cGUoKSAmJiAoZGlzcGxheVN0YXRlKCkgIT0gRGlzcGxheWluZ1NuYXBzaG90KSkK