135354 2014-07-28 14:20:03 -0700 Disable tagged strings for the plugin process 2014-07-28 15:33:34 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 roger_fong webkit-unassigned andersca ap barraclough jonlee mrowe roger_fong oldest_to_newest 1025233 0 roger_fong 2014-07-28 14:20:03 -0700 Disable tagged strings within the plugin process as they cause problems for various plugins. <rdar://problem/17295639> 1025242 1 235618 roger_fong 2014-07-28 14:58:14 -0700 Created attachment 235618 patch 1025259 2 235622 roger_fong 2014-07-28 15:22:54 -0700 Created attachment 235622 patch moved setenv call to call site 1025260 3 roger_fong 2014-07-28 15:23:26 -0700 (In reply to comment #2) > Created an attachment (id=235622) [details] > patch > > moved setenv call to call site of addDYLDEnvironmentAdditions 1025261 4 235623 roger_fong 2014-07-28 15:26:44 -0700 Created attachment 235623 patch 1025265 5 roger_fong 2014-07-28 15:33:34 -0700 Landed: http://trac.webkit.org/changeset/171706 235618 2014-07-28 14:58:14 -0700 2014-07-28 15:22:54 -0700 patch patch.patch text/plain 2286 roger_fong SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTY5NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA3LTI4ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgRGlzYWJsZSB0YWdnZWQgc3Ry aW5ncyBmb3IgdGhlIHBsdWdpbiBwcm9jZXNzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1MzU0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNzI5 NTYzOT4uCisKKyAgICAgICAgUGF0Y2ggYnkgQWxleGV5IFByb3NrdXJ5YWtvdiBhbmQgUm9nZXIg Rm9uZy4KKyAgICAgICAgCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogUGx1Z2luUHJvY2Vzcy9FbnRyeVBvaW50L21hYy9YUENTZXJ2aWNlL1BsdWdpblNl cnZpY2UuMzItNjQuSW5mby5wbGlzdDoKKyAgICAgICAgKiBVSVByb2Nlc3MvTGF1bmNoZXIvbWFj L1Byb2Nlc3NMYXVuY2hlck1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6YWRkRFlMREVudmlyb25t ZW50QWRkaXRpb25zKToKKwogMjAxNC0wNy0yNyAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVh QGdtYWlsLmNvbT4KIAogICAgICAgICBbR1RLXSBLZWVwIG5vbi1EQVRBQkFTRV9QUk9DRVNTIGJ1 aWxkCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL0VudHJ5UG9pbnQvbWFjL1hQ Q1NlcnZpY2UvUGx1Z2luU2VydmljZS4zMi02NC5JbmZvLnBsaXN0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvRW50cnlQb2ludC9tYWMvWFBDU2VydmljZS9QbHVn aW5TZXJ2aWNlLjMyLTY0LkluZm8ucGxpc3QJKHJldmlzaW9uIDE3MTMxNikKKysrIFNvdXJjZS9X ZWJLaXQyL1BsdWdpblByb2Nlc3MvRW50cnlQb2ludC9tYWMvWFBDU2VydmljZS9QbHVnaW5TZXJ2 aWNlLjMyLTY0LkluZm8ucGxpc3QJKHdvcmtpbmcgY29weSkKQEAgLTUwLDYgKzUwLDggQEAKIAkJ PGRpY3Q+CiAJCQk8a2V5PkRZTERfSU5TRVJUX0xJQlJBUklFUzwva2V5PgogCQkJPHN0cmluZz4k KFdFQktJVF9GUkFNRVdPUktTX0RJUikvV2ViS2l0LmZyYW1ld29yay9QbHVnaW5Qcm9jZXNzLmFw cC9Db250ZW50cy9NYWNPUy9QbHVnaW5Qcm9jZXNzU2hpbS5keWxpYjwvc3RyaW5nPgorCQkJPGtl eT5OU1N0cmluZ0Rpc2FibGVUYWdnZWQ8L2tleT4KKwkJCTxzdHJpbmc+WUVTPC9zdHJpbmc+CiAJ CTwvZGljdD4KIAk8L2RpY3Q+CiA8L2RpY3Q+CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvTGF1bmNoZXIvbWFjL1Byb2Nlc3NMYXVuY2hlck1hYy5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvbWFjL1Byb2Nlc3NMYXVuY2hlck1hYy5tbQko cmV2aXNpb24gMTcxMzE2KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL21h Yy9Qcm9jZXNzTGF1bmNoZXJNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTExOSw2ICsxMTksOSBA QCBzdGF0aWMgdm9pZCBhZGREWUxERW52aXJvbm1lbnRBZGRpdGlvbnMoCiAgICAgICAgIE5TU3Ry aW5nICpwcm9jZXNzQXBwRXhlY3V0YWJsZVBhdGggPSBbW05TQnVuZGxlIGJ1bmRsZVdpdGhQYXRo OnByb2Nlc3NQYXRoXSBleGVjdXRhYmxlUGF0aF07CiAKICAgICAgICAgcHJvY2Vzc1NoaW1QYXRo TlNTdHJpbmcgPSBbW3Byb2Nlc3NBcHBFeGVjdXRhYmxlUGF0aCBzdHJpbmdCeURlbGV0aW5nTGFz dFBhdGhDb21wb25lbnRdIHN0cmluZ0J5QXBwZW5kaW5nUGF0aENvbXBvbmVudDpAIlBsdWdpblBy b2Nlc3NTaGltLmR5bGliIl07CisKKyAgICAgICAgLy8gVGFnZ2VkIHBvaW50ZXJzIGJyZWFrIHZp ZGVvIGluIEZsYXNoLCBzZWUgYnVnIDEzNTM1NC4KKyAgICAgICAgZW52aXJvbm1lbnRWYXJpYWJs ZXMuc2V0KCJOU1N0cmluZ0Rpc2FibGVUYWdnZWQiLCAiWUVTIik7CiAgICAgfSBlbHNlCiAjZW5k aWYgLy8gRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCiAjaWYgRU5BQkxFKE5FVFdPUktfUFJP Q0VTUykK 235622 2014-07-28 15:22:54 -0700 2014-07-28 15:26:44 -0700 patch patch.patch text/plain 2304 roger_fong SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTcwMSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA3LTI4ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgRGlzYWJsZSB0YWdnZWQgc3Ry aW5ncyBmb3IgdGhlIHBsdWdpbiBwcm9jZXNzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1MzU0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNzI5 NTYzOT4uCisKKyAgICAgICAgUGF0Y2ggYnkgQWxleGV5IFByb3NrdXJ5YWtvdiBhbmQgUm9nZXIg Rm9uZy4KKworICAgICAgICAqIFBsdWdpblByb2Nlc3MvRW50cnlQb2ludC9tYWMvWFBDU2Vydmlj ZS9QbHVnaW5TZXJ2aWNlLjMyLTY0LkluZm8ucGxpc3Q6CisgICAgICAgICogVUlQcm9jZXNzL0xh dW5jaGVyL21hYy9Qcm9jZXNzTGF1bmNoZXJNYWMubW06CisgICAgICAgIChXZWJLaXQ6OmNvbm5l Y3RUb1JlRXhlY1NlcnZpY2UpOgorCiAyMDE0LTA3LTI3ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFu ZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtHVEtdIEtlZXAgbm9uLURBVEFCQVNFX1BST0NF U1MgYnVpbGQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvRW50cnlQb2ludC9t YWMvWFBDU2VydmljZS9QbHVnaW5TZXJ2aWNlLjMyLTY0LkluZm8ucGxpc3QKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9FbnRyeVBvaW50L21hYy9YUENTZXJ2aWNl L1BsdWdpblNlcnZpY2UuMzItNjQuSW5mby5wbGlzdAkocmV2aXNpb24gMTcxMzE2KQorKysgU291 cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9FbnRyeVBvaW50L21hYy9YUENTZXJ2aWNlL1BsdWdp blNlcnZpY2UuMzItNjQuSW5mby5wbGlzdAkod29ya2luZyBjb3B5KQpAQCAtNTAsNiArNTAsOCBA QAogCQk8ZGljdD4KIAkJCTxrZXk+RFlMRF9JTlNFUlRfTElCUkFSSUVTPC9rZXk+CiAJCQk8c3Ry aW5nPiQoV0VCS0lUX0ZSQU1FV09SS1NfRElSKS9XZWJLaXQuZnJhbWV3b3JrL1BsdWdpblByb2Nl c3MuYXBwL0NvbnRlbnRzL01hY09TL1BsdWdpblByb2Nlc3NTaGltLmR5bGliPC9zdHJpbmc+CisJ CQk8a2V5Pk5TU3RyaW5nRGlzYWJsZVRhZ2dlZDwva2V5PgorCQkJPHN0cmluZz5ZRVM8L3N0cmlu Zz4KIAkJPC9kaWN0PgogCTwvZGljdD4KIDwvZGljdD4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9MYXVuY2hlci9tYWMvUHJvY2Vzc0xhdW5jaGVyTWFjLm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9tYWMvUHJvY2Vzc0xhdW5jaGVyTWFj Lm1tCShyZXZpc2lvbiAxNzEzMTYpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNo ZXIvbWFjL1Byb2Nlc3NMYXVuY2hlck1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjkwLDYgKzI5 MCwxMSBAQCBzdGF0aWMgdm9pZCBjb25uZWN0VG9SZUV4ZWNTZXJ2aWNlKGNvbnN0CiAgICAgRW52 aXJvbm1lbnRWYXJpYWJsZXMgZW52aXJvbm1lbnRWYXJpYWJsZXM7CiAgICAgYWRkRFlMREVudmly b25tZW50QWRkaXRpb25zKGxhdW5jaE9wdGlvbnMsIHRydWUsIGVudmlyb25tZW50VmFyaWFibGVz KTsKIAorICAgIGlmIChsYXVuY2hPcHRpb25zLnByb2Nlc3NUeXBlID09IFByb2Nlc3NMYXVuY2hl cjo6UGx1Z2luUHJvY2VzcykgeworICAgICAgICAvLyBUYWdnZWQgcG9pbnRlcnMgYnJlYWsgdmlk ZW8gaW4gRmxhc2gsIHNlZSBidWcgMTM1MzU0LgorICAgICAgICBlbnZpcm9ubWVudFZhcmlhYmxl cy5zZXQoIk5TU3RyaW5nRGlzYWJsZVRhZ2dlZCIsICJZRVMiKTsKKyAgICB9CisKICAgICAvLyBH ZW5lcmF0ZSB0aGUgdXVpZCBmb3IgdGhlIHNlcnZpY2UgaW5zdGFuY2Ugd2UgYXJlIGFib3V0IHRv IGNyZWF0ZS4KICAgICAvLyBGSVhNRTogVGhpcyBVVUlEIHNob3VsZCBiZSBzdG9yZWQgb24gdGhl IENoaWxkUHJvY2Vzc1Byb3h5LgogICAgIFJlZlB0cjxVVUlESG9sZGVyPiBpbnN0YW5jZVVVSUQg PSBVVUlESG9sZGVyOjpjcmVhdGUoKTsK 235623 2014-07-28 15:26:44 -0700 2014-07-28 15:28:13 -0700 patch patch.patch text/plain 2345 roger_fong SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTcwMSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA3LTI4ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgRGlzYWJsZSB0YWdnZWQgc3Ry aW5ncyBmb3IgdGhlIHBsdWdpbiBwcm9jZXNzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1MzU0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNzI5 NTYzOT4uCisKKyAgICAgICAgUGF0Y2ggYnkgQWxleGV5IFByb3NrdXJ5YWtvdiBhbmQgUm9nZXIg Rm9uZy4KKworICAgICAgICAqIFBsdWdpblByb2Nlc3MvRW50cnlQb2ludC9tYWMvWFBDU2Vydmlj ZS9QbHVnaW5TZXJ2aWNlLjMyLTY0LkluZm8ucGxpc3Q6CisgICAgICAgICogVUlQcm9jZXNzL0xh dW5jaGVyL21hYy9Qcm9jZXNzTGF1bmNoZXJNYWMubW06CisgICAgICAgIChXZWJLaXQ6OmNvbm5l Y3RUb1JlRXhlY1NlcnZpY2UpOgorCiAyMDE0LTA3LTI3ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFu ZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtHVEtdIEtlZXAgbm9uLURBVEFCQVNFX1BST0NF U1MgYnVpbGQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvRW50cnlQb2ludC9t YWMvWFBDU2VydmljZS9QbHVnaW5TZXJ2aWNlLjMyLTY0LkluZm8ucGxpc3QKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9FbnRyeVBvaW50L21hYy9YUENTZXJ2aWNl L1BsdWdpblNlcnZpY2UuMzItNjQuSW5mby5wbGlzdAkocmV2aXNpb24gMTcxMzE2KQorKysgU291 cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9FbnRyeVBvaW50L21hYy9YUENTZXJ2aWNlL1BsdWdp blNlcnZpY2UuMzItNjQuSW5mby5wbGlzdAkod29ya2luZyBjb3B5KQpAQCAtNTAsNiArNTAsOCBA QAogCQk8ZGljdD4KIAkJCTxrZXk+RFlMRF9JTlNFUlRfTElCUkFSSUVTPC9rZXk+CiAJCQk8c3Ry aW5nPiQoV0VCS0lUX0ZSQU1FV09SS1NfRElSKS9XZWJLaXQuZnJhbWV3b3JrL1BsdWdpblByb2Nl c3MuYXBwL0NvbnRlbnRzL01hY09TL1BsdWdpblByb2Nlc3NTaGltLmR5bGliPC9zdHJpbmc+CisJ CQk8a2V5Pk5TU3RyaW5nRGlzYWJsZVRhZ2dlZDwva2V5PgorCQkJPHN0cmluZz5ZRVM8L3N0cmlu Zz4KIAkJPC9kaWN0PgogCTwvZGljdD4KIDwvZGljdD4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9MYXVuY2hlci9tYWMvUHJvY2Vzc0xhdW5jaGVyTWFjLm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9tYWMvUHJvY2Vzc0xhdW5jaGVyTWFj Lm1tCShyZXZpc2lvbiAxNzEzMTYpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNo ZXIvbWFjL1Byb2Nlc3NMYXVuY2hlck1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjkwLDYgKzI5 MCwxMyBAQCBzdGF0aWMgdm9pZCBjb25uZWN0VG9SZUV4ZWNTZXJ2aWNlKGNvbnN0CiAgICAgRW52 aXJvbm1lbnRWYXJpYWJsZXMgZW52aXJvbm1lbnRWYXJpYWJsZXM7CiAgICAgYWRkRFlMREVudmly b25tZW50QWRkaXRpb25zKGxhdW5jaE9wdGlvbnMsIHRydWUsIGVudmlyb25tZW50VmFyaWFibGVz KTsKIAorI2lmIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQorICAgIGlmIChsYXVuY2hPcHRp b25zLnByb2Nlc3NUeXBlID09IFByb2Nlc3NMYXVuY2hlcjo6UGx1Z2luUHJvY2VzcykgeworICAg ICAgICAvLyBUYWdnZWQgcG9pbnRlcnMgYnJlYWsgdmlkZW8gaW4gRmxhc2gsIHNlZSBidWcgMTM1 MzU0LgorICAgICAgICBlbnZpcm9ubWVudFZhcmlhYmxlcy5zZXQoIk5TU3RyaW5nRGlzYWJsZVRh Z2dlZCIsICJZRVMiKTsKKyAgICB9CisjZW5kaWYKKwogICAgIC8vIEdlbmVyYXRlIHRoZSB1dWlk IGZvciB0aGUgc2VydmljZSBpbnN0YW5jZSB3ZSBhcmUgYWJvdXQgdG8gY3JlYXRlLgogICAgIC8v IEZJWE1FOiBUaGlzIFVVSUQgc2hvdWxkIGJlIHN0b3JlZCBvbiB0aGUgQ2hpbGRQcm9jZXNzUHJv eHkuCiAgICAgUmVmUHRyPFVVSURIb2xkZXI+IGluc3RhbmNlVVVJRCA9IFVVSURIb2xkZXI6OmNy ZWF0ZSgpOwo=