135350 2014-07-28 13:28:16 -0700 Make sure that we don't use non-speculative BooleanToNumber for a speculative Branch 2014-07-28 13:41:41 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg mmirman msaboff oliver sam oldest_to_newest 1025204 0 fpizlo 2014-07-28 13:28:16 -0700 Patch forthcoming. 1025206 1 235612 fpizlo 2014-07-28 13:31:13 -0700 Created attachment 235612 the patch 1025207 2 mhahnenberg 2014-07-28 13:36:09 -0700 r=me too! 1025210 3 fpizlo 2014-07-28 13:41:41 -0700 Landed in http://trac.webkit.org/changeset/171689 235612 2014-07-28 13:31:13 -0700 2014-07-28 13:32:50 -0700 the patch blah.patch text/plain 5233 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcxNjg3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDE0LTA3LTI4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg TWFrZSBzdXJlIHRoYXQgd2UgZG9uJ3QgdXNlIG5vbi1zcGVjdWxhdGl2ZSBCb29sZWFuVG9OdW1i ZXIgZm9yIGEgc3BlY3VsYXRpdmUgQnJhbmNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzUzNTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3NTA5 ODg5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAg ICAgICAgSWYgd2UgaGF2ZSBhbiBleGl0aW5nIG5vZGUgdGhhdCB1c2VzIGEgY29udmVyc2lvbiBu b2RlLCB0aGVuIHRoYXQgZXhpdGluZyBub2RlCisgICAgICAgIG5lZWRzIHRvIGhhdmUgYSBQaGFu dG9tIGFmdGVyIGl0IGZvciB0aGUgdGhlIG9yaWdpbmFsIG5vZGUuIEJ1dCB3ZSBjYW4ndCBkbyB0 aGF0CisgICAgICAgIGZvciBCcmFuY2ggYmVjYXVzZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTI2Nzc4LgorCisgICAgICAgICogZGZnL0RGR0ZpeHVwUGhhc2UuY3Bw OgorICAgICAgICAoSlNDOjpERkc6OkZpeHVwUGhhc2U6OmZpeHVwTm9kZSk6CisgICAgICAgIChK U0M6OkRGRzo6Rml4dXBQaGFzZTo6Y2xlYXJQaGFudG9tc0F0RW5kKToKKyAgICAgICAgKiB0ZXN0 cy9zdHJlc3MvYnJhbmNoLWNoZWNrLWludDMyLW9uLWJvb2xlYW4tdG8tbnVtYmVyLXVudHlwZWQu anM6IEFkZGVkLgorICAgICAgICAoZm9vKToKKyAgICAgICAgKHRlc3QpOgorICAgICAgICAqIHRl c3RzL3N0cmVzcy9icmFuY2gtY2hlY2stbnVtYmVyLW9uLWJvb2xlYW4tdG8tbnVtYmVyLXVudHlw ZWQuanM6IEFkZGVkLgorICAgICAgICAoZm9vKToKKyAgICAgICAgKHRlc3QpOgorCiAyMDE0LTA3 LTI4ICBCcmlhbiBKLiBCdXJnICA8YnVyZ0Bjcy53YXNoaW5ndG9uLmVkdT4KIAogICAgICAgICBX ZWIgUmVwbGF5OiBhdXRvLWRlY29kaW5nIG9mIHBhcmFtZXRlcml6ZWQgdmVjdG9yJ3MgZWxlbWVu dHMgaXMgaW5jb3JyZWN0CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZpeHVw UGhhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4 dXBQaGFzZS5jcHAJKHJldmlzaW9uIDE3MTY3NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHRml4dXBQaGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcwOCwxMCArNzA4LDE0IEBA IHByaXZhdGU6CiAgICAgICAgICAgICAgICAgZml4RWRnZTxCb29sZWFuVXNlPihub2RlLT5jaGls ZDEoKSk7CiAgICAgICAgICAgICBlbHNlIGlmIChub2RlLT5jaGlsZDEoKS0+c2hvdWxkU3BlY3Vs YXRlT2JqZWN0T3JPdGhlcigpKQogICAgICAgICAgICAgICAgIGZpeEVkZ2U8T2JqZWN0T3JPdGhl clVzZT4obm9kZS0+Y2hpbGQxKCkpOwotICAgICAgICAgICAgZWxzZSBpZiAobm9kZS0+Y2hpbGQx KCktPnNob3VsZFNwZWN1bGF0ZUludDMyT3JCb29sZWFuKCkpCi0gICAgICAgICAgICAgICAgZml4 SW50T3JCb29sZWFuRWRnZShub2RlLT5jaGlsZDEoKSk7Ci0gICAgICAgICAgICBlbHNlIGlmIChu b2RlLT5jaGlsZDEoKS0+c2hvdWxkU3BlY3VsYXRlTnVtYmVyT3JCb29sZWFuKCkpCi0gICAgICAg ICAgICAgICAgZml4RG91YmxlT3JCb29sZWFuRWRnZShub2RlLT5jaGlsZDEoKSk7CisgICAgICAg ICAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIGp1c3QgYmUgYWJsZSB0byBkbyBzaG91bGRTcGVjdWxh dGVJbnQzMk9yQm9vbGVhbigpIGFuZAorICAgICAgICAgICAgLy8gc2hvdWxkU3BlY3VsYXRlTnVt YmVyT3JCb29sZWFuKCkgaGVyZSwgYnV0IHdlIGNhbid0IGJlY2F1c2UgdGhlbiB0aGUgQnJhbmNo CisgICAgICAgICAgICAvLyBjb3VsZCBzcGVjdWxhdGUgb24gdGhlIHJlc3VsdCBvZiBhIG5vbi1z cGVjdWxhdGl2ZSBjb252ZXJzaW9uIG5vZGUuCisgICAgICAgICAgICAvLyBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2Nzc4CisgICAgICAgICAgICBlbHNlIGlmIChu b2RlLT5jaGlsZDEoKS0+c2hvdWxkU3BlY3VsYXRlSW50MzIoKSkKKyAgICAgICAgICAgICAgICBm aXhFZGdlPEludDMyVXNlPihub2RlLT5jaGlsZDEoKSk7CisgICAgICAgICAgICBlbHNlIGlmIChu b2RlLT5jaGlsZDEoKS0+c2hvdWxkU3BlY3VsYXRlTnVtYmVyKCkpCisgICAgICAgICAgICAgICAg Zml4RWRnZTxEb3VibGVSZXBVc2U+KG5vZGUtPmNoaWxkMSgpKTsKICAgICAgICAgICAgIGJyZWFr OwogICAgICAgICB9CiAgICAgICAgICAgICAKQEAgLTE5ODEsMTEgKzE5ODUsMTEgQEAgcHJpdmF0 ZToKICAgICB7CiAgICAgICAgIC8vIFRlcm1pbmFsIG5vZGVzIGRvbid0IG5lZWQgcG9zdC1waGFu dG9tcywgYW5kIGluc2VydGluZyB0aGVtIHdvdWxkIHZpb2xhdGUKICAgICAgICAgLy8gdGhlIGN1 cnJlbnQgcmVxdWlyZW1lbnQgdGhhdCBhIHRlcm1pbmFsIGlzIHRoZSBsYXN0IHRoaW5nIGluIGEg YmxvY2suIFdlCi0gICAgICAgIC8vIHNob3VsZCBldmVudHVhbGx5IGNoYW5nZSB0aGF0IHJlcXVp cmVtZW50IGJ1dCBldmVuIGlmIHdlIGRpZCwgdGhpcyB3b3VsZAotICAgICAgICAvLyBzdGlsbCBi ZSBhIHZhbGlkIG9wdGltaXphdGlvbi4gQWxsIHRlcm1pbmFscyBhY2NlcHQganVzdCBvbmUgaW5w dXQsIGFuZAotICAgICAgICAvLyBpZiB0aGF0IGlucHV0IGlzIGEgY29udmVyc2lvbiBub2RlIHRo ZW4gbm8gZnVydGhlciBzcGVjdWxhdGlvbnMgd2lsbCBiZQotICAgICAgICAvLyBwZXJmb3JtZWQu Ci0gICAgICAgIAorICAgICAgICAvLyBzaG91bGQgZXZlbnR1YWxseSBjaGFuZ2UgdGhhdCByZXF1 aXJlbWVudC4gQ3VycmVudGx5IHdlIGdldCBhcm91bmQgdGhpcyBieQorICAgICAgICAvLyBlbnN1 cmluZyB0aGF0IGFsbCB0ZXJtaW5hbHMgYWNjZXB0IGp1c3Qgb25lIGlucHV0LCBhbmQgaWYgdGhh dCBpbnB1dCBpcyBhCisgICAgICAgIC8vIGNvbnZlcnNpb24gbm9kZSB0aGVuIG5vIGZ1cnRoZXIg c3BlY3VsYXRpb25zIHdpbGwgYmUgcGVyZm9ybWVkLiBTZWUKKyAgICAgICAgLy8gcmVmZXJlbmNl cyB0byB0aGUgYnVnLCBiZWxvdywgZm9yIHBsYWNlcyB3aGVyZSB3ZSBoYXZlIHRvIGhhdmUgaGFj a3MgdG8KKyAgICAgICAgLy8gd29yayBhcm91bmQgdGhpcy4KICAgICAgICAgLy8gRklYTUU6IEdl dCByaWQgb2YgdGhpcyBieSBhbGxvd2luZyBQaGFudG9tcyBhZnRlciB0ZXJtaW5hbHMuCiAgICAg ICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjY3NzgKICAg ICAgICAgCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2JyYW5jaC1j aGVjay1pbnQzMi1vbi1ib29sZWFuLXRvLW51bWJlci11bnR5cGVkLmpzCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvYnJhbmNoLWNoZWNrLWludDMyLW9u LWJvb2xlYW4tdG8tbnVtYmVyLXVudHlwZWQuanMJKHJldmlzaW9uIDApCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2JyYW5jaC1jaGVjay1pbnQzMi1vbi1ib29sZWFuLXRv LW51bWJlci11bnR5cGVkLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMjMgQEAKK2Z1bmN0 aW9uIGZvbyhvKSB7CisgICAgaWYgKG8uZikKKyAgICAgICAgcmV0dXJuICJ5ZXMiOworICAgIGVs c2UKKyAgICAgICAgcmV0dXJuICJubyI7Cit9CisKK25vSW5saW5lKGZvbyk7CisKK2Z1bmN0aW9u IHRlc3QodmFsdWUsIGV4cGVjdGVkKSB7CisgICAgdmFyIHJlc3VsdCA9IGZvbyh7Zjp2YWx1ZX0p OworICAgIGlmIChyZXN1bHQgIT0gZXhwZWN0ZWQpCisgICAgICAgIHRocm93ICJFcnJvcjogYmFk IHJlc3VsdCBmb3IgIiArIHZhbHVlICsgIjogIiArIHJlc3VsdDsKK30KKworZm9yICh2YXIgaSA9 IDA7IGkgPCAxMDAwMDsgKytpKSB7CisgICAgdGVzdCgxLCAieWVzIik7CisgICAgdGVzdCgwLCAi bm8iKTsKKyAgICB0ZXN0KHRydWUsICJ5ZXMiKTsKKyAgICB0ZXN0KGZhbHNlLCAibm8iKTsKK30K KwordGVzdCgieWVzIiwgInllcyIpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3Rz L3N0cmVzcy9icmFuY2gtY2hlY2stbnVtYmVyLW9uLWJvb2xlYW4tdG8tbnVtYmVyLXVudHlwZWQu anMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9icmFu Y2gtY2hlY2stbnVtYmVyLW9uLWJvb2xlYW4tdG8tbnVtYmVyLXVudHlwZWQuanMJKHJldmlzaW9u IDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2JyYW5jaC1jaGVjay1u dW1iZXItb24tYm9vbGVhbi10by1udW1iZXItdW50eXBlZC5qcwkod29ya2luZyBjb3B5KQpAQCAt MCwwICsxLDIzIEBACitmdW5jdGlvbiBmb28obykgeworICAgIGlmIChvLmYpCisgICAgICAgIHJl dHVybiAieWVzIjsKKyAgICBlbHNlCisgICAgICAgIHJldHVybiAibm8iOworfQorCitub0lubGlu ZShmb28pOworCitmdW5jdGlvbiB0ZXN0KHZhbHVlLCBleHBlY3RlZCkgeworICAgIHZhciByZXN1 bHQgPSBmb28oe2Y6dmFsdWV9KTsKKyAgICBpZiAocmVzdWx0ICE9IGV4cGVjdGVkKQorICAgICAg ICB0aHJvdyAiRXJyb3I6IGJhZCByZXN1bHQgZm9yICIgKyB2YWx1ZSArICI6ICIgKyByZXN1bHQ7 Cit9CisKK2ZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDA7ICsraSkgeworICAgIHRlc3QoMS41LCAi eWVzIik7CisgICAgdGVzdCgwLjAsICJubyIpOworICAgIHRlc3QodHJ1ZSwgInllcyIpOworICAg IHRlc3QoZmFsc2UsICJubyIpOworfQorCit0ZXN0KCJ5ZXMiLCAieWVzIik7Cg==