135345 2014-07-28 12:04:28 -0700 JSContext Inspector: crash when using step-into 2014-07-28 13:38:55 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1025171 0 joepeck 2014-07-28 12:04:28 -0700 * STEPS TO REPRODUCE 1. JSContext with "function a() { debugger; b() } function b() { console.log("b"); }" 2. Inspect JSContext 3. run a() 4. Step Into => CRASH * DETAILS Thread 0 name: Dispatch queue: com.apple.main-thread Thread 0 Crashed: 0 JavaScriptCore 0x003db692 Inspector::InspectorDebuggerAgent::stepInto(WTF::String*) + 90 1 JavaScriptCore 0x003db6b8 non-virtual thunk to Inspector::InspectorDebuggerAgent::stepInto(WTF::String*) + 24 2 JavaScriptCore 0x003e60ce Inspector::InspectorDebuggerBackendDispatcher::stepInto(long, Inspector::InspectorObject const&) + 70 3 JavaScriptCore 0x003e5136 Inspector::InspectorDebuggerBackendDispatcher::dispatch(long, WTF::String const&, WTF::PassRefPtr<Inspector::InspectorObject>) + 634 4 JavaScriptCore 0x003cdf6c Inspector::InspectorBackendDispatcher::dispatch(WTF::String const&) + 1060 5 JavaScriptCore 0x0048d3d4 Inspector::JSGlobalObjectInspectorController::dispatchMessageFromFrontend(WTF::String const&) + 40 Looks like we forgot to null check m_listener in this one place. <rdar://problem/17364180> 1025175 1 235605 joepeck 2014-07-28 12:20:42 -0700 Created attachment 235605 [PATCH] Proposed Fix 1025208 2 235605 commit-queue 2014-07-28 13:38:52 -0700 Comment on attachment 235605 [PATCH] Proposed Fix Clearing flags on attachment: 235605 Committed r171688: <http://trac.webkit.org/changeset/171688> 1025209 3 commit-queue 2014-07-28 13:38:55 -0700 All reviewed patches have been landed. Closing bug. 235605 2014-07-28 12:20:42 -0700 2014-07-28 13:38:52 -0700 [PATCH] Proposed Fix step-into.patch text/plain 1370 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGVjMmU4OTEuLjU4MjMzZmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA3LTI4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgSlNDb250ZXh0IEluc3BlY3Rvcjog Y3Jhc2ggd2hlbiB1c2luZyBzdGVwLWludG8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzNTM0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JEZWJ1Z2dlckFn ZW50LmNwcDoKKyAgICAgICAgKEluc3BlY3Rvcjo6SW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6c3Rl cEludG8pOgorICAgICAgICBOdWxsIGNoZWNrIG1fbGlzdGVuZXIgc2luY2UgaXQgbWF5IG5vdCBi ZSBzZXQuCisKIDIwMTQtMDctMjggIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+ CiAKICAgICAgICAgW1dpbl0gVW5yZXZpZXdlZCBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50 LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckRl YnVnZ2VyQWdlbnQuY3BwCmluZGV4IDIzMTMyZmMuLjUwOTZhNmMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3Rv ckRlYnVnZ2VyQWdlbnQuY3BwCkBAIC00ODMsNyArNDgzLDkgQEAgdm9pZCBJbnNwZWN0b3JEZWJ1 Z2dlckFnZW50OjpzdGVwSW50byhFcnJvclN0cmluZyogZXJyb3JTdHJpbmcpCiAKICAgICBtX2lu amVjdGVkU2NyaXB0TWFuYWdlci0+cmVsZWFzZU9iamVjdEdyb3VwKEluc3BlY3RvckRlYnVnZ2Vy QWdlbnQ6OmJhY2t0cmFjZU9iamVjdEdyb3VwKTsKICAgICBzY3JpcHREZWJ1Z1NlcnZlcigpLnN0 ZXBJbnRvU3RhdGVtZW50KCk7Ci0gICAgbV9saXN0ZW5lci0+c3RlcEludG8oKTsKKworICAgIGlm IChtX2xpc3RlbmVyKQorICAgICAgICBtX2xpc3RlbmVyLT5zdGVwSW50bygpOwogfQogCiB2b2lk IEluc3BlY3RvckRlYnVnZ2VyQWdlbnQ6OnN0ZXBPdXQoRXJyb3JTdHJpbmcqIGVycm9yU3RyaW5n KQo=