135341 2014-07-28 11:08:06 -0700 Web Replay: vectors of characters should be base64-encoded 2014-07-28 14:31:46 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 burg burg commit-queue joepeck kling mhahnenberg timothy oldest_to_newest 1025153 0 burg 2014-07-28 11:08:06 -0700 Add this specialization separately since at least two replay features (resource loading, navigations) depend on it. 1025159 1 235600 burg 2014-07-28 11:27:04 -0700 Created attachment 235600 Patch 1025176 2 235600 commit-queue 2014-07-28 12:21:38 -0700 Comment on attachment 235600 Patch Clearing flags on attachment: 235600 Committed r171682: <http://trac.webkit.org/changeset/171682> 1025177 3 commit-queue 2014-07-28 12:21:41 -0700 All reviewed patches have been landed. Closing bug. 1025216 4 mhahnenberg 2014-07-28 13:46:54 -0700 (In reply to comment #2) > (From update of attachment 235600 [details]) > Clearing flags on attachment: 235600 > > Committed r171682: <http://trac.webkit.org/changeset/171682> Looks like this broke the build. 1025217 5 mhahnenberg 2014-07-28 13:47:34 -0700 (In reply to comment #4) > (In reply to comment #2) > > (From update of attachment 235600 [details] [details]) > > Clearing flags on attachment: 235600 > > > > Committed r171682: <http://trac.webkit.org/changeset/171682> > > Looks like this broke the build. See, e.g. http://build.webkit.org/builders/Apple%20Mavericks%2032-bit%20JSC%20%28BuildAndTest%29/builds/3167 1025225 6 burg 2014-07-28 14:10:43 -0700 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #2) > > > (From update of attachment 235600 [details] [details] [details]) > > > Clearing flags on attachment: 235600 > > > > > > Committed r171682: <http://trac.webkit.org/changeset/171682> > > > > Looks like this broke the build. > > See, e.g. http://build.webkit.org/builders/Apple%20Mavericks%2032-bit%20JSC%20%28BuildAndTest%29/builds/3167 Landed a fix in <http://trac.webkit.org/changeset/171694>. Still not sure why the build break cannot reproduce locally or on EWS... 1025226 7 mhahnenberg 2014-07-28 14:11:21 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > (In reply to comment #2) > > > > (From update of attachment 235600 [details] [details] [details] [details]) > > > > Clearing flags on attachment: 235600 > > > > > > > > Committed r171682: <http://trac.webkit.org/changeset/171682> > > > > > > Looks like this broke the build. > > > > See, e.g. http://build.webkit.org/builders/Apple%20Mavericks%2032-bit%20JSC%20%28BuildAndTest%29/builds/3167 > > Landed a fix in <http://trac.webkit.org/changeset/171694>. Still not sure why the build break cannot reproduce locally or on EWS... Might be 32-bit specific? *shrugs* 1025235 8 burg 2014-07-28 14:31:46 -0700 Still didn't fix it. It seems this is the first use of base64encode() from a header. Looking at Base64.h, there are 4 adapters and 2 actual implementations, but all are marked WTF_EXPORT_PRIVATE. Since EncodedValue.h is included multiple places, it will trigger weak symbol problems that seem to have been latent in that header. 235600 2014-07-28 11:27:04 -0700 2014-07-28 12:21:38 -0700 Patch bug-135341-20140728112651.patch text/plain 2770 burg U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxMjQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk ZmM0YWJiNGFjMDQwN2YzZDZmM2YzZGEzY2U4MTViNTNlNGRmMDE4Li41YzgwY2M3YjFlZTJjODNk YjgxMjZjY2RlYjAwZWFjNjNhOTY1OTUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNC0wNy0xNSAgQnJpYW4gSi4gQnVyZyAgPGJ1cmdAY3Mud2FzaGluZ3Rv bi5lZHU+CisKKyAgICAgICAgV2ViIFJlcGxheTogdmVjdG9ycyBvZiBjaGFyYWN0ZXJzIHNob3Vs ZCBiZSBiYXNlNjQtZW5jb2RlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM1MzQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2l0aG91dCB0aGlzIHNwZWNpYWxpemF0aW9uLCBlbmNvZGUvZGVjb2RlIG1l dGhvZHMgdHJ5IHRvIGNyZWF0ZSBhbgorICAgICAgICBhcnJheSBvZiBzaW5nbGUgY2hhcmFjdGVy cyBpbiBKU09OLCByYXRoZXIgdGhhbiB0cmVhdGluZyB0aGUKKyAgICAgICAgdmVjdG9yIGFzIGEg YmluYXJ5IGJsb2IuCisKKyAgICAgICAgKiByZXBsYXkvRW5jb2RlZFZhbHVlLmNwcDoKKyAgICAg ICAgKEpTQzo6RW5jb2RpbmdUcmFpdHM8VmVjdG9yPGNoYXI+Pjo6ZW5jb2RlVmFsdWUpOiBBZGRl ZC4KKyAgICAgICAgKEpTQzo6RW5jb2RpbmdUcmFpdHM8VmVjdG9yPGNoYXI+Pjo6ZGVjb2RlVmFs dWUpOiBBZGRlZC4KKyAgICAgICAgKiByZXBsYXkvRW5jb2RlZFZhbHVlLmg6CisKIDIwMTQtMDct MTQgIEJyaWFuIEouIEJ1cmcgIDxidXJnQGNzLndhc2hpbmd0b24uZWR1PgogCiAgICAgICAgIFdl YiBSZXBsYXk6IGRvbid0IGVuY29kZS9kZWNvZGUgcHJpbWl0aXZlIHR5cGVzIHRoYXQgbGFjayBl eHBsaWNpdCBzaXplcwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3JlcGxheS9F bmNvZGVkVmFsdWUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3JlcGxheS9FbmNvZGVkVmFs dWUuY3BwCmluZGV4IGNlZTcwZTI0M2E3MjJiZDI1MmY4ODNlYTg1ODdjMTk5ZmM3YjgxMDcuLjcz Zjk4YTU2ZDI3ZDA5MWMxNjU1MDk2Y2NhNzMzYzA2ZGMwZjVlOTUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9yZXBsYXkvRW5jb2RlZFZhbHVlLmNwcAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcmVwbGF5L0VuY29kZWRWYWx1ZS5jcHAKQEAgLTU1LDYgKzU1LDE2IEBAIFBh c3NSZWZQdHI8SW5zcGVjdG9yQXJyYXk+IEVuY29kZWRWYWx1ZTo6YXNBcnJheSgpCiAgICAgcmV0 dXJuIHJlc3VsdC5yZWxlYXNlKCk7CiB9CiAKK0VuY29kZWRWYWx1ZSBFbmNvZGluZ1RyYWl0czxW ZWN0b3I8Y2hhcj4+OjplbmNvZGVWYWx1ZShjb25zdCBWZWN0b3I8Y2hhcj4mIGJ1ZmZlcikKK3sK KyAgICByZXR1cm4gRW5jb2RlZFZhbHVlOjpjcmVhdGVTdHJpbmcoYmFzZTY0RW5jb2RlKGJ1ZmZl cikpOworfQorCitib29sIEVuY29kaW5nVHJhaXRzPFZlY3RvcjxjaGFyPj46OmRlY29kZVZhbHVl KEVuY29kZWRWYWx1ZSYgZW5jb2RlZEJ1ZmZlciwgVmVjdG9yPGNoYXI+JiBkZWNvZGVkVmFsdWUp Cit7CisgICAgcmV0dXJuIGJhc2U2NERlY29kZShlbmNvZGVkQnVmZmVyLmNvbnZlcnRUbzxTdHJp bmc+KCksIGRlY29kZWRWYWx1ZSk7Cit9CisKIHRlbXBsYXRlPD4gRW5jb2RlZFZhbHVlIFNjYWxh ckVuY29kaW5nVHJhaXRzPGJvb2w+OjplbmNvZGVWYWx1ZShjb25zdCBib29sJiB2YWx1ZSkKIHsK ICAgICByZXR1cm4gRW5jb2RlZFZhbHVlKEluc3BlY3RvckJhc2ljVmFsdWU6OmNyZWF0ZSh2YWx1 ZSkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3JlcGxheS9FbmNvZGVkVmFs dWUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9yZXBsYXkvRW5jb2RlZFZhbHVlLmgKaW5kZXgg NGZiOGE4NTNhNGY5ZWNjNTUwOWQ0NjE5NDljMTI1NDU2NTNjOTA1ZC4uNjU2NjczNDY0YmZiNjAx ZTM2MTcwMWU2YzBmMWY2MTgwYTkyMDBjYSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3JlcGxheS9FbmNvZGVkVmFsdWUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcmVw bGF5L0VuY29kZWRWYWx1ZS5oCkBAIC0xMzYsNiArMTM2LDEzIEBAIHRlbXBsYXRlPD4gc3RydWN0 IEVuY29kaW5nVHJhaXRzPEVuY29kZWRWYWx1ZT4gewogICAgIC8vIHNvIGVuY29kZVZhbHVlIGFu ZCBkZWNvZGVWYWx1ZSBhcmUgaW50ZW50aW9uYWxseSBvbWl0dGVkIGhlcmUuCiB9OwogCisvLyBT cGVjaWFsaXplIGJ5dGUgdmVjdG9ycyB0byB1c2UgYmFzZTY0IGVuY29kaW5nLgordGVtcGxhdGU8 PiBzdHJ1Y3QgRW5jb2RpbmdUcmFpdHM8VmVjdG9yPGNoYXI+PiB7CisgICAgdHlwZWRlZiBWZWN0 b3I8Y2hhcj4gRGVjb2RlZFR5cGU7CisgICAgc3RhdGljIEpTX0VYUE9SVF9QUklWQVRFIEVuY29k ZWRWYWx1ZSBlbmNvZGVWYWx1ZShjb25zdCBEZWNvZGVkVHlwZSYpOworICAgIHN0YXRpYyBKU19F WFBPUlRfUFJJVkFURSBib29sIGRlY29kZVZhbHVlKEVuY29kZWRWYWx1ZSYsIERlY29kZWRUeXBl Jik7Cit9OworCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgogc3RydWN0IFNjYWxhckVuY29kaW5nVHJh aXRzIHsKICAgICB0eXBlZGVmIFQgRGVjb2RlZFR5cGU7Cg==