135325 2014-07-26 19:40:19 -0700 [WebKit2 iOS]Add support for caret movement for the 3rd party keyboard protocol 2014-07-27 10:25:53 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica commit-queue oldest_to_newest 1025041 0 enrica 2014-07-26 19:40:19 -0700 We need to implement a way to move the caret in one forward/backward by n positions. <rdar://problem/17682120> 1025042 1 235579 enrica 2014-07-26 19:44:14 -0700 Created attachment 235579 Patch 1025043 2 commit-queue 2014-07-26 19:45:31 -0700 Attachment 235579 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:421: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:534: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 1025055 3 enrica 2014-07-27 10:25:53 -0700 Committed revision 171651. 235579 2014-07-26 19:44:14 -0700 2014-07-26 23:33:59 -0700 Patch 3rdpartyarrowkeys.txt text/plain 7018 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTY1MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA3LTI2ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYktpdDIgaU9TXUFkZCBz dXBwb3J0IGZvciBjYXJldCBtb3ZlbWVudCBmb3IgdGhlIDNyZCBwYXJ0eSBrZXlib2FyZCBwcm90 b2NvbC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz NTMyNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTc2ODIxMjA+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV0tDb250ZW50VmlldyBub3cgaW1wbGVt ZW50cyBtb3ZlQnlPZmZzZXQgdG8gc3VwcG9ydCB0aGUKKyAgICAgICAgcHJvdG9jb2wgZm9yIDNy ZCBwYXJ0eSBrZXlib2FyZHMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5Lmg6 CisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06Cisg ICAgICAgICgtW1dLQ29udGVudFZpZXcgbW92ZUJ5T2Zmc2V0Ol0pOgorICAgICAgICAqIFVJUHJv Y2Vzcy9pb3MvV2ViUGFnZVByb3h5SU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJv eHk6Om1vdmVTZWxlY3Rpb25CeU9mZnNldCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdl L1dlYlBhZ2UuaDoKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5tZXNzYWdl cy5pbjoKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW06Cisg ICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6Om1vdmVTZWxlY3Rpb25CeU9mZnNldCk6CisKIDIwMTQt MDctMjYgIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAg ICAgIENyYXNoIGluIFdlYiBDb250ZW50IFByb2Nlc3MgdW5kZXIgflBERkRvY3VtZW50IHVuZGVy IGNsZWFyVG91Y2hFdmVudExpc3RlbmVycyBhdCB0b3BEb2N1bWVudCgpCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCShyZXZpc2lvbiAxNzE2NTApCisrKyBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgJKHdvcmtpbmcgY29weSkKQEAgLTQx OCw2ICs0MTgsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCB1cGRhdGVCbG9ja1NlbGVjdGlvbldpdGhU b3VjaChjb25zdCBXZWJDb3JlOjpJbnRQb2ludCwgdWludDMyX3QgdG91Y2gsIHVpbnQzMl90IGhh bmRsZVBvc2l0aW9uKTsKICAgICB2b2lkIGV4dGVuZFNlbGVjdGlvbihXZWJDb3JlOjpUZXh0R3Jh bnVsYXJpdHkpOwogICAgIHZvaWQgc2VsZWN0V29yZEJhY2t3YXJkKCk7CisgICAgdm9pZCBtb3Zl U2VsZWN0aW9uQnlPZmZzZXQoaW50MzJfdCBvZmZzZXQsIHN0ZDo6ZnVuY3Rpb248dm9pZCAoQ2Fs bGJhY2tCYXNlOjpFcnJvcik+KTsKICAgICB2b2lkIHJlcXVlc3RBdXRvY29ycmVjdGlvbkRhdGEo Y29uc3QgU3RyaW5nJiB0ZXh0Rm9yQXV0b2NvcnJlY3Rpb24sIHN0ZDo6ZnVuY3Rpb248dm9pZCAo Y29uc3QgVmVjdG9yPFdlYkNvcmU6OkZsb2F0UmVjdD4mLCBjb25zdCBTdHJpbmcmLCBkb3VibGUs IHVpbnQ2NF90LCBDYWxsYmFja0Jhc2U6OkVycm9yKT4pOwogICAgIHZvaWQgYXBwbHlBdXRvY29y cmVjdGlvbihjb25zdCBTdHJpbmcmIGNvcnJlY3Rpb24sIGNvbnN0IFN0cmluZyYgb3JpZ2luYWxU ZXh0LCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKGNvbnN0IFN0cmluZyYsIENhbGxiYWNrQmFzZTo6RXJy b3IpPik7CiAgICAgYm9vbCBhcHBseUF1dG9jb3JyZWN0aW9uKGNvbnN0IFN0cmluZyYgY29ycmVj dGlvbiwgY29uc3QgU3RyaW5nJiBvcmlnaW5hbFRleHQpOwpJbmRleDogU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0J KHJldmlzaW9uIDE3MTY1MCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250 ZW50Vmlld0ludGVyYWN0aW9uLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xNjk3LDYgKzE2OTcsMTcg QEAgLSAodm9pZCljaGFuZ2VCbG9ja1NlbGVjdGlvbldpdGhUb3VjaEF0OgogICAgIF9wYWdlLT51 cGRhdGVCbG9ja1NlbGVjdGlvbldpdGhUb3VjaChXZWJDb3JlOjpJbnRQb2ludChwb2ludCksIHN0 YXRpY19jYXN0PHVpbnQzMl90Pih0b1NlbGVjdGlvblRvdWNoKHRvdWNoKSksIHN0YXRpY19jYXN0 PHVpbnQzMl90Pih0b1NlbGVjdGlvbkhhbmRsZVBvc2l0aW9uKGhhbmRsZSkpKTsKIH0KIAorLSAo dm9pZCltb3ZlQnlPZmZzZXQ6KE5TSW50ZWdlcilvZmZzZXQKK3sKKyAgICBpZiAoIW9mZnNldCkK KyAgICAgICAgcmV0dXJuOworICAgIAorICAgIFtzZWxmIGJlZ2luU2VsZWN0aW9uQ2hhbmdlXTsK KyAgICBfcGFnZS0+bW92ZVNlbGVjdGlvbkJ5T2Zmc2V0KG9mZnNldCwgW3NlbGZdKENhbGxiYWNr QmFzZTo6RXJyb3IpIHsKKyAgICAgICAgW3NlbGYgZW5kU2VsZWN0aW9uQ2hhbmdlXTsKKyAgICB9 KTsKK30KKwogLSAoY29uc3QgV0tBdXRvQ29ycmVjdGlvbkRhdGEmKWF1dG9jb3JyZWN0aW9uRGF0 YQogewogICAgIHJldHVybiBfYXV0b2NvcnJlY3Rpb25EYXRhOwpJbmRleDogU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL2lvcy9XZWJQYWdlUHJveHlJT1MubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XZWJQYWdlUHJveHlJT1MubW0JKHJldmlzaW9uIDE3MTY1 MCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV2ViUGFnZVByb3h5SU9TLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC01MzEsNiArNTMxLDE3IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpzZWxl Y3RXb3JkQmFja3dhcmQoKQogICAgIG1fcHJvY2Vzcy0+c2VuZChNZXNzYWdlczo6V2ViUGFnZTo6 U2VsZWN0V29yZEJhY2t3YXJkKCksIG1fcGFnZUlEKTsKIH0KIAordm9pZCBXZWJQYWdlUHJveHk6 Om1vdmVTZWxlY3Rpb25CeU9mZnNldChpbnQzMl90IG9mZnNldCwgc3RkOjpmdW5jdGlvbjx2b2lk IChDYWxsYmFja0Jhc2U6OkVycm9yKT4gY2FsbGJhY2tGdW5jdGlvbikKK3sKKyAgICBpZiAoIWlz VmFsaWQoKSkgeworICAgICAgICBjYWxsYmFja0Z1bmN0aW9uKENhbGxiYWNrQmFzZTo6RXJyb3I6 OlVua25vd24pOworICAgICAgICByZXR1cm47CisgICAgfQorICAgIAorICAgIHVpbnQ2NF90IGNh bGxiYWNrSUQgPSBtX2NhbGxiYWNrcy5wdXQoV1RGOjptb3ZlKGNhbGxiYWNrRnVuY3Rpb24pLCBz dGQ6Om1ha2VfdW5pcXVlPFByb2Nlc3NUaHJvdHRsZXI6OkJhY2tncm91bmRBY3Rpdml0eVRva2Vu PihtX3Byb2Nlc3MtPnRocm90dGxlcigpKSk7CisgICAgbV9wcm9jZXNzLT5zZW5kKE1lc3NhZ2Vz OjpXZWJQYWdlOjpNb3ZlU2VsZWN0aW9uQnlPZmZzZXQob2Zmc2V0LCBjYWxsYmFja0lEKSwgbV9w YWdlSUQpOworfQorCiB2b2lkIFdlYlBhZ2VQcm94eTo6aW50ZXJwcmV0S2V5RXZlbnQoY29uc3Qg RWRpdG9yU3RhdGUmIHN0YXRlLCBib29sIGlzQ2hhckV2ZW50LCBib29sJiBoYW5kbGVkKQogewog ICAgIG1fZWRpdG9yU3RhdGUgPSBzdGF0ZTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9XZWJQYWdlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaAkocmV2aXNpb24gMTcxNjUwKQorKysgU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaAkod29ya2luZyBjb3B5KQpAQCAtNDg1LDYg KzQ4NSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHNlbGVjdFdpdGhUd29Ub3VjaGVzKGNvbnN0IFdl YkNvcmU6OkludFBvaW50JiBmcm9tLCBjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYgdG8sIHVpbnQz Ml90IGdlc3R1cmVUeXBlLCB1aW50MzJfdCBnZXN0dXJlU3RhdGUsIHVpbnQ2NF90IGNhbGxiYWNr SUQpOwogICAgIHZvaWQgZXh0ZW5kU2VsZWN0aW9uKHVpbnQzMl90IGdyYW51bGFyaXR5KTsKICAg ICB2b2lkIHNlbGVjdFdvcmRCYWNrd2FyZCgpOworICAgIHZvaWQgbW92ZVNlbGVjdGlvbkJ5T2Zm c2V0KGludDMyX3Qgb2Zmc2V0LCB1aW50NjRfdCBjYWxsYmFja0lEKTsKICAgICB2b2lkIGVsZW1l bnREaWRGb2N1cyhXZWJDb3JlOjpOb2RlKik7CiAgICAgdm9pZCBlbGVtZW50RGlkQmx1cihXZWJD b3JlOjpOb2RlKik7CiAgICAgdm9pZCByZXF1ZXN0RGljdGF0aW9uQ29udGV4dCh1aW50NjRfdCBj YWxsYmFja0lEKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQ YWdlLm1lc3NhZ2VzLmluCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9XZWJQYWdlLm1lc3NhZ2VzLmluCShyZXZpc2lvbiAxNzE2NTApCisrKyBTb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5tZXNzYWdlcy5pbgkod29ya2luZyBj b3B5KQpAQCAtNjQsNiArNjQsNyBAQCBtZXNzYWdlcyAtPiBXZWJQYWdlIExlZ2FjeVJlY2VpdmVy IHsKICAgICBTZWxlY3RXaXRoVHdvVG91Y2hlcyhXZWJDb3JlOjpJbnRQb2ludCBmcm9tLCBXZWJD b3JlOjpJbnRQb2ludCB0bywgdWludDMyX3QgZ2VzdHVyZVR5cGUsIHVpbnQzMl90IGdlc3R1cmVT dGF0ZSwgdWludDY0X3QgY2FsbGJhY2tJRCkKICAgICBFeHRlbmRTZWxlY3Rpb24odWludDMyX3Qg Z3JhbnVsYXJpdHkpCiAgICAgU2VsZWN0V29yZEJhY2t3YXJkKCkKKyAgICBNb3ZlU2VsZWN0aW9u QnlPZmZzZXQoaW50MzJfdCBvZmZzZXQsIHVpbnQ2NF90IGNhbGxiYWNrSUQpCiAgICAgUmVxdWVz dERpY3RhdGlvbkNvbnRleHQodWludDY0X3QgY2FsbGJhY2tJRCkKICAgICBSZXBsYWNlRGljdGF0 ZWRUZXh0KFN0cmluZyBvbGRUZXh0LCBTdHJpbmcgbmV3VGV4dCkKICAgICBSZXBsYWNlU2VsZWN0 ZWRUZXh0KFN0cmluZyBvbGRUZXh0LCBTdHJpbmcgbmV3VGV4dCkKSW5kZXg6IFNvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0JKHJldmlz aW9uIDE3MTY1MCkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2Vi UGFnZUlPUy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTUzMiw2ICsxNTMyLDI1IEBAIHZvaWQgV2Vi UGFnZTo6c2VsZWN0V29yZEJhY2t3YXJkKCkKICAgICAgICAgZnJhbWUuc2VsZWN0aW9uKCkuc2V0 U2VsZWN0ZWRSYW5nZShSYW5nZTo6Y3JlYXRlKCpmcmFtZS5kb2N1bWVudCgpLCBzdGFydFBvc2l0 aW9uLCBwb3NpdGlvbikuZ2V0KCksIHBvc2l0aW9uLmFmZmluaXR5KCksIHRydWUpOwogfQogCit2 b2lkIFdlYlBhZ2U6Om1vdmVTZWxlY3Rpb25CeU9mZnNldChpbnQzMl90IG9mZnNldCwgdWludDY0 X3QgY2FsbGJhY2tJRCkKK3sKKyAgICBGcmFtZSYgZnJhbWUgPSBtX3BhZ2UtPmZvY3VzQ29udHJv bGxlcigpLmZvY3VzZWRPck1haW5GcmFtZSgpOworICAgIAorICAgIFZpc2libGVQb3NpdGlvbiBz dGFydFBvc2l0aW9uID0gZnJhbWUuc2VsZWN0aW9uKCkuc2VsZWN0aW9uKCkuZW5kKCk7CisgICAg aWYgKHN0YXJ0UG9zaXRpb24uaXNOdWxsKCkpCisgICAgICAgIHJldHVybjsKKyAgICBTZWxlY3Rp b25EaXJlY3Rpb24gZGlyZWN0aW9uID0gb2Zmc2V0IDwgMCA/IERpcmVjdGlvbkJhY2t3YXJkIDog RGlyZWN0aW9uRm9yd2FyZDsKKyAgICBWaXNpYmxlUG9zaXRpb24gcG9zaXRpb24gPSBzdGFydFBv c2l0aW9uOworICAgIGZvciAoaW50IGkgPSAwOyBpIDwgYWJzKG9mZnNldCk7ICsraSkgeworICAg ICAgICBwb3NpdGlvbiA9IHBvc2l0aW9uT2ZOZXh0Qm91bmRhcnlPZkdyYW51bGFyaXR5KHBvc2l0 aW9uLCBDaGFyYWN0ZXJHcmFudWxhcml0eSwgZGlyZWN0aW9uKTsKKyAgICAgICAgaWYgKHBvc2l0 aW9uLmlzTnVsbCgpKQorICAgICAgICAgICAgYnJlYWs7CisgICAgfQorICAgIGlmIChwb3NpdGlv bi5pc05vdE51bGwoKSAmJiBzdGFydFBvc2l0aW9uICE9IHBvc2l0aW9uKQorICAgICAgICBmcmFt ZS5zZWxlY3Rpb24oKS5zZXRTZWxlY3RlZFJhbmdlKFJhbmdlOjpjcmVhdGUoKmZyYW1lLmRvY3Vt ZW50KCksIHBvc2l0aW9uLCBwb3NpdGlvbikuZ2V0KCksIHBvc2l0aW9uLmFmZmluaXR5KCksIHRy dWUpOworICAgIHNlbmQoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6Vm9pZENhbGxiYWNrKGNhbGxi YWNrSUQpKTsKK30KKwogdm9pZCBXZWJQYWdlOjpjb252ZXJ0U2VsZWN0aW9uUmVjdHNUb1Jvb3RW aWV3KEZyYW1lVmlldyogdmlldywgVmVjdG9yPFNlbGVjdGlvblJlY3Q+JiBzZWxlY3Rpb25SZWN0 cykKIHsKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHNlbGVjdGlvblJlY3RzLnNpemUoKTsg KytpKSB7Cg==