135304 2014-07-25 14:34:54 -0700 [iOS] REGRESSION(r171526): Images fail to load sometimes in Apple Store app 2014-07-26 16:04:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psolanki psolanki darin psolanki oldest_to_newest 1024919 0 psolanki 2014-07-25 14:34:54 -0700 [iOS] REGRESSION(r171526): Images fail to load sometimes 1024922 1 235545 psolanki 2014-07-25 14:37:53 -0700 Created attachment 235545 Patch 1024925 2 235545 ap 2014-07-25 14:46:27 -0700 Comment on attachment 235545 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235545&action=review > Source/WebCore/ChangeLog:15 > + No new tests because no functional changes. This doesn't seem like an accurate description - the fix is supposed to make it so that images always load. 1024928 3 psolanki 2014-07-25 14:53:51 -0700 Committed r171619: <http://trac.webkit.org/changeset/171619> 1024992 4 darin 2014-07-25 21:48:08 -0700 Check-in comment says this is “covered by existing tests”, but clearly that’s wrong. Was there a test failing when this was broken? 1025014 5 psolanki 2014-07-26 07:34:18 -0700 (In reply to comment #4) > Check-in comment says this is “covered by existing tests”, but clearly that’s wrong. Was there a test failing when this was broken? A number of layout tests in fast/images fail without this change. They only fail in WK1 since WK2 with network process does not go through this code path (if you disable network process you will likely hit this in WK2 as well). This is why I didn't see this bug during my original testing of r171526 and which is why this showed up as broken images in Apple Store app. Any image that we get in a single CFDataRef from CFNetwork will fail to load. This includes images that are disk cache file backed. 1025040 6 darin 2014-07-26 16:04:28 -0700 (In reply to comment #5) > A number of layout tests in fast/images fail without this change. OK. Thanks. I didn’t know that. 235545 2014-07-25 14:37:53 -0700 2014-07-25 14:46:26 -0700 Patch bug-135304-20140725143738.patch text/plain 1954 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxNjAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmI0YTM5NTk2MDNmYTY2 MTkxZTc4MGYwMmU3ZDdlMWViMTMzY2JiMi4uMGYwMzA3ZTNlZGRiODJhMjE2N2MyOTJiY2IwYzIw ZjA5MWE2Y2EzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTA3LTI1ICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBSRUdSRVNT SU9OKHIxNzE1MjYpOiBJbWFnZXMgZmFpbCB0byBsb2FkIHNvbWV0aW1lcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1MzA0CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8xNzgxMTkyMj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTaGFyZWRCdWZmZXI6OmNyZWF0ZUNGRGF0YSgpIGNhbGxzIGRhdGEoKSBh cyBhIHdheSB0byBjb2FsZXNjZSB0aGUgZGF0YSBhcnJheSBlbGVtZW50cyBhbmQKKyAgICAgICAg c2VnbWVudHMgaW50byBtX2J1ZmZlci4gSG93ZXZlciwgZGF0YSgpIGhhcyBhbiBvcHRpbWl6YXRp b24gd2hlcmUgaWYgd2UgaGFkIGEgc2luZ2xlIGVsZW1lbnQKKyAgICAgICAgaW4gdGhlIGRhdGEg YXJyYXksIGl0IHdvdWxkIGp1c3QgcmV0dXJuIHRoYXQgYW5kIG5vdCBkbyBjb2FsZXNjaW5nLiBC cmluZyB0aGF0IG9wdGltaXphdGlvbgorICAgICAgICB0byBjcmVhdGVDRkRhdGEoKSBhbmQgcmV0 dXJuIHRoZSBDRkRhdGFSZWYgZnJvbSB0aGUgZGF0YSBhcnJheSBpZiB3ZSBqdXN0IGhhdmUgYSBz aW5nbGUKKyAgICAgICAgZWxlbWVudC4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSBu byBmdW5jdGlvbmFsIGNoYW5nZXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvU2hhcmVkQnVm ZmVyTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6U2hhcmVkQnVmZmVyOjpjcmVhdGVDRkRhdGEp OgorCiAyMDE0LTA3LTI1ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAg ICAgUmVzb3VyY2VFcnJvckJhc2U6OmNvbXBhcmUgZG9lc27igJl0IGNhbGwgdGhlIHJpZ2h0IHBs YXRmb3JtQ29tcGFyZSBvdmVycmlkZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWFjL1NoYXJlZEJ1ZmZlck1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9T aGFyZWRCdWZmZXJNYWMubW0KaW5kZXggZjZlN2FlYWZiYTJmYTU5MmQyMWJjYTZiZDczY2NmM2Ey ZWI0OGNjYy4uOGM1MDFkNTliYWJmZjVlODdhZmE1MzRmNmMxZmVmNzNhYTlkZjk0NiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1NoYXJlZEJ1ZmZlck1hYy5tbQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2hhcmVkQnVmZmVyTWFjLm1tCkBAIC0xMDUs NiArMTA1LDExIEBAIFJldGFpblB0cjxDRkRhdGFSZWY+IFNoYXJlZEJ1ZmZlcjo6Y3JlYXRlQ0ZE YXRhKCkKICAgICBpZiAobV9jZkRhdGEpCiAgICAgICAgIHJldHVybiBtX2NmRGF0YTsKIAorI2lm IFVTRShORVRXT1JLX0NGREFUQV9BUlJBWV9DQUxMQkFDSykKKyAgICBpZiAobV9kYXRhQXJyYXku c2l6ZSgpID09IDEpCisgICAgICAgIHJldHVybiBtX2RhdGFBcnJheS5hdCgwKTsKKyNlbmRpZgor CiAgICAgZGF0YSgpOyAvLyBGb3JjZSBkYXRhIGludG8gbV9idWZmZXIgZnJvbSBzZWdtZW50cyBv ciBkYXRhIGFycmF5LgogICAgIGlmIChoYXNQdXJnZWFibGVCdWZmZXIoKSkgewogICAgICAgICBS ZWZQdHI8U2hhcmVkQnVmZmVyOjpEYXRhQnVmZmVyPiBjb3BpZWRCdWZmZXIgPSBhZG9wdFJlZihu ZXcgRGF0YUJ1ZmZlcik7Cg==