135288 2014-07-25 08:21:21 -0700 [GTK] CMake tries to install JavaScriptCore-3.0.gir outside of install prefix 2014-08-14 02:01:13 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mcatanzaro webkit-unassigned bunhere commit-queue gyuyoung.kim mrobinson rakuco sergio oldest_to_newest 1024822 0 mcatanzaro 2014-07-25 08:21:21 -0700 I'm trying to install WebKit into an install prefix in my home directory, calling CMake manually rather than with the build-webkit script: cmake /home/mcatanzaro/WebKit -DPORT=GTK -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/home/mcatanzaro/jhbuild/install -DLIB_INSTALL_DIR=/home/mcatanzaro/jhbuild/install/lib -GNinja But CMAKE_INSTALL_PREFIX is not respected when installing JavaScriptCore-3.0.gir; it's unconditionally installed into /usr/share because FindGObjectIntrospection.cmake uses pkgconfig to decide where to install to, and that's what pkgconfig says to do: # /usr/lib64/pkgconfig/gobject-introspection-1.0.pc datadir=/usr/share ... girdir=${datadir}/gir-1.0 FindGObjectIntrospection.cmake tries to define the prefix variable, but it's not actually used by gobject-introspection-1.0.pc since $datadir was set to /usr/share by my distro (Fedora) at configure time (I think all RPM-based distros will do this). So this can never work. The upcoming patch fixes this error from the user's perspective, but makes FindGObjectIntrospection.cmake depend on variables set in OptionsGTK.cmake, which I'm worried is probably evil. I don't know what else to do, though. 1024823 1 235520 mcatanzaro 2014-07-25 08:29:28 -0700 Created attachment 235520 Patch 1024830 2 235520 mrobinson 2014-07-25 08:43:28 -0700 Comment on attachment 235520 Patch Seems entirely reasonable 1024839 3 235520 commit-queue 2014-07-25 09:18:37 -0700 Comment on attachment 235520 Patch Clearing flags on attachment: 235520 Committed r171598: <http://trac.webkit.org/changeset/171598> 1024840 4 commit-queue 2014-07-25 09:18:40 -0700 All reviewed patches have been landed. Closing bug. 1029051 5 235520 cgarcia 2014-08-14 02:01:13 -0700 Comment on attachment 235520 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235520&action=review > Source/cmake/FindGObjectIntrospection.cmake:48 > - _gir_get_pkgconfig_var(INTROSPECTION_INSTALL_GIRDIR "girdir" "--define-variable=prefix=${CMAKE_INSTALL_PREFIX}") > - _gir_get_pkgconfig_var(INTROSPECTION_INSTALL_TYPELIBDIR "typelibdir" "--define-variable=prefix=${CMAKE_INSTALL_PREFIX}") > + _gir_get_pkgconfig_var(INTROSPECTION_INSTALL_GIRDIR "girdir" "--define-variable=datadir=${DATA_INSTALL_DIR}") > + _gir_get_pkgconfig_var(INTROSPECTION_INSTALL_TYPELIBDIR "typelibdir" "--define-variable=libdir=${LIB_INSTALL_DIR}") This is indeed wrong, we want to install the introspection stuff in the standard location together with the other gir and typelibs. DATA_INSTALL_DIR is also versioned, but gir and typelibs doesn't need to be installe din a versioned directory because their filenames already contain the binary version. But the previous code was not correct in my opinion either. We need to get the introspection tools from the pkg-configl file because they might not be in the path, we definitely don't want to get the girdir and typelibdir from the pkg-config file, because that would mean that if I'm using gobject-instrospection from my distro, but building in muy jhbuild, we would end up trying to install introspection files to /usr. I guess this bug was about that. In autotools we defined both dirs unconditionally depending on $datadir and $libdir. 235520 2014-07-25 08:29:28 -0700 2014-08-14 02:01:13 -0700 Patch bug-135288-20140725102913.patch text/plain 4809 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxNTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZEdPYmplY3RJbnRyb3NwZWN0aW9uLmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRHT2JqZWN0SW50 cm9zcGVjdGlvbi5jbWFrZQppbmRleCAwOGVjN2IzMGEwYmZkYjA1MTA5NWI4OGUxMzMxZTBlM2M5 MzFlZmZlLi4wZmI4NWYwMTg5NTliZjEwODBlYTlmNzcxNjhkZmZiODc3Njk1YzIwIDEwMDY0NAot LS0gYS9Tb3VyY2UvY21ha2UvRmluZEdPYmplY3RJbnRyb3NwZWN0aW9uLmNtYWtlCisrKyBiL1Nv dXJjZS9jbWFrZS9GaW5kR09iamVjdEludHJvc3BlY3Rpb24uY21ha2UKQEAgLTExLDYgKzExLDcg QEAKICMgIElOVFJPU1BFQ1RJT05fTElCUwogIwogIyBDb3B5cmlnaHQgKEMpIDIwMTAsIFBpbm8g VG9zY2FubywgPHBpbm9Aa2RlLm9yZz4KKyMgQ29weXJpZ2h0IChDKSAyMDE0IElnYWxpYSBTLkwu CiAjCiAjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaXMgYWxsb3dlZCBhY2NvcmRpbmcgdG8gdGhl IHRlcm1zIG9mIHRoZSBCU0QgbGljZW5zZS4KIApAQCAtNDMsOCArNDQsOCBAQCBpZiAoUEtHX0NP TkZJR19GT1VORCkKICAgICAgICAgX2dpcl9nZXRfcGtnY29uZmlnX3ZhcihJTlRST1NQRUNUSU9O X0dFTkVSQVRFICJnX2lyX2dlbmVyYXRlIiAiIikKICAgICAgICAgX2dpcl9nZXRfcGtnY29uZmln X3ZhcihJTlRST1NQRUNUSU9OX0dJUkRJUiAiZ2lyZGlyIiAiIikKICAgICAgICAgX2dpcl9nZXRf cGtnY29uZmlnX3ZhcihJTlRST1NQRUNUSU9OX1RZUEVMSUJESVIgInR5cGVsaWJkaXIiICIiKQot ICAgICAgICBfZ2lyX2dldF9wa2djb25maWdfdmFyKElOVFJPU1BFQ1RJT05fSU5TVEFMTF9HSVJE SVIgImdpcmRpciIgIi0tZGVmaW5lLXZhcmlhYmxlPXByZWZpeD0ke0NNQUtFX0lOU1RBTExfUFJF RklYfSIpCi0gICAgICAgIF9naXJfZ2V0X3BrZ2NvbmZpZ192YXIoSU5UUk9TUEVDVElPTl9JTlNU QUxMX1RZUEVMSUJESVIgInR5cGVsaWJkaXIiICItLWRlZmluZS12YXJpYWJsZT1wcmVmaXg9JHtD TUFLRV9JTlNUQUxMX1BSRUZJWH0iKQorICAgICAgICBfZ2lyX2dldF9wa2djb25maWdfdmFyKElO VFJPU1BFQ1RJT05fSU5TVEFMTF9HSVJESVIgImdpcmRpciIgIi0tZGVmaW5lLXZhcmlhYmxlPWRh dGFkaXI9JHtEQVRBX0lOU1RBTExfRElSfSIpCisgICAgICAgIF9naXJfZ2V0X3BrZ2NvbmZpZ192 YXIoSU5UUk9TUEVDVElPTl9JTlNUQUxMX1RZUEVMSUJESVIgInR5cGVsaWJkaXIiICItLWRlZmlu ZS12YXJpYWJsZT1saWJkaXI9JHtMSUJfSU5TVEFMTF9ESVJ9IikKICAgICAgICAgc2V0KElOVFJP U1BFQ1RJT05fQ0ZMQUdTICIke19wY19naXJfQ0ZMQUdTfSIpCiAgICAgICAgIHNldChJTlRST1NQ RUNUSU9OX0xJQlMgIiR7X3BjX2dpcl9MSUJTfSIpCiAgICAgZW5kaWYgKCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsu Y21ha2UKaW5kZXggMmY3ZmEyZDFjYjcwN2ViN2QwNDJkYjZhZWE2NjdkZGEzNTIxMjc4ZS4uMTkw YWFlNjhkZTE2NjI4NjUyN2E0MzliNDExY2NlNThhNzJmYjU2NyAxMDA2NDQKLS0tIGEvU291cmNl L2NtYWtlL09wdGlvbnNHVEsuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21h a2UKQEAgLTE2LDYgKzE2LDE2IEBAIHNldChFTkFCTEVfR1RLRE9DIE9GRiBDQUNIRSBCT09MICJX aGV0aGVyIG9yIG5vdCB0byB1c2UgZ2VuZXJhdGUgZ3RrZG9jLiIpCiBzZXQoRU5BQkxFX1gxMV9U QVJHRVQgT04gQ0FDSEUgQk9PTCAiV2hldGhlciB0byBlbmFibGUgc3VwcG9ydCBmb3IgdGhlIFgx MSB3aW5kb3dpbmcgdGFyZ2V0LiIpCiBzZXQoRU5BQkxFX1dBWUxBTkRfVEFSR0VUIE9GRiBDQUNI RSBCT09MICJXaGV0aGVyIHRvIGVuYWJsZSBzdXBwb3J0IGZvciB0aGUgV2F5bGFuZCB3aW5kb3dp bmcgdGFyZ2V0LiIpCiAKKyMgVGhlc2UgYXJlIHNoYXJlZCB2YXJpYWJsZXMsIGJ1dCB3ZSBzcGVj aWFsIGNhc2UgdGhlaXIgZGVmaW5pdGlvbiBzbyB0aGF0IHdlIGNhbiB1c2UgdGhlCisjIENNQUtF X0lOU1RBTExfKiB2YXJpYWJsZXMgdGhhdCBhcmUgcG9wdWxhdGVkIGJ5IHRoZSBHTlVJbnN0YWxs RGlycyBtYWNyby4KK3NldChMSUJfSU5TVEFMTF9ESVIgIiR7Q01BS0VfSU5TVEFMTF9GVUxMX0xJ QkRJUn0iIENBQ0hFIFBBVEggIkFic29sdXRlIHBhdGggdG8gbGlicmFyeSBpbnN0YWxsYXRpb24g ZGlyZWN0b3J5IikKK3NldChFWEVDX0lOU1RBTExfRElSICIke0NNQUtFX0lOU1RBTExfRlVMTF9C SU5ESVJ9IiBDQUNIRSBQQVRIICJBYnNvbHV0ZSBwYXRoIHRvIGV4ZWN1dGFibGUgaW5zdGFsbGF0 aW9uIGRpcmVjdG9yeSIpCitzZXQoTElCRVhFQ19JTlNUQUxMX0RJUiAiJHtDTUFLRV9JTlNUQUxM X0ZVTExfTElCRVhFQ0RJUn0iIENBQ0hFIFBBVEggIkFic29sdXRlIHBhdGggdG8gaW5zdGFsbCBl eGVjdXRhYmxlcyBleGVjdXRlZCBieSB0aGUgbGlicmFyeSIpCisKK3NldChEQVRBX0JVSUxEX0RJ UiAiJHtDTUFLRV9CSU5BUllfRElSfS9zaGFyZS8ke1dlYktpdF9PVVRQVVRfTkFNRX0iKQorc2V0 KERBVEFfSU5TVEFMTF9ESVIgIiR7Q01BS0VfSU5TVEFMTF9EQVRBRElSfS93ZWJraXRndGstJHtX RUJLSVRHVEtfQVBJX1ZFUlNJT059IikKK3NldChXRUJLSVRHVEtfSEVBREVSX0lOU1RBTExfRElS ICIke0NNQUtFX0lOU1RBTExfSU5DTFVERURJUn0vd2Via2l0Z3RrLSR7V0VCS0lUR1RLX0FQSV9W RVJTSU9OfSIpCisKIGZpbmRfcGFja2FnZShDYWlybyAxLjEwLjIgUkVRVUlSRUQpCiBmaW5kX3Bh Y2thZ2UoRm9udGNvbmZpZyAyLjguMCBSRVFVSVJFRCkKIGZpbmRfcGFja2FnZShGcmVldHlwZTIg Mi40LjIgUkVRVUlSRUQpCkBAIC0xNzMsMTYgKzE4Myw2IEBAIHNldChXZWJLaXQyX1dlYlByb2Nl c3NfT1VUUFVUX05BTUUgV2ViS2l0V2ViUHJvY2VzcykKIHNldChXZWJLaXQyX05ldHdvcmtQcm9j ZXNzX09VVFBVVF9OQU1FIFdlYktpdE5ldHdvcmtQcm9jZXNzKQogc2V0KFdlYktpdDJfUGx1Z2lu UHJvY2Vzc19PVVRQVVRfTkFNRSBXZWJLaXRQbHVnaW5Qcm9jZXNzKQogCi0jIFRoZXNlIGFyZSBz aGFyZWQgdmFyaWFibGVzLCBidXQgd2Ugc3BlY2lhbCBjYXNlIHRoZWlyIGRlZmluaXRpb24gc28g dGhhdCB3ZSBjYW4gdXNlIHRoZQotIyBDTUFLRV9JTlNUQUxMXyogdmFyaWFibGVzIHRoYXQgYXJl IHBvcHVsYXRlZCBieSB0aGUgR05VSW5zdGFsbERpcnMgbWFjcm8uCi1zZXQoTElCX0lOU1RBTExf RElSICIke0NNQUtFX0lOU1RBTExfRlVMTF9MSUJESVJ9IiBDQUNIRSBQQVRIICJBYnNvbHV0ZSBw YXRoIHRvIGxpYnJhcnkgaW5zdGFsbGF0aW9uIGRpcmVjdG9yeSIpCi1zZXQoRVhFQ19JTlNUQUxM X0RJUiAiJHtDTUFLRV9JTlNUQUxMX0ZVTExfQklORElSfSIgQ0FDSEUgUEFUSCAiQWJzb2x1dGUg cGF0aCB0byBleGVjdXRhYmxlIGluc3RhbGxhdGlvbiBkaXJlY3RvcnkiKQotc2V0KExJQkVYRUNf SU5TVEFMTF9ESVIgIiR7Q01BS0VfSU5TVEFMTF9GVUxMX0xJQkVYRUNESVJ9IiBDQUNIRSBQQVRI ICJBYnNvbHV0ZSBwYXRoIHRvIGluc3RhbGwgZXhlY3V0YWJsZXMgZXhlY3V0ZWQgYnkgdGhlIGxp YnJhcnkiKQotCi1zZXQoREFUQV9CVUlMRF9ESVIgIiR7Q01BS0VfQklOQVJZX0RJUn0vc2hhcmUv JHtXZWJLaXRfT1VUUFVUX05BTUV9IikKLXNldChEQVRBX0lOU1RBTExfRElSICIke0NNQUtFX0lO U1RBTExfREFUQURJUn0vd2Via2l0Z3RrLSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfSIpCi1zZXQo V0VCS0lUR1RLX0hFQURFUl9JTlNUQUxMX0RJUiAiJHtDTUFLRV9JTlNUQUxMX0lOQ0xVREVESVJ9 L3dlYmtpdGd0ay0ke1dFQktJVEdUS19BUElfVkVSU0lPTn0iKQotCiBhZGRfZGVmaW5pdGlvbnMo LURCVUlMRElOR19HVEtfXz0xKQogYWRkX2RlZmluaXRpb25zKC1ER0VUVEVYVF9QQUNLQUdFPSJX ZWJLaXQyR1RLLSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfSIpCiBhZGRfZGVmaW5pdGlvbnMoLURE QVRBX0RJUj0iJHtDTUFLRV9JTlNUQUxMX0RBVEFESVJ9IikKZGlmZiAtLWdpdCBhL0NoYW5nZUxv ZyBiL0NoYW5nZUxvZwppbmRleCAxODgyNWM5NWIyNjNmMGY3ZDhmMDQ4YWQyZjVmNTdlNmUxZjdm Y2JjLi5iZmQyMjA1NmMzMjc0OWNjOWQ3MzM4Zjk2MWQ3NDBlYTFjMzhjMmY5IDEwMDY0NAotLS0g YS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDctMjUg IE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtH VEtdIENNYWtlIHRyaWVzIHRvIGluc3RhbGwgSmF2YVNjcmlwdENvcmUtMy4wLmdpciBvdXRzaWRl IG9mIGluc3RhbGwgcHJlZml4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzUyODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFNvdXJjZS9jbWFrZS9GaW5kR09iamVjdEludHJvc3BlY3Rpb24uY21ha2U6 IHBhc3MgY29ycmVjdCBsaWJkaXIgYW5kCisgICAgICAgIGRhdGFkaXIgdG8gcGtnY29uZmlnCisg ICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6IGRlZmluZSBpbnN0YWxsIGRp cmVjdG9yaWVzIGVhcmx5CisgICAgICAgIGVub3VnaCB0byBiZSB1c2VkIGluIEZpbmRHT2JqZWN0 SW50cm9zcGVjdGlvbi5jbWFrZQorCiAyMDE0LTA3LTIzICBCZW0gSm9uZXMtQmV5ICA8YmpvbmVz YmVAYWRvYmUuY29tPgogCiAgICAgICAgIFJlbW92ZSBDU1NfRVhDTFVTSU9OUyBjb21waWxlIGZs YWcgYW5kIGxlZnRvdmVyIGNvZGUK