135278 2014-07-24 18:50:04 -0700 REGRESSION(r164401): Placing a caret doesn't bring up autocorrection panel 2014-07-24 21:51:31 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa darin ddavidso enrica oldest_to_newest 1024733 0 rniwa 2014-07-24 18:50:04 -0700 REGRESSION(r164401): Placing a caret doesn't bring up autocorrection panel 1024737 1 235488 rniwa 2014-07-24 18:55:54 -0700 Created attachment 235488 Fixes the bug 1024738 2 rniwa 2014-07-24 18:56:29 -0700 <rdar://problem/17748416> 1024763 3 235488 thorton 2014-07-24 20:08:01 -0700 Comment on attachment 235488 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=235488&action=review > Source/WebCore/ChangeLog:9 > + triggred by ditaction instead of only if it was NOT triggred by dictation. sp.: triggered > Source/WebCore/ChangeLog:13 > + options around but the boolean logic was erroneously. erroneously what? maybe just "erroneous" 1024784 4 rniwa 2014-07-24 21:51:31 -0700 Committed r171580: <http://trac.webkit.org/changeset/171580> 235488 2014-07-24 18:55:54 -0700 2014-07-24 20:08:01 -0700 Fixes the bug bug-135278-20140724185539.patch text/plain 2096 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTU3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA3LTI0ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE2NDQwMSk6 IFBsYWNpbmcgYSBjYXJldCBkb2Vzbid0IGJyaW5nIHVwIGF1dG9jb3JyZWN0aW9uIHBhbmVsCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzUyNzgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYnVnIHdh cyBjYXVzZWQgYnkgZWRpdG9yVUlVcGRhdGVUaW1lckZpcmVkIGNhbGxpbmcgcmVzcG9uZFRvQ2hh bmdlZFNlbGVjdGlvbiBvbmx5IGlmIHRoZSBzZWxlY3Rpb24gd2FzCisgICAgICAgIHRyaWdncmVk IGJ5IGRpdGFjdGlvbiBpbnN0ZWFkIG9mIG9ubHkgaWYgaXQgd2FzIE5PVCB0cmlnZ3JlZCBieSBk aWN0YXRpb24uCisKKyAgICAgICAgUHJpb3IgdG8gcjE2NDQwMSwgQWx0ZXJuYXRpdmVUZXh0Q29u dHJvbGxlcjo6cmVzcG9uZFRvTWFya2VyQXRFbmRPZldvcmQgZXhpdGVkIGVhcmx5IHdoZW4gU2V0 U2VsZWN0aW9uT3B0aW9ucworICAgICAgICBoYWQgRGljdGF0aW9uVHJpZ2dlcmVkIHNldC4gcjE2 NDQwMSBpbnRlbmRlZCB0byBtb3ZlIHRoaXMgY2hlY2sgdG8gZWRpdG9yVUlVcGRhdGVUaW1lckZp cmVkIHRvIGF2b2lkIHBhc3NpbmcKKyAgICAgICAgb3B0aW9ucyBhcm91bmQgYnV0IHRoZSBib29s ZWFuIGxvZ2ljIHdhcyBlcnJvbmVvdXNseS4KKworICAgICAgICBGaXhlZCB0aGUgYnVnIGJ5IG5l Z2F0aW5nIHRoZSBjb25kaXRpb24gaW4gZWRpdG9yVUlVcGRhdGVUaW1lckZpcmVkLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cyBmb3Igbm93IHNpbmNlIGF1dG9jb3JyZWN0aW9uIHBhbmVsIGNhbm5v dCBiZSB0ZXN0ZWQgYXV0b21hdGljYWxseS4gKFdlIHNob3VsZCByZWFsbHkgYXV0b21hdGUgdGhp cyEpCisKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpF ZGl0b3I6OmVkaXRvclVJVXBkYXRlVGltZXJGaXJlZCk6CisKIDIwMTQtMDctMjQgIERhbiBCZXJu c3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJDb3JlIHBhcnQgb2YgPHJkYXI6 Ly9wcm9ibGVtLzE3NTkzNzAxPiBBc3NlcnRpb24gZmFpbHVyZSBpbiBXZWJQYWdlOjpyZWxvYWQg KCFtX3BlbmRpbmdOYXZpZ2F0aW9uSUQpIHdoZW4gcmVsb2FkaW5nIGFmdGVyIGEgc2FtZS1kb2N1 bWVudCBiYWNrIG5hdmlnYXRpb24KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9y LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAJKHJl dmlzaW9uIDE3MTU2MykKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMzUyNiw3ICszNTI2LDcgQEAgdm9pZCBFZGl0b3I6OmVkaXRvclVJVXBk YXRlVGltZXJGaXJlZChUaQogI2lmIEVOQUJMRShERUxFVElPTl9VSSkKICAgICBtX2RlbGV0ZUJ1 dHRvbkNvbnRyb2xsZXItPnJlc3BvbmRUb0NoYW5nZWRTZWxlY3Rpb24ob2xkU2VsZWN0aW9uKTsK ICNlbmRpZgotICAgIGlmIChtX2VkaXRvclVJVXBkYXRlVGltZXJXYXNUcmlnZ2VyZWRCeURpY3Rh dGlvbikKKyAgICBpZiAoIW1fZWRpdG9yVUlVcGRhdGVUaW1lcldhc1RyaWdnZXJlZEJ5RGljdGF0 aW9uKQogICAgICAgICBtX2FsdGVybmF0aXZlVGV4dENvbnRyb2xsZXItPnJlc3BvbmRUb0NoYW5n ZWRTZWxlY3Rpb24ob2xkU2VsZWN0aW9uKTsKIAogICAgIG1fb2xkU2VsZWN0aW9uRm9yRWRpdG9y VUlVcGRhdGUgPSBtX2ZyYW1lLnNlbGVjdGlvbigpLnNlbGVjdGlvbigpOwo=