135277 2014-07-24 18:44:47 -0700 [iOS][WK2] Do not try to hit test a null mainFrameRenderView on dynamicViewportSizeUpdate() 2014-07-24 20:01:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 1024731 0 benjamin 2014-07-24 18:44:47 -0700 [iOS][WK2] Do not try to hit test a null mainFrameRenderView on dynamicViewportSizeUpdate() 1024734 1 235487 benjamin 2014-07-24 18:52:14 -0700 Created attachment 235487 Patch 1024736 2 235487 thorton 2014-07-24 18:55:29 -0700 Comment on attachment 235487 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235487&action=review > Source/WebKit2/ChangeLog:11 > + There is no guarantee that the main frame have its root layer when performing a dynamicViewportSizeUpdate(), s/have/has/ should "layer" be "view"? > Source/WebKit2/ChangeLog:18 > + When the hit test is not done, the position restored become a relative in the content size. the end of this sentence is grammatically wrong but I'm not sure the best way to fix it and it's not important :D 1024757 3 benjamin 2014-07-24 20:01:29 -0700 Committed r171576: <http://trac.webkit.org/changeset/171576> 235487 2014-07-24 18:52:14 -0700 2014-07-24 18:55:29 -0700 Patch bug-135277-20140724185111.patch text/plain 2828 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxNTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2E3YWUzOTE5Mzg1NThm NTMyNDBmZTZmMGEwMDlmODk2Y2QzYjkxZC4uMmU1Y2FmN2VjOTc3MTkyMDVjZGY1YjVhZmU3YmJi ZmQ1NjUwMjFmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTA3LTI0ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdW1dLMl0g RG8gbm90IHRyeSB0byBoaXQgdGVzdCBhIG51bGwgbWFpbkZyYW1lUmVuZGVyVmlldyBvbiBkeW5h bWljVmlld3BvcnRTaXplVXBkYXRlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzNTI3NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTc4MDQ4OTE+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW06CisgICAgICAgIChXZWJLaXQ6OldlYlBh Z2U6OmR5bmFtaWNWaWV3cG9ydFNpemVVcGRhdGUpOgorICAgICAgICBUaGVyZSBpcyBubyBndWFy YW50ZWUgdGhhdCB0aGUgbWFpbiBmcmFtZSBoYXZlIGl0cyByb290IGxheWVyIHdoZW4gcGVyZm9y bWluZyBhIGR5bmFtaWNWaWV3cG9ydFNpemVVcGRhdGUoKSwKKyAgICAgICAgd2Ugc2hvdWxkIG5v dCBhdHRlbXB0IHRvIHVzZSB0aGUgbGF5ZXIgd2l0aG91dCBudWxsIGNoZWNraW5nIGl0IGZpcnN0 LgorCisgICAgICAgIFRoZSBvZGQgcGFydCBmb3IgbWUgaXMgPHJkYXI6Ly9wcm9ibGVtLzE3ODA0 ODkxPiBpcyBhIGxpdHRsZSB0b28gZnJlcXVlbnQuIEluIHRoZSB2YXN0IG1ham9yaXR5IG9mIGNh c2VzLAorICAgICAgICB0aGVyZSBpcyBhIFJlbmRlclZpZXcsIGl0IHNlZW1zIGFjdHVhbGx5IHBy ZXR0eSBoYXJkIG5vdCB0byBoYXZlIG9uZSBvbiBkeW5hbWljVmlld3BvcnRTaXplVXBkYXRlKCku CisKKyAgICAgICAgU2tpcHBpbmcgaGl0IHRlc3RpbmcgaXMgc2FmZSBiZWNhdXNlIGl0IGlzIGEg Y29tcGxldGVseSBvcHRpb25hbCBwYXJ0IG9mIHRoaXMgYWxnb3JpdGhtLgorICAgICAgICBXaGVu IHRoZSBoaXQgdGVzdCBpcyBub3QgZG9uZSwgdGhlIHBvc2l0aW9uIHJlc3RvcmVkIGJlY29tZSBh IHJlbGF0aXZlIGluIHRoZSBjb250ZW50IHNpemUuCisKIDIwMTQtMDctMjQgIEJlbmphbWluIFBv dWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFtXSzJdIEZpeGVkL1N0aWNr eSBsYXllcnMgY2FuIGdldCBtaXNwb3NpdGlvbmVkIHdoZW4gdGhlIGxheWVyIHRyZWUgY29tbWl0 IGNoYW5nZSB0aGVpciBwb3NpdGlvbiBvciBzaXplCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0gYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KaW5kZXggMjY5OGE2NDdkMDI3NTBh OTM1ZDU5ZDQ4NDE1ODYyNWM3OWE2NDJmMC4uNzljNjJkZDk2OTYzNDliMTgyY2E3OTlhNzkwM2Vh Mjc5ZWVhNmNhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L2lvcy9XZWJQYWdlSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9pb3MvV2ViUGFnZUlPUy5tbQpAQCAtMjIxNiwxMSArMjIxNiwxMiBAQCB2b2lkIFdlYlBhZ2U6 OmR5bmFtaWNWaWV3cG9ydFNpemVVcGRhdGUoY29uc3QgRmxvYXRTaXplJiBtaW5pbXVtTGF5b3V0 U2l6ZSwgY29ucwogICAgICAgICB2aXNpYmxlSG9yaXpvbnRhbEZyYWN0aW9uID0gZnJhbWVWaWV3 LnVub2JzY3VyZWRDb250ZW50U2l6ZSgpLndpZHRoKCkgLyBvbGRDb250ZW50U2l6ZS53aWR0aCgp OwogICAgICAgICBJbnRQb2ludCB1bm9ic2N1cmVkQ29udGVudFJlY3RDZW50ZXIgPSBmcmFtZVZp ZXcudW5vYnNjdXJlZENvbnRlbnRSZWN0KCkuY2VudGVyKCk7CiAKLSAgICAgICAgSGl0VGVzdFJl cXVlc3QgcmVxdWVzdChIaXRUZXN0UmVxdWVzdDo6UmVhZE9ubHkgfCBIaXRUZXN0UmVxdWVzdDo6 QWN0aXZlIHwgSGl0VGVzdFJlcXVlc3Q6OkRpc2FsbG93U2hhZG93Q29udGVudCk7CiAgICAgICAg IEhpdFRlc3RSZXN1bHQgaGl0VGVzdFJlc3VsdCA9IEhpdFRlc3RSZXN1bHQodW5vYnNjdXJlZENv bnRlbnRSZWN0Q2VudGVyKTsKIAotICAgICAgICBSZW5kZXJWaWV3KiBtYWluRnJhbWVSZW5kZXJW aWV3ID0gZnJhbWVWaWV3LnJlbmRlclZpZXcoKTsKLSAgICAgICAgbWFpbkZyYW1lUmVuZGVyVmll dy0+aGl0VGVzdChyZXF1ZXN0LCBoaXRUZXN0UmVzdWx0KTsKKyAgICAgICAgaWYgKFJlbmRlclZp ZXcqIG1haW5GcmFtZVJlbmRlclZpZXcgPSBmcmFtZVZpZXcucmVuZGVyVmlldygpKSB7CisgICAg ICAgICAgICBIaXRUZXN0UmVxdWVzdCByZXF1ZXN0KEhpdFRlc3RSZXF1ZXN0OjpSZWFkT25seSB8 IEhpdFRlc3RSZXF1ZXN0OjpBY3RpdmUgfCBIaXRUZXN0UmVxdWVzdDo6RGlzYWxsb3dTaGFkb3dD b250ZW50KTsKKyAgICAgICAgICAgIG1haW5GcmFtZVJlbmRlclZpZXctPmhpdFRlc3QocmVxdWVz dCwgaGl0VGVzdFJlc3VsdCk7CisgICAgICAgIH0KIAogICAgICAgICBpZiAoTm9kZSogbm9kZSA9 IGhpdFRlc3RSZXN1bHQuaW5uZXJOb2RlKCkpIHsKICAgICAgICAgICAgIGlmIChSZW5kZXJPYmpl Y3QqIHJlbmRlcmVyID0gbm9kZS0+cmVuZGVyZXIoKSkgewo=