135270 2014-07-24 16:46:04 -0700 ImageDiff builds for the simulator when running iOS layout tests 2014-07-28 13:00:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) iPhone / iPad All RESOLVED FIXED P2 Normal --- 1 dfarler dfarler dbates ddkilzer simon.fraser oldest_to_newest 1024675 0 dfarler 2014-07-24 16:46:04 -0700 ImageDiff is a host-side tool for comparing image output from layout tests and should only ever run on the host. As it stands, there is no good way to do separate aggregate target members to build against a different SDK in Xcode, so we can provide a tool, build-imagediff, which run-webkit-tests can invoke if necessary and --no-build wasn't passed. 1024699 1 235479 dfarler 2014-07-24 17:23:51 -0700 Created attachment 235479 Patch 1024704 2 235479 simon.fraser 2014-07-24 17:32:05 -0700 Comment on attachment 235479 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235479&action=review > Tools/ChangeLog:3 > + ImageDiff builds for the simulator when running iOS layout tests I think this should say "Build ImageDiff for the simulator"? 1024727 3 dfarler 2014-07-24 18:32:09 -0700 (In reply to comment #2) > (From update of attachment 235479 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235479&action=review > > > Tools/ChangeLog:3 > > + ImageDiff builds for the simulator when running iOS layout tests > > I think this should say "Build ImageDiff for the simulator"? Nope, it already builds for the simulator. The script it a shortcut to build it for the host at all times. Running it in the sim bootstrap is pretty slow and not really necessary. webkitpy will invoke it out of WebKitBuild/Debug. 1025192 4 dfarler 2014-07-28 13:00:00 -0700 Committed r171686: <http://trac.webkit.org/changeset/171686> 235479 2014-07-24 17:23:51 -0700 2014-07-24 17:32:05 -0700 Patch bug-135270-20140724172337.patch text/plain 3299 dfarler U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxNTU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTcyNTA3YWViZmIyMjU2MGEyNDdiYWQ5OWI5OWQyNGM4 Zjk4NTA3NS4uOWY1YjNhOTY4ZGNhZWVlNzllYWQ0ZTQxZWIzMWE1OWNjNTgzZTRkYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE0LTA3LTI0ICBEYXZpZCBGYXJsZXIgIDxkZmFybGVyQGFwcGxlLmNvbT4KKworICAg ICAgICBJbWFnZURpZmYgYnVpbGRzIGZvciB0aGUgc2ltdWxhdG9yIHdoZW4gcnVubmluZyBpT1Mg bGF5b3V0IHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzUyNzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFNjcmlwdHMvYnVpbGQtaW1hZ2VkaWZmOiBBZGRlZC4KKwogMjAxNC0wNy0yNCAgTWlj aGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgR1RLIGpo YnVpbGQgbW9kdWxlcyBuZWVkcyB0byBidWlsZCB4c2VydmVyIHdpdGggLS1kaXNhYmxlLWxvY2Fs LXRyYW5zcG9ydApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9idWlsZC1pbWFnZWRpZmYgYi9U b29scy9TY3JpcHRzL2J1aWxkLWltYWdlZGlmZgpuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43ODBjYjNhOTM0OWM1NjVi MTg3NzVkMjQzODRiNjQzNWE0MzQwYmFjCi0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvU2NyaXB0 cy9idWlsZC1pbWFnZWRpZmYKQEAgLTAsMCArMSw2NyBAQAorIyEvdXNyL2Jpbi9wZXJsIC13CisK KyMgQ29weXJpZ2h0IChDKSAyMDE0IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMK KyMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0 aCBvciB3aXRob3V0CisjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0 IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucworIyBhcmUgbWV0OgorIworIyAxLiAgUmVkaXN0cmli dXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMg ICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlz Y2xhaW1lci4KKyMgMi4gIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJv ZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0CisjICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25k aXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisjICAgICBkb2N1bWVu dGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0 aW9uLgorIyAzLiAgTmVpdGhlciB0aGUgbmFtZSBvZiBBcHBsZSBJbmMuICgiQXBwbGUiKSBub3Ig dGhlIG5hbWVzIG9mCisjICAgICBpdHMgY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9y c2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkCisjICAgICBmcm9tIHRoaXMgc29mdHdhcmUg d2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24uCisjCisjIFRISVMgU09G VFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgQU5EIElUUyBDT05UUklCVVRPUlMgIkFTIElTIiBB TkQgQU5ZCisjIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBO T1QgTElNSVRFRCBUTywgVEhFIElNUExJRUQKKyMgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJ VFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRQorIyBESVNDTEFJTUVE LiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBPUiBJVFMgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBG T1IgQU5ZCisjIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFS WSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTCisjIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRF RCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsKKyMgTE9T UyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9X RVZFUiBDQVVTRUQgQU5ECisjIE9OIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElO IENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisjIChJTkNMVURJTkcgTkVHTElH RU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBPRgor IyBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNV Q0ggREFNQUdFLgorCit1c2Ugc3RyaWN0OwordXNlIEZpbGU6OkJhc2VuYW1lOwordXNlIEZpbmRC aW47Cit1c2UgR2V0b3B0OjpMb25nIHF3KDpjb25maWcgcGFzc190aHJvdWdoKTsKK3VzZSBsaWIg JEZpbmRCaW46OkJpbjsKK3VzZSB3ZWJraXRkaXJzOwordXNlIFBPU0lYOworCitteSAkc2hvd0hl bHAgPSAwOworbXkgJGNsZWFuID0gMDsKKworbXkgJHByb2dyYW1OYW1lID0gYmFzZW5hbWUoJDAp OworbXkgJHVzYWdlID0gPDxFT0Y7CitVc2FnZTogJHByb2dyYW1OYW1lIFtvcHRpb25zXSBbb3B0 aW9ucyB0byBwYXNzIHRvIGJ1aWxkIHN5c3RlbV0KKyAgLS1oZWxwICAgICAgICBTaG93IHRoaXMg aGVscCBtZXNzYWdlCisgIC0tY2xlYW4gICAgICAgQ2xlYW4gdXAgdGhlIGJ1aWxkIGRpcmVjdG9y eQorRU9GCisKK0dldE9wdGlvbnMoCisgICAgJ2hlbHAnID0+IFwkc2hvd0hlbHAsCisgICAgJ2Ns ZWFuJyA9PiBcJGNsZWFuLAorKTsKKworaWYgKCRzaG93SGVscCkgeworICAgcHJpbnQgU1RERVJS ICR1c2FnZTsKKyAgIGV4aXQgMTsKK30KKworY2hlY2tSZXF1aXJlZFN5c3RlbUNvbmZpZygpOwor c2V0Q29uZmlndXJhdGlvbigpOworY2hkaXJXZWJLaXQoKTsKKworbXkgQHhjb2RlT3B0aW9ucyA9 ICgiLXRhcmdldCIsICJJbWFnZURpZmYiKTsKK3B1c2ggQHhjb2RlT3B0aW9ucywgWGNvZGVPcHRp b25zKCk7CisKKyMgQnVpbGQKK2NoZGlyICJUb29scy9EdW1wUmVuZGVyVHJlZSIgb3IgZGllOwor bXkgJHJlc3VsdCA9IGJ1aWxkWENvZGVQcm9qZWN0KCJEdW1wUmVuZGVyVHJlZSIsICRjbGVhbiwg QHhjb2RlT3B0aW9ucywgQEFSR1YpOworZXhpdCBleGl0U3RhdHVzKCRyZXN1bHQpOwo=