135264 2014-07-24 16:02:24 -0700 Crash when measuring a glyphs from a fallback SVG font 2014-07-24 17:30:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield dino jonlee simon.fraser thorton webkit-bug-importer oldest_to_newest 1024648 0 mmaxfield 2014-07-24 16:02:24 -0700 Crash when measuring a glyphs from a fallback SVG font 1024687 1 235476 mmaxfield 2014-07-24 17:10:39 -0700 Created attachment 235476 Patch 1024690 2 mmaxfield 2014-07-24 17:13:03 -0700 <rdar://problem/16591706> 1024692 3 235476 simon.fraser 2014-07-24 17:13:54 -0700 Comment on attachment 235476 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235476&action=review > Source/WebCore/platform/graphics/WidthIterator.cpp:127 > + if (iterator.run().renderingContext() && typesettingFeatures & Kerning) { Minor preference for parens around (typesettingFeatures & Kerning) > Source/WebCore/platform/graphics/WidthIterator.cpp:129 > + // However, doing the above FIXME seems like questionable design. Perhaps a larger refactoring of SVG fonts is necessary. Odd comment in this context. Just reword the FIXME. 1024701 4 mmaxfield 2014-07-24 17:29:51 -0700 https://trac.webkit.org/r171561 235476 2014-07-24 17:10:39 -0700 2014-07-24 17:13:53 -0700 Patch bug-135264-20140724171024.patch text/plain 5266 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxNTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTY3ZTYzOGE1ZTk4MDRk N2E2ZDZiNzNjM2QyZWNkZWU4Yzc2YWRmZC4uZmJlMzBjMWFlOGNkMzA5OWJiMjRkMTRjZTQ3OWZl YzZhODgzZGM3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTA3LTI0ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggd2hl biBtZWFzdXJpbmcgYSBnbHlwaHMgZnJvbSBhIGZhbGxiYWNrIFNWRyBmb250CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzUyNjQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBjYW4ndCByZWFsaXplIGZv bnQgZGF0YSBmb3IgYWxsIGZhbGxiYWNrIGZvbnRzIGFoZWFkCisgICAgICAgIG9mIHRpbWUsIGJ1 dCB3ZSBkb24ndCBoYXZlIGFsbCB0aGUgbmVjZXNzYXJ5IGNvbnRleHQgdG8KKyAgICAgICAgcmVh bGl6ZSBTVkcgZmFsbGJhY2sgZGF0YSB3aGVuIGl0J3MgbmVlZGVkLiBGb3Igbm93LCB3ZQorICAg ICAgICBjYW4ganVzdCBiYWlsOyBob3dldmVyLCBhIGxhcmdlciwgbW9yZSBpbnZhc2l2ZSBmaXgg aXMKKyAgICAgICAgaW4gb3JkZXIuCisKKyAgICAgICAgVGVzdDogc3ZnL3RleHQvc3ZnLWZhbGxi YWNrLWZvbnQtY3Jhc2guaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvV2lkdGhJ dGVyYXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjphcHBseUZvbnRUcmFuc2Zvcm1zKToKKwog MjAxNC0wNy0yNCAgcGVhdm9Ab3V0bG9vay5jb20gIDxwZWF2b0BvdXRsb29rLmNvbT4KIAogICAg ICAgICBbQ3VybF0gRW5hYmxlIGZpbGUgbG9nZ2luZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL1dpZHRoSXRlcmF0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvV2lkdGhJdGVyYXRvci5jcHAKaW5kZXggNzc3ZGMyOTc4ZGJmOTdj YmQxNzczZmY2YTBjYmZiMDA1M2M2Y2I1OS4uNjQyOGQ3MTU1OTA5ZWZlZjFjYjM4ZjI2MGYxZmEx MzJlNmU5YTYyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv V2lkdGhJdGVyYXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv V2lkdGhJdGVyYXRvci5jcHAKQEAgLTEyMywxMCArMTIzLDEyIEBAIHN0YXRpYyBpbmxpbmUgZmxv YXQgYXBwbHlGb250VHJhbnNmb3JtcyhHbHlwaEJ1ZmZlciogZ2x5cGhCdWZmZXIsIGJvb2wgbHRy LCBpbnQmCiAjZWxzZQogICAgIC8vIFdlIG5lZWQgdG8gaGFuZGxlIHRyYW5zZm9ybXMgb24gU1ZH IGZvbnRzIGludGVybmFsbHksIHNpbmNlIHRoZXkgYXJlIHJlbmRlcmVkIGludGVybmFsbHkuCiAg ICAgaWYgKGZvbnREYXRhLT5pc1NWR0ZvbnQoKSkgewotICAgICAgICBBU1NFUlQoaXRlcmF0b3Iu cnVuKCkucmVuZGVyaW5nQ29udGV4dCgpKTsKICAgICAgICAgLy8gU1ZHIGZvbnQgbGlnYXR1cmVz IGFyZSBoYW5kbGVkIGR1cmluZyBnbHlwaCBzZWxlY3Rpb24sIG9ubHkga2VybmluZyByZW1haW5p bmcuCi0gICAgICAgIGlmICh0eXBlc2V0dGluZ0ZlYXR1cmVzICYgS2VybmluZykKKyAgICAgICAg aWYgKGl0ZXJhdG9yLnJ1bigpLnJlbmRlcmluZ0NvbnRleHQoKSAmJiB0eXBlc2V0dGluZ0ZlYXR1 cmVzICYgS2VybmluZykgeworICAgICAgICAgICAgLy8gRklYTUU6IFNvbWVob3cgcGFzcyB0aGUg bmVjZXNzYXJ5IGNvbnRleHQgZG93biB0byB0aGlzIGxldmVsIHNvIHdlIGNhbiBsYXppbHkgY3Jl YXRlIHJlbmRlcmluZyBjb250ZXh0cyBhdCB0aGlzIHBvaW50LgorICAgICAgICAgICAgLy8gSG93 ZXZlciwgZG9pbmcgdGhlIGFib3ZlIEZJWE1FIHNlZW1zIGxpa2UgcXVlc3Rpb25hYmxlIGRlc2ln bi4gUGVyaGFwcyBhIGxhcmdlciByZWZhY3RvcmluZyBvZiBTVkcgZm9udHMgaXMgbmVjZXNzYXJ5 LgogICAgICAgICAgICAgaXRlcmF0b3IucnVuKCkucmVuZGVyaW5nQ29udGV4dCgpLT5hcHBseVNW R0tlcm5pbmcoZm9udERhdGEsIGl0ZXJhdG9yLCBnbHlwaEJ1ZmZlciwgbGFzdEdseXBoQ291bnQp OworICAgICAgICB9CiAgICAgfSBlbHNlCiAjZW5kaWYKICAgICAgICAgZm9udERhdGEtPmFwcGx5 VHJhbnNmb3JtcyhnbHlwaEJ1ZmZlci0+Z2x5cGhzKGxhc3RHbHlwaENvdW50KSwgYWR2YW5jZXMg KyBsYXN0R2x5cGhDb3VudCwgZ2x5cGhCdWZmZXJTaXplIC0gbGFzdEdseXBoQ291bnQsIHR5cGVz ZXR0aW5nRmVhdHVyZXMpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGQ2NDY4MWUyYjVhZDZiYjAzYzgwZGVkN2E3YTlhMmFj YjRmNTVhZmEuLmIzZGQ0NzM0Y2VlNmNmMmE1ZmYxZWYwMzBkYTkxNWVhYzg2MmUyODEgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNyBAQAorMjAxNC0wNy0yNCAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4Zmll bGRAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIHdoZW4gbWVhc3VyaW5nIGEgZ2x5cGhzIGZy b20gYSBmYWxsYmFjayBTVkcgZm9udAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM1MjY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmVuZGVyIHNvbWUgdGV4dCB3aXRoIGEgZmFsbGJhY2sgU1ZHIEZvbnQg aW5jbHVkaW5nIGEgZ2x5cGggd2hpY2gKKyAgICAgICAgb25seSBleGlzdHMgaW4gdGhhdCBmYWxs YmFjayBmb250LiBNYWtlIHN1cmUgdGhlcmUgaXMgbm8gY3Jhc2guCisKKyAgICAgICAgKiBzdmcv dGV4dC9yZXNvdXJjZXMvTGl0aGVydW0uc3ZnOgorICAgICAgICAqIHN2Zy90ZXh0L3N2Zy1mYWxs YmFjay1mb250LWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogc3ZnL3RleHQv c3ZnLWZhbGxiYWNrLWZvbnQtY3Jhc2guaHRtbDogQWRkZWQuCisKIDIwMTQtMDctMjQgIE1paG5l YSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CiAKICAgICAgICAgW05ldyBNdWx0aWNvbHVt bl0gQXNzZXJ0aW9uIGZhaWx1cmUgd2hlbiBhbiBpbnB1dCBlbGVtZW50IGhhcyBtdWx0aWNvbHVt biBzdHlsZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3ZnL3RleHQvcmVzb3VyY2VzL0xpdGhl cnVtLnN2ZyBiL0xheW91dFRlc3RzL3N2Zy90ZXh0L3Jlc291cmNlcy9MaXRoZXJ1bS5zdmcKaW5k ZXggMDQyYzdlZDk0ZWYxNzRiZTYwYjk2MDczODY0NGM5MGQzMTA5NzBmYS4uZTk1YTFhNDk0YTg2 OGEyNzI3NjJkZTM5Y2U2YTE4OGY3NDQ2YTUzYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3Zn L3RleHQvcmVzb3VyY2VzL0xpdGhlcnVtLnN2ZworKysgYi9MYXlvdXRUZXN0cy9zdmcvdGV4dC9y ZXNvdXJjZXMvTGl0aGVydW0uc3ZnCkBAIC02LDYgKzYsNyBAQAogPGZvbnQgaWQ9IkxpdGhlcnVt IiBob3Jpei1hZHYteD0iMTAyNCI+CiA8Zm9udC1mYWNlIHVuaXRzLXBlci1lbT0iMTQiIGFzY2Vu dD0iMTQiIGRlc2NlbnQ9Ii03Ii8+CiA8Z2x5cGggdW5pY29kZT0ifCIgaG9yaXotYWR2LXg9IjE0 IiBkPSJNNSAtN3YyMWg0di0yMXoiLz4KKzxnbHlwaCB1bmljb2RlPSImI3gyMDAwMTsiIGhvcml6 LWFkdi14PSIxNCIgZD0iTTUgLTd2MjFoNHYtMjF6Ii8+CiA8L2ZvbnQ+CiA8L2RlZnM+CiA8L3N2 Zz4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2Zy90ZXh0L3N2Zy1mYWxsYmFjay1mb250LWNy YXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3N2Zy90ZXh0L3N2Zy1mYWxsYmFjay1mb250 LWNyYXNoLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kZTIzMjA1N2JjYzE2ZWM3ZjEyM2FlNmIx NjhiNGQwMTQ3YzExMDU4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3ZnL3RleHQv c3ZnLWZhbGxiYWNrLWZvbnQtY3Jhc2gtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMiBAQAorVGhp cyB0ZXN0IG1ha2VzIHN1cmUgdGhhdCB0aGVyZSBpcyBubyBjcmFzaCBpZiBhIGNoYXJhY3RlciBp cyByZW5kZXJlZCB3aXRoIGEgU1ZHIGZhbGxiYWNrIGZvbnQuIFRoZSB0ZXN0IGlzIHN1Y2Nlc3Nm dWwgaWYgdGhlcmUgaXMgbm8gY3Jhc2guCitUaGlzIGlzIGEgZm9yZWlnbiBjaGFyYWN0ZXIuIPCg gIEgVGhhdCB3YXMgYSBmb3JlaWduIGNoYXJhY3Rlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3N2Zy90ZXh0L3N2Zy1mYWxsYmFjay1mb250LWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9zdmcv dGV4dC9zdmctZmFsbGJhY2stZm9udC1jcmFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjBiODZlNzRjOThi MzUxZTk0MmY0ZWQ4N2YyZWY0ZDg1YWNkZTRkMzEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9zdmcvdGV4dC9zdmctZmFsbGJhY2stZm9udC1jcmFzaC5odG1sCkBAIC0wLDAgKzEsMTkg QEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzdHlsZT4KK0Bmb250LWZhY2Ug eworICAgIGZvbnQtZmFtaWx5OiAnTGl0aGVydW0nOworICAgIHNyYzogdXJsKCIuL3Jlc291cmNl cy9MaXRoZXJ1bS5zdmciKSBmb3JtYXQoc3ZnKQorfQorPC9zdHlsZT4KKzxzY3JpcHQ+CitpZiAo d2luZG93LnRlc3RSdW5uZXIpCisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7Cis8L3Njcmlw dD4KKzwvaGVhZD4KKzxib2R5PgorVGhpcyB0ZXN0IG1ha2VzIHN1cmUgdGhhdCB0aGVyZSBpcyBu byBjcmFzaCBpZiBhIGNoYXJhY3RlciBpcyByZW5kZXJlZCB3aXRoIGEgU1ZHIGZhbGxiYWNrIGZv bnQuIFRoZSB0ZXN0IGlzIHN1Y2Nlc3NmdWwgaWYgdGhlcmUgaXMgbm8gY3Jhc2guCis8ZGl2IHN0 eWxlPSJmb250LWZhbWlseTogJ0hlbHZldGljYScgJ0xpdGhlcnVtJzsiPlRoaXMgaXMgYSBmb3Jl aWduIGNoYXJhY3Rlci4gJiN4MjAwMDE7IFRoYXQgd2FzIGEgZm9yZWlnbiBjaGFyYWN0ZXIuPC9k aXY+Cis8L2JvZHk+Cis8L2h0bWw+Cg==