13525 2007-04-27 10:04:53 -0700 Repainting a listbox schedules a relayout 2007-04-28 00:06:46 -0700 1 1 1 Unclassified WebKit Forms 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 mitz webkit-unassigned oldest_to_newest 11947 0 mitz 2007-04-27 10:04:53 -0700 When painting listboxes (and file upload controls) a temporary anonymous block is used to run the bidi algorithm. Manipulating the block results in marking it for relayout. Due to a bug first noted in bug 10862, this results in the entire view being scheduled for relayout every single time the listbox is painted. Patch forthcoming. 11948 1 14229 mitz 2007-04-27 10:05:49 -0700 Created attachment 14229 Fix scheduleRelayout() 11956 2 14231 mitz 2007-04-27 10:59:29 -0700 Created attachment 14231 Fix scheduleRelayout() Corrected a sentence in the change log. Thanks, Mark! 12001 3 mrowe 2007-04-28 00:06:46 -0700 Landed in r21162. 14229 2007-04-27 10:05:49 -0700 2007-04-27 10:59:29 -0700 Fix scheduleRelayout() 13525_r1.patch text/plain 2722 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTE0OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjYgQEAKKzIwMDctMDQtMjcgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTI1CisgICAgICAgICAg UmVwYWludGluZyBhIGxpc3Rib3ggc2NoZWR1bGVzIGEgcmVsYXlvdXQKKworICAgICAgICBObyB0 ZXN0IHBvc3NpYmxlIGFzIHRoZXJlIGlzIG5vIGNoYW5nZSB0byBmdW5jdGlvbmFsaXR5LgorCisg ICAgICAgIC0gZml4IHRoZSByb290IGNhdXNlIG9mIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwODYyCisgICAgICAgICAgUkVHUkVTU0lPTjogQ29sbGFwc2luZyBmb3Jt IGlucHV0IG9uIHd3dy5teXNwYWNlLmNvbQorCisgICAgICAgIE5vIHRlc3QgcG9zc2libGUgc2lu Y2UgdGV4dCBmaWVsZHMgYXJlIG5vIGxvbmdlciBpbXBsZW1lbnRlZCBhcyBmbGV4Ym94ZXMuCisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlck9iamVjdDo6c2NoZWR1bGVSZWxheW91dCk6IEFkZGVkIGEgY2hlY2sgdGhhdCB0aGUg c3VidHJlZQorICAgICAgICByb290IGlzIGluIHRoZSB0cmVlIGFuZCBub3QgZnJlZS1mbG9hdGlu Zy4KKyAgICAgICAgKiByZW5kZXJpbmcvYmlkaS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJCbG9jazo6YmlkaVJlb3JkZXJDaGFyYWN0ZXJzKTogQ2hhbmdlZCBhZGRDaGlsZCBhbmQgcmVt b3ZlQ2hpbGQKKyAgICAgICAgdG8gc2xpZ2h0bHkgYXBwZW5kQ2hpbGROb2RlIGFuZCByZW1vdmVD aGlsZE5vZGUgdG8gc2F2ZSBzb21lIHVubmVjZXNzYXJ5CisgICAgICAgIHJlbmRlciB0cmVlIG1h aW50ZW5hbmNlLiBUaGVzZSBjYWxscyBzdGlsbCBtYXJrIHRoZSB0cmVlIGZvciByZWxheW91dCwg YnV0CisgICAgICAgIHRoZSBjaGFuZ2UgaW4gc2NoZWR1bGVSZWxheW91dCBlbnN1cmVzIHRoYXQg YSBsYXlvdXQgd29uJ3QgYmUgc2NoZWR1bGVkLgorCiAyMDA3LTA0LTI3ICBBbnR0aSBLb2l2aXN0 byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiwgSHlhdHQu CkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAJKHJldmlzaW9uIDIxMTQ1KQorKysg V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjcx Niw3ICsyNzE2LDcgQEAgdm9pZCBSZW5kZXJPYmplY3Q6OnNjaGVkdWxlUmVsYXlvdXQoKQogICAg ICAgICBGcmFtZVZpZXcqIHZpZXcgPSBzdGF0aWNfY2FzdDxSZW5kZXJWaWV3Kj4odGhpcyktPmZy YW1lVmlldygpOwogICAgICAgICBpZiAodmlldykKICAgICAgICAgICAgIHZpZXctPnNjaGVkdWxl UmVsYXlvdXQoKTsKLSAgICB9IGVsc2UgeworICAgIH0gZWxzZSBpZiAocGFyZW50KCkpIHsKICAg ICAgICAgRnJhbWVWaWV3KiB2ID0gdmlldygpID8gdmlldygpLT5mcmFtZVZpZXcoKSA6IDA7CiAg ICAgICAgIGlmICh2KQogICAgICAgICAgICAgdi0+c2NoZWR1bGVSZWxheW91dE9mU3VidHJlZShu b2RlKCkpOwpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvYmlkaS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9yZW5kZXJpbmcvYmlkaS5jcHAJKHJldmlzaW9uIDIxMTQ1KQorKysgV2ViQ29yZS9y ZW5kZXJpbmcvYmlkaS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzNCw3ICsxMzQsNyBAQCB2b2lk IFJlbmRlckJsb2NrOjpiaWRpUmVvcmRlckNoYXJhY3RlcnMoCiAgICAgLy8gQ3JlYXRlIFJlbmRl clRleHQKICAgICBSZW5kZXJUZXh0KiB0ZXh0ID0gbmV3IChkb2N1bWVudC0+cmVuZGVyQXJlbmEo KSkgUmVuZGVyVGV4dChkb2N1bWVudCwgc3RyaW5nLmltcGwoKSk7CiAgICAgdGV4dC0+c2V0U3R5 bGUoYmxvY2tTdHlsZSk7Ci0gICAgYmxvY2stPmFkZENoaWxkKHRleHQpOworICAgIGJsb2NrLT5h cHBlbmRDaGlsZE5vZGUodGV4dCwgZmFsc2UpOwogICAgIAogICAgIC8vIENhbGwgYmlkaVJlb3Jk ZXJMaW5lCiAgICAgQmlkaVN0YXRlIGJpZGk7CkBAIC0xNzQsNyArMTc0LDcgQEAgdm9pZCBSZW5k ZXJCbG9jazo6YmlkaVJlb3JkZXJDaGFyYWN0ZXJzKAogICAgIH0KIAogICAgIC8vIFRlYXIgZG93 biB0ZW1wb3JhcnkgUmVuZGVyQmxvY2ssIFJlbmRlclRleHQsIGFuZCBCaWRpUnVucwotICAgIGJs b2NrLT5yZW1vdmVDaGlsZCh0ZXh0KTsKKyAgICBibG9jay0+cmVtb3ZlQ2hpbGROb2RlKHRleHQs IGZhbHNlKTsKICAgICB0ZXh0LT5kZXN0cm95KCk7CiAgICAgYmxvY2stPmRlc3Ryb3koKTsKICAg ICBkZWxldGVCaWRpUnVucyhkb2N1bWVudC0+cmVuZGVyQXJlbmEoKSk7Cg== 14231 2007-04-27 10:59:29 -0700 2007-04-27 14:15:19 -0700 Fix scheduleRelayout() 13525_r1.patch text/plain 2699 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTE0OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjYgQEAKKzIwMDctMDQtMjcgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTI1CisgICAgICAgICAg UmVwYWludGluZyBhIGxpc3Rib3ggc2NoZWR1bGVzIGEgcmVsYXlvdXQKKworICAgICAgICBObyB0 ZXN0IHBvc3NpYmxlIGFzIHRoZXJlIGlzIG5vIGNoYW5nZSB0byBmdW5jdGlvbmFsaXR5LgorCisg ICAgICAgIC0gZml4IHRoZSByb290IGNhdXNlIG9mIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwODYyCisgICAgICAgICAgUkVHUkVTU0lPTjogQ29sbGFwc2luZyBmb3Jt IGlucHV0IG9uIHd3dy5teXNwYWNlLmNvbQorCisgICAgICAgIE5vIHRlc3QgcG9zc2libGUgc2lu Y2UgdGV4dCBmaWVsZHMgYXJlIG5vIGxvbmdlciBpbXBsZW1lbnRlZCBhcyBmbGV4Ym94ZXMuCisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlck9iamVjdDo6c2NoZWR1bGVSZWxheW91dCk6IEFkZGVkIGEgY2hlY2sgdGhhdCB0aGUg c3VidHJlZQorICAgICAgICByb290IGlzIGluIHRoZSB0cmVlIGFuZCBub3QgZnJlZS1mbG9hdGlu Zy4KKyAgICAgICAgKiByZW5kZXJpbmcvYmlkaS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJCbG9jazo6YmlkaVJlb3JkZXJDaGFyYWN0ZXJzKTogQ2hhbmdlZCBhZGRDaGlsZCBhbmQgcmVt b3ZlQ2hpbGQKKyAgICAgICAgdG8gYXBwZW5kQ2hpbGROb2RlIGFuZCByZW1vdmVDaGlsZE5vZGUg dG8gc2F2ZSBzb21lIHVubmVjZXNzYXJ5IG92ZXJoZWFkLgorICAgICAgICBUaGVzZSBjYWxscyBz dGlsbCBtYXJrIHRoZSB0cmVlIGZvciByZWxheW91dCwgYnV0IHRoZSBjaGFuZ2UgaW4gc2NoZWR1 bGVSZWxheW91dCAKKyAgICAgICAgZW5zdXJlcyB0aGF0IGEgbGF5b3V0IHdvbid0IGJlIHNjaGVk dWxlZC4KKwogMjAwNy0wNC0yNyAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4sIEh5YXR0LgpJbmRleDogV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJPYmplY3QuY3BwCShyZXZpc2lvbiAyMTE0NSkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ck9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI3MTYsNyArMjcxNiw3IEBAIHZvaWQgUmVu ZGVyT2JqZWN0OjpzY2hlZHVsZVJlbGF5b3V0KCkKICAgICAgICAgRnJhbWVWaWV3KiB2aWV3ID0g c3RhdGljX2Nhc3Q8UmVuZGVyVmlldyo+KHRoaXMpLT5mcmFtZVZpZXcoKTsKICAgICAgICAgaWYg KHZpZXcpCiAgICAgICAgICAgICB2aWV3LT5zY2hlZHVsZVJlbGF5b3V0KCk7Ci0gICAgfSBlbHNl IHsKKyAgICB9IGVsc2UgaWYgKHBhcmVudCgpKSB7CiAgICAgICAgIEZyYW1lVmlldyogdiA9IHZp ZXcoKSA/IHZpZXcoKS0+ZnJhbWVWaWV3KCkgOiAwOwogICAgICAgICBpZiAodikKICAgICAgICAg ICAgIHYtPnNjaGVkdWxlUmVsYXlvdXRPZlN1YnRyZWUobm9kZSgpKTsKSW5kZXg6IFdlYkNvcmUv cmVuZGVyaW5nL2JpZGkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL2JpZGku Y3BwCShyZXZpc2lvbiAyMTE0NSkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL2JpZGkuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMzQsNyArMTM0LDcgQEAgdm9pZCBSZW5kZXJCbG9jazo6YmlkaVJlb3Jk ZXJDaGFyYWN0ZXJzKAogICAgIC8vIENyZWF0ZSBSZW5kZXJUZXh0CiAgICAgUmVuZGVyVGV4dCog dGV4dCA9IG5ldyAoZG9jdW1lbnQtPnJlbmRlckFyZW5hKCkpIFJlbmRlclRleHQoZG9jdW1lbnQs IHN0cmluZy5pbXBsKCkpOwogICAgIHRleHQtPnNldFN0eWxlKGJsb2NrU3R5bGUpOwotICAgIGJs b2NrLT5hZGRDaGlsZCh0ZXh0KTsKKyAgICBibG9jay0+YXBwZW5kQ2hpbGROb2RlKHRleHQsIGZh bHNlKTsKICAgICAKICAgICAvLyBDYWxsIGJpZGlSZW9yZGVyTGluZQogICAgIEJpZGlTdGF0ZSBi aWRpOwpAQCAtMTc0LDcgKzE3NCw3IEBAIHZvaWQgUmVuZGVyQmxvY2s6OmJpZGlSZW9yZGVyQ2hh cmFjdGVycygKICAgICB9CiAKICAgICAvLyBUZWFyIGRvd24gdGVtcG9yYXJ5IFJlbmRlckJsb2Nr LCBSZW5kZXJUZXh0LCBhbmQgQmlkaVJ1bnMKLSAgICBibG9jay0+cmVtb3ZlQ2hpbGQodGV4dCk7 CisgICAgYmxvY2stPnJlbW92ZUNoaWxkTm9kZSh0ZXh0LCBmYWxzZSk7CiAgICAgdGV4dC0+ZGVz dHJveSgpOwogICAgIGJsb2NrLT5kZXN0cm95KCk7CiAgICAgZGVsZXRlQmlkaVJ1bnMoZG9jdW1l bnQtPnJlbmRlckFyZW5hKCkpOwo=