135237 2014-07-24 05:38:34 -0700 [TexMap] GraphicsLayerTextureMapper::addAnimation() box size parameter should be FloatSize 2014-07-29 01:13:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan cmarcelo commit-queue kondapallykalyan luiz mrobinson noam oldest_to_newest 1024498 0 zan 2014-07-24 05:38:34 -0700 [TexMap] GraphicsLayerTextureMapper::addAnimation() box size parameter should be FloatSize 1024499 1 235426 zan 2014-07-24 05:43:13 -0700 Created attachment 235426 Patch 1024512 2 235426 mrobinson 2014-07-24 07:20:00 -0700 Comment on attachment 235426 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235426&action=review > Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h:84 > - virtual bool addAnimation(const KeyframeValueList&, const IntSize&, const Animation*, const String&, double); > + virtual bool addAnimation(const KeyframeValueList&, const FloatSize&, const Animation*, const String&, double); I think adding override to this delcaration is a good idea, since it has the potential to catch these errors in the future. 1025406 3 235426 zan 2014-07-29 01:10:06 -0700 Comment on attachment 235426 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235426&action=review >> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h:84 >> + virtual bool addAnimation(const KeyframeValueList&, const FloatSize&, const Animation*, const String&, double); > > I think adding override to this delcaration is a good idea, since it has the potential to catch these errors in the future. That should be done throughout the texmap code. I'll at least run clang-modernize over it, but there are also other things I want to improve. 1025409 4 235426 zan 2014-07-29 01:13:31 -0700 Comment on attachment 235426 Patch Clearing flags on attachment: 235426 Committed r171725: <http://trac.webkit.org/changeset/171725> 1025410 5 zan 2014-07-29 01:13:40 -0700 All reviewed patches have been landed. Closing bug. 235426 2014-07-24 05:43:13 -0700 2014-07-29 01:13:31 -0700 Patch bug-135237-20140724054257.patch text/plain 2713 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTUxMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA3LTI0ICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbVGV4TWFwXSBHcmFwaGlj c0xheWVyVGV4dHVyZU1hcHBlcjo6YWRkQW5pbWF0aW9uKCkgYm94IHNpemUgcGFyYW1ldGVyIHNo b3VsZCBiZSBGbG9hdFNpemUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzNTIzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJl TWFwcGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVy OjphZGRBbmltYXRpb24pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9HcmFw aGljc0xheWVyVGV4dHVyZU1hcHBlci5oOiBUaGUgYm94U2l6ZSBwYXJhbWV0ZXIgb2YgdGhlCisg ICAgICAgIGFkZEFuaW1hdGlvbigpIG1ldGhvZCBtdXN0IGJlIG9mIHRoZSBzYW1lIHR5cGUgYXMg dGhlIHBhcmFtZXRlciBpbiB0aGUgYmFzZSBjbGFzcworICAgICAgICBkZWNsYXJhdGlvbiAtLSBh IGNvbnN0IEZsb2F0U2l6ZSByZWZlcmVuY2UuIE9ubHkgdGhlbiBpcyB0aGUgYmFzZSB2aXJ0dWFs IG1ldGhvZAorICAgICAgICBhY3R1YWxseSBvdmVycmlkZW4uCisKIDIwMTQtMDctMjQgIE1paG5l YSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CiAKICAgICAgICAgW05ldyBNdWx0aWNvbHVt bl0gQXNzZXJ0aW9uIGZhaWx1cmUgd2hlbiBhbiBpbnB1dCBlbGVtZW50IGhhcyBtdWx0aWNvbHVt biBzdHlsZQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dy YXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIuY3Bw CShyZXZpc2lvbiAxNzE0NzUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90 ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02 MjAsNyArNjIwLDcgQEAgYm9vbCBHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6c2hvdWxkSAog ICAgIHJldHVybiBkcmF3c0NvbnRlbnQoKSAmJiBjb250ZW50c0FyZVZpc2libGUoKSAmJiAhbV9z aXplLmlzRW1wdHkoKTsKIH0KIAotYm9vbCBHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6YWRk QW5pbWF0aW9uKGNvbnN0IEtleWZyYW1lVmFsdWVMaXN0JiB2YWx1ZUxpc3QsIGNvbnN0IEludFNp emUmIGJveFNpemUsIGNvbnN0IEFuaW1hdGlvbiogYW5pbSwgY29uc3QgU3RyaW5nJiBrZXlmcmFt ZXNOYW1lLCBkb3VibGUgdGltZU9mZnNldCkKK2Jvb2wgR3JhcGhpY3NMYXllclRleHR1cmVNYXBw ZXI6OmFkZEFuaW1hdGlvbihjb25zdCBLZXlmcmFtZVZhbHVlTGlzdCYgdmFsdWVMaXN0LCBjb25z dCBGbG9hdFNpemUmIGJveFNpemUsIGNvbnN0IEFuaW1hdGlvbiogYW5pbSwgY29uc3QgU3RyaW5n JiBrZXlmcmFtZXNOYW1lLCBkb3VibGUgdGltZU9mZnNldCkKIHsKICAgICBBU1NFUlQoIWtleWZy YW1lc05hbWUuaXNFbXB0eSgpKTsKIApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0 dXJlTWFwcGVyLmgJKHJldmlzaW9uIDE3MTQ3NSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3RleG1hcC9HcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5oCSh3b3JraW5nIGNv cHkpCkBAIC04MSw3ICs4MSw3IEBAIHB1YmxpYzoKIAogICAgIGlubGluZSBpbnQgY2hhbmdlTWFz aygpIGNvbnN0IHsgcmV0dXJuIG1fY2hhbmdlTWFzazsgfQogCi0gICAgdmlydHVhbCBib29sIGFk ZEFuaW1hdGlvbihjb25zdCBLZXlmcmFtZVZhbHVlTGlzdCYsIGNvbnN0IEludFNpemUmLCBjb25z dCBBbmltYXRpb24qLCBjb25zdCBTdHJpbmcmLCBkb3VibGUpOworICAgIHZpcnR1YWwgYm9vbCBh ZGRBbmltYXRpb24oY29uc3QgS2V5ZnJhbWVWYWx1ZUxpc3QmLCBjb25zdCBGbG9hdFNpemUmLCBj b25zdCBBbmltYXRpb24qLCBjb25zdCBTdHJpbmcmLCBkb3VibGUpOwogICAgIHZpcnR1YWwgdm9p ZCBwYXVzZUFuaW1hdGlvbihjb25zdCBTdHJpbmcmLCBkb3VibGUpOwogICAgIHZpcnR1YWwgdm9p ZCByZW1vdmVBbmltYXRpb24oY29uc3QgU3RyaW5nJik7CiAgICAgdm9pZCBzZXRBbmltYXRpb25z KGNvbnN0IEdyYXBoaWNzTGF5ZXJBbmltYXRpb25zJik7Cg==