135216 2014-07-23 14:52:59 -0700 Add a pseudo target to create sandbox override roots 2014-07-23 17:52:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver ap mitz oldest_to_newest 1024347 0 oliver 2014-07-23 14:52:59 -0700 Add a pseudo target to create sandbox override roots 1024351 1 235382 oliver 2014-07-23 14:59:07 -0700 Created attachment 235382 Patch 1024354 2 235382 ap 2014-07-23 15:01:55 -0700 Comment on attachment 235382 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235382&action=review > Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:10029 > + PRODUCT_NAME = "WebKit2SandboxProfiles copy"; :-/ > Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:10036 > + PRODUCT_NAME = "WebKit2SandboxProfiles copy"; :-/ > Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:10043 > + PRODUCT_NAME = "WebKit2SandboxProfiles copy"; :-/ 1024356 3 oliver 2014-07-23 15:04:21 -0700 Committed r171493: <http://trac.webkit.org/changeset/171493> 1024402 4 mitz 2014-07-23 17:52:10 -0700 (In reply to comment #0) > Add a pseudo target to create sandbox override roots What makes this new target a “pseudo target”? Why can’t this be accomplished by a build setting to the existing target (similarly to how there are no separate targets for staged frameworks)? 235382 2014-07-23 14:59:07 -0700 2014-07-23 15:01:54 -0700 Patch bug-135216-20140723145852.patch text/plain 5993 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxNDkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmI2ZWEzZWYyM2JiNjQx ZWNmN2ExY2EwM2ViN2EyN2U5OTc2OTgxZS4uNDQxMDQwODY4OTk5YWIyY2ExZjA2ZmI2ZjkzMWUx M2ZlZDFkYzkyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTA3LTIzICBPbGl2 ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKKyAgICAgICAgQWRkIGEgcHNldWRvIHRhcmdl dCB0byBjcmVhdGUgc2FuZGJveCBvdmVycmlkZSByb290cworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1MjE2CisgICAgICAgIDxyZGFyOi8vMTc3ODU1 NjA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSnVz dCBhIGR1cGxpY2F0ZSBvZiB0aGUgc3RhbmRhcmQgaW9zIHNhbmRib3ggdGFyZ2V0LCB0YXJnZXR0 aW5nCisgICAgICAgIHRoZSBwcm9maWxlIG92ZXJyaWRlcyBkaXJlY3RvcnkuICBUaGlzIG1lYW5z IHdlIGNhbiBtYWtlIHJvb3RzCisgICAgICAgIHRoYXQgIkp1c3QgV29yayIuCisKKyAgICAgICAg KiBXZWJLaXQyLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2o6CisKKzIwMTQtMDctMjMgIE9saXZl ciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKwogICAgICAgICBJbmNvcnJlY3QgY29tbWl0IGZv ciBzYW5kYm94IHByb2ZpbGUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzNTIxNAogICAgICAgICA8cmRhcjovLzE3NzM5MTA4PgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvV2ViS2l0Mi54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qIGIvU291cmNl L1dlYktpdDIvV2ViS2l0Mi54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IDVhNzg0Nzhh M2NlYzg1NTJjNjNlMzFmNjkwZTg4Mjg0MmE2ZjFlZDQuLmE5NDI1YzJiY2RiODY3NTdlOWM1NzFj YWY3Njg2Yjg1NTEyNWI5ZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYktpdDIueGNv ZGVwcm9qL3Byb2plY3QucGJ4cHJvagorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJLaXQyLnhjb2Rl cHJvai9wcm9qZWN0LnBieHByb2oKQEAgLTQ1LDYgKzQ1LDE3IEBACiAJCQluYW1lID0gV2ViS2l0 MlNhbmRib3hQcm9maWxlczsKIAkJCXByb2R1Y3ROYW1lID0gV2ViS2l0MlNhbmRib3hQcm9maWxl czsKIAkJfTsKKwkJQTdDMERDMkQxOTgwNERFRTAwMjUzQ0VEIC8qIFdlYktpdDJTYW5kYm94UHJv ZmlsZXMtSU9TT3ZlcnJpZGUgKi8gPSB7CisJCQlpc2EgPSBQQlhBZ2dyZWdhdGVUYXJnZXQ7CisJ CQlidWlsZENvbmZpZ3VyYXRpb25MaXN0ID0gQTdDMERDMzIxOTgwNERFRTAwMjUzQ0VEIC8qIEJ1 aWxkIGNvbmZpZ3VyYXRpb24gbGlzdCBmb3IgUEJYQWdncmVnYXRlVGFyZ2V0ICJXZWJLaXQyU2Fu ZGJveFByb2ZpbGVzLUlPU092ZXJyaWRlIiAqLzsKKwkJCWJ1aWxkUGhhc2VzID0gKAorCQkJCUE3 QzBEQzJFMTk4MDRERUUwMDI1M0NFRCAvKiBDb3B5RmlsZXMgKi8sCisJCQkpOworCQkJZGVwZW5k ZW5jaWVzID0gKAorCQkJKTsKKwkJCW5hbWUgPSAiV2ViS2l0MlNhbmRib3hQcm9maWxlcy1JT1NP dmVycmlkZSI7CisJCQlwcm9kdWN0TmFtZSA9IFdlYktpdDJTYW5kYm94UHJvZmlsZXM7CisJCX07 CiAJCUMwQ0U3Mjg1MTI0N0U2NjgwMEJDMEVDNCAvKiBEZXJpdmVkIFNvdXJjZXMgKi8gPSB7CiAJ CQlpc2EgPSBQQlhBZ2dyZWdhdGVUYXJnZXQ7CiAJCQlidWlsZENvbmZpZ3VyYXRpb25MaXN0ID0g QzBDRTcyODkxMjQ3RTY4NjAwQkMwRUM0IC8qIEJ1aWxkIGNvbmZpZ3VyYXRpb24gbGlzdCBmb3Ig UEJYQWdncmVnYXRlVGFyZ2V0ICJEZXJpdmVkIFNvdXJjZXMiICovOwpAQCAtMTExMiw2ICsxMTIz LDkgQEAKIAkJQTc4Q0NEREExOTNBQzlGNDAwNUVDQzI1IC8qIGNvbS5hcHBsZS5XZWJLaXQuRGF0 YWJhc2VzLnNiIGluIENvcHlGaWxlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYg PSBBNzhDQ0RENzE5M0FDOUUzMDA1RUNDMjUgLyogY29tLmFwcGxlLldlYktpdC5EYXRhYmFzZXMu c2IgKi87IH07CiAJCUE3OENDRERCMTkzQUM5RjgwMDVFQ0MyNSAvKiBjb20uYXBwbGUuV2ViS2l0 Lk5ldHdvcmtpbmcuc2IgaW4gQ29weUZpbGVzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmls ZVJlZiA9IEE3OENDREQ4MTkzQUM5RTMwMDVFQ0MyNSAvKiBjb20uYXBwbGUuV2ViS2l0Lk5ldHdv cmtpbmcuc2IgKi87IH07CiAJCUE3OENDRERDMTkzQUM5RkIwMDVFQ0MyNSAvKiBjb20uYXBwbGUu V2ViS2l0LldlYkNvbnRlbnQuc2IgaW4gQ29weUZpbGVzICovID0ge2lzYSA9IFBCWEJ1aWxkRmls ZTsgZmlsZVJlZiA9IEE3OENDREQ5MTkzQUM5RTMwMDVFQ0MyNSAvKiBjb20uYXBwbGUuV2ViS2l0 LldlYkNvbnRlbnQuc2IgKi87IH07CisJCUE3QzBEQzJGMTk4MDRERUUwMDI1M0NFRCAvKiBjb20u YXBwbGUuV2ViS2l0LkRhdGFiYXNlcy5zYiBpbiBDb3B5RmlsZXMgKi8gPSB7aXNhID0gUEJYQnVp bGRGaWxlOyBmaWxlUmVmID0gQTc4Q0NERDcxOTNBQzlFMzAwNUVDQzI1IC8qIGNvbS5hcHBsZS5X ZWJLaXQuRGF0YWJhc2VzLnNiICovOyB9OworCQlBN0MwREMzMDE5ODA0REVFMDAyNTNDRUQgLyog Y29tLmFwcGxlLldlYktpdC5OZXR3b3JraW5nLnNiIGluIENvcHlGaWxlcyAqLyA9IHtpc2EgPSBQ QlhCdWlsZEZpbGU7IGZpbGVSZWYgPSBBNzhDQ0REODE5M0FDOUUzMDA1RUNDMjUgLyogY29tLmFw cGxlLldlYktpdC5OZXR3b3JraW5nLnNiICovOyB9OworCQlBN0MwREMzMTE5ODA0REVFMDAyNTND RUQgLyogY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiIGluIENvcHlGaWxlcyAqLyA9IHtp c2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSBBNzhDQ0REOTE5M0FDOUUzMDA1RUNDMjUgLyog Y29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiICovOyB9OwogCQlBN0Q3OTJENjE3NjdDQjZF MDA4ODFDQkUgLyogQWN0aXZpdHlBc3NlcnRpb24uY3BwIGluIFNvdXJjZXMgKi8gPSB7aXNhID0g UEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gQTdENzkyRDUxNzY3Q0I2RTAwODgxQ0JFIC8qIEFjdGl2 aXR5QXNzZXJ0aW9uLmNwcCAqLzsgfTsKIAkJQTdENzkyRDgxNzY3Q0NBMzAwODgxQ0JFIC8qIEFj dGl2aXR5QXNzZXJ0aW9uLmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZp bGVSZWYgPSBBN0Q3OTJENDE3NjdDQjA5MDA4ODFDQkUgLyogQWN0aXZpdHlBc3NlcnRpb24uaCAq LzsgfTsKIAkJQTdFOTNDRUQxOTI1MzMxMTAwQTFEQzQ4IC8qIENoaWxkUHJvY2Vzc0lPUy5tbSBp biBTb3VyY2VzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IEE3RTkzQ0VCMTky NTMxQUEwMEExREM0OCAvKiBDaGlsZFByb2Nlc3NJT1MubW0gKi87IH07CkBAIC0xOTU3LDYgKzE5 NzEsMTggQEAKIAkJCSk7CiAJCQlydW5Pbmx5Rm9yRGVwbG95bWVudFBvc3Rwcm9jZXNzaW5nID0g MDsKIAkJfTsKKwkJQTdDMERDMkUxOTgwNERFRTAwMjUzQ0VEIC8qIENvcHlGaWxlcyAqLyA9IHsK KwkJCWlzYSA9IFBCWENvcHlGaWxlc0J1aWxkUGhhc2U7CisJCQlidWlsZEFjdGlvbk1hc2sgPSAy MTQ3NDgzNjQ3OworCQkJZHN0UGF0aCA9IC91c3IvbG9jYWwvc2hhcmUvc2FuZGJveDsKKwkJCWRz dFN1YmZvbGRlclNwZWMgPSAwOworCQkJZmlsZXMgPSAoCisJCQkJQTdDMERDMkYxOTgwNERFRTAw MjUzQ0VEIC8qIGNvbS5hcHBsZS5XZWJLaXQuRGF0YWJhc2VzLnNiIGluIENvcHlGaWxlcyAqLywK KwkJCQlBN0MwREMzMDE5ODA0REVFMDAyNTNDRUQgLyogY29tLmFwcGxlLldlYktpdC5OZXR3b3Jr aW5nLnNiIGluIENvcHlGaWxlcyAqLywKKwkJCQlBN0MwREMzMTE5ODA0REVFMDAyNTNDRUQgLyog Y29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiIGluIENvcHlGaWxlcyAqLywKKwkJCSk7CisJ CQlydW5Pbmx5Rm9yRGVwbG95bWVudFBvc3Rwcm9jZXNzaW5nID0gMDsKKwkJfTsKIAkJQkNERTA5 M0MxMzI3MjQ5NjAwMTI1OUZCIC8qIENvcHkgUGx1Zy1pbiBQcm9jZXNzIFNoaW0gKi8gPSB7CiAJ CQlpc2EgPSBQQlhDb3B5RmlsZXNCdWlsZFBoYXNlOwogCQkJYnVpbGRBY3Rpb25NYXNrID0gMjE0 NzQ4MzY0NzsKQEAgLTgyMjEsNiArODI0Nyw3IEBACiAJCQkJNTFGN0RDM0YxODBDQzkzNjAwMjEy Q0EzIC8qIERhdGFiYXNlcyAqLywKIAkJCQk1MTgwQzcxMzE4MENDQTMxMDBGREE2MTIgLyogRGF0 YWJhc2VzLkRldmVsb3BtZW50ICovLAogCQkJCUE3QUFEQTEwMTkzOTVDQTkwMDNFQTFDNyAvKiBX ZWJLaXQyU2FuZGJveFByb2ZpbGVzICovLAorCQkJCUE3QzBEQzJEMTk4MDRERUUwMDI1M0NFRCAv KiBXZWJLaXQyU2FuZGJveFByb2ZpbGVzLUlPU092ZXJyaWRlICovLAogCQkJKTsKIAkJfTsKIC8q IEVuZCBQQlhQcm9qZWN0IHNlY3Rpb24gKi8KQEAgLTk5OTYsNiArMTAwMjMsMjcgQEAKIAkJCX07 CiAJCQluYW1lID0gUHJvZHVjdGlvbjsKIAkJfTsKKwkJQTdDMERDMzMxOTgwNERFRTAwMjUzQ0VE IC8qIERlYnVnICovID0geworCQkJaXNhID0gWENCdWlsZENvbmZpZ3VyYXRpb247CisJCQlidWls ZFNldHRpbmdzID0geworCQkJCVBST0RVQ1RfTkFNRSA9ICJXZWJLaXQyU2FuZGJveFByb2ZpbGVz IGNvcHkiOworCQkJfTsKKwkJCW5hbWUgPSBEZWJ1ZzsKKwkJfTsKKwkJQTdDMERDMzQxOTgwNERF RTAwMjUzQ0VEIC8qIFJlbGVhc2UgKi8gPSB7CisJCQlpc2EgPSBYQ0J1aWxkQ29uZmlndXJhdGlv bjsKKwkJCWJ1aWxkU2V0dGluZ3MgPSB7CisJCQkJUFJPRFVDVF9OQU1FID0gIldlYktpdDJTYW5k Ym94UHJvZmlsZXMgY29weSI7CisJCQl9OworCQkJbmFtZSA9IFJlbGVhc2U7CisJCX07CisJCUE3 QzBEQzM1MTk4MDRERUUwMDI1M0NFRCAvKiBQcm9kdWN0aW9uICovID0geworCQkJaXNhID0gWENC dWlsZENvbmZpZ3VyYXRpb247CisJCQlidWlsZFNldHRpbmdzID0geworCQkJCVBST0RVQ1RfTkFN RSA9ICJXZWJLaXQyU2FuZGJveFByb2ZpbGVzIGNvcHkiOworCQkJfTsKKwkJCW5hbWUgPSBQcm9k dWN0aW9uOworCQl9OwogCQlCQzNERTQ3MzE1QTkxNzY0MDA4RDI2RkMgLyogRGVidWcgKi8gPSB7 CiAJCQlpc2EgPSBYQ0J1aWxkQ29uZmlndXJhdGlvbjsKIAkJCWJhc2VDb25maWd1cmF0aW9uUmVm ZXJlbmNlID0gQkNBQ0M0MEUxNkIwQjhBODAwQjZFMDkyIC8qIFdlYkNvbnRlbnRTZXJ2aWNlLnhj Y29uZmlnICovOwpAQCAtMTAzNDAsNiArMTAzODgsMTYgQEAKIAkJCWRlZmF1bHRDb25maWd1cmF0 aW9uSXNWaXNpYmxlID0gMDsKIAkJCWRlZmF1bHRDb25maWd1cmF0aW9uTmFtZSA9IFByb2R1Y3Rp b247CiAJCX07CisJCUE3QzBEQzMyMTk4MDRERUUwMDI1M0NFRCAvKiBCdWlsZCBjb25maWd1cmF0 aW9uIGxpc3QgZm9yIFBCWEFnZ3JlZ2F0ZVRhcmdldCAiV2ViS2l0MlNhbmRib3hQcm9maWxlcy1J T1NPdmVycmlkZSIgKi8gPSB7CisJCQlpc2EgPSBYQ0NvbmZpZ3VyYXRpb25MaXN0OworCQkJYnVp bGRDb25maWd1cmF0aW9ucyA9ICgKKwkJCQlBN0MwREMzMzE5ODA0REVFMDAyNTNDRUQgLyogRGVi dWcgKi8sCisJCQkJQTdDMERDMzQxOTgwNERFRTAwMjUzQ0VEIC8qIFJlbGVhc2UgKi8sCisJCQkJ QTdDMERDMzUxOTgwNERFRTAwMjUzQ0VEIC8qIFByb2R1Y3Rpb24gKi8sCisJCQkpOworCQkJZGVm YXVsdENvbmZpZ3VyYXRpb25Jc1Zpc2libGUgPSAwOworCQkJZGVmYXVsdENvbmZpZ3VyYXRpb25O YW1lID0gUHJvZHVjdGlvbjsKKwkJfTsKIAkJQkMzREU0NzYxNUE5MTc2NDAwOEQyNkZDIC8qIEJ1 aWxkIGNvbmZpZ3VyYXRpb24gbGlzdCBmb3IgUEJYTmF0aXZlVGFyZ2V0ICJXZWJDb250ZW50IiAq LyA9IHsKIAkJCWlzYSA9IFhDQ29uZmlndXJhdGlvbkxpc3Q7CiAJCQlidWlsZENvbmZpZ3VyYXRp b25zID0gKAo=