135206 2014-07-23 12:08:02 -0700 [iOS] Client-certificate authentication isn’t working with some certificates 2014-07-23 13:19:19 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mitz webkit-unassigned oldest_to_newest 1024285 0 mitz 2014-07-23 12:08:02 -0700 Responding to an authentication challenge with an identity-based credential fails when more than one copy of the identity’s private key exists in the keychain. 1024286 1 mitz 2014-07-23 12:11:29 -0700 <rdar://problem/17782623> 1024292 2 235368 mitz 2014-07-23 12:24:01 -0700 Created attachment 235368 Specify an access group when creating a persistent reference to a key 1024293 3 235368 andersca 2014-07-23 12:33:22 -0700 Comment on attachment 235368 Specify an access group when creating a persistent reference to a key View in context: https://bugs.webkit.org/attachment.cgi?id=235368&action=review > Source/WebKit2/Shared/cf/ArgumentCodersCF.cpp:637 > + RetainPtr<NSDictionary> query = @{ This doesn't need to be a RetainPtr. 1024294 4 235368 ap 2014-07-23 12:38:10 -0700 Comment on attachment 235368 Specify an access group when creating a persistent reference to a key View in context: https://bugs.webkit.org/attachment.cgi?id=235368&action=review > Source/WebKit2/Shared/cf/ArgumentCodersCF.cpp:632 > +static CFDataRef copyPersistentRef(SecKeyRef key) This doesn't seem to be in a PLATFORM(IOS) ifdef, and it should. > Source/WebKit2/Shared/cf/ArgumentCodersCF.cpp:637 > + RetainPtr<NSDictionary> query = @{ I don't see how this RetainPtr can be appropriate here. > Source/WebKit2/Shared/cf/ArgumentCodersCF.cpp:645 > + OSStatus status = SecItemCopyMatching((__bridge CFDictionaryRef)query.get(), &persistentRef); Do we need __bridge in WebKit code? > Source/WebKit2/Shared/cf/ArgumentCodersCF.cpp:652 > + if (CFGetTypeID(persistentRef) != CFDataGetTypeID()) { > + CFRelease(persistentRef); > + return nullptr; > + } Can this happen? Documentation says that kSecReturnPersistentRef always provides a CFDataRef. 1024297 5 mitz 2014-07-23 13:19:19 -0700 Fixed in <http://trac.webkit.org/r171485>. 235368 2014-07-23 12:24:01 -0700 2014-07-23 12:38:10 -0700 Specify an access group when creating a persistent reference to a key 135206.diff text/plain 3016 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTQ4MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA3LTIzICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3Nzgy NjIzPiBbaU9TXSBDbGllbnQtY2VydGlmaWNhdGUgYXV0aGVudGljYXRpb24gaXNu4oCZdCB3b3Jr aW5nIHdpdGggc29tZSBjZXJ0aWZpY2F0ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzNTIwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogU2hhcmVkL2NmL0FyZ3VtZW50Q29kZXJzQ0YuY3BwOgorICAg ICAgICAoSVBDOjpjb3B5UGVyc2lzdGVudFJlZik6IEFkZGVkIHRoaXMgaGVscGVyIGZ1bmN0aW9u LiBJdCBkaWZmZXJzIGZyb20KKyAgICAgICAgU2VjS2V5Q29weVBlcnNpc3RlbnRSZWYgaW4gdGhh dCBpZiBtdWx0aXBsZSBjb3BpZXMgb2YgdGhlIGtleSBleGlzdCBpbiB0aGUga2V5Y2hhaW4sIGl0 CisgICAgICAgIGVuc3VyZXMgdGhhdCB3ZSBnZXQgYSByZWZlcmVuY2UgdG8gdGhlIGNvcHkgdGhh dCBpcyBpbiB0aGUga2V5Y2hhaW4gYWNjZXNzIGdyb3VwIHRoYXQgdGhlCisgICAgICAgIE5ldHdv cmtpbmcgcHJvY2VzcyBjYW4gdXNlLgorICAgICAgICAoSVBDOjplbmNvZGUpOiBVc2UgY29weVBl cnNpc3RlbnRSZWYuCisKIDIwMTQtMDctMjMgIEJlbSBKb25lcy1CZXkgIDxiam9uZXNiZUBhZG9i ZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIENTU19FWENMVVNJT05TIGNvbXBpbGUgZmxhZyBhbmQg bGVmdG92ZXIgY29kZQpJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL2NmL0FyZ3VtZW50Q29k ZXJzQ0YuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9jZi9Bcmd1bWVu dENvZGVyc0NGLmNwcAkocmV2aXNpb24gMTcxMzU1KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVk L2NmL0FyZ3VtZW50Q29kZXJzQ0YuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Nyw3ICs0Nyw2IEBA IGV4dGVybiAiQyIgU2VjSWRlbnRpdHlSZWYgU2VjSWRlbnRpdHlDcmUKICNpbmNsdWRlIDxTZWN1 cml0eS9TZWNLZXlQcml2Lmg+CiAjZW5kaWYKIAotZXh0ZXJuICJDIiBPU1N0YXR1cyBTZWNLZXlD b3B5UGVyc2lzdGVudFJlZihTZWNLZXlSZWYga2V5LCBDRkRhdGFSZWYqIHBlcnNpc3RlbnRSZWYp OwogZXh0ZXJuICJDIiBPU1N0YXR1cyBTZWNLZXlGaW5kV2l0aFBlcnNpc3RlbnRSZWYoQ0ZEYXRh UmVmIHBlcnNpc3RlbnRSZWYsIFNlY0tleVJlZiogbG9va2VkVXBEYXRhKTsKICNlbmRpZgogCkBA IC02MzAsNiArNjI5LDMxIEBAIHZvaWQgc2V0QWxsb3dzRGVjb2RpbmdTZWNLZXlSZWYoYm9vbCBh bGwKIH0KICNlbmRpZgogCitzdGF0aWMgQ0ZEYXRhUmVmIGNvcHlQZXJzaXN0ZW50UmVmKFNlY0tl eVJlZiBrZXkpCit7CisgICAgLy8gVGhpcyBmdW5jdGlvbiBkaWZmZXJzIGZyb20gU2VjSXRlbUNv cHlQZXJzaXN0ZW50UmVmIGluIHRoYXQgaXQgc3BlY2lmaWVzIGFuIGFjY2VzcyBncm91cC4KKyAg ICAvLyBUaGlzIGlzIG5lY2Vzc2FyeSBpbiBjYXNlIHRoZXJlIGFyZSBtdWx0aXBsZSBjb3BpZXMg b2YgdGhlIGtleSBpbiB0aGUga2V5Y2hhaW4sIGJlY2F1c2Ugd2UKKyAgICAvLyBuZWVkIGEgcmVm ZXJlbmNlIHRvIHRoZSBvbmUgdGhhdCB0aGUgTmV0d29ya2luZyBwcm9jZXNzIHdpbGwgYmUgYWJs ZSB0byBhY2Nlc3MuCisgICAgUmV0YWluUHRyPE5TRGljdGlvbmFyeT4gcXVlcnkgPSBAeworICAg ICAgICAoaWQpa1NlY1JldHVyblBlcnNpc3RlbnRSZWY6IEBZRVMsCisgICAgICAgIChpZClrU2Vj VmFsdWVSZWY6IChpZClrZXksCisgICAgICAgIChpZClrU2VjQXR0clN5bmNocm9uaXphYmxlOiAo aWQpa1NlY0F0dHJTeW5jaHJvbml6YWJsZUFueSwKKyAgICAgICAgKGlkKWtTZWNBdHRyQWNjZXNz R3JvdXA6IEAiY29tLmFwcGxlLmlkZW50aXRpZXMiLAorICAgIH07CisKKyAgICBDRlR5cGVSZWYg cGVyc2lzdGVudFJlZiA9IG51bGxwdHI7CisgICAgT1NTdGF0dXMgc3RhdHVzID0gU2VjSXRlbUNv cHlNYXRjaGluZygoX19icmlkZ2UgQ0ZEaWN0aW9uYXJ5UmVmKXF1ZXJ5LmdldCgpLCAmcGVyc2lz dGVudFJlZik7CisgICAgaWYgKHN0YXR1cyB8fCAhcGVyc2lzdGVudFJlZikKKyAgICAgICAgcmV0 dXJuIG51bGxwdHI7CisKKyAgICBpZiAoQ0ZHZXRUeXBlSUQocGVyc2lzdGVudFJlZikgIT0gQ0ZE YXRhR2V0VHlwZUlEKCkpIHsKKyAgICAgICAgQ0ZSZWxlYXNlKHBlcnNpc3RlbnRSZWYpOworICAg ICAgICByZXR1cm4gbnVsbHB0cjsKKyAgICB9CisKKyAgICByZXR1cm4gc3RhdGljX2Nhc3Q8Q0ZE YXRhUmVmPihwZXJzaXN0ZW50UmVmKTsKK30KKwogdm9pZCBlbmNvZGUoQXJndW1lbnRFbmNvZGVy JiBlbmNvZGVyLCBTZWNJZGVudGl0eVJlZiBpZGVudGl0eSkKIHsKICAgICBTZWNDZXJ0aWZpY2F0 ZVJlZiBjZXJ0aWZpY2F0ZSA9IG51bGxwdHI7CkBAIC02NDIsNyArNjY2LDcgQEAgdm9pZCBlbmNv ZGUoQXJndW1lbnRFbmNvZGVyJiBlbmNvZGVyLCBTZQogCiAgICAgQ0ZEYXRhUmVmIGtleURhdGEg PSBudWxscHRyOwogI2lmIFBMQVRGT1JNKElPUykKLSAgICBTZWNLZXlDb3B5UGVyc2lzdGVudFJl ZihrZXksICZrZXlEYXRhKTsKKyAgICBrZXlEYXRhID0gY29weVBlcnNpc3RlbnRSZWYoa2V5KTsK ICNlbmRpZgogI2lmIFBMQVRGT1JNKE1BQykKICAgICBTZWNLZXljaGFpbkl0ZW1DcmVhdGVQZXJz aXN0ZW50UmVmZXJlbmNlKChTZWNLZXljaGFpbkl0ZW1SZWYpa2V5LCAma2V5RGF0YSk7Cg==