135201 2014-07-23 10:28:09 -0700 [WinCairo] Gstreamer rendering is not working. 2014-07-23 14:56:53 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen alex.christensen bfulgham commit-queue oldest_to_newest 1024255 0 peavo 2014-07-23 10:28:09 -0700 Gstreamer is not enabled on WinCairo, but if someone should want to try it out, rendering is not working. 1024256 1 235357 peavo 2014-07-23 10:32:01 -0700 Created attachment 235357 Patch 1024308 2 achristensen 2014-07-23 13:49:09 -0700 This could be implemented someday. Could you put a FIXME comment saying that it just hasn't been implemented yet? 1024316 3 235374 peavo 2014-07-23 14:00:39 -0700 Created attachment 235374 Patch 1024317 4 peavo 2014-07-23 14:01:29 -0700 (In reply to comment #2) > This could be implemented someday. Could you put a FIXME comment saying that it just hasn't been implemented yet? Thanks for reviewing, updated patch :) 1024349 5 235374 commit-queue 2014-07-23 14:56:51 -0700 Comment on attachment 235374 Patch Clearing flags on attachment: 235374 Committed r171492: <http://trac.webkit.org/changeset/171492> 1024350 6 commit-queue 2014-07-23 14:56:53 -0700 All reviewed patches have been landed. Closing bug. 235357 2014-07-23 10:32:01 -0700 2014-07-23 14:00:29 -0700 Patch bug-135201-20140723193137.patch text/plain 1605 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTQ3OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA3LTIzICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gR3N0 cmVhbWVyIHJlbmRlcmluZyBpcyBub3Qgd29ya2luZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTIwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdpbkNhaXJvIGRvZXMgbm90IHN1cHBvcnQgYWNjZWxl cmF0ZWQgcmVuZGVyaW5nIHlldC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmg6CisgICAgICAgIChXZWJDb3Jl OjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjpzdXBwb3J0c0FjY2VsZXJhdGVkUmVu ZGVyaW5nKToKKwogMjAxNC0wNy0yMyAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4K IAogICAgICAgICBbTVNFXVtNYWNdIFN1cHBvcnQgYWJvcnQoKSBpbiBTb3VyY2VCdWZmZXJQcml2 YXRlQVZGT2JqQy4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lckJhc2UuaAkocmV2aXNpb24gMTcxNDc4KQorKysgU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2Uu aAkod29ya2luZyBjb3B5KQpAQCAtOTgsNyArOTgsMTEgQEAgcHVibGljOgogCiAjaWYgVVNFKFRF WFRVUkVfTUFQUEVSX0dMKSAmJiAhVVNFKENPT1JESU5BVEVEX0dSQVBISUNTKQogICAgIHZpcnR1 YWwgUGxhdGZvcm1MYXllciogcGxhdGZvcm1MYXllcigpIGNvbnN0IHsgcmV0dXJuIGNvbnN0X2Nh c3Q8TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZSo+KHRoaXMpOyB9CisjaWYgUExBVEZP Uk0oV0lOX0NBSVJPKQorICAgIHZpcnR1YWwgYm9vbCBzdXBwb3J0c0FjY2VsZXJhdGVkUmVuZGVy aW5nKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KKyNlbHNlCiAgICAgdmlydHVhbCBib29sIHN1 cHBvcnRzQWNjZWxlcmF0ZWRSZW5kZXJpbmcoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9CisjZW5k aWYKICAgICB2aXJ0dWFsIHZvaWQgcGFpbnRUb1RleHR1cmVNYXBwZXIoVGV4dHVyZU1hcHBlcios IGNvbnN0IEZsb2F0UmVjdCYsIGNvbnN0IFRyYW5zZm9ybWF0aW9uTWF0cml4JiwgZmxvYXQpOwog I2VuZGlmCiAK 235374 2014-07-23 14:00:39 -0700 2014-07-23 14:56:51 -0700 Patch bug-135201-20140723230014.patch text/plain 1709 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTQ4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA3LTIzICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gR3N0 cmVhbWVyIHJlbmRlcmluZyBpcyBub3Qgd29ya2luZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTIwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdpbkNhaXJvIGRvZXMgbm90IHN1cHBvcnQgYWNjZWxl cmF0ZWQgcmVuZGVyaW5nIHlldC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmg6CisgICAgICAgIChXZWJDb3Jl OjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjpzdXBwb3J0c0FjY2VsZXJhdGVkUmVu ZGVyaW5nKToKKwogMjAxNC0wNy0yMyAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3 ZWJraXQub3JnPgogCiAgICAgICAgIENvbXBpbGUgd2luZG93LWluYWN0aXZlIGFuZCBmdWxsc2Ny ZWVuIHBzZXVkb2NsYXNzZXMgaW4gY3NzIHNlbGVjdG9ycy4KSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJC YXNlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuaAkocmV2aXNpb24gMTcxNDc4 KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuaAkod29ya2luZyBjb3B5KQpAQCAtOTgsNyArOTgsMTIg QEAgcHVibGljOgogCiAjaWYgVVNFKFRFWFRVUkVfTUFQUEVSX0dMKSAmJiAhVVNFKENPT1JESU5B VEVEX0dSQVBISUNTKQogICAgIHZpcnR1YWwgUGxhdGZvcm1MYXllciogcGxhdGZvcm1MYXllcigp IGNvbnN0IHsgcmV0dXJuIGNvbnN0X2Nhc3Q8TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFz ZSo+KHRoaXMpOyB9CisjaWYgUExBVEZPUk0oV0lOX0NBSVJPKQorICAgIC8vIEZJWE1FOiBBY2Nl bGVyYXRlZCByZW5kZXJpbmcgaGFzIG5vdCBiZWVuIGltcGxlbWVudGVkIGZvciBXaW5DYWlybyB5 ZXQuCisgICAgdmlydHVhbCBib29sIHN1cHBvcnRzQWNjZWxlcmF0ZWRSZW5kZXJpbmcoKSBjb25z dCB7IHJldHVybiBmYWxzZTsgfQorI2Vsc2UKICAgICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHNBY2Nl bGVyYXRlZFJlbmRlcmluZygpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KKyNlbmRpZgogICAgIHZp cnR1YWwgdm9pZCBwYWludFRvVGV4dHVyZU1hcHBlcihUZXh0dXJlTWFwcGVyKiwgY29uc3QgRmxv YXRSZWN0JiwgY29uc3QgVHJhbnNmb3JtYXRpb25NYXRyaXgmLCBmbG9hdCk7CiAjZW5kaWYKIAo=