135199 2014-07-23 09:18:12 -0700 [Win] Use NO_RETURN_DUE_TO_CRASH on Windows 2014-07-23 11:19:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham benjamin bfulgham cmarcelo commit-queue d-r fmalita fpizlo gyuyoung.kim mark.lam pdr schenney sergio oldest_to_newest 1024237 0 bfulgham 2014-07-23 09:18:12 -0700 The NO_RETURN_DUE_TO_CRASH macro is defined for Clang as NO_RETURN. We have a NO_RETURN implementation on Windows; let's use it! This patch activates NO_RETURN_DUE_TO_CRASH, and makes sure the declaration is made in the appropriate part of the function call to satisfy the MSVC compiler. 1024242 1 235354 bfulgham 2014-07-23 09:30:25 -0700 Created attachment 235354 Patch 1024245 2 235354 mark.lam 2014-07-23 09:50:42 -0700 Comment on attachment 235354 Patch r=me 1024274 3 bfulgham 2014-07-23 11:19:15 -0700 Committed r171482: <http://trac.webkit.org/changeset/171482> 235354 2014-07-23 09:30:25 -0700 2014-07-23 09:50:41 -0700 Patch bug-135199-20140723093026.patch text/plain 5626 bfulgham SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcxNDc3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTA3LTIzICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAg ICAgIFtXaW5dIFVzZSBOT19SRVRVUk5fRFVFX1RPX0NSQVNIIG9uIFdpbmRvd3MKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTE5OQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICoganNjLmNwcDoKKyAgICAg ICAgKFdURjo6UnVudGltZUFycmF5OjpkZWxldGVQcm9wZXJ0eSk6IFN0b3AgdXNpbmcgdWdseQor ICAgICAgICBjb21waWxlciB3b3JrLWFyb3VuZCBvbiBXaW5kb3dzOyB1c2UgTk9fUkVUVVJOX0RV RV9UT19DUkFTSAorICAgICAgICBjb2RlcGF0aCBpbnN0ZWFkLgorCiAyMDE0LTA3LTIzICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2Vk LCByb2xsaW5nIG91dCByMTcxMzY3LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAJKHJldmlzaW9u IDE3MTM5NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zNTYsNyArMzU2LDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBOT19SRVRVUk5fRFVFX1RP X0NSQVNIIGJvb2wgZGVsZXRlUHJvcGVydHkoSlNDZWxsKiwgRXhlY1N0YXRlKiwgUHJvcGVydHlO YW1lKQogICAgIHsKICAgICAgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSNpZiAh Q09NUElMRVIoQ0xBTkcpCisjaWYgIUNPTVBJTEVSKENMQU5HKSAmJiAhQ09NUElMRVIoTVNWQykK ICAgICAgICAgcmV0dXJuIHRydWU7CiAjZW5kaWYKICAgICB9CkluZGV4OiBTb3VyY2UvV1RGL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL0NoYW5nZUxvZwkocmV2aXNpb24gMTcx NDc3KQorKysgU291cmNlL1dURi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx MyBAQAorMjAxNC0wNy0yMyAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KKwor ICAgICAgICBbV2luXSBVc2UgTk9fUkVUVVJOX0RVRV9UT19DUkFTSCBvbiBXaW5kb3dzLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1MTkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9Bc3NlcnRp b25zLmg6IEFkZCBNU1ZDIHRvIGxpc3Qgb2YgY29tcGlsZXJzIHN1cHBvcnRpbmcgdGhpcyBtYWNy by4KKyAgICAgICAgKiB3dGYvRmFzdE1hbGxvYy5jcHA6IENvcnJlY3QgZnVuY3Rpb24gZGVjbGFy YXRpb24gZm9yIE5PX1JFVFVSTl9EVUVfVE9fQ1JBU0guCisKIDIwMTQtMDctMjIgIEZpbGlwIFBp emxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBNZXJnZSByMTY5MTQ4LCByMTY5MTg1 LCByMTY5MTg4LCByMTY5NTc4LCByMTY5NTgyLCByMTY5NTg0LCByMTY5NTg4LCByMTY5NzUzIGZy b20gZnRsb3B0LgpJbmRleDogU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAkocmV2aXNpb24gMTcxMzkyKQorKysgU291 cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTEsNyArMTExLDcg QEAgZXh0ZXJuICJDIiB7CiAKICAgIFNpZ25hbHMgYXJlIGlnbm9yZWQgYnkgdGhlIGNyYXNoIHJl cG9ydGVyIG9uIE9TIFggc28gd2UgbXVzdCBkbyBiZXR0ZXIuCiAqLwotI2lmIENPTVBJTEVSKENM QU5HKQorI2lmIENPTVBJTEVSKENMQU5HKSB8fCBDT01QSUxFUihNU1ZDKQogI2RlZmluZSBOT19S RVRVUk5fRFVFX1RPX0NSQVNIIE5PX1JFVFVSTgogI2Vsc2UKICNkZWZpbmUgTk9fUkVUVVJOX0RV RV9UT19DUkFTSApAQCAtMTMzLDcgKzEzMyw3IEBAIFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIFdU RkxvZyhXVEZMb2dDaGEKIFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIFdURkxvZ1ZlcmJvc2UoY29u c3QgY2hhciogZmlsZSwgaW50IGxpbmUsIGNvbnN0IGNoYXIqIGZ1bmN0aW9uLCBXVEZMb2dDaGFu bmVsKiwgY29uc3QgY2hhciogZm9ybWF0LCAuLi4pIFdURl9BVFRSSUJVVEVfUFJJTlRGKDUsIDYp OwogV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgV1RGTG9nQWx3YXlzVihjb25zdCBjaGFyKiBmb3Jt YXQsIHZhX2xpc3QpOwogV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgV1RGTG9nQWx3YXlzKGNvbnN0 IGNoYXIqIGZvcm1hdCwgLi4uKSBXVEZfQVRUUklCVVRFX1BSSU5URigxLCAyKTsKLVdURl9FWFBP UlRfUFJJVkFURSB2b2lkIFdURkxvZ0Fsd2F5c0FuZENyYXNoKGNvbnN0IGNoYXIqIGZvcm1hdCwg Li4uKSBXVEZfQVRUUklCVVRFX1BSSU5URigxLCAyKSBOT19SRVRVUk5fRFVFX1RPX0NSQVNIOwor V1RGX0VYUE9SVF9QUklWQVRFIE5PX1JFVFVSTl9EVUVfVE9fQ1JBU0ggdm9pZCBXVEZMb2dBbHdh eXNBbmRDcmFzaChjb25zdCBjaGFyKiBmb3JtYXQsIC4uLikgV1RGX0FUVFJJQlVURV9QUklOVEYo MSwgMik7CiBXVEZfRVhQT1JUX1BSSVZBVEUgV1RGTG9nQ2hhbm5lbCogV1RGTG9nQ2hhbm5lbEJ5 TmFtZShXVEZMb2dDaGFubmVsKltdLCBzaXplX3QgY291bnQsIGNvbnN0IGNoYXIqKTsKIFdURl9F WFBPUlRfUFJJVkFURSB2b2lkIFdURkluaXRpYWxpemVMb2dDaGFubmVsU3RhdGVzRnJvbVN0cmlu ZyhXVEZMb2dDaGFubmVsKltdLCBzaXplX3QgY291bnQsIGNvbnN0IGNoYXIqKTsKIApAQCAtMTU2 LDcgKzE1Niw3IEBAIFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIFdURkluc3RhbGxSZXBvcnQKICNp ZmRlZiBfX2NwbHVzcGx1cwogZXh0ZXJuICJDIiB7CiAjZW5kaWYKLVdURl9FWFBPUlRfUFJJVkFU RSB2b2lkIFdURkNyYXNoKCkgTk9fUkVUVVJOX0RVRV9UT19DUkFTSDsKKyAgICBXVEZfRVhQT1JU X1BSSVZBVEUgTk9fUkVUVVJOX0RVRV9UT19DUkFTSCB2b2lkIFdURkNyYXNoKCk7CiAjaWZkZWYg X19jcGx1c3BsdXMKIH0KICNlbmRpZgpAQCAtMTY4LDcgKzE2OCw3IEBAIFdURl9FWFBPUlRfUFJJ VkFURSB2b2lkIFdURkNyYXNoKCkgTk9fUkUKICNpZmRlZiBfX2NwbHVzcGx1cwogZXh0ZXJuICJD IiB7CiAjZW5kaWYKLSAgICBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBXVEZDcmFzaFdpdGhTZWN1 cml0eUltcGxpY2F0aW9uKCkgTk9fUkVUVVJOX0RVRV9UT19DUkFTSDsKKyAgICBXVEZfRVhQT1JU X1BSSVZBVEUgTk9fUkVUVVJOX0RVRV9UT19DUkFTSCB2b2lkIFdURkNyYXNoV2l0aFNlY3VyaXR5 SW1wbGljYXRpb24oKTsKICNpZmRlZiBfX2NwbHVzcGx1cwogfQogI2VuZGlmCkluZGV4OiBTb3Vy Y2UvV1RGL3d0Zi9GYXN0TWFsbG9jLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9G YXN0TWFsbG9jLmNwcAkocmV2aXNpb24gMTcxMzkyKQorKysgU291cmNlL1dURi93dGYvRmFzdE1h bGxvYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE4OSw3ICsxODksNyBAQCBuYW1lc3BhY2UgV1RG IHsKIAogbmFtZXNwYWNlIEludGVybmFsIHsKICNpZiAhRU5BQkxFKFdURl9NQUxMT0NfVkFMSURB VElPTikKLVdURl9FWFBPUlRfUFJJVkFURSB2b2lkIGZhc3RNYWxsb2NNYXRjaEZhaWxlZCh2b2lk Kik7CitXVEZfRVhQT1JUX1BSSVZBVEUgTk9fUkVUVVJOX0RVRV9UT19DUkFTSCB2b2lkIGZhc3RN YWxsb2NNYXRjaEZhaWxlZCh2b2lkKik7CiAjZWxzZQogQ09NUElMRV9BU1NFUlQoKChzaXplb2Yo VmFsaWRhdGlvbkhlYWRlcikgJSBzaXplb2YoQWxsb2NBbGlnbm1lbnRJbnRlZ2VyKSkgPT0gMCks IFZhbGlkYXRpb25IZWFkZXJfbXVzdF9wcm9kdWNlX2NvcnJlY3RfYWxpZ25tZW50KTsKICNlbmRp ZgpJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcxNDc4KQorKysgU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMDctMjMgIEJyZW50 IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW1dpbl0gVXNlIE5PX1JF VFVSTl9EVUVfVE9fQ1JBU0ggb24gV2luZG93cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBzdmcvU1ZHWm9vbUFuZFBhbi5oOiBBZGQgTk9fUkVUVVJO X0RVRV9UT19DUkFTSCB0bworICAgICAgICBoZWFkZXIgc28gZnVuY3Rpb24gZGVjbGFyYXRpb25z IG1hdGNoIGltcGxlbWVudGF0aW9uLgorCiAyMDE0LTA3LTIzICBKZXIgTm9ibGUgIDxqZXIubm9i bGVAYXBwbGUuY29tPgogCiAgICAgICAgIFtNU0VdW01hY10gU3VwcG9ydCBhYm9ydCgpIGluIFNv dXJjZUJ1ZmZlclByaXZhdGVBVkZPYmpDLgpJbmRleDogU291cmNlL1dlYkNvcmUvc3ZnL1NWR1pv b21BbmRQYW4uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZHWm9vbUFuZFBh bi5oCShyZXZpc2lvbiAxNzEzOTIpCisrKyBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZHWm9vbUFuZFBh bi5oCSh3b3JraW5nIGNvcHkpCkBAIC03Niw5ICs3Niw5IEBAIHB1YmxpYzoKIAogICAgIC8vIFRo ZXNlIG1ldGhvZHMgb25seSBleGlzdCB0byBhbGxvdyB1cyB0byBjb21waWxlIEpTU1ZHWm9vbUFu ZFBhbi4qLgogICAgIC8vIFRoZXNlIGFyZSBuZXZlciBjYWxsZWQsIGFuZCB0aHVzIEFTU0VSVF9O T1RfUkVBQ0hFRC4KLSAgICB2b2lkIHJlZigpOwotICAgIHZvaWQgZGVyZWYoKTsKLSAgICB2b2lk IHNldFpvb21BbmRQYW4odW5zaWduZWQgc2hvcnQpOworICAgIE5PX1JFVFVSTl9EVUVfVE9fQVNT RVJUIHZvaWQgcmVmKCk7CisgICAgTk9fUkVUVVJOX0RVRV9UT19BU1NFUlQgdm9pZCBkZXJlZigp OworICAgIE5PX1JFVFVSTl9EVUVfVE9fQVNTRVJUIHZvaWQgc2V0Wm9vbUFuZFBhbih1bnNpZ25l ZCBzaG9ydCk7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==