135177 2014-07-22 14:37:35 -0700 REGRESSION (r171239): Much more time spent taking snapshots during the PLT 2014-07-23 03:25:30 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 135190 1 thorton thorton commit-queue mitz rniwa sam simon.fraser oldest_to_newest 1024071 0 thorton 2014-07-22 14:37:35 -0700 We're taking way more snapshots now due to a mistake in r171239. <rdar://problem/17764847> 1024073 1 235316 thorton 2014-07-22 14:43:28 -0700 Created attachment 235316 patch 1024075 2 thorton 2014-07-22 14:47:11 -0700 http://trac.webkit.org/changeset/171366 1024169 3 ap 2014-07-22 22:53:15 -0700 This change broke three API tests, so I'm going to roll out. Tests that failed: WKUserContentController.ScriptMessageHandlerWithNavigation WebKit2.RestoreSessionStateContainingFormData Tests that timed out: DeviceScaleFactorOnBack.WebKit2 1024172 4 commit-queue 2014-07-22 23:00:02 -0700 Re-opened since this is blocked by bug 135190 1024197 5 thorton 2014-07-23 03:04:54 -0700 What! How is that possible? I added this message very recently and the *only* thing it does is take a snapshot. Will investigate. 1024198 6 thorton 2014-07-23 03:16:49 -0700 The UI process is stuck in a HashTable lock adding a string to the AtomicString table under decidePolicyForResponse. Still unclear how I could have influenced this. 1024199 7 thorton 2014-07-23 03:19:03 -0700 Given http://trac.webkit.org/changeset/171367 I wonder if ap was off-by-one somehow. Testing now. 1024200 8 thorton 2014-07-23 03:23:48 -0700 Rolling out my patch changes nothing, rolling out Joe's fixes all three tests. gg. 1024203 9 thorton 2014-07-23 03:25:30 -0700 (In reply to comment #8) > Rolling out my patch changes nothing, rolling out Joe's fixes all three tests. gg. Rolled this one back in in http://trac.webkit.org/changeset/171471, will go roll Joe out. 235316 2014-07-22 14:43:28 -0700 2014-07-22 14:45:51 -0700 patch snapshot-frequency.diff text/plain 5176 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhOWE4ZTA5Li5jMzIzNWEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTQtMDctMjIgIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxNzEyMzkpOiBNdWNoIG1vcmUgdGltZSBzcGVudCB0 YWtpbmcgc25hcHNob3RzIGR1cmluZyB0aGUgUExUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzUxNzcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3 NzY0ODQ3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQ cm94eTo6d2lsbENoYW5nZUN1cnJlbnRIaXN0b3J5SXRlbUZvck1haW5GcmFtZSk6CisgICAgICAg IChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6d2lsbENoYW5nZUN1cnJlbnRIaXN0b3J5SXRlbSk6IERl bGV0ZWQuCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oOgorICAgICAgICAqIFVJ UHJvY2Vzcy9XZWJQYWdlUHJveHkubWVzc2FnZXMuaW46CisgICAgICAgICogV2ViUHJvY2Vzcy9X ZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYkZyYW1lTG9hZGVyQ2xpZW50Ojp3aWxsQ2hhbmdlQ3VycmVudEhpc3RvcnlJdGVtKToKKyAg ICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYlBhZ2U6OndpbGxDaGFuZ2VDdXJyZW50SGlzdG9yeUl0ZW1Gb3JNYWluRnJhbWUpOgorICAg ICAgICAoV2ViS2l0OjpXZWJQYWdlOjp3aWxsQ2hhbmdlQ3VycmVudEhpc3RvcnlJdGVtKTogRGVs ZXRlZC4KKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oOgorICAgICAgICBS ZW5hbWUgV2lsbENoYW5nZUN1cnJlbnRIaXN0b3J5SXRlbSB0byBXaWxsQ2hhbmdlQ3VycmVudEhp c3RvcnlJdGVtRm9yTWFpbkZyYW1lLgorICAgICAgICBPbmx5IHNlbmQgaXQgd2hlbiB0aGUgY3Vy cmVudCBoaXN0b3J5IGl0ZW0gZm9yIHRoZSBtYWluIGZyYW1lIGNoYW5nZXMuCisKIDIwMTQtMDct MjIgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2lP U11bV0syXSBVSSBoZWxwZXJzIHRoYXQgem9vbSBvbiBhbiBlbGVtZW50IGlnbm9yZSB0aGUgdmll d3BvcnQncyBhbGxvd3NVc2VyU2NhbGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFn ZVByb3h5LmNwcAppbmRleCA3ZjU4NGEzLi5iNWFmMzg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtNTE3MSw3ICs1MTcxLDcgQEAgdm9pZCBXZWJQYWdl UHJveHk6Om5hdmlnYXRpb25HZXN0dXJlU25hcHNob3RXYXNSZW1vdmVkKCkKICAgICBtX2lzU2hv d2luZ05hdmlnYXRpb25HZXN0dXJlU25hcHNob3QgPSBmYWxzZTsKIH0KIAotdm9pZCBXZWJQYWdl UHJveHk6OndpbGxDaGFuZ2VDdXJyZW50SGlzdG9yeUl0ZW0oKQordm9pZCBXZWJQYWdlUHJveHk6 OndpbGxDaGFuZ2VDdXJyZW50SGlzdG9yeUl0ZW1Gb3JNYWluRnJhbWUoKQogewogICAgIHJlY29y ZE5hdmlnYXRpb25TbmFwc2hvdCgpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1dlYlBhZ2VQcm94eS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5oCmluZGV4IGJlMjcwN2QuLjBkNGUwMDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmgKQEAgLTEwMzEsNyArMTAzMSw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBk aWRCbG9ja0luc2VjdXJlUGx1Z2luVmVyc2lvbihjb25zdCBTdHJpbmcmIG1pbWVUeXBlLCBjb25z dCBTdHJpbmcmIHBsdWdpblVSTFN0cmluZywgY29uc3QgU3RyaW5nJiBmcmFtZVVSTFN0cmluZywg Y29uc3QgU3RyaW5nJiBwYWdlVVJMU3RyaW5nLCBib29sIHJlcGxhY2VtZW50T2JzY3VyZWQpOwog I2VuZGlmIC8vIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQogICAgIHZvaWQgc2V0Q2FuU2hv cnRDaXJjdWl0SG9yaXpvbnRhbFdoZWVsRXZlbnRzKGJvb2wgY2FuU2hvcnRDaXJjdWl0SG9yaXpv bnRhbFdoZWVsRXZlbnRzKSB7IG1fY2FuU2hvcnRDaXJjdWl0SG9yaXpvbnRhbFdoZWVsRXZlbnRz ID0gY2FuU2hvcnRDaXJjdWl0SG9yaXpvbnRhbFdoZWVsRXZlbnRzOyB9Ci0gICAgdm9pZCB3aWxs Q2hhbmdlQ3VycmVudEhpc3RvcnlJdGVtKCk7CisgICAgdm9pZCB3aWxsQ2hhbmdlQ3VycmVudEhp c3RvcnlJdGVtRm9yTWFpbkZyYW1lKCk7CiAKICAgICB2b2lkIHJlYXR0YWNoVG9XZWJQcm9jZXNz KCk7CiAgICAgdWludDY0X3QgcmVhdHRhY2hUb1dlYlByb2Nlc3NXaXRoSXRlbShXZWJCYWNrRm9y d2FyZExpc3RJdGVtKik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi UGFnZVByb3h5Lm1lc3NhZ2VzLmluIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5tZXNzYWdlcy5pbgppbmRleCBiMGYxOWJmLi5mODAyNTJmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5Lm1lc3NhZ2VzLmluCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkubWVzc2FnZXMuaW4KQEAgLTQwNCw3ICs0 MDQsNyBAQCBtZXNzYWdlcyAtPiBXZWJQYWdlUHJveHkgewogICAgIERpZEZpbmlzaExvYWRGb3JR dWlja0xvb2tEb2N1bWVudEluTWFpbkZyYW1lKFdlYktpdDo6UXVpY2tMb29rRG9jdW1lbnREYXRh IGRhdGEpCiAjZW5kaWYKIAotICAgIFdpbGxDaGFuZ2VDdXJyZW50SGlzdG9yeUl0ZW0oKQorICAg IFdpbGxDaGFuZ2VDdXJyZW50SGlzdG9yeUl0ZW1Gb3JNYWluRnJhbWUoKQogCiAjaWYgVVNFKENP TlRFTlRfRklMVEVSSU5HKQogICAgIENvbnRlbnRGaWx0ZXJEaWRCbG9ja0xvYWRGb3JGcmFtZShX ZWJDb3JlOjpDb250ZW50RmlsdGVyIGNvbnRlbnRGaWx0ZXIsIHVpbnQ2NF90IGZyYW1lSUQpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZy YW1lTG9hZGVyQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1 cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCmluZGV4IGY1NTBlYjUuLjZkYzI4OGMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJh bWVMb2FkZXJDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29y ZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCkBAIC0xNjI2LDggKzE2MjYsMTAgQEAg dm9pZCBXZWJGcmFtZUxvYWRlckNsaWVudDo6d2lsbENoYW5nZUN1cnJlbnRIaXN0b3J5SXRlbSgp CiAgICAgV2ViUGFnZSogd2ViUGFnZSA9IG1fZnJhbWUtPnBhZ2UoKTsKICAgICBpZiAoIXdlYlBh Z2UpCiAgICAgICAgIHJldHVybjsKKyAgICBpZiAoIW1fZnJhbWUtPmlzTWFpbkZyYW1lKCkpCisg ICAgICAgIHJldHVybjsKIAotICAgIHdlYlBhZ2UtPndpbGxDaGFuZ2VDdXJyZW50SGlzdG9yeUl0 ZW0oKTsKKyAgICB3ZWJQYWdlLT53aWxsQ2hhbmdlQ3VycmVudEhpc3RvcnlJdGVtRm9yTWFpbkZy YW1lKCk7CiB9CiAKICNpZiBVU0UoQ09OVEVOVF9GSUxURVJJTkcpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKaW5kZXggMWMyZWQ4YS4uM2YwMTBhZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcApAQCAt NDg0OCw5ICs0ODQ4LDkgQEAgdm9pZCBXZWJQYWdlOjpkaWRDaGFuZ2VTY3JvbGxPZmZzZXRGb3JG cmFtZShGcmFtZSogZnJhbWUpCiAgICAgdXBkYXRlTWFpbkZyYW1lU2Nyb2xsT2Zmc2V0UGlubmlu ZygpOwogfQogCi12b2lkIFdlYlBhZ2U6OndpbGxDaGFuZ2VDdXJyZW50SGlzdG9yeUl0ZW0oKQor dm9pZCBXZWJQYWdlOjp3aWxsQ2hhbmdlQ3VycmVudEhpc3RvcnlJdGVtRm9yTWFpbkZyYW1lKCkK IHsKLSAgICBzZW5kKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OldpbGxDaGFuZ2VDdXJyZW50SGlz dG9yeUl0ZW0oKSk7CisgICAgc2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpXaWxsQ2hhbmdl Q3VycmVudEhpc3RvcnlJdGVtRm9yTWFpbkZyYW1lKCkpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBX ZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQ YWdlLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCmluZGV4 IGZiZmZiMjMuLjhhMTA3MmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9XZWJQYWdlLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L1dlYlBhZ2UuaApAQCAtODQyLDcgKzg0Miw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgZGlkQ2hh bmdlU2Nyb2xsT2Zmc2V0Rm9yRnJhbWUoV2ViQ29yZTo6RnJhbWUqKTsKIAotICAgIHZvaWQgd2ls bENoYW5nZUN1cnJlbnRIaXN0b3J5SXRlbSgpOworICAgIHZvaWQgd2lsbENoYW5nZUN1cnJlbnRI aXN0b3J5SXRlbUZvck1haW5GcmFtZSgpOwogCiBwcml2YXRlOgogICAgIFdlYlBhZ2UodWludDY0 X3QgcGFnZUlELCBjb25zdCBXZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzJik7Cg==