135149 2014-07-21 23:16:22 -0700 Reproducible ASSERT_NOT_REACHED in SelectorChecker::checkOne on my.yahoo.com 2014-07-23 10:40:29 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton achristensen achristensen benjamin commit-queue simon.fraser thorton oldest_to_newest 1023891 0 thorton 2014-07-21 23:16:22 -0700 Steps to Reproduce: 1. Load my.yahoo.com while logged into yahoo. 2. Wait. Expected: No assert! Actual: An assertion failure: Notes: I'm using UI-side compositing in Minibrowser but it seems unlikely either of those are prerequisites for this failure. SHOULD NEVER BE REACHED /Users/thorton/src/WebKit/OpenSource/Source/WebCore/css/SelectorChecker.cpp(793) : bool WebCore::SelectorChecker::checkOne(const WebCore::SelectorChecker::SelectorCheckingContext &) const 1 0x10abecf10 WTFCrash 2 0x10d912b13 WebCore::SelectorChecker::checkOne(WebCore::SelectorChecker::SelectorCheckingContext const&) const 3 0x10d910c1e WebCore::SelectorChecker::matchRecursively(WebCore::SelectorChecker::SelectorCheckingContext const&, WebCore::PseudoId&) const 4 0x10d9112cf WebCore::SelectorChecker::matchRecursively(WebCore::SelectorChecker::SelectorCheckingContext const&, WebCore::PseudoId&) const 5 0x10d9112cf WebCore::SelectorChecker::matchRecursively(WebCore::SelectorChecker::SelectorCheckingContext const&, WebCore::PseudoId&) const 6 0x10d910b1a WebCore::SelectorChecker::match(WebCore::SelectorChecker::SelectorCheckingContext const&) const 7 0x10c5689a0 WebCore::ElementRuleCollector::ruleMatches(WebCore::RuleData const&) 8 0x10c566ec5 WebCore::ElementRuleCollector::collectMatchingRulesForList(WTF::Vector<WebCore::RuleData, 0ul, WTF::CrashOnOverflow> const*, WebCore::MatchRequest const&, WebCore::StyleResolver::RuleRange&) 9 0x10c566c76 WebCore::ElementRuleCollector::collectMatchingRules(WebCore::MatchRequest const&, WebCore::StyleResolver::RuleRange&) 10 0x10c5674c8 WebCore::ElementRuleCollector::matchAuthorRules(bool) 11 0x10da346ce WebCore::invalidateStyleRecursively(WebCore::Element&, WebCore::SelectorFilter&, WebCore::DocumentRuleSets const&) [ ... a bunch of levels of recursion elided ... ] 27 0x10da347e7 WebCore::invalidateStyleRecursively(WebCore::Element&, WebCore::SelectorFilter&, WebCore::DocumentRuleSets const&) 28 0x10da3462d WebCore::StyleInvalidationAnalysis::invalidateStyle(WebCore::Document&) 29 0x10c42f368 WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange(WebCore::DocumentStyleSheetCollection::UpdateFlag, WTF::Vector<WTF::RefPtr<WebCore::CSSStyleSheet>, 0ul, WTF::CrashOnOverflow> const&, WebCore::DocumentStyleSheetCollection::StyleResolverUpdateType&, bool&) 30 0x10c42f4bf WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets(WebCore::DocumentStyleSheetCollection::UpdateFlag) 31 0x10c3acb04 WebCore::Document::styleResolverChanged(WebCore::StyleResolverUpdateFlag) 1023892 1 thorton 2014-07-21 23:21:25 -0700 (lldb) p selector->pseudoClassType() (WebCore::CSSSelector::PseudoClassType) $0 = PseudoClassWindowInactive Which does indeed seem to be missing from that switch. 1024078 2 achristensen 2014-07-22 14:57:20 -0700 I'll look into this. It is quite upsetting that this was not caught with a test :( 1024113 3 235327 achristensen 2014-07-22 17:05:01 -0700 Created attachment 235327 Patch 1024116 4 235327 thorton 2014-07-22 17:19:15 -0700 Comment on attachment 235327 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235327&action=review > Source/WebCore/css/SelectorChecker.cpp:-792 > - default: A++ 1024128 5 235327 commit-queue 2014-07-22 18:02:22 -0700 Comment on attachment 235327 Patch Clearing flags on attachment: 235327 Committed r171378: <http://trac.webkit.org/changeset/171378> 1024129 6 commit-queue 2014-07-22 18:02:29 -0700 All reviewed patches have been landed. Closing bug. 1024186 7 235327 benjamin 2014-07-23 01:10:31 -0700 Comment on attachment 235327 Patch I am only catching up with my mails now. This is amazing. The lack of tests for something this simple baffles me. Can you please add PseudoClassWindowInactive as an unoptimizedPseudoClass to the CSS JIT? In SelectorChecker, you should remove the branch "if (context.hasSelectionPseudo) -> check for :window-inactive". Can you please also add a test for style resolution? It is common to find bugs that only appear in one of style-resolution/querySelector. 1024261 8 achristensen 2014-07-23 10:40:29 -0700 (In reply to comment #7) > (From update of attachment 235327 [details]) > I am only catching up with my mails now. This is amazing. The lack of tests for something this simple baffles me. > > Can you please add PseudoClassWindowInactive as an unoptimizedPseudoClass to the CSS JIT? https://bugs.webkit.org/show_bug.cgi?id=135200 > > In SelectorChecker, you should remove the branch "if (context.hasSelectionPseudo) -> check for :window-inactive". > > Can you please also add a test for style resolution? It is common to find bugs that only appear in one of style-resolution/querySelector. There already was a test for style resolution, but not for querySelector, which is why this bug existed. 235327 2014-07-22 17:05:01 -0700 2014-07-23 01:10:30 -0700 Patch bug-135149-20140722170446.patch text/plain 4594 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTM3MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA3LTIyICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHdpbmRv dy1pbmFjdGl2ZSBjc3Mgc2VsZWN0b3JzIHdoZW4gdXNpbmcgcXVlcnlTZWxlY3Rvci4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTE0OQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGZhc3Qvc2Vs ZWN0b3JzL3F1ZXJ5U2VsZWN0b3Itd2luZG93LWluYWN0aXZlLmh0bWwKKworICAgICAgICAqIGNz cy9TZWxlY3RvckNoZWNrZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VsZWN0b3JDaGVja2Vy OjpjaGVja09uZSk6CisgICAgICAgIFJlbW92ZWQgZGVmYXVsdCBhbmQgaW1wbGVtZW50ZWQgY2Fz ZSBQc2V1ZG9DbGFzc1dpbmRvd0luYWN0aXZlLgorCiAyMDE0LTA3LTIyICBwZWF2b0BvdXRsb29r LmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgogCiAgICAgICAgIFtXaW5dIENyYXNoIGFmdGVyIHBs dWdpbiBpcyB1bmxvYWRlZC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNr ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNrZXIu Y3BwCShyZXZpc2lvbiAxNzEzNjYpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvU2VsZWN0b3JDaGVj a2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzc2LDYgKzc3Niw5IEBAIGJvb2wgU2VsZWN0b3JD aGVja2VyOjpjaGVja09uZShjb25zdCBTZWwKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgICAgIH0KIAorICAgICAgICBjYXNlIENTU1NlbGVjdG9yOjpQc2V1ZG9DbGFzc1dpbmRvd0lu YWN0aXZlOgorICAgICAgICAgICAgcmV0dXJuICFlbGVtZW50LT5kb2N1bWVudCgpLnBhZ2UoKS0+ Zm9jdXNDb250cm9sbGVyKCkuaXNBY3RpdmUoKTsKKwogICAgICAgICBjYXNlIENTU1NlbGVjdG9y OjpQc2V1ZG9DbGFzc0hvcml6b250YWw6CiAgICAgICAgIGNhc2UgQ1NTU2VsZWN0b3I6OlBzZXVk b0NsYXNzVmVydGljYWw6CiAgICAgICAgIGNhc2UgQ1NTU2VsZWN0b3I6OlBzZXVkb0NsYXNzRGVj cmVtZW50OgpAQCAtNzg5LDcgKzc5Miw2IEBAIGJvb2wgU2VsZWN0b3JDaGVja2VyOjpjaGVja09u ZShjb25zdCBTZWwKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgICAgICBjYXNlIENT U1NlbGVjdG9yOjpQc2V1ZG9DbGFzc1Vua25vd246Ci0gICAgICAgIGRlZmF1bHQ6CiAgICAgICAg ICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9 CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCShyZXZpc2lvbiAxNzEzNzIpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxNC0wNy0yMiAgQWxleCBDaHJpc3RlbnNl biAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgorCisgICAgICAgIEZpeCB3aW5kb3ctaW5hY3Rp dmUgY3NzIHNlbGVjdG9ycyB3aGVuIHVzaW5nIHF1ZXJ5U2VsZWN0b3IuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzUxNDkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3Qvc2VsZWN0b3JzL3F1ZXJ5 U2VsZWN0b3Itd2luZG93LWluYWN0aXZlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog ZmFzdC9zZWxlY3RvcnMvcXVlcnlTZWxlY3Rvci13aW5kb3ctaW5hY3RpdmUuaHRtbDogQWRkZWQu CisgICAgICAgICogcGxhdGZvcm0vd2syL1Rlc3RFeHBlY3RhdGlvbnM6CisgICAgICAgIEFkZGVk IHF1ZXJ5U2VsZWN0b3Itd2luZG93LWluYWN0aXZlLmh0bWwgdG8gbGlzdCBvZiB0ZXN0cyB0aGF0 IGRvIG5vdCB3b3JrIGluIFdLMiBiZWNhdXNlIG9mIHNldFdpbmRvd0lzS2V5LiAKKwogMjAxNC0w Ny0yMiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIE1lcmdlIHIx Njg2MzUsIHIxNjg3ODAsIHIxNjkwMDUsIHIxNjkwMTQsIGFuZCByMTY5MTQzIGZyb20gZnRsb3B0 LgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9zZWxlY3RvcnMvcXVlcnlTZWxlY3Rvci13aW5kb3ct aW5hY3RpdmUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qvc2Vs ZWN0b3JzL3F1ZXJ5U2VsZWN0b3Itd2luZG93LWluYWN0aXZlLWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMCkKKysrIExheW91dFRlc3RzL2Zhc3Qvc2VsZWN0b3JzL3F1ZXJ5U2VsZWN0b3Itd2luZG93 LWluYWN0aXZlLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDExIEBACitU ZXN0IHdpbmRvdy1pbmFjdGl2ZSBpbiBxdWVyeVNlbGVjdG9yQWxsLgorCitPbiBzdWNjZXNzLCB5 b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVT VCBDT01QTEVURSIuCisKKworUEFTUyBkb2N1bWVudC5xdWVyeVNlbGVjdG9yQWxsKCJhOndpbmRv dy1pbmFjdGl2ZSIpLmxlbmd0aCBpcyAwCitQQVNTIGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3JBbGwo ImE6d2luZG93LWluYWN0aXZlIikubGVuZ3RoIGlzIDEKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2Vk IGlzIHRydWUKKworVEVTVCBDT01QTEVURQorc29tZSB0ZXh0CkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L3NlbGVjdG9ycy9xdWVyeVNlbGVjdG9yLXdpbmRvdy1pbmFjdGl2ZS5odG1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qvc2VsZWN0b3JzL3F1ZXJ5U2VsZWN0b3Itd2luZG93LWlu YWN0aXZlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3NlbGVjdG9ycy9x dWVyeVNlbGVjdG9yLXdpbmRvdy1pbmFjdGl2ZS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAg KzEsMTggQEAKKzwhZG9jdHlwZSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIu Li8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+ Cis8YT5zb21lIHRleHQ8L2E+Cis8L2JvZHk+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oJ1Rlc3Qg d2luZG93LWluYWN0aXZlIGluIHF1ZXJ5U2VsZWN0b3JBbGwuJyk7CitzaG91bGRCZSgnZG9jdW1l bnQucXVlcnlTZWxlY3RvckFsbCgiYTp3aW5kb3ctaW5hY3RpdmUiKS5sZW5ndGgnLCAnMCcpOwor aWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgdGVzdFJ1bm5lci5zZXRXaW5kb3dJc0tleShm YWxzZSk7CisgICAgc2hvdWxkQmUoJ2RvY3VtZW50LnF1ZXJ5U2VsZWN0b3JBbGwoImE6d2luZG93 LWluYWN0aXZlIikubGVuZ3RoJywgJzEnKTsKK30KKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4u Ly4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9odG1sPgpJbmRleDog TGF5b3V0VGVzdHMvcGxhdGZvcm0vd2syL1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvcGxhdGZvcm0vd2syL1Rlc3RFeHBlY3RhdGlvbnMJKHJldmlzaW9uIDE3MTM2 NikKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3drMi9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5n IGNvcHkpCkBAIC0yMTAsNiArMjEwLDcgQEAgaHR0cC90ZXN0cy9tdWx0aXBhcnQvbXVsdGlwYXJ0 LXdhaXQtYmVmbwogIyBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRXaW5kb3dJc0tleSgpIGhhcyBu byBlZmZlY3Qgb24gdGhlIHdlYiBwcm9jZXNzIHNpZGUgaW4gV2ViS2l0MgogIyBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE3MzYgcmRhcjovL3Byb2JsZW0vMTEwODgy NjgKIGZhc3QvZXZlbnRzL2JsdXItZm9jdXMtd2luZG93LXNob3VsZC1ibHVyLWZvY3VzLWVsZW1l bnQuaHRtbAorZmFzdC9zZWxlY3RvcnMvcXVlcnlTZWxlY3Rvci13aW5kb3ctaW5hY3RpdmUuaHRt bAogZmFzdC9zZWxlY3RvcnMvc2VsZWN0aW9uLXdpbmRvdy1pbmFjdGl2ZS5odG1sCiBmYXN0L2Rv bS9XaW5kb3cvd2luZG93LWZvY3VzLXNlbGYuaHRtbAogCg==