135131 2014-07-21 14:21:59 -0700 WebVideoFullscreenInterfaceAVKit leaks AVPlayerViewController 2014-07-24 21:44:09 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jeremyj-wk jeremyj-wk ap commit-queue eric.carlson glenn jer.noble jonlee philipj sergio webkit-bug-importer oldest_to_newest 1023781 0 jeremyj-wk 2014-07-21 14:21:59 -0700 WebVideoFullscreenInterfaceAVKit leaks AVPlayerViewController 1023782 1 235246 jeremyj-wk 2014-07-21 14:25:40 -0700 Created attachment 235246 Patch 1023838 2 235246 eric.carlson 2014-07-21 17:40:51 -0700 Comment on attachment 235246 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235246&action=review > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:865 > [m_window setRootViewController:nil]; > [m_playerViewController setDelegate:nil]; > [m_playerViewController setPlayerController:nil]; > + [[m_playerViewController view] removeFromSuperview]; > + [m_playerViewController removeFromParentViewController]; > m_playerViewController = nil; > m_viewController = nil; > m_window = nil; > [m_videoLayer removeFromSuperlayer]; > m_videoLayer = nil; > [m_videoLayerContainer removeFromSuperlayer]; > + [m_videoLayerContainer setPlayerViewController:nil]; > m_videoLayerContainer = nil; Please file a bug to consolidate the duplicate code in invalidate and cleanupFullscreen. 1024781 3 jonlee 2014-07-24 21:44:09 -0700 <rdar://problem/17751079> 235246 2014-07-21 14:25:40 -0700 2014-07-21 17:40:51 -0700 Patch bug-135131-20140721142517.patch text/plain 3017 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxMzA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2EzM2NkZGZkYTE2MzBj MDVjYzJmY2M5YzY0YWEyNzYwZDE0OTZmMi4uZmVlMWYxNDIzMDg2MTYwYTg1YWUxYzdjNjRkY2I1 Yzc5MGE2Y2IxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA3LTIxICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJWaWRlb0Z1bGxzY3Jl ZW5JbnRlcmZhY2VBVktpdCBsZWFrcyBBVlBsYXllclZpZXdDb250cm9sbGVyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzUxMzEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcm9wZXJseSB0ZWFyIGRvd24g dmlldyBjb250cm9sbGVyLgorCisgICAgICAgICogcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNj cmVlbkludGVyZmFjZUFWS2l0Lm1tOgorICAgICAgICAoV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJm YWNlQVZLaXQ6OnNldHVwRnVsbHNjcmVlbik6IGRvbid0IGNhbGwgZGlkTW92ZVRvUGFyZW50Vmll d0NvbnRyb2xsZXIKKyAgICAgICAgKFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Ojpj bGVhbnVwRnVsbHNjcmVlbik6IGNhbGwgcmVtb3ZlRnJvbVN1cGVydmlldywgcmVtb3ZlRnJvbVBh cmVudFZpZXdDb250cm9sbGVyCisgICAgICAgIChXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VB VktpdDo6aW52YWxpZGF0ZSk6IGRpdHRvLiBzZXRQbGF5ZXJWaWV3Q29udHJvbGxlciBuaWwuCisK IDIwMTQtMDctMjEgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW2lPU10gYSBQYXVzZWQgbWVkaWEgc2Vzc2lvbiBpcyBub3QgYWN0aXZlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJm YWNlQVZLaXQubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2Ny ZWVuSW50ZXJmYWNlQVZLaXQubW0KaW5kZXggYmJiZjVmNWE5Y2QyN2U1MDY4ODk0MTRmNWM4NzM0 OTNjMTFiZGRlYi4uNzdkNDhlM2Q1NzE4MjUyZjFlMzAwZDFmZTAyOWNmZWYzNmVkMjFiOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbklu dGVyZmFjZUFWS2l0Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRl b0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQpAQCAtNzcwLDcgKzc3MCw2IEBAIHZvaWQgV2Vi VmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OnNldHVwRnVsbHNjcmVlbihQbGF0Zm9ybUxh eWVyJiB2aWRlb0xheWVyCiAgICAgICAgIFtbbV92aWV3Q29udHJvbGxlciB2aWV3XSBhZGRTdWJ2 aWV3OlttX3BsYXllclZpZXdDb250cm9sbGVyIHZpZXddXTsKICAgICAgICAgW21fcGxheWVyVmll d0NvbnRyb2xsZXIgdmlld10uZnJhbWUgPSBpbml0aWFsUmVjdDsKICAgICAgICAgW1ttX3BsYXll clZpZXdDb250cm9sbGVyIHZpZXddIHNldEJhY2tncm91bmRDb2xvcjpbZ2V0VUlDb2xvckNsYXNz KCkgY2xlYXJDb2xvcl1dOwotICAgICAgICBbbV9wbGF5ZXJWaWV3Q29udHJvbGxlciBkaWRNb3Zl VG9QYXJlbnRWaWV3Q29udHJvbGxlcjptX3ZpZXdDb250cm9sbGVyLmdldCgpXTsKICAgICAgICAg W1ttX3BsYXllclZpZXdDb250cm9sbGVyIHZpZXddIGxheW91dElmTmVlZGVkXTsKIAogICAgICAg ICBbQ0FUcmFuc2FjdGlvbiBjb21taXRdOwpAQCAtODI5LDYgKzgyOCw4IEBAIHZvaWQgV2ViVmlk ZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OmNsZWFudXBGdWxsc2NyZWVuKCkKICAgICAgICAg W21fd2luZG93IHNldEhpZGRlbjpZRVNdOwogICAgICAgICBbbV93aW5kb3cgc2V0Um9vdFZpZXdD b250cm9sbGVyOm5pbF07CiAgICAgICAgIFttX3BsYXllclZpZXdDb250cm9sbGVyIHNldERlbGVn YXRlOm5pbF07CisgICAgICAgIFtbbV9wbGF5ZXJWaWV3Q29udHJvbGxlciB2aWV3XSByZW1vdmVG cm9tU3VwZXJ2aWV3XTsKKyAgICAgICAgW21fcGxheWVyVmlld0NvbnRyb2xsZXIgcmVtb3ZlRnJv bVBhcmVudFZpZXdDb250cm9sbGVyXTsKICAgICAgICAgW21fcGxheWVyVmlld0NvbnRyb2xsZXIg c2V0UGxheWVyQ29udHJvbGxlcjpuaWxdOwogICAgICAgICBtX3BsYXllclZpZXdDb250cm9sbGVy ID0gbmlsOwogICAgICAgICBtX3ZpZXdDb250cm9sbGVyID0gbmlsOwpAQCAtODUyLDEyICs4NTMs MTUgQEAgdm9pZCBXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6aW52YWxpZGF0ZSgp CiAgICAgW21fd2luZG93IHNldFJvb3RWaWV3Q29udHJvbGxlcjpuaWxdOwogICAgIFttX3BsYXll clZpZXdDb250cm9sbGVyIHNldERlbGVnYXRlOm5pbF07CiAgICAgW21fcGxheWVyVmlld0NvbnRy b2xsZXIgc2V0UGxheWVyQ29udHJvbGxlcjpuaWxdOworICAgIFtbbV9wbGF5ZXJWaWV3Q29udHJv bGxlciB2aWV3XSByZW1vdmVGcm9tU3VwZXJ2aWV3XTsKKyAgICBbbV9wbGF5ZXJWaWV3Q29udHJv bGxlciByZW1vdmVGcm9tUGFyZW50Vmlld0NvbnRyb2xsZXJdOwogICAgIG1fcGxheWVyVmlld0Nv bnRyb2xsZXIgPSBuaWw7CiAgICAgbV92aWV3Q29udHJvbGxlciA9IG5pbDsKICAgICBtX3dpbmRv dyA9IG5pbDsKICAgICBbbV92aWRlb0xheWVyIHJlbW92ZUZyb21TdXBlcmxheWVyXTsKICAgICBt X3ZpZGVvTGF5ZXIgPSBuaWw7CiAgICAgW21fdmlkZW9MYXllckNvbnRhaW5lciByZW1vdmVGcm9t U3VwZXJsYXllcl07CisgICAgW21fdmlkZW9MYXllckNvbnRhaW5lciBzZXRQbGF5ZXJWaWV3Q29u dHJvbGxlcjpuaWxdOwogICAgIG1fdmlkZW9MYXllckNvbnRhaW5lciA9IG5pbDsKIH0KIAo=