135126 2014-07-21 12:10:46 -0700 Add support for Wayland EGL to ANGLE's eglplatform.h 2014-07-22 11:34:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 zan zan commit-queue dino kondapallykalyan mrobinson roger_fong oldest_to_newest 1023745 0 zan 2014-07-21 12:10:46 -0700 Add support for Wayland EGL to ANGLE's eglplatform.h 1023746 1 235237 zan 2014-07-21 12:13:08 -0700 Created attachment 235237 Patch 1023747 2 commit-queue 2014-07-21 12:14:13 -0700 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1023755 3 235237 mrobinson 2014-07-21 12:28:04 -0700 Comment on attachment 235237 Patch We shouldn't be using the eglplatform.h from the ANGLE library. Is this unavoidable? 1023759 4 zan 2014-07-21 12:54:53 -0700 As long as we're using ANGLE's headers, I believe it is. Mesa's eglplatform.h is based off Khronos' version as well, with extra entries for additionally supported platforms. Future ANGLE updates would possibly remove the Wayland platform typedefs, but it shouldn't be hard to re-add them. 1023769 5 mrobinson 2014-07-21 13:23:17 -0700 (In reply to comment #4) > As long as we're using ANGLE's headers, I believe it is. > > Mesa's eglplatform.h is based off Khronos' version as well, with extra entries for additionally supported platforms. > > Future ANGLE updates would possibly remove the Wayland platform typedefs, but it shouldn't be hard to re-add them. If possible we should use the version from the system, since that is the version of GL we will be using at runtime. 1024009 6 zan 2014-07-22 11:34:59 -0700 (In reply to comment #5) > (In reply to comment #4) > > As long as we're using ANGLE's headers, I believe it is. > > > > Mesa's eglplatform.h is based off Khronos' version as well, with extra entries for additionally supported platforms. > > > > Future ANGLE updates would possibly remove the Wayland platform typedefs, but it shouldn't be hard to re-add them. > > If possible we should use the version from the system, since that is the version of GL we will be using at runtime. OK, agreed. This patch was necessary due to Source/ThirdParty/ANGLE/include being listed in the WebCore_INCLUDE_DIRECTORIES, so we ended up using ANGLE's eglplatform.h at compile-time. I'll change the build rules so the ANGLESupport library will still be built with that inclusion directory (which is necessary) while the WebCore library won't include it anymore, falling back to system's eglplatform.h. 235237 2014-07-21 12:13:08 -0700 2014-07-21 16:59:36 -0700 Patch bug-135126-20140721121252.patch text/plain 1456 zan SW5kZXg6IFNvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTMxMCkKKysrIFNv dXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE0IEBACisyMDE0LTA3LTIxICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4K KworICAgICAgICBBZGQgc3VwcG9ydCBmb3IgV2F5bGFuZCBFR0wgdG8gQU5HTEUncyBlZ2xwbGF0 Zm9ybS5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MzUxMjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGluY2x1ZGUvRUdML2VnbHBsYXRmb3JtLmg6IEFkZCBzdXBwb3J0IGZvciB0aGUgV2F5bGFuZCBF R0wgcGxhdGZvcm0sIGRlZmluaW5nCisgICAgICAgIHRoZSBFR0xOYXRpdmVEaXNwbGF5VHlwZSwg RUdMTmF0aXZlUGl4bWFwVHlwZSBhbmQgRUdMTmF0aXZlV2luZG93VHlwZSB0eXBlcyBpZgorICAg ICAgICB0aGUgV0xfRUdMX1BMQVRGT1JNIG1hY3JvIHZhcmlhYmxlIHdhcyBkZWZpbmVkLiBUaGlz IG1hdGNoZXMgdGhlIE1lc2EncyBlZ2xwbGF0Zm9ybS5oLgorCiAyMDE0LTA2LTA0ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRW5hYmxlIFdl YkdMIG9uIFdpbmRvd3MuCkluZGV4OiBTb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9pbmNsdWRlL0VH TC9lZ2xwbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL2lu Y2x1ZGUvRUdML2VnbHBsYXRmb3JtLmgJKHJldmlzaW9uIDE3MTMwNykKKysrIFNvdXJjZS9UaGly ZFBhcnR5L0FOR0xFL2luY2x1ZGUvRUdML2VnbHBsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAg LTgzLDYgKzgzLDEyIEBAIHR5cGVkZWYgaW50ICAgRUdMTmF0aXZlRGlzcGxheVR5cGU7CiB0eXBl ZGVmIHZvaWQgKkVHTE5hdGl2ZVdpbmRvd1R5cGU7CiB0eXBlZGVmIHZvaWQgKkVHTE5hdGl2ZVBp eG1hcFR5cGU7CiAKKyNlbGlmIGRlZmluZWQoV0xfRUdMX1BMQVRGT1JNKQorCit0eXBlZGVmIHN0 cnVjdCB3bF9kaXNwbGF5ICAgICAqRUdMTmF0aXZlRGlzcGxheVR5cGU7Cit0eXBlZGVmIHN0cnVj dCB3bF9lZ2xfcGl4bWFwICAqRUdMTmF0aXZlUGl4bWFwVHlwZTsKK3R5cGVkZWYgc3RydWN0IHds X2VnbF93aW5kb3cgICpFR0xOYXRpdmVXaW5kb3dUeXBlOworCiAjZWxpZiBkZWZpbmVkKF9fdW5p eF9fKQogCiAvKiBYMTEgKHRlbnRhdGl2ZSkgICovCg==